From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39782A0524; Tue, 13 Apr 2021 14:02:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4AE5160EE5; Tue, 13 Apr 2021 14:02:33 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id F3C30160EE4 for ; Tue, 13 Apr 2021 14:02:32 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13DBt96N030744; Tue, 13 Apr 2021 05:02:24 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2107.outbound.protection.outlook.com [104.47.70.107]) by mx0b-0016f401.pphosted.com with ESMTP id 37vpuu3jst-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Apr 2021 05:02:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R0PHnm5rEOGupQzRGvKiA3kCnArU6ShDt7oyJiI6gF7em1Ilnp5eoXfWmAQGfyFDJeu2f3Ypbwm1TL2L5UrwlyHAVNVS0awadW1vAJEo21c2t2ZHcvKvDiV2gYDPVYf2G+UtsahIm0j/AkcmBOWTsOV+jZIxwj8k9RlfdHXNDQiTjjMYCOXfdljUPJDZlQVqNRc42pcntRAUnkdxHDyPKdyjE+OPnZ/uCzEaOsVtOYdGfQyWBxKtcOj4dW6x8cdR5xlQBtvxQyFW3OESibKMWMh5YSIXtEz4wfwidAnaxEkdXJEIiubU0maFyzH/rPej3tD/VqGmfQpxNaysiNQuFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZEwqKjRElU0TCCRT9PaTe1zcj3aM9/YW7XqRTw0ikkA=; b=cpkfnLAHH3V8z+gMEcrSv50rZ4emQJf63MCKHvA30ZSvpWI/FrQUhEKH1cvX0F5ZzL6r0jwfKoyyIXGFzmHfSCUvCiofCF/uz4VrExelRiwmA3IqWD7nr04gKWe5OlJt+OYme72MAVA03ShRtU4KdCE8tfhLYpEnZ/KvliUYbRIuA3FLE+xLbe7Q9Rn+b7kuGb23pEuj03bsVuegljW81NyswCAJK3UfZCC7PQtdwd2fKodACTRSReJC+8sLFlHTKfK73+aUPO3va0oZxYeW1IfPwhmwjXFTu8e2mFYfhksSegBOW7e9+lS9BLdaabK563i+Q47Vn5yuuQ3whqSU2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZEwqKjRElU0TCCRT9PaTe1zcj3aM9/YW7XqRTw0ikkA=; b=iaa1rfvADAYAOdGyW62BpCFS8KFGwz/ngDVGly9dlw02G8Gq9Ol0979JOHckRKp/ZMjeV+dGUITB8YB5V1aphmYt1TILQUZXnC30MwbyDvhRpmE1tnLGKgJTrhjB7Bt+1j46qfzZ1p769K4WL3rw+vEjDhQWYOC5Ws5dIAPUKIs= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MW2PR18MB2140.namprd18.prod.outlook.com (2603:10b6:907:e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Tue, 13 Apr 2021 12:02:22 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4020.022; Tue, 13 Apr 2021 12:02:22 +0000 From: Akhil Goyal To: Matan Azrad , "dev@dpdk.org" , Ray Kinsella CC: Declan Doherty , Somalapuram Amaranath , Ruifeng Wang , Ajit Khaparde , Anoob Joseph , Fan Zhang , John Griffin , Pablo de Lara , Michael Shamis , Nagadheeraj Rottela , Ankur Dwivedi , Gagandeep Singh , Jay Zhou , ArkadiuszX Kusztal , "sashakot@nvidia.com" , "oren@nvidia.com" , Shiri Kuzin Thread-Topic: [EXT] [PATCH v2] cryptodev: support multiple cipher data-units Thread-Index: AQHXKWWymVi0yzdFTkC/egeAQi7vuaqyZRfg Date: Tue, 13 Apr 2021 12:02:21 +0000 Message-ID: References: <1615724283-26149-1-git-send-email-matan@nvidia.com> <20210404150809.2154241-1-matan@nvidia.com> In-Reply-To: <20210404150809.2154241-1-matan@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [182.69.47.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d02788e1-2090-4b5b-ac79-08d8fe73feb8 x-ms-traffictypediagnostic: MW2PR18MB2140: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: A73QfksdAxlmKDtzc6ze3Y4tfDrs8GjwgArpdwoVS+CK1DTSoTVyD5N26vPNEljB55ZDdLeiV0QF/ZmTKuagWENjV4uKE7hFslJR7eSGtbkPznxiPAvwNarw+dm6227t+BfXjy9oI8gMh28PGM+gVxFX97o70oAk1r5y6oIu7yRXXfN6y3MacZgRDHLcF8OticyK9yFHlWQBcae0yWSbBauZcU1xMorKFnPCyKI9xGWTgct1yErU/+22B0+m3e1PFEqYaFqRl7kv46DlLgPgHF9I5WUrcDPDnGvl4XFBGcJd+hjXca+RXq+4w6XJuu2JKDLw6bGYX/g14artEBjgBXj5s5zw1pp6+eADFzENbiI0bBnp5oWd50x0VDWlexkGwwrwUV6YMLEGHZBT4GOxlozTOvNZLMoAuIlYK/yM6RZtxUY97XQk2GqQx5xS9IInzeBYzWnQ9teadTKhkfKqpVaf2xcjK4e9vZW9EMmzi7iLEPXfcKucJWF+eDm2J4AvSUTCc162SS4Hf+lmYPODuh2p8tg7ja9WVkGyNs80zMeLxqWC4Em0KSJGBs4GSuMP8Y+WU8UKSoNx8wB2i7bEQ63Si8m/Ev2nwN6JTdXuWUU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66476007)(26005)(6506007)(66946007)(33656002)(110136005)(66556008)(64756008)(9686003)(66446008)(86362001)(8676002)(54906003)(5660300002)(76116006)(38100700002)(83380400001)(55016002)(186003)(71200400001)(2906002)(498600001)(8936002)(7416002)(4326008)(52536014)(7696005)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?5/aKdwTAi4CtIH4+iW8E+MMexDqQCkATnems1la7CnAa9x9XdP7KrtuxK3+j?= =?us-ascii?Q?oE6xtNMUyCL6rOFs6sNtXR5Tz5vRVV5GCQ6bSuRJZipTxJq1ynK7iYvHrErz?= =?us-ascii?Q?OehyIhq8EKoivKrOpRxjggz8TRNuv0tZTCq/nfdSMr59sHH1tYVMKevP6arX?= =?us-ascii?Q?hnv1/n0PhcbazsJCCig7VN6H3WZ0lrEe5YkVzPTYJV2Y7nO11O/NBB7tUvyy?= =?us-ascii?Q?J4TMUKfXsQ3/tnDCEXXMYtWtI2JUz1JDwDwgvECG+BOxA89q7CiPZjbQVv2x?= =?us-ascii?Q?3QJDrGJBcH2F45nD+E0TQSqrc/F5BGHwtEn5YgbnrGrJySjT5jZHT7LKWhXN?= =?us-ascii?Q?+GegdzWk6lTi9EpoSUErZh9hAvqXfDegobbJKy1zLIi+j0TGyVwhfFXQ0ok4?= =?us-ascii?Q?7rrvNefR9Yw7YefgoGYq69hG9+/mjDNxND6c9JMoV56bjkx160Pe0uEXfJTk?= =?us-ascii?Q?M+pz1IgJCWMNsCIySbJVOnqwSO6iBV5En7uYg68DG0QzAejWvbkqrylmGwlo?= =?us-ascii?Q?uB+HG3NOpcW8kTtLgf9Qg/PWA081S5Y89rO1t9ezlcTRdzi9XpnZZYRM6weZ?= =?us-ascii?Q?QOjIZsoPhTGYao+h7ShvTGd/r3wEQMb34os5as7o9GfLU+FY3qzN4rZc5EjK?= =?us-ascii?Q?qsDxQXvTfAWYsNtTRME9R5VlM0luLvON/aPW3xajWavd2pn2pgSvKRotLrH6?= =?us-ascii?Q?y4SpCQTq+91SzhrHq11vbLgfLWM+NBti7aUZFwBJTCi9QpiaJVO8ayia8IA8?= =?us-ascii?Q?G52Rzq1ZVXff83rujobAkloa3djhjAzBGGNOlzPTPsfwBDVk/ThfaH3giLr3?= =?us-ascii?Q?tqwf0Ns9+oj1suQDi7vvQYQpFke0K1dZinQ50Cz1iZnryeVjD478pndcvw+h?= =?us-ascii?Q?XZzaGzjH10JPSFVNS9hGSrNJqLsf3ESeuBNBgnd8zIzbx/bO1J+prmoTpvPz?= =?us-ascii?Q?pSCjLRbPLG0WSfG/CaK42RhvTXBNHA+7OkTaQSPBIeG1ZIxlKWLKX9bssnvj?= =?us-ascii?Q?F2z8gmAz0IaKPJO+y7mV6N/rtApz3aEKhN7GIa03GCCNFxrT5ELR3U1KdaFm?= =?us-ascii?Q?veMBO6i+1PvrOibxnvGa2+KAFq4977NZpW2G/bpxmJe47VVcQDkzuKzQVYS+?= =?us-ascii?Q?giWvpS1DGD6TW9mxVT78etwVNb6cCH4KoHeYQBjphguKmUBP+ATTPWln46at?= =?us-ascii?Q?P3fe789sfiJdHeqMnBdi4kH2mYbBdSWqFf6+EXOCwSpoz3i0Ib6kzi4X7+D4?= =?us-ascii?Q?sLtRsLrt3d+/VD/zozBkCXYoEkqYQ1Zw8I14/gUSd4ye6tBFtfrJAUy9k4Xl?= =?us-ascii?Q?SSk=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d02788e1-2090-4b5b-ac79-08d8fe73feb8 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2021 12:02:21.9026 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: L2DJOSgx9q3C/zviTGOIE4toSlnWl2LEvokply7FYevgRGtIUtIaw5eLIipylwaRNYd4vTd25KIu+U2C4StkaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR18MB2140 X-Proofpoint-GUID: Y2PyBeqpSfkhyoV6yzJDYG_sZA8ql6jA X-Proofpoint-ORIG-GUID: Y2PyBeqpSfkhyoV6yzJDYG_sZA8ql6jA X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-13_04:2021-04-13, 2021-04-13 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v2] cryptodev: support multiple cipher data-units X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Matan, > In cryptography, a block cipher is a deterministic algorithm operating > on fixed-length groups of bits, called blocks. >=20 > A block cipher consists of two paired algorithms, one for encryption > and the other for decryption. Both algorithms accept two inputs: > an input block of size n bits and a key of size k bits; and both yield > an n-bit output block. The decryption algorithm is defined to be the > inverse function of the encryption. >=20 > For AES standard the block size is 16 bytes. > For AES in XTS mode, the data to be encrypted\decrypted does not have to > be multiple of 16B size, the unit of data is called data-unit. > The data-unit size can be any size in range [16B, 2^24B], so, in this > case, a data stream is divided into N amount of equal data-units and > must be encrypted\decrypted in the same data-unit resolution. >=20 > The current cryptodev API doesn't allow the user to select a specific > data-unit length supported by the devices. > In addition, there is no definition how the IV is detected per data-unit > when single operation includes more than one data-unit. >=20 > That causes applications to use single operation per data-unit even thoug= h > all the data is continuous in memory what reduces datapath performance. >=20 > Add a new feature flag to support multiple data-unit sizes, called > RTE_CRYPTODEV_FF_CIPHER_MULITPLE_DATA_UNITS. > Add a new field in cipher capability, called dataunit_set, > where the devices can report the range of the supported data-unit sizes. > Add a new cipher transformation field, called dataunit_len, where the use= r > can select the data-unit length for all the operations. >=20 > All the new fields do not change the size of their structures. >=20 Please check that the CI is failing. I see that ignore exception is present= in=20 devtools/libabigail.abignore For rte_cryptodev. But not sure why this is st= ill failing. Can you check? Regards, Akhil > Using a bitmap to report the supported data-unit sizes capability allows > the devices to report a range simply as same as the user to read it > simply. also, thus sizes are usually common and probably will be shared > among different devices. >=20 > Signed-off-by: Matan Azrad > ---