From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFCF3A0524; Tue, 13 Apr 2021 11:52:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F55F160D6C; Tue, 13 Apr 2021 11:52:46 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 34231160D68 for ; Tue, 13 Apr 2021 11:52:44 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13D9jF8C005017; Tue, 13 Apr 2021 02:52:43 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2176.outbound.protection.outlook.com [104.47.56.176]) by mx0a-0016f401.pphosted.com with ESMTP id 37w6vugep8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Apr 2021 02:52:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lkRnib3VdiF1rxD42yPt2cmCVlzNZIHdI8Ru+/Ug8XI9ZBRNy6bXqrb6qUqYQe+q3O1orG8u6PP/h1rTFun9nxpUxWBKbtye+we7WcJt8PQCWVB8Hbgs10jNbDb89fBEPo9an0wiZ7xlfGdk9dUyRoHgOxFdj1Tsipj1Ju9VrBjoRh6Y29sSaOkhYN/86Ra6/wylyUkmm+H007d8Q4NJoElaC08XRbt8VxX+YMl73f0JC2sqxvgWjs+mpl4u8NxM+XWINk2APtn658HXnRw6n7PtQJnwv1QfzhQB1fTedIBaVl6vNQoa57Z1iiOfGUKUb6rkayfFFjFcFq4bhSmV9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nbpVDvTKyFgNYcKQ3FcKlWvIb7Molc8FNJR94+sazsU=; b=fNgBlfwvAmFHj90TwGfMMtxK48PVmOswyClADYUaAvI/7n9XiFFHIJ7O3tBl7KShAInBiVVmpX88YZfvRgl8OzgRxGJdERsk7JUiIbdi+6IitWfx6abpE4ZjBLmTDls746iEpVAZPDK9pmDoN1L51o3vLSOYEJVpFIyHuv8gvm4CCqSUPnhJjrn1QyFYsCh2CYtpF+jgcQQbFdTH3r2sRhq81eAq/vfyyTEpmNsa0qawtDbogAIdqn9l7WBHMcZAoBo9OoR9SiCnEAEBkZrumk9+QWHd3reDx5R5y8Q8Vz1xbem86uBtLzcInEQ9GzWsOK5mHqbCEAoSJG0cpDCTXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nbpVDvTKyFgNYcKQ3FcKlWvIb7Molc8FNJR94+sazsU=; b=ZD+5rVdGnLGYleeQh/9/9YvurYP9ymuIokIDzrD426OT3W4n2f5lNOR+g0Jui7ryLjzWToKnjRgXqBu87osgLTaG7NKtX1L+tFf8tMjLlIIFPe0JxcbFndSVMfaYR3cXd/SOnJJPUfY0kegAAoz4hlVsRjSixm9UxQFPXX3wIfQ= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by CO6PR18MB3937.namprd18.prod.outlook.com (2603:10b6:5:345::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16; Tue, 13 Apr 2021 09:52:42 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4020.022; Tue, 13 Apr 2021 09:52:42 +0000 From: Akhil Goyal To: Shiri Kuzin , "dev@dpdk.org" CC: "matan@nvidia.com" , "declan.doherty@intel.com" Thread-Topic: [EXT] [dpdk-dev] [PATCH] examples/l2fwd-crypto: remove key size validation Thread-Index: AQHXLFQ5eThxshWzyUmNbG+heTyIDKqyOz1A Date: Tue, 13 Apr 2021 09:52:42 +0000 Message-ID: References: <20210408084958.4443-1-shirik@nvidia.com> In-Reply-To: <20210408084958.4443-1-shirik@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [182.69.47.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7e83236a-244f-468e-ea61-08d8fe61e182 x-ms-traffictypediagnostic: CO6PR18MB3937: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SXiWZWaM3YrCZT0YtD4HdApZTKW6B+YTf71G5RaqVFzAYQSEgKk3NAvMVdjoNNPThZMdtPPAv1V0V9UiK+LH+8JZuYlIme4YjsbY7nG9Ha2crDyQ821TQQ9rVsMVCLkp2zi5pWWgtP29K7JtDUVdQqiHuYpzwwBTASmX15zx9yhXXX7bL7GFu+LpeUo+f6zmPwAs+GpyHzykTBnvXUBsPaQ/TEqzhp5yfrqPWeWjBZZ2UI2xiLZtzOdSgR0kbb4ELC1tZbETFk5o9l1s8H26OcpKuf244fJ7rI7Sf3QfbUq3mj2+SuSvZpHTIPqDBNqbS8bXdGbgahxke1dO78UHqS4Ya2NSN2yXloMPzW95h594GO6v6StEGXGWDMg67otpGhHgO4qlNrdUrA1uadFK+QOAZoraS/Qa2FpHnnHTd8DzUqEuDq9j3SiMPtkQKnndC7lqPx3UpYayJT1WHmWJiXbVCCkwuvu1jCfiEmmDQYHNYdpWQYrgUthJzB4nJ2I1G32+oUcjo/lPTaCgwEOk/jPYrjVZ/r92nT0EZBBJMP2r0nyOUgXl5LKIzgWvvzvSoA9Q+Sd75iUhNxRhFlqYzr8M5M1escmbNlzU/4sJ7+uj47LockA3CzGOHT76+JNAy5d7rZUGwLvh9xEc+fmtnrlthfnFrGneQCKMu/NetzwO0hkMiKWiReem06DSonJF x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(136003)(396003)(366004)(39850400004)(26005)(8676002)(316002)(4326008)(122000001)(186003)(8936002)(33656002)(38100700002)(83380400001)(6506007)(7696005)(478600001)(86362001)(52536014)(71200400001)(2906002)(54906003)(110136005)(66556008)(5660300002)(66946007)(64756008)(66476007)(66446008)(76116006)(966005)(9686003)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ywbEMZhkU6QjYQ2qMlYUgo8H0O/f1juWTnneiU+tlu5CVtlCN0YE1hqSNwEp?= =?us-ascii?Q?VsyvOf41zjuJPtFBDD2TorJqfohFOLumun2BLIc+GPCm1w5e3iJk9iyjKRBz?= =?us-ascii?Q?Ck7mL7vaXLNUBKyET3wi0FqdEJyZ5cC0bhcnAHXp/jFDSf+jgh6ojZHYgN7z?= =?us-ascii?Q?aT1HPi7ikaVvKLIIW7T+GFs1/WFVZzp5JedAUNU10ifYW8B/1FUFX/1Ky2XK?= =?us-ascii?Q?WEw55axmsmeudGXX0j60PTOzVMsOlXK5sKGRu0BCAtDwu1mrELhTs1+gWEVL?= =?us-ascii?Q?sIS6U4kInGPYYlPoyfJHcDKncOPkK3UE/9PWa9HZiezjHo+5fv+vVjIl6PUN?= =?us-ascii?Q?orX5BJlhaJRDBD+AfxUFzN6eX4+MKXYNizAJa8b4PelHX243yarGJo1NRMg6?= =?us-ascii?Q?iXhT6o5ws0zUdkOIjaby0hU//Ynay+7J2MBSYY6+IY+/ruS05bh+tEDAddE9?= =?us-ascii?Q?ekPjCClw/WXSRPmJ0vrb16HwP5PFyQm0EfZaiP0elBpBOS5HR/ex1TBtSOum?= =?us-ascii?Q?ZMfquPNSo5JYPreDI2L4xmox6x06woqhzxf6NOHwA256eyf6yN4cp191iHTB?= =?us-ascii?Q?ArtNo7AJBNWhJGkZtTzzZFaEwLi1JBWLpq9s6NgoGeek1bFTJHmFfHTr9o0A?= =?us-ascii?Q?4uLsv3Xli6PkQePWM+lNbC1oEqc2ij78GwTu7NdLHO2wA79YOmSYdGDDrwqa?= =?us-ascii?Q?l97xcV7HSY5onqWKmgO8E3IkmTffLdapD1YYoKlW9HyfWWgSP78LFxdBi1nn?= =?us-ascii?Q?svipz3yGrRNvkXzWzovb831usXsObD67Op3W4OI0f0++etdXD+zj+WyRKwx5?= =?us-ascii?Q?aG5t9UKUKLPk+sPlH/rR7IEU/H3/IfhXv8uiaIIt38nUJvnPbGaOFC1uscfR?= =?us-ascii?Q?hhOr24TJUtZVx+vj8oXW6vqEpI3QuRemEN0YGq/aqhcIPSnX4bZJhiIj0eBT?= =?us-ascii?Q?HnoNnOk+Oi171sWv7+Vi/hUVN6U+mfbUDxkD/uyywd241fhhI3VsgwCjFVgk?= =?us-ascii?Q?/j8KeFQf3vGiJm6dqlT2i3JUPtT5472et4jvYUJeU2Ew3u6ZotJUrwHWUQeJ?= =?us-ascii?Q?pce4QqkwRhAxPzxtlGMmWu9s/pwRxSzsiK/X9eKIOoXc0bCucFPi0qVtYs8n?= =?us-ascii?Q?Krp1NalZdRO3vRgbWdu4HR16a6IirVWxaYr/aIPnGNegqregdbC7WxdGEVuf?= =?us-ascii?Q?0YXcVuN5iH47V2l34yiqgla8bCPc1RH+i4yW3ktg09CbvZt85kIXojmAroIX?= =?us-ascii?Q?srg2Q8LSNPfOchnoGmKf8ly69helgcQZCuxkcvZO9GFYXEtBGiTl/LJ0ksYZ?= =?us-ascii?Q?nL8=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e83236a-244f-468e-ea61-08d8fe61e182 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2021 09:52:42.0342 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ILqnVdE46FNpeD0wtXsyxOQYJNcay+4MEMF1hwav/r0Bnt8DaSr5oP/vW0IfSpbZdDuGGApXZTyZtu0pgk2d7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB3937 X-Proofpoint-GUID: dEhYVJm440wg7uJxiPMjbT-TAs14xwll X-Proofpoint-ORIG-GUID: dEhYVJm440wg7uJxiPMjbT-TAs14xwll X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-13_04:2021-04-13, 2021-04-13 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH] examples/l2fwd-crypto: remove key size validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: > In the example application the key can be provided by the user or > generated randomly by the example application. >=20 > Then a validation is done in order to check if the key size is > supported in the algorithm capabilities. >=20 > As a result of patch [1] application should support the case where a > user supplies a wrapped key. >=20 > In order to align with this patch and be able to use the app with > wrapped keys, app should remove the validation of key size in the > application and rely on a PMD key size validation. >=20 > The validation is removed in case the key is provided by by user, and > kept in case the key should be generated by the application. >=20 > [1] https://www.mail-archive.com/dev@dpdk.org/msg201281.html=20 >=20 > Signed-off-by: Shiri Kuzin > --- This patch should be aligned as per the latest version of the patch. http://patches.dpdk.org/project/dpdk/patch/20210413063718.3123698-1-matan@n= vidia.com/ > examples/l2fwd-crypto/main.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) >=20 > diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c > index a96cb94cc4..5ae2569065 100644 > --- a/examples/l2fwd-crypto/main.c > +++ b/examples/l2fwd-crypto/main.c > @@ -2111,13 +2111,11 @@ check_capabilities(struct l2fwd_crypto_options > *options, uint8_t cdev_id) > cap->sym.cipher.key_size.min, > cap->sym.cipher.key_size.max, > cap->sym.cipher.key_size.increment) > - !=3D 0) { > + !=3D 0) > RTE_LOG(DEBUG, USER1, > - "Device %u does not support cipher " > - "key length\n", > + "Key length does not match the > device " > + "%u capability\n", > cdev_id); > - return -1; > - } > /* > * Check if length of the cipher key to be randomly generated > * is supported by the algorithm chosen. > -- > 2.21.0