From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A361BA0C3F; Thu, 15 Apr 2021 21:01:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 221C716241B; Thu, 15 Apr 2021 21:01:15 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 0637716241A for <dev@dpdk.org>; Thu, 15 Apr 2021 21:01:13 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13FItlJU008742; Thu, 15 Apr 2021 12:01:10 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2049.outbound.protection.outlook.com [104.47.66.49]) by mx0a-0016f401.pphosted.com with ESMTP id 37xcn4u20h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Apr 2021 12:01:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bf/5nnORMssYW5rIwuic1awlaknObxbIapWB3rBV9ab+QXq1GI+lm2f8mgGRNqCW76Jyo1uKSYsoRej+QM5V/qYDBnP6qG/EJOvhdJDo1nd2f/tS7aqkaQVPvksVo2ZYAt0RMyQep8j3tWbZ0RQ+UuQEhu0X+f/LUMicfurK7SIcfEOTX2J7KuOyvvVSwX2szfJh7BZkMexRWFHBnmOdTzgk3RhOvEuigBxL6z8nbaAmUOsSYuXTOynWRxZ+n1WrRglqf0HQhs5PhNKeHkV0eIKv/LZIHVHOhCr1egUNj8iaoEd96ADo4HbqCQJaqkm2+47vWHqFmOiKbuWHBj5MSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U9MdBmAJLU/14RwxWgmFQWENYS1+yRMafdZQ0meSesc=; b=RX8EhmvJq/wIUq78fFZPC4bZgI+KxoEys4Ml+zXatyIVabjRBXryq9qan1D8z8HQF83RZmLcmY6BLfb/oJmNBd2yCMH26Cn0oy+/IaOtvJE+xlMd3I8U6Glt98aDKqGHM4mA+z88YpqX6l/wvvA+UOoNtUY7rOPifzn87PqTDyMc4G0vFsPSpfs5vpDb7+A03FbCcnJYgD+1ZYHsY3jq+u5b6hAsYFDou8FuJ2EMt3xSNpJ+3nyoVg1wj98Sm/yEK1AY8M3+sLM5mRuUX1FbIAUcsZrdItecg/Nb+3qzNT8U8V7tQZ2yJ8uFQs/Uypkm2ZaRhSSpjnTNb71UBZVdJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U9MdBmAJLU/14RwxWgmFQWENYS1+yRMafdZQ0meSesc=; b=hCZdpaXkOtYe9ZnSCUUQdJeXvhS3bu7abYK0h0HhMqc74eGL/LkBimgf5HjbbmkEyfbyjBKHLy3tvU813ZaVOzi3yU9Z9cBT5pITZg8LGke86eZDvdoCN9CBSQSHifImQEyX7QJZHjgn9iG0ZZ/GlIWcXfYTR1CHfTGmdK1Vdkc= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MW2PR18MB2138.namprd18.prod.outlook.com (2603:10b6:907:d::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.18; Thu, 15 Apr 2021 19:01:07 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4042.018; Thu, 15 Apr 2021 19:01:07 +0000 From: Akhil Goyal <gakhil@marvell.com> To: Akhil Goyal <gakhil@marvell.com>, Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>, "matan@nvidia.com" <matan@nvidia.com> CC: Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>, Declan Doherty <declan.doherty@intel.com> Thread-Topic: [dpdk-dev] [EXT] [PATCH v5] cryptodev: support multiple cipher data-units Thread-Index: AQHXMimwFimw7SLAz0GKeE//cT4mLg== Date: Thu, 15 Apr 2021 19:01:07 +0000 Message-ID: <MW2PR18MB228490086BC9B6D99282F3F2D84D9@MW2PR18MB2284.namprd18.prod.outlook.com> References: <1612449252-395208-1-git-send-email-matan@nvidia.com> <20210414202159.1075118-1-thomas@monjalon.net> <MW2PR18MB22849E41AFC7BEBC88B7F15AD84D9@MW2PR18MB2284.namprd18.prod.outlook.com> In-Reply-To: <MW2PR18MB22849E41AFC7BEBC88B7F15AD84D9@MW2PR18MB2284.namprd18.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [182.69.47.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f2855269-1a90-44ee-cd65-08d90040d39f x-ms-traffictypediagnostic: MW2PR18MB2138: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <MW2PR18MB2138C07A0ED88B5887D2FEF8D84D9@MW2PR18MB2138.namprd18.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9MN9HKIvNl4TbsW3eSQZOF2yQeA47os1b9UBvtqoIWgum9cLOe3FSpxp449UhiudrZVAzy/XIgaIEZV1lVGVqKXGzre1CKLjEbI3gyy6s+WCDb99l+puepLJ9SWQRWigfxrOeVLtmqLAovYU0Sfv7qGLiI2rJ+Pd5jBAntZrZmVRpnlWWwnDgj/FjuNOyCfjrausiDN56maN/fugyW8+u6g4cISdzv+bzZ/Zt6EkDo30/qXFbFjF+PlbrnCCSm1/tPeq5zTihV1oMSOMLHVX6rXUa+/OIX+zuTO40xJXtm7NIuS537jBRZXvpk211E8G8IjW7QXVMXaRkg9x9OfC8eIdkF3H/ukCCK6Cz4iP3sHJ0yhRXo7dYzeOi3TmLKsQgj2UU5RStc4GCTyPAHpEkrpLGNcuL30nLpey8mt2rgu1obmR+O59tmIpdJZGGuu5BDYUobvQf2G8e++q4nFR3QMrbQK38zIIjdtfYUOpUEZbmRdkx6iGfEO6vGaEUgg22k6jUzEjLVwji/jHjwWnSy0MYs74BOYe94NPC7MncEXv0ONaCvjKaumS2w7U7cv0lZxWGVattNHE2fCvas/FYqBo/hE13tqvZIUk/m7ocK0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(136003)(376002)(39850400004)(346002)(110136005)(54906003)(26005)(478600001)(7696005)(2906002)(2940100002)(186003)(316002)(33656002)(5660300002)(55016002)(6506007)(52536014)(9686003)(86362001)(76116006)(4326008)(8936002)(66446008)(8676002)(71200400001)(83380400001)(38100700002)(122000001)(64756008)(66556008)(66946007)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?96sX/yik79RyeNWXhxa2KbFBcRegKCEBdn7xkbktPAlrO9cQJHpNAmkrOz1m?= =?us-ascii?Q?lZ4m8jrtxPoicD8xpQsqTNMJHbiK6j/tweUwS/8EwfDxvz7Xg3vc34EPAls+?= =?us-ascii?Q?Csc5XTk462yUlEkPUSLP4ugb7kvJgA/ZdUUr+pmyd24kJqlrPs05HVj0CkKH?= =?us-ascii?Q?KOixvJD7X4GrSfMRzGV6cYSHDtaSySpzvPY5/R4avgX1jK6dz93Z2QziYbD4?= =?us-ascii?Q?mfUioiWzvZ9GBN0DgV8tlbmKXnhuVj6P9eQCDCUtqMC6jdgiZ4uvK1Y92iyH?= =?us-ascii?Q?sY67G5Wc+WQOurkngovm0WBeO3VCvHhMtwXciOiiobpvUzu1mrEb87WKMbzl?= =?us-ascii?Q?t0QSt8TWuo4xt2x82FQ3gUb403jR/HiQClUaWmoEIup2OxNqKLJwQm5PxETP?= =?us-ascii?Q?dr+42xBBYEZrfVCU0tc0OcCLIarEuzzTMLQV9wnaEsa1Z7pavASLGr6JwVpx?= =?us-ascii?Q?vs0hpJ52yyTJ2et4ycj6Qw5ugghhFKRT4sdVRWjdRWdVF1/TYpG0ZbWEwJQj?= =?us-ascii?Q?vA+p8N9KYUiKbPto5HsPfDyxWef7Slo1LiAYG8NrFblSUEvFOGNtOR8ujO2f?= =?us-ascii?Q?YqEWMGWgYYrFohdnJJAxWGc9tboCzFzYPtH1ZQmfCQ1QLct+XEqeBAKpLILU?= =?us-ascii?Q?vTaJLDzmX2K4uk/cJ1J63CwjmpdOeyLfLkq9Gu8TO1LKzyzpqpwo107sedHC?= =?us-ascii?Q?PlY60PYBM4eg+kjCuqcVR0U287DuPfpXmWTqRs2fAll2n6b22VpmmCxaawPE?= =?us-ascii?Q?J6E1WxRwdChRstc9Si5X27W8jQmaOV1VYWF4Xai8GNTBFZ/JUnivQqKzyOD5?= =?us-ascii?Q?EIU8TDifnXoyfa1Mnmm2R3Rcdvqz0uWJIQpB9/YPX9gcyl2FOpby1R7BPemj?= =?us-ascii?Q?RuJXE+zQFubjtlrZnWH3FSp1khQ7EdLYO8EOG8PsSngR4zlnk2MM5zhi/sFK?= =?us-ascii?Q?uJioKTCVjNqTYOWjdrjEeq0lo8OhzkXfpkmFsMen2kaV7G2z5FCiPbhWOKkj?= =?us-ascii?Q?BU4VF132FwHeyk17r4gSkGOH3O7kpjBKczpSoRdNVA0GCqbHyHYthcGoUOXl?= =?us-ascii?Q?MnsZL+n5fOhBfFrUDk8OpX9kq0bZUDEbTmoatQy5lJwjKNPmSRUj/ipNK3Hp?= =?us-ascii?Q?7yzYRxzwousk0hVlyolmiDQi0817md4/Xl50zCrC2lFBryp43+GYazzJ8rms?= =?us-ascii?Q?dRpsN7OrsIQ67wvu4L3qk02uATXOf5kgEkWH2w9sAhBO9vb/n0kjW3BqfsaV?= =?us-ascii?Q?jv6/INBH5KlVR5Oy3MUikQ6VFQmKDctIdwp+ApdMn7eofZXSfW+yta+WtZtq?= =?us-ascii?Q?9/U=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2855269-1a90-44ee-cd65-08d90040d39f X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2021 19:01:07.6199 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tHhJysnj7srtB1LTCiHOu7/ebjZzb7zm2F76JdMQM6o7gsg6vnZzRolcy804xn1HgQ0TKzf3hIEjsgetGp1E0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR18MB2138 X-Proofpoint-ORIG-GUID: bHYwHthwk068VZkfifnxDMXDqz9s--br X-Proofpoint-GUID: bHYwHthwk068VZkfifnxDMXDqz9s--br X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-15_09:2021-04-15, 2021-04-15 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v5] cryptodev: support multiple cipher data-units X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > > From: Matan Azrad <matan@nvidia.com> > > > > In cryptography, a block cipher is a deterministic algorithm operating > > on fixed-length groups of bits, called blocks. > > > > A block cipher consists of two paired algorithms, one for encryption > > and the other for decryption. Both algorithms accept two inputs: > > an input block of size n bits and a key of size k bits; and both yield > > an n-bit output block. The decryption algorithm is defined to be the > > inverse function of the encryption. > > > > For AES standard the block size is 16 bytes. > > For AES in XTS mode, the data to be encrypted\decrypted does not have t= o > > be multiple of 16B size, the unit of data is called data-unit. > > The data-unit size can be any size in range [16B, 2^24B], so, in this > > case, a data stream is divided into N amount of equal data-units and > > must be encrypted\decrypted in the same data-unit resolution. > > > > For ABI compatibility reason, the size is limited to 64K (16-bit field)= . > > The new field dataunit_len is inserted in a struct padding hole, > > which is only 2 bytes long in 32-bit build. > > It could be moved and extended later during an ABI-breakage window. > > > > The current cryptodev API doesn't allow the user to select a specific > > data-unit length supported by the devices. > > In addition, there is no definition how the IV is detected per data-uni= t > > when single operation includes more than one data-unit. > > > > That causes applications to use single operation per data-unit even tho= ugh > > all the data is continuous in memory what reduces datapath performance. > > > > Add a new feature flag to support multiple data-unit sizes, called > > RTE_CRYPTODEV_FF_CIPHER_MULTIPLE_DATA_UNITS. > > Add a new field in cipher capability, called dataunit_set, > > where the devices can report the range of the supported data-unit sizes= . > > Add a new cipher transformation field, called dataunit_len, where the u= ser > > can select the data-unit length for all the operations. > > > > All the new fields do not change the size of their structures, > > by filling some struct padding holes. > > They are added as exceptions in the ABI check file libabigail.abignore. > > > > Using a bitmap to report the supported data-unit sizes capability allow= s > > the devices to report a range simply as same as the user to read it > > simply. also, thus sizes are usually common and probably will be shared > > among different devices. > > > > Signed-off-by: Matan Azrad <matan@nvidia.com> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > > --- > Acked-by: Akhil Goyal <gakhil@marvell.com> Applied to dpdk-next-crypto This patch is causing ABI breakage at my end, but since CI is passing, I am= applying this patch. I believe my libabigail version is older than what CI is using. @thomas : Please pull crypto tree to main and send the dependent patches ag= ain so that CI can run on them. Regards, Akhil