From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBA73A0548; Sun, 9 May 2021 11:14:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71C9B406FF; Sun, 9 May 2021 11:14:57 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id A31B940140 for ; Sun, 9 May 2021 11:14:55 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 149968bC006441; Sun, 9 May 2021 02:14:54 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2104.outbound.protection.outlook.com [104.47.55.104]) by mx0b-0016f401.pphosted.com with ESMTP id 38dt5rjs4a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 09 May 2021 02:14:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nW8rIncozfmGS8JDVJ4xLIZzzYyIKwMmFNsbEeEIwlbJQqJF9Ttr3Va1CK7GZ2BkNn7yqT9kQHap3+RpFfBkF30oLcQASnZPWugJ5U5cWHr34+lgGJAQF95zy8uGXayrVhZmqgnwC3NfiRf5ZHlHACQY8Ufr7t4qtPV4QsjPpcFCk0h1kvVckPv82Tbqyzm/p6L97RFf9FITqzp3uNXuhOA8/Xbyijnup0dDBIjIvOJVGpJUF6FNqBebuAiIjjbkFYPAmpvSBu4FhQOsjiHiVB0Q4hZz/ZRQJH62wqQF3dp2BQMc65RMuF4l3EdLgPTDg/FP6UXqe3q+plh/UTkVwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=skw5qpWs+6q1jny3+ojDEC0AUntBnEG3LeoWFI9KRV4=; b=Aje5WfytaEwh+Ao72fGeYHH1xcRTUtrODUdKorSdfFK/sb4F8ap5qgkc5nRQ0Kp7WB9O1molG2QbMNzBqgMjSjSoiB7dcQ/qtu5fAIKRgzy866RJnnzf69QYGKgO0JwxlsHZd0E7Y2+f38zJWq+Ei5V0dpJYjR+ukiUmpFp6nFLDlrJrPmDrYhnv/Np6MP764SPHKw45tizZBVfSfJf+nxullykqo0omEx0qX34wCmCbBgAXe2fQEVnqEuhx9SUq5+bCAlTcex7DG2zg8duF7UMrr3kQPQUTkmd0PG1hNzVTyNLPDIbHlgjvIlkNTH6LEPXpVvYNO/BwZ1ZQ5wGAfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=skw5qpWs+6q1jny3+ojDEC0AUntBnEG3LeoWFI9KRV4=; b=RA3HR33rfZm4rul/NfCbYP07MPjf9+NUE+Q2O3wQTu4sAd99A2z5lwOsu/q+NogKIgMgkS7K4c3RRtL6AGF7ydK/XrPNC0+0tpCulHlZGNJ8O6p9ItfRBHSLHelBEVyXCArgr7kSk5THuW8LqV3BCME8amr1a3yrmyepFBgQyuw= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR18MB1103.namprd18.prod.outlook.com (2603:10b6:300:98::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24; Sun, 9 May 2021 09:14:50 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4108.031; Sun, 9 May 2021 09:14:50 +0000 From: Akhil Goyal To: Matan Azrad , "dev@dpdk.org" CC: Suanming Mou , NBU-Contact-Thomas Monjalon , Shiri Kuzin Thread-Topic: [EXT] [PATCH v3 15/15] crypto/mlx5: set feature flags and capabilities Thread-Index: AQHXQSnWsvz25MKtdkqt23wDGjSfNKrZdQEAgAFodoCAAAPToA== Date: Sun, 9 May 2021 09:14:50 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-16-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [171.48.51.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a5c6eaba-d4c5-48f7-9705-08d912cae634 x-ms-traffictypediagnostic: MWHPR18MB1103: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: c6w6Jh/8MG2B9NZ7360sTgADiKScNPgX3O19H3T8Q0Ou25Mb4H4K8bNsKmia5JLD1k/JTTK7XmRrQx4ot+5e5nIzPBtSImCscGsTSwIRXdxE+FP6ySmxvQpyYornsakl7iViyg0OA3C/qcrn8h+eirLxLBr6F7gzx9zZg2eY7RhQ/aBLU07yWNz4La8GiwvLiUhswS1QXXY4gHMnI793pZ8W/G3PiiXQQB5jC0+HVnrYMH6pv8hJThf3GtJLFyii1R4u/+GcTrAjYXmaCletJfCEdMIflTXrFbts8pIQzFmBe1VW1+Wb8ar2sHH4oR7sTwR6DOXhfKqd8ue+RmyLr8R+CKMlnWcc5mFxk48/A1KVq0eZQuDDKQWB/vfrQovxQ7yjxYL6Z8NI6AS+JaUBrRdoyERogv3n4TJFXeaq1t1Nvj9yqbRQebId0EdCna+npF8k066rplwKZxUMuyO5crrtmsdaK8612KxUF6DEXefodIbmOh8RhQlFG05PEY2FVFYRJoint5SQTJNXeFJlyutQRhrASo+1jgaOYQS1wngfz8DcEcfqsiSygpepV1+ypmucXPo8hsQV4U2ItAbvaCoQBIAWVwjdF1lqJa/6bAs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39850400004)(366004)(346002)(396003)(136003)(83380400001)(38100700002)(122000001)(8676002)(5660300002)(55016002)(9686003)(52536014)(66446008)(6506007)(66476007)(66556008)(64756008)(186003)(316002)(2906002)(478600001)(4326008)(86362001)(110136005)(26005)(54906003)(33656002)(76116006)(8936002)(66946007)(71200400001)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Z9+YYx/vY/O5jo6F+TNOmdB9n+OB/xeHvao7KWQ64repkaL4kRoInXvN20EF?= =?us-ascii?Q?PqfgU6DbvQobC/u5vQyIDlyIDHn8vm/pzZXay2LxBBBIXLMWD3EpCMQftivp?= =?us-ascii?Q?i0a3BdhZT3+3xZZre7CPkrc8Qhg775yuKAl2r+rI8Wz48gYegoy9cBFcXhLr?= =?us-ascii?Q?FQL48A/OZXeVbYbaKcruzDz7h4vPnZg5t2Nsy3Gl4Q+nGi+U2+gAih7thahB?= =?us-ascii?Q?sNpZp1OmeFVpmYgKkNuG2VUW1S2m+lymyrHbcnseM1SH1uoSfcdQ0qQXxC+e?= =?us-ascii?Q?xhIWw93ykCCfDpfxuxyZh36K62EXnKHHL6Nej/sCfWgE2QM0LMejENt+ThPv?= =?us-ascii?Q?kV8SfsRDm6k8fP7os0vi6zNcKVfHA0QcGSpD5wb2zOoj31uSLeMiO9yxzxj+?= =?us-ascii?Q?6LJxwCt2sOO4MWN6Nml4dzdY3/4/PnaBKHA/rYKtTJTW98qv42wGEzoUiVN3?= =?us-ascii?Q?LmoUSjSmID+Ap+CLdNuKqmRgggDrmxHtR/FhZ0qfscx2JmjKsNQWyNS/cCd/?= =?us-ascii?Q?Wv263L7aOtyz+Y6SswmFHPCSUs9RT0d4qBD5AS6kBhkMA2rGRLlHIa8VCPW1?= =?us-ascii?Q?OfBXSlRpBxIaJaYZDIuzmLozfLbv+bvfvs371e6Z8dIfPlfgKnzuvg0Cp/Xy?= =?us-ascii?Q?LIVqhtfhrHXDqmRFAtActYl9yRS3IER30DFm+QN3eRZ0BneVgFJWkaHv4hGI?= =?us-ascii?Q?KmETAVdpfjUwe7ytC22otrNOC3M4Hd359dHPBxJ2P8FKJS/k7zOJNvrrT0Bs?= =?us-ascii?Q?lCHcoYlUq/dnIsmlmurp2ovp8TB021NCyzVcxXzbN+uNiys3HRvPKisHzkIx?= =?us-ascii?Q?eiMiSyMXowf9u1CV51aMaU3T57ilrPO5gRoTZqU4Kcop5M0KRYYtTdkBccsG?= =?us-ascii?Q?tgQITjWZCRl50S6OswuJ9LY4beIp0EqC6CFLmwBRa3WihBYxJYoomZ8iTeE9?= =?us-ascii?Q?fWzDiQ4+t/dhmwxi5dCpkFvNI8LJJ0K+/0qkn2wnC23+uL7hTvxhWBy1Ho7a?= =?us-ascii?Q?MBw3Gwr5brj8ZdsRC9qG1cmUkT/UwP5GPsbXQ2OFvBi2V7IZwpdC6uihM5WI?= =?us-ascii?Q?W2xgZ5+vgwQ7YX4f/zdlPVG71sUe1oFJHQpp4uMhAyZ/rL+DILfIePHYewcr?= =?us-ascii?Q?4SwwgsEowKCIgTRyGG8ETIEk41FbJeWLP83nN9P7OUkrdkzPQrpIBO1C7OyU?= =?us-ascii?Q?o8kJe/CKBGFQvCP4QvpLb+1XqMtK3qPpNkqi6+hIeOAwqCJQnj5HgUqBMAGb?= =?us-ascii?Q?NOw3qWOcXUrIrml8hpF205MS/OkTwCv4PdQjjtrIH/I+7NA5ZidqTiSnolGZ?= =?us-ascii?Q?eyY=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5c6eaba-d4c5-48f7-9705-08d912cae634 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2021 09:14:50.2656 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: P1AUiF5xq/0Xxn2oeTheGhBozcPfu/+Kp2XN+YA0LIx8ypfW1SNchLlM4nbXt1GK/72P+h4+3moD7RnuAsk8Kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1103 X-Proofpoint-ORIG-GUID: sK_g-FMvfiOQmtO6_iTFjoosN_hiQMdT X-Proofpoint-GUID: sK_g-FMvfiOQmtO6_iTFjoosN_hiQMdT X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-09_04:2021-05-06, 2021-05-09 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 15/15] crypto/mlx5: set feature flags and capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > +Supported NICs > > > +-------------- > > > + > > > +* Mellanox\ |reg| ConnectX\ |reg|-6 200G MCX654106A-HCAT (2x200G) > > > + > > > +Prerequisites > > > +------------- > > > + > > > +- Mellanox OFED version: **5.3** > > > + see :doc:`../../nics/mlx5` guide for more Mellanox OFED details. > > > > Since the driver is by default compiled off due to the dependency on > > external Libraries, I would recommend to add few lines here as well for > > compilation. > > Like to compile rdma-core and set PKG_CONFIG_LIBDIR. >=20 > Why? all Mellanox drivers has the same external dependencies. > I added here link for the doc explains it well. This is a crypto PMD, not a NIC PMD. Somebody working on crypto PMDs, do not really care about the NIC PMDs. Hence it would be convenient to have compilation information here as well. You can refer to other document for details, but basic info should be added here as well. >=20 > > And I do not see any updates to the test application for testing this d= river. >=20 > You can see update to l2fwd_crypto, we tested with this example for the f= irst > stage. > Everything looks ok there. L2fwd-crypto is an app which only test data path with no packet validation. It does not tell if your encryption is correctly done as per standards or n= ot. Did you test interoperability with l2fwd-crypto? All basic configuration tests are also not done, like cleanup etc of the PM= D. I haven't seen a driver getting merge without the unit test application run= . Test app helps you comply with the way dpdk drivers are meant to be written= . >=20 > > Is this driver really tested or is it work in progress? If it is work i= n progress, > We > > should defer this PMD to next release. >=20 > We can continue test this driver for a long time. > The basics were tested in the above crypto example what proofs that drive= r > works well. > If we will find issues in other tests, we will send fixes. >=20 > I'll send v4 with your comments adjustment soon. >=20