From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 862C6A0C40; Fri, 16 Apr 2021 12:38:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1EE9D1418B4; Fri, 16 Apr 2021 12:38:12 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id C0DE51418B4 for ; Fri, 16 Apr 2021 12:38:10 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13GAaBUp032506; Fri, 16 Apr 2021 03:38:09 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2102.outbound.protection.outlook.com [104.47.55.102]) by mx0b-0016f401.pphosted.com with ESMTP id 37xyr4hrgs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Apr 2021 03:38:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JkZ4YkJ0CddBd/6rZTk8EiUri57vP4j/1Pcmc2tLFuN0vwYao74PWt7QGTU4MCBFTxdeTDHhkIfQnR3sgY+rvIL7LXtUGQpGvtCEtI8Kz4cpbHrHLBIds0pzx6F3hA6k+oeKjECeY+rMdgQ59cxnP/anyTzcathoUHQzf/m+KBgnYpDkRWbxUPm66QnDOvakEkc/hBEH1gfUjT8XtZmQHg1+66Kc5YuMwWACXYSxjf6Go2ck88Czrqaam78P1IHhGrJjX9zr0n+cvvB5jSd0gZZpeKPr7RtYIhr4jVJuW5/xqmm8oF982h3+oF9HriCZM6aSGzXXX7FOL2Y3hhkFSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pGyvIZHgc9j/eXwSBKRM2ngzZMyaE4ddWbHWvYbdP1g=; b=l4Y1pdQ+MZIHdnkTDJAI29ZdVTYWX4OAn4Fi6UO0hflxHFApaD2yUEqX/Q9zQN5DACGWvtQ/jZqNf9ZoIwCcOwleq00b0pciksi25m0jOxWnWjciWJpDfbsVMQ5ruOHKW152HF6mTH+nr0eVcivyZ0vix6LFv6l+w6fix7xJx7gO+ukuiuCU013wpFtDP23z8kzNr3KZBD1FBbHadxXudw3Vpx1C1vi8PCAaZBtezbq6FgLeCdJ4yetCK7hfAt7JQ/MdZC0ilg8z+arawTEW2wqWyJmBm+w5udVlrHnUJXnGDuw54KWDBp/C2GvG1UtgCEq6RMMEY46za6f2AqCTSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pGyvIZHgc9j/eXwSBKRM2ngzZMyaE4ddWbHWvYbdP1g=; b=rR96VAseBstzLhJx2FxAAki4NPiCLa9/UKaPkkmaXGXW9KghV5SOhQ4jTPpNE48Uu6IY9fftYM8Q0kXfapfneGjd/wEWcjr139WdJAogbJzSTBtQgRml6laf9mmpL8yuIiGGuU/tffoXcV+VsDmjllfgCg1XEOSnRZLLSkyx4SQ= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR18MB1677.namprd18.prod.outlook.com (2603:10b6:300:d1::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Fri, 16 Apr 2021 10:38:07 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4042.018; Fri, 16 Apr 2021 10:38:07 +0000 From: Akhil Goyal To: Shiri Kuzin , "dev@dpdk.org" CC: "matan@nvidia.com" , "declan.doherty@intel.com" , Thomas Monjalon Thread-Topic: [EXT] [PATCH v2] examples/l2fwd-crypto: remove key size validation Thread-Index: AQHXMIGYjbZ2RqHyS0+kMwZN9n0pjKq295bA Date: Fri, 16 Apr 2021 10:38:06 +0000 Message-ID: References: <20210408084958.4443-1-shirik@nvidia.com> <20210413162452.17168-1-shirik@nvidia.com> In-Reply-To: <20210413162452.17168-1-shirik@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [182.69.47.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6bf2600d-2e7a-423c-c8cd-08d900c3b8e7 x-ms-traffictypediagnostic: MWHPR18MB1677: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IPOFFi9qpFd02re1fxMvuuruKHCUYF/KtQjb7DnuQ1dc3CbLztF29DUnIu/WftzmmgRHc7kekKPeDfnjcJTiS6HxVOsdm3+21FXwWXEwM5iMkLppIEX1feZDwEpm/s38wR6xy2Q6/GzbGc3Cow7UuT/d6ePFMi1NqWMt/Dr8cYAFQk72Qgq+crQrEAhBVNqFixMokqTl/AM46Hsfjnyj6yiZ0lXkeR+sncFMQkFE/ELbO7m9d5MPS3SMI8in+Xv3v4bg7mQI+8+uOhOxzfDJRlT1npygHMvlDRhNmlhnom1eaTovPGrtQL80OL7QN5MabbskZKNVW/1TLg7iLSJWFxklmztG1j3oXU0eT5oZlK1UGw7n4qOSXtXt/zdC/++xcqul7/UpQx7IqEGacEG81FITZmgB4QNueLDBQqb+mEQ82POOxftMRD5ri+ExyN6NPSWqTEgXZRb1WqaeJU9pZqRIpfWcml/TQ0LuaIYE2QXms1KJM3xsg7kCuaBDSDvWZcJqo4B8NV1lQx6nt3rp3S0WJH4AzLzkkdjapKRSbpdmZOLIfHtF3rTnbH8R+P/24fCYdTqB4snASE806ZT0GT2cW2clmOH0PnWLOhRszq2RvTuU3JtXzALw28g/lOYp9vZwPjH6TAlJ/ERi5dyD3whq+5piYaK+o66/A+wYlkY4+DYiWwotQOEITsk3IXCa x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(396003)(136003)(346002)(39860400002)(76116006)(8676002)(66476007)(66946007)(966005)(83380400001)(71200400001)(86362001)(66556008)(66446008)(478600001)(55016002)(64756008)(52536014)(8936002)(2906002)(7696005)(54906003)(9686003)(38100700002)(5660300002)(122000001)(110136005)(33656002)(186003)(316002)(6506007)(4326008)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?jkrr9SV1hLqrYYt9DKh90AioutsWn7R4rkDBwwYLDIIJQE4jNld9MjbyfpJB?= =?us-ascii?Q?KiIfGntEZpvjRymzMWdkzt+nYsZP47QZjZ9WbD+S/i0a3l1fGRgrTzaUplTG?= =?us-ascii?Q?Qw/mJRTtmLgBZc3Rt3ryWZVwrWvLIMkXwVP8Qs2IE/9Lx86yy2IocLQrMr1S?= =?us-ascii?Q?THeGAi9Bd9nutrVFP+n1+BuFFskc4I5mzu/bef44XhCH92/HtBia7yHsHGI1?= =?us-ascii?Q?YDOX7CwbYFThIlo/G8DR+fgR3vfnz8cQ7ttTLziGJdY74FajqOlZ1TCf9Ooy?= =?us-ascii?Q?FFnFI0rjC0x8uyRINk2vhwG5UlOFfu3OEI0genp9df4pm2CG0k5IHoAJOLDz?= =?us-ascii?Q?T1njpQHXxfPwm0n3/uxJQ8jgYMhrVwqf//GTqtWd46VOKAIJfWOUDaonZggx?= =?us-ascii?Q?vgIoKu/nSrZmMmlzvDARABJIKeqeXhMJNcYpVGO/t5bQjSN+LXOnLNz6Q3JB?= =?us-ascii?Q?1DsaJy/U8is50w/cs8AnZ84YDogZlwXuSPoEPb3puTECXQ6OZnHgBZOudxNE?= =?us-ascii?Q?bphlfnMP8lb/3gpxOEa5Rs04YxOu4zqRKZEG4Gg4O2FjdVjDPUwK9xkbPY+C?= =?us-ascii?Q?LUgRszcrLj3Nqg6UooHOI9NoZywhXk3low/WvbLK7+3XEqB5/wjEOCpbIMC1?= =?us-ascii?Q?vpSZa/cnpYbicKKDk6p5D9KYBkWYh0vc8H/yL1QOaG5OcIK1r3gKfEuf01xW?= =?us-ascii?Q?9chZ/eIh+pe4z31ap6Cl9m7NOYAmhDkVrpNQ2mPKDLeMtCUieisphXpY+sSb?= =?us-ascii?Q?hENAFGSEpQtHjcXdLdXafAyP+zn9Z17nUGDpwomq3xQBNcw4fye8v7pYSP+e?= =?us-ascii?Q?f+1gtZngSBJrkVyFjr9PuAPcvTCT1btZbMHqJZ4fb7rzXMy5CUyv2fa/HBLH?= =?us-ascii?Q?OljHzSkbEJ1tak7hFRc/BaURenWLT5wC8rQ2oMRWyPJOMXPHYKGmaMp3pQYK?= =?us-ascii?Q?NQt530X8mQDjMLyg2/y7qmuX8pJMnc9KaGt2E10AZs4TJFtIBwfJzvuqdq8G?= =?us-ascii?Q?y5PUhBAJo2sFjEo7EVwmjkXoyGx61VnH2rkuh/TFl7J5m67edgDeJ/0/lgb2?= =?us-ascii?Q?w2R4mbZgmBMKhRaYCiMNGFxSleV2SQLiognfbR93ttzSwP1osCtbTl0doG2W?= =?us-ascii?Q?3hRTjRr2HEZQ4Z+gf3bTh7tIFE/AmDV5uCCe5w/chigrGCsCGwpdyqi3+GMM?= =?us-ascii?Q?TbYfkaysewbECnwkbVQcZbDvMaVvPGgJUoqyjKoGBp3A/zYbP5r6zYdETfGi?= =?us-ascii?Q?pdp2P4Yx3wMwNeRavDjzUe9eYGfScZzFp+KNP94uIbFt9WiOlSnBuFjYgAI6?= =?us-ascii?Q?8bo=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6bf2600d-2e7a-423c-c8cd-08d900c3b8e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2021 10:38:06.7478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BpqGyEfMGtv1OISoxhDjxvoeQoHBFjn1o5PFd1Ie/WQSXgK74JRESz1+joShIsSZEs+YxBZErYItFknjzalznw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1677 X-Proofpoint-ORIG-GUID: yctKn3TuKvtZVi8vtuwzpu2sM6wtRb3X X-Proofpoint-GUID: yctKn3TuKvtZVi8vtuwzpu2sM6wtRb3X X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-16_06:2021-04-15, 2021-04-16 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v2] examples/l2fwd-crypto: remove key size validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > In the example application the key can be provided by the user or > generated randomly by the example application. >=20 > Then a validation is done in order to check if the key size is > supported in the algorithm capabilities. >=20 > As a result of patch [1] application should support the case where a > user supplies a wrapped key. >=20 > In order to align with this patch and be able to use the app with > wrapped keys, app should remove the validation of key size in the > application and rely on a PMD key size validation. >=20 > The validation is removed in case the key is provided by user and > the RTE_CRYPTODEV_FF_CIPHER_WRAPPED_KEY feature flag is set, and > kept in case the key should be generated by the application or > RTE_CRYPTODEV_FF_CIPHER_WRAPPED_KEY is not set. >=20 > [1] https://www.mail-archive.com/dev@dpdk.org/msg204836.html=20 >=20 > Signed-off-by: Shiri Kuzin > Acked-by: Matan Azrad > --- Acked-by: Akhil Goyal Applied to dpdk-next-crypto Patch description is changes as below while applying. examples/l2fwd-crypto: remove key size validation In the example application the key can be provided by the user or generated randomly by the example application. Then a validation is done in order to check if the key size is supported in the algorithm capabilities. A new feature flag is added in crypto PMDs to allow wrapped keys, hence, to allow wrapped keys, app should remove the validation of key size in the application and rely on a PMD key size validation. The validation is removed in case the key is provided by user and the RTE_CRYPTODEV_FF_CIPHER_WRAPPED_KEY feature flag is set, and kept in case the key should be generated by the application or RTE_CRYPTODEV_FF_CIPHER_WRAPPED_KEY is not set.