From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE6DFA0A02; Tue, 23 Mar 2021 16:06:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6208D140F2B; Tue, 23 Mar 2021 16:06:10 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id DB3924069E for ; Tue, 23 Mar 2021 16:06:08 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12NF5LQV032653; Tue, 23 Mar 2021 08:06:08 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by mx0b-0016f401.pphosted.com with ESMTP id 37dgjp1814-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Mar 2021 08:06:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N/cDDsO+vEttsgs/jp2hB4xuoJIqiaKHVCcX0zhgH2bSZUcGFCQQLQN8lxvBov9DC+/27RNN3fwXGzy6sQ+5dbv/SvAj0MOnP/5yugGAhQ5zE04/tVpwJEno+nfvZkrBd2PJKE34WtyzVJMh5Gz1/MbKzNqy3S9mqH/eydG46egXG9pgVsTieuUqsr+mTWMscr9KJOdeZRiY2+9ww1mASkNnAPqLrXCHaWy8leFLUBpeF3UssjKuYoGPgMJppOoMsHx+Mx7XgaXwjkIJ5ZfX3fZ5FOkX1dfqrDr3EPKP+sChtcJezau6tgKliuhB/VYfCbHIGKxLjr0OmRFolOey/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jKd9CHR6itrIBhKDoYbxM//phQqduMisiwd4lxXskN8=; b=BuE/ABqcXhjyiLTkLBYFIC/V3rHu9ad5zcRy5vuNtWjfDAQ4DLw1X26YkNgAbxtghRKC61hrJ8ZHVfXtdKvu9AlWkeJ9oEb2laXw6sDdXykzaZz/MeB4Q19joi11DhvyIe7+SE9PTZjf/L0H8GD2RNyKDd5RezUv3ahWmMuQ6VPS5y0oSBlVjuf5kOv+Uqd/BbyZXfD8olA9sbUmXJcQlynvKu3wEw9D1jVr/5eVf2ep1qT7DIyXxON4I7Kks85kzuCCpYF39G1bdyMXMUsLQsl3MZ1wRC4ATrfkacRl9rQakLX5flIIK4Y4OGrzsrHrnhjx/EgsIDmGW62HSvUF5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jKd9CHR6itrIBhKDoYbxM//phQqduMisiwd4lxXskN8=; b=m9sYSR7sE3cPDUPR+YoeGpDX0a5VuHlcsaTDgTMRkllghAwSjos1JAKaUwgWAcCQSUqEzYKV3sVht7eQ2TV6fkaNks2BRinE2sS7LsEqWXWczWcNbg9xLSSE2kokhy+sP4zoRQNCqKYmxQbWmbuaNxLyJOyEwAn6J11X15DVljM= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR18MB1120.namprd18.prod.outlook.com (2603:10b6:300:a3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Tue, 23 Mar 2021 15:06:05 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::b40a:1145:2f52:123a]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::b40a:1145:2f52:123a%7]) with mapi id 15.20.3955.027; Tue, 23 Mar 2021 15:06:05 +0000 From: Akhil Goyal To: "Ananyev, Konstantin" , Tejasree Kondoj , "Nicolau, Radu" CC: Anoob Joseph , Ankur Dwivedi , Jerin Jacob Kollanukkaran , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 2/3] examples/ipsec-secgw: add UDP encapsulation support Thread-Index: AQHXGX8sU8FE6QG6F0awQ3BjF6w2x6qLi/MAgAWiylCAAIASAIAACBqw Date: Tue, 23 Mar 2021 15:06:04 +0000 Message-ID: References: <20210315103616.31364-1-ktejasree@marvell.com> <20210315103616.31364-3-ktejasree@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [122.162.28.216] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9fcc6063-aac2-4391-9cd8-08d8ee0d2e4b x-ms-traffictypediagnostic: MWHPR18MB1120: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: e9laAG4jasVfDuxRMaDxrOlOGX4HwArRzdVbMtjYydbyUzTzgEhTHhXJnKf0TfWpSnoprIWk2OiI2StGmHD4j701WCWQiqiYZv4VD2iypP8DC+0g5hpasiXsgXEAWeWUijOasOAOgNEsuVEw3DkhrqHDZiTtYlKQKjQl87Fsm551pQI59lCUDfdqkQxjsh2NA1c8ienDd3t5WHKlIeZ6PPdVcp5pLxQICDhbXdDkLMIS7Ee/Iq5u/ymhHlfaB7h8QNnZsX8eAjBd23qRkRFHZ3s0PmScNa3WFk/ZnFqZu6NsOP5ejlNnH4wU9Ahc0eDhfi1eaP+wWs+hUYOGZG6BX7vxiz2dbLgbB/YIT8j55j5A6WqfuGwjI5PXNt9wTn8s7iWVjzN9Iv1qHJg6dg0fj4UI67Ak2f50ybiU+wyBEKIoggVeuiiTqAiVsHHHpDux2YXzT98prWAH2nAA8D9DTVZnJ+3iV9fKFFmlLQ5NzCBxmMYNNL+R6M2dK+ljWkm5gGvFl9WNNWkR3enplZI6GEi8M4fF8zGyMH9A00AcwDg6kirxOqnZeqmKgvBQgNOr2kYV+Va701N9iSkVKjqmjtA1OkGSb+PycnFS57JogJPRtnxGSGfaIqqq8XTpmFZLkWNmvP/ZR2ZbuaWpHro3rDjYO8cDGC9nP8XlEK4R1ZQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(346002)(376002)(39850400004)(366004)(38100700001)(71200400001)(8676002)(316002)(478600001)(86362001)(2906002)(55016002)(33656002)(8936002)(52536014)(66476007)(64756008)(76116006)(4326008)(66946007)(6506007)(186003)(110136005)(7696005)(54906003)(9686003)(5660300002)(26005)(66446008)(66556008)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?iQpgFplgE1rAMSJGm4FL/xPcisrsAmY8EqoUkcTS5LaVkJDlXcgDWc0LHDFR?= =?us-ascii?Q?Ka94j8M0+IBt+KkM+Rw3XfDqQq59+oKGQbK0Kaw9cZs8KOa6GGkVRASQ53Hp?= =?us-ascii?Q?+cbtmoPbN/7hNLcMcYC0idiN5n7x+ylbFXU/rjmrv43TIBZm0TzGNh/bTyyh?= =?us-ascii?Q?0Qjy4PStvPLARwTn8qhCBbjDRKK9+ZeAQtO9ShlK175H+4jlzBZ4u68BAG5i?= =?us-ascii?Q?Iq6LLSPCakdIxtr0Jrzw1eFe1Q06Gbr2G4eeVex8Z19l9XjK/VOBl+1XDxjN?= =?us-ascii?Q?xYUdzVSOMsD/zUE9kssBz9waoh9hMzijd3rlLEw+Yc91mSR3mRIC9AO91RmO?= =?us-ascii?Q?+nKWsbQWuXrK/SHx7W49y444IG3ULc7tx4kwb43UTnBnyP26j2D+uywPBl3m?= =?us-ascii?Q?CwRByXuN8ysbHorDrW/OkZ0CO6q0zKWdcSkbrhbuHuYqEFGEV41iWaAt0r2o?= =?us-ascii?Q?kVrzLjvmAUyQcXCqFNeHQiw8cfpt+a96Ol6Yb/SGGxlglTbogMa8zbfpiCgp?= =?us-ascii?Q?7/OO11e9E74/hPNbcglUnDnbaYczHsFa6d2qn6fSJRz0mhrV+6dyWK0l4qYi?= =?us-ascii?Q?y+AHQTgmpGTe0k7Eohw70i8R7LTeCzSMl5xhrNU3oLDI9TXQc3c1CeVnAFt+?= =?us-ascii?Q?hrT/z8XHwkitOAY4KJ2kMAxKvtV2hJvRs1RWbg2f738gVEwzeu0CbPPjurXp?= =?us-ascii?Q?XSzbniZWjddOeJSEbzEvdflsGf46OyMiw82TL19Jl+hSPAqLpHx2OUrfMDA5?= =?us-ascii?Q?IPhT9ZUT1EYTl/OvIZZkxF/MBMtoeCIUPU4YQ34XJaDFhvNx0EmR1dJ2/y0u?= =?us-ascii?Q?2ZsqKwlpR4UH84+VCghsJyQk0rhi1CP/wC6qHTdS232oiSsQ6BSo15R+9dMJ?= =?us-ascii?Q?Ng6T3iO2IaFqnLQZmbaLka3KZUadMC62ZEqqzKoLGkbHvFalWbKb/R3gWFOL?= =?us-ascii?Q?EGXs6mDXEesvu5GowPRj4iUk1CGUFwqSs7g27saLKFiRzBAJlAK4ZljvTCrU?= =?us-ascii?Q?l3tY0F/Ow3lyeOdxR/l/rd7b4kV9tQZHmzoMZP2Xoao3c98XUx7zfNRr8KG/?= =?us-ascii?Q?Pm4SgwgB5nvobXEInYAhPejUcAdZEkigegjlbK2JZFPiEh6NXsCgvmBtYs9O?= =?us-ascii?Q?BpQzdISDSwMXv9YjmM1AmD2pl5yTfvZ+RaVUfJhe5deGXpnfW82HDth0I7J3?= =?us-ascii?Q?DqohFzFmfaWCAvP/sNLscnJw+WLDfmnfusIH1VO2IWTL5s9VkolhntN4D7Qp?= =?us-ascii?Q?k2xHwnndoXZX/HyDsju0LhOGj9nR7FOvEJqna17isDq4Yjtfb7v+2M1vd8ya?= =?us-ascii?Q?LWLA5L+h0dmrrJlh7janMMNs?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fcc6063-aac2-4391-9cd8-08d8ee0d2e4b X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2021 15:06:04.8479 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0/CPzFeBWqyR9dpKxtTdHnFVHQGV6UGWZUlQ1XymtGYsM/S4wbVLKNifGcwozFa9qfVWZB+F4t9hIY4ANJyfjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1120 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-23_07:2021-03-22, 2021-03-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH 2/3] examples/ipsec-secgw: add UDP encapsulation support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Konstantin, >=20 > Hi Akhil, > > > > Adding lookaside IPsec UDP encapsulation support > > > > for NAT traversal. > > > > Added --udp-encap option for application to specify > > > > if UDP encapsulation need to be enabled. > > > > Example secgw command with UDP encapsultation enabled: > > > > -c 0x1 -- -P -p 0x1 --config "(0,0,0)" -f ep0.cfg --udp-enc= ap > > > > > > Can we have it not as global, but a per SA option? > > > Add new keyword for SA/SP into ipsec-secgw config file, etc. > > > Konstantin > > > > > > > Any specific reason to make udp_encap as per SA? > > UDP encapsulation is a feature which I believe should be application vi= de. > > If it supports the feature it should be enabled for all SAs when the UD= P port > > is 4500 which is reserved for it. >=20 > Not sure why it has to be application wide? > Why it is not possible have let say SA1 in ipv4/ipv6 tunnel mode over por= t 0, > and SA2 with udp encap over port 1? > Note that in DPDK librte_security it is per SA option. UDP encapsulation can be done only if the UDP port is 4500 as per the speci= fication. Please correct me if I am wrong. So if UDP port is NOT 4500 and udp-encap i= s enabled in the Command line, UDP encapsulation will not work. Hence it does make sense to make it application vide. It will be tedious fo= r the user to Add this in every SA. Regards, Akhil