From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6470CA0C3F; Tue, 11 May 2021 19:35:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 554F94003F; Tue, 11 May 2021 19:35:02 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 01FE14003E for ; Tue, 11 May 2021 19:35:00 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14BHUHub024307; Tue, 11 May 2021 10:35:00 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2106.outbound.protection.outlook.com [104.47.55.106]) by mx0a-0016f401.pphosted.com with ESMTP id 38fw8y8ajw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 May 2021 10:35:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VCCnOv3+PUIvJpKMtNpXZAEc90XASvxfYas0ksIABRNALeTipWam9YRUmksctXywtZi6iGmytvawjLTiSN42J+1osOYIA6nL8wBzx+J78Ze6PrUnA0ZjVxCSsDKjPvnj7B5QtE9i+dRirFAFsbDtAyRnVtSNTzEIHj2ON8L0K/h03qRewHcuN8RHjFgb9pdFOtHpgOXHIk+zNsG3WDKw2PCgYU8W6wEIzAsVwKgcQn7E6NHEhaGWz1F2FW/MNp5kse32V4s2ScBAU2qeJuOTluHsNJre6bJm8RVPK4AuW75S+vdXvQC2SBVEtQEDrFT6/cDFrmFlenTXs3iqvIkGjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dnvghkh6b5KO2vehrdDChGsU6NtZW7zvx1ZUHI/TH24=; b=Gys3ZSy7ePBil21AqkP8toadmTme/NottQEQp0cNTg753JMNVnNBcpZxnnb7LoWaLrEyu5+VtHkHrnZC5KiYhTHtEBzAjihrw/oPrXQwNL4Eplg+FbSjjl++nVtzuTTMqXxWX+WAZSGGQJREGIdw4ukHbsFz+FeOejGxh6S9wuWsUkpV+GyEauL5FGR6TEhe3Vxls4nsnOZywH5/Zbus1ErikZCX62MFNhgYns9das+vPf2p9nA0+VKHRobftaPs5IGyWOvfQXv4sVjjcyvqabDMfAk23q+PA7LVi8Oo0sFm8vlbR/ZGPpQps7YvibnDQa+OefRINSdBQ1fKQx6LNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dnvghkh6b5KO2vehrdDChGsU6NtZW7zvx1ZUHI/TH24=; b=fjkBlCf6w70perLXGYGe4R/h+i7brqr4s8ILRoisdFTqPmGj11M1rFi86be5K+Lg0ZZCne2nTM/OdvL9BRrtf2vjEdEqfTQTgPqfiPEj32DnSbYk4t1PRJzV4EPS4LMVmSnSbW+PdsoD0i7Uc4Eglw2UzPfcKSRHWO0jXz7jyLU= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR18MB1453.namprd18.prod.outlook.com (2603:10b6:320:2d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.29; Tue, 11 May 2021 17:34:57 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4129.025; Tue, 11 May 2021 17:34:57 +0000 From: Akhil Goyal To: Matan Azrad , "dev@dpdk.org" CC: Suanming Mou , NBU-Contact-Thomas Monjalon , Shiri Kuzin Thread-Topic: [EXT] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data unit API Thread-Index: AQHXQSnPWST5nsDOH0Wf5VoieFG/G6rZh6kwgAFKRoCAABRREIAAVWwAgANZLfA= Date: Tue, 11 May 2021 17:34:56 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-10-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [171.48.51.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c3c0e2fd-6ea2-48b2-43c8-08d914a3185f x-ms-traffictypediagnostic: MWHPR18MB1453: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yEe94bejMdnw9g4+cau9z6XmU3yDfridLCWRyuvqxfMywuzzNeNqs6tizA+Fll2hphzzR2KReWLEi6Zb41vQ8GP8qESDwdHmgtMbNyEb5JCCGeCy3p/fncvI8e+qwOEV5Pc7LkSHmeJ1elCnSd37ZfaMcpMm/hsfUtwtqc7NBJNQLcniSEAqpD5Ag33F2S3KP4yQmHjG53YTfdkNf9mrkPiqIXCL7gn8J8srMOrYQx+b7Vc2+Oqk9BgiAIPbf8scfsc3MgDpLYNvCxzE8OFI0zZC7iTX5fcH4K6q19K+J84v7O4aeybXltiDopZHaf+yoR85Zptv7RGsEdwSCkhiQd6y2j4qMqle4ctpk9NaI++YhZvDDkMbaMqI9/NF39OD19G/Cpa+yVqTswm28sBGJtqG78i+vc7nNzQtWv1fH3J5HIX63vvAGtoS+LlkhvQLEmXYpRZYKxeg8zzOy4rF+RUxXZyGrMnqcTve5YyGPb/DS9MjFZSuf7tPabdHV9su9OXSSoJ1G5XR2KuhR1xiL31oFnE7kTCYjbHVNwwykARpuPDa1bxy4w/2u7Z3oeTdodcuZ7rJKWhfT4pFZQ/Mok79ngU0HgHEHVGsvI/Ul1A= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(136003)(396003)(39860400002)(346002)(316002)(4744005)(8676002)(66446008)(86362001)(110136005)(478600001)(8936002)(186003)(5660300002)(71200400001)(54906003)(66946007)(7696005)(2906002)(55016002)(38100700002)(4326008)(52536014)(64756008)(122000001)(33656002)(26005)(66476007)(66556008)(9686003)(6506007)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ca2g9GA5Rflny9wUTTBblbtBPZmxiUWDWnRimGIFiX7/YQI0fnRWS8YOS63k?= =?us-ascii?Q?TkG0EfaCFCAo+COXxvPrug7CbUkIeeoTGgomKd+q/Csf33TGk2I+E8U1Tip5?= =?us-ascii?Q?+eTyUWsgUwaWdldcgIKleSpkUjSIZzMcaKPPAQJ4P8bwuiHKM3m8FqNoRiQ6?= =?us-ascii?Q?q/9svrCVo4Av34JoHTy+tkoQQwE9QsVlO5iuzAj1ou/noMCphfKc4CM5HSpW?= =?us-ascii?Q?5oUn2CRrHfFl5VvScPxUmb0CVo+q4yYPAzKSXXvrt86dUQ5ynEuwMKRw3lP1?= =?us-ascii?Q?AjXOmJOgDHOfX11BP2cRkxGQlQc+0ykZMqnokcIUfo3di00isHcIQJxFYpin?= =?us-ascii?Q?XAn1WPNQh9l55LdfnGj5bR58UyV4zWbpXDmTMEhjNypVh/eBZk91mfJ67QYh?= =?us-ascii?Q?2xbXY08Fk/44qAOMxmreLzjHOI4B8dKd0WhE1ibYJjYc4Lg0DUuvBNMHYdlf?= =?us-ascii?Q?sECDXY6M+jrLIpto6Pk99thzQCWLHnE4sVN7qDY3kMNk4xec79FiA1d7m1OQ?= =?us-ascii?Q?T9C/SPkMQj3A24nUk56LkFOD8Y02jG7cP2RXo+PIkpSi4R21XPJK8p2fhMNJ?= =?us-ascii?Q?W30bWkkb7qCRL+R5Cduqg7Of4PVr96dCFMb9FR9hOwo1Rgz7EaeSyqiW/NnA?= =?us-ascii?Q?kkZDfEzPFpJc/B5uZNcp6f08UbZRXINDallemwVqhsB1CLW+wUkPCJ6XHzac?= =?us-ascii?Q?j3pnK54lY759UF7cOERg3xd1efVZGVmKsPLJ/enqnv25dy5Ut2pTqbUeCZ67?= =?us-ascii?Q?XZA5EiXywxIt7Vdb0P3QUUp2qQdc3nYfOLufNNp686lRkpFxEI9y54r69T7f?= =?us-ascii?Q?UbDgYVigVtx0mnOEzZF8gOjB2BBy/P3PfcVkmEi6X/MRb7da92CLlFryx1qg?= =?us-ascii?Q?rit/eROLiBPkxmbTh3F6MSyzaUKuedrezPwymVVysYyZZKF5oqJgqKvnsZ4j?= =?us-ascii?Q?Ag37gqXCvOvhPeJhTGkIjsH5eCLcRUIzCWLYinx3Q9xn/OCrXz2ZQAFx6EV9?= =?us-ascii?Q?xKb6AiuVeX2fD9QWXDtJR2x17UxrCLcd7Pupye+VJx9Co/0R/yfUWB+WBwAb?= =?us-ascii?Q?vy7G11gyFJZ6yQ+RORW8OTM/YvLbP14x3yH9hJA+kahToJgWsICGntKeL2D0?= =?us-ascii?Q?gkpWcgPlVsP00acv+97a+pX96USTSipnNAvNcVj5B/YTJfapeN82KsnVuHZz?= =?us-ascii?Q?VNXYD6VTlMod1HQwTK+IIIusrdt77xqI6trCFDp+uxMYpjSFCQmkYHRhH8C4?= =?us-ascii?Q?BPF7Gw/xJglbtEB81cKeny3vgdm4Ok5b/EQPAjhHF0q0nwSqPtGf+id7KlMR?= =?us-ascii?Q?FBs=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3c0e2fd-6ea2-48b2-43c8-08d914a3185f X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2021 17:34:56.9577 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pITpHUOpO/T9XMp2TKWjQehvkNTzSldJJTRJIrkhOACnmcl3SS9KyrzFq9V5CKjYgnpa4Cw5V8oCp9gzm2StCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1453 X-Proofpoint-GUID: qSpl0OUn3kp3k5U-pHeVAx2ss9K29rAD X-Proofpoint-ORIG-GUID: qSpl0OUn3kp3k5U-pHeVAx2ss9K29rAD X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-11_04:2021-05-11, 2021-05-11 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data unit API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > > Also set feature flag in the code and the documentation in this pat= ch. > > > > I see that you are setting all of them in a single patch in the end= . > > > > This is not correct. It should be added where the feature is suppor= ted. > > > > Please fix this for all the feature flags. > > > > > > No, in this stage no feature is really supported, the actual time it > > > will be supported is after the datapath patches and capabilities set. > > > > > Move the patch after adding data path, but documentation should be part > Of > > this patch. >=20 > I will squash this patch to the session commit. I am not asking you to squash the patch to the session commit. The point is documentation patch should be part of code patch which Introduced that feature. This methodology has been discussed in the past and is being followed now. Please discuss this in techboard in case of devi= ation. Regards, Akhil