From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FA17A0C3F; Tue, 11 May 2021 19:30:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6D9340140; Tue, 11 May 2021 19:30:46 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 5480D4003E for ; Tue, 11 May 2021 19:30:45 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14BHUHmb024294; Tue, 11 May 2021 10:30:44 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2103.outbound.protection.outlook.com [104.47.70.103]) by mx0a-0016f401.pphosted.com with ESMTP id 38fw8y8a0y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 May 2021 10:30:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IVphjPUCRAL0BJhotzqvpY4nh7CAH1vkvNtasfJ9y3DL8lKwj4iGRt7qNZm5frP2Fbbdp7ELKHzvj0qAtU9o0V0YLblTypbhlZVWXQCjwGMuw7h9vbS7Nw9nTZ8YitUopdC3tHVCHGRt1YZ/eOlAcq1zvV5jBFDLHDdqCfz0i19NLY5hSaUsdFXWVaSVu5/G0oWmhaWaY0swQTPfMMkgAqjRzy92C9g+p8Nk+Ovaj9y+7ZU2XV72FIo6tXLb44qv79Q8d/b01yc52Ib5ZSiFiyySFggjzyl0ybZfo+PuLaQPbQWYZn385tq8sT3Jl7Y/fx8X8ouI3FJkoIzGwv57BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hC5J0pP065+YJSccO3zmqjIsX5zBTGZnBNJTwcL+AJA=; b=P8GB4tijxVpFjwIDa0XReMFvruEiy2iJv6SxLW1nyqryxIgAk9SXBnhOxsVJ3sZCuQX37yKvWIXgGjkeI3HqRJkA8DbMxgMZatOTKKRs9MS9B1JtBePSMnKhm28ywNAQiZyjgM0mHs461+CTlnwpGmA2J8/+pOsE6A5tk4WAcWOtymdghPfHJ1UCh6wYRncc6hgYUaNE9LLJIi5ndgzXc+cj0LSNKR4Jp35H1M8lwpwU0mNfNvCwOeYYAGOcN7bBXHeOGFg8QOiVMoWgFmRsSVwnNOINjHv9xcULKc1/EuHzB8Z+ZopCD6dVDL7QrQ1eL9Ho99VeJcqol94biCI21Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hC5J0pP065+YJSccO3zmqjIsX5zBTGZnBNJTwcL+AJA=; b=VQBXL6X4wQvavMdTsnKYWCI9XX1PVwQmcrI6noNra1N4ZbR13JWqmDwU9EDV2xENGuMdowVFXBXZ4CvODMNorleJn6OuNy8/Od0Ojqi8rgLLinn+OHO08XQDxXNfqmQsbjQi/rx8kJwjbrfv1bIqEfwyHnQqzZ9h4Q9OXQQP+Cw= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR18MB0974.namprd18.prod.outlook.com (2603:10b6:300:a0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24; Tue, 11 May 2021 17:30:40 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4129.025; Tue, 11 May 2021 17:30:40 +0000 From: Akhil Goyal To: Matan Azrad , "dev@dpdk.org" , NBU-Contact-Thomas Monjalon CC: Suanming Mou , Shiri Kuzin Thread-Topic: [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations Thread-Index: AQHXQSnJ4KJlusD3MUiFAPGamVq8bKrZjGyggAFE9QCAABU0oIAAVUcAgANXCnA= Date: Tue, 11 May 2021 17:30:40 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-4-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [171.48.51.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4cde1649-6262-4c7c-9196-08d914a27f62 x-ms-traffictypediagnostic: MWHPR18MB0974: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2RjLuVUNtvaIG0NH/VDkx2chenr3SV4l5yUHKaTXZJeaRlco5OkAHvTJApi3L/k6UekCYBL/A15NxSu58Pebp9n+Zjd/xzTrihMDfqYZ6KNl/Xkx+ABIWIAkt3OGtCWK6/Y9KE8oOpqTX4DECTuFtaNdRcgSsh5HSMMjSduIUW1RSvgvkY2yNC7ICl8b2p9P4wp7krioVT3+KYz1Zn/1In1XTElZPf/62ChBKm0s8kFZp9g+4hhFosg8sXO8vJsySF9szgOVenT27GrWewddXkRLOgqaIXLCL7WBJuQ8e7aD2dBglA3O2DGi5F3/ZsPqKkEhl9piVbNT/sKDIchLJXFEPG6hPuzhXJGOR11r7PKRoXyKDbsdNWf6bHcYFJuETXnghzEKdNFpZrctMmxpv3Ig5dYCmwt9U/K9W4Dz42L/iP+5PGz/ZRPDtmZ+6nuJIaMLsM1B8iHHCRriE36PFIDakGEN0Qc73RGX05asV4qXP+Hv7D9dlDwtungzKAT+MFqHkvmlrT732ppRhaxxydehEFr74Cirrs77ukSSpb6NAYI6sJ/kl9TD6wAj6Ga00S4vIudkvf9hiAJnL07w7QCxHwXsX6LfQU/FfNW8rvU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(366004)(39860400002)(136003)(396003)(55016002)(33656002)(38100700002)(5660300002)(7696005)(122000001)(76116006)(66476007)(86362001)(66556008)(478600001)(66446008)(66946007)(2906002)(8936002)(4326008)(8676002)(316002)(64756008)(186003)(52536014)(71200400001)(110136005)(6506007)(54906003)(26005)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?a+qbtC+t4sldTFklznyT4CKbHHdD96pKAOA2On7+v4z0YfSBHnQ5ID2Vaudc?= =?us-ascii?Q?8Wejii+5dy/wp+GMRn75gUX7b8ByvPguDSTd00CiQizUkBP1DR37mdxTkR3O?= =?us-ascii?Q?Ay60dCzgZTdHesknueEFiIiEHkKqlsbnDvIH3iaxokWsa2ZhyGmRAfJhvbBa?= =?us-ascii?Q?toJFPxxmK6s96ITGCHG2c3XuCCN5znkCkzVs+ud7FxS0v0DK7fJyXAgkO7Is?= =?us-ascii?Q?MSqk3YMxZ8KXukpD5gmU7zbcsVulG33y2cYINHIEGLfC8Mxy/naAksJSosm6?= =?us-ascii?Q?CoHDQzBViJoLMGYL9yk7EoB2nfYRm0eGxJCdq0wgvcoLQun4EBkQz1UO4jJF?= =?us-ascii?Q?5+c6JHe8IIzVggKgCi/LvAfVgW9Nc6acdA4r7yuGlZXMvchqKqeBbeC8WB6h?= =?us-ascii?Q?gIc1gtptPfGv6y9bok8uYaLze1MJ/DLhpe6dPKvAUhl7wujFhPCfybg1didC?= =?us-ascii?Q?h3cGyj8pORA+nhtySjRGDquhDSKA0p6dYDiCyLwxMhjGbQ20dURjaAipqS1+?= =?us-ascii?Q?gIyLW78hTTJIlVy0bQG/Rx5tH87Si+emQNveW+EPhxagXoqbvrRG6OmjG7FY?= =?us-ascii?Q?/6gYqwBs5VAkcEMZXUY+JVm/68/Lf2eNZ+PVOUUw1PtSiG6q6mXl57qrNlkT?= =?us-ascii?Q?poKE2Lc0G1UZGZJpn4gO8EtnpIeoU78wBQq4JnUo1c1J88AujMcRZV56zvU0?= =?us-ascii?Q?Eer1So7aQfd8x7+9//WRlpkrXcpt1JKBh3LCLKsi+NPFmSav4l6Qt6W3m1+Q?= =?us-ascii?Q?EPztYR1KWLyddNJbqQUcm/BXImAEOgc/r/ptsSeN4bqhkzEVs54++PirK2TN?= =?us-ascii?Q?CnjTHlHpW9R896YG+9vdg63KPqtEbGTGMIxaLe5LJYEjVOGQddJ5l5TS4uHM?= =?us-ascii?Q?XYfdBKO52CYUfZfyf9Q4qOgjPsIaVizAAAfod3YqH+mGfPYi/V27V9nGo8Hc?= =?us-ascii?Q?SAlV5f2/RG0RPitOXXlWHGnWN6OGU93O7rtluLQXmNvC6mKPOrZGzt6E31wb?= =?us-ascii?Q?6knoqTWinXe2i2SuNZb3q15oGJMZCUuBMmIF8fwriuez/cCymURs8qIDBymS?= =?us-ascii?Q?cGUgjo/w9FZaWobV9yFex1I1pp5beuTepRdill8tLeEZfm+WZe23bqF77V5a?= =?us-ascii?Q?BYNjDF/RjHiaokZCqt97f3HZSd3/BBhj4K5ROpx+pX6tvxCCyNPmMzVG+i8U?= =?us-ascii?Q?YZVmpuIm7V+f4tOqa4d56LUBS+4vszlnZO23WkMVFLZO2doBYeHUPlLBZMj/?= =?us-ascii?Q?UAXSAuHqTDrY1RKqJ5b1ypeXhjzt7k2HivP/+Xm6Lgpo4+agCWf5wzbQCyEa?= =?us-ascii?Q?p8Q=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4cde1649-6262-4c7c-9196-08d914a27f62 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2021 17:30:40.2320 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6IcWM1JdbNWSwfGnn+y0b+77mbq0N382XFiQ8WIzG01AU8tYlDy+LyJJar+2SqGEok+ePYZol7XJDoiw+BPUOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB0974 X-Proofpoint-GUID: cuekL_eiU7DB6pNtrm5eI_P3XqHiUYWN X-Proofpoint-ORIG-GUID: cuekL_eiU7DB6pNtrm5eI_P3XqHiUYWN X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-11_04:2021-05-11, 2021-05-11 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > > +static void > > > > > +mlx5_crypto_sym_session_clear(struct rte_cryptodev *dev, > > > > > + struct rte_cryptodev_sym_session *ses= s) { > > > > > + struct mlx5_crypto_priv *priv =3D dev->data->dev_private; > > > > > + struct mlx5_crypto_session *sess_private_data =3D > > > > > + get_sym_session_private_data(sess, > > > > > +dev->driver_id); > > > > > + > > > > > + if (unlikely(sess_private_data =3D=3D NULL)) { > > > > > + DRV_LOG(ERR, "Failed to get session %p private data= .", > > > > > + sess_private_data); > > > > > + return; > > > > > + } > > > > > + mlx5_crypto_dek_destroy(priv, sess_private_data->dek); > > > > > + DRV_LOG(DEBUG, "Session %p was cleared.", sess_private_data= ); > } > > > > > > > > Memory leakage, mempool is not freed. > > > > > > Yes, good catch, this part was missed. > > > > > > > IMO, this driver is not properly tested with the unit test app. > > > > > > The only app we tested until now is l2fwd_crypto and it works fine! > > > We can add it to doc. > > > > > > > Please add a note in the documentation that it is tested with autot= est. > > > > > > > > > The next app we want to test with, is test-crypto-perf. > > > > > I would recommend to run the test app first. > > It will catch most of your basic bugs like the one above. >=20 > It is too late for this, will add the test adjustment later. Can we postpone the PMD to next release. I believe test application makes The PMD look robust as per the DPDK crypto PMD API usage. I haven't seen a PMD getting merged without test app. And I apologize I did not mentioned it earlier, but it is kind of obvious t= hing to run test app before sending it to upstream. L2fwd-crypto is not doing data validation hence you cannot be sure that it = is working fine as per other standard stacks like Linux. Regards, Akhil