DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <gakhil@marvell.com>
To: Matan Azrad <matan@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>,
	NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Cc: Suanming Mou <suanmingm@nvidia.com>, Shiri Kuzin <shirik@nvidia.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations
Date: Wed, 12 May 2021 06:47:30 +0000	[thread overview]
Message-ID: <MW2PR18MB2284E81977C537C5D48F86AAD8529@MW2PR18MB2284.namprd18.prod.outlook.com> (raw)
In-Reply-To: <DM4PR12MB53891BB77E00C44C2173E4F9DF529@DM4PR12MB5389.namprd12.prod.outlook.com>

> From: Akhil Goyal
> > > > > > > +static void
> > > > > > > +mlx5_crypto_sym_session_clear(struct rte_cryptodev *dev,
> > > > > > > +                           struct rte_cryptodev_sym_session *sess) {
> > > > > > > +     struct mlx5_crypto_priv *priv = dev->data->dev_private;
> > > > > > > +     struct mlx5_crypto_session *sess_private_data =
> > > > > > > +                     get_sym_session_private_data(sess,
> > > > > > > +dev->driver_id);
> > > > > > > +
> > > > > > > +     if (unlikely(sess_private_data == NULL)) {
> > > > > > > +             DRV_LOG(ERR, "Failed to get session %p private data.",
> > > > > > > +                             sess_private_data);
> > > > > > > +             return;
> > > > > > > +     }
> > > > > > > +     mlx5_crypto_dek_destroy(priv, sess_private_data->dek);
> > > > > > > +     DRV_LOG(DEBUG, "Session %p was cleared.",
> > > > > > > + sess_private_data);
> > > }
> > > > > >
> > > > > > Memory leakage, mempool is not freed.
> > > > >
> > > > > Yes, good catch, this part was missed.
> > > > >
> > > > > > IMO, this driver is not properly tested with the unit test app.
> > > > >
> > > > > The only app we tested until now is l2fwd_crypto and it works fine!
> > > > > We can add it to doc.
> > > > >
> > > > > > Please add a note in the documentation that it is tested with
> autotest.
> > > > >
> > > > >
> > > > > The next app we want to test with, is test-crypto-perf.
> > > > >
> > > > I would recommend to run the test app first.
> > > > It will catch most of your basic bugs like the one above.
> > >
> > > It is too late for this, will add the test adjustment later.
> >
> > Can we postpone the PMD to next release.
> 
> We can, but this is not our plan.
> We met all the DPDK rules to push it on time.

On time!! Really? Incomplete v1 was submitted before RC1,
The complete PMD was submitted only during RC2.

> 
> > I believe test application makes
> > The PMD look robust as per the DPDK crypto PMD API usage.
> 
> Every test will add robustness to the PMD.
> 
> > I haven't seen a PMD getting merged without test app.
> 
> compress/mlx5, vdpa/mlx5, regex/mlx5, net/mlx5, vdev_netvsc....
> 
All these are 'not' crypto PMDs.
For crypto, UT is a must. I would like to add a statement in the guidelines if it is not there.

> > And I apologize I did not mentioned it earlier, but it is kind of obvious thing
> to
> > run test app before sending it to upstream.
> 
> In fact, no, I added more than one PMD, no one require specific test.
> 
> > L2fwd-crypto is not doing data validation hence you cannot be sure that it
> is
> > working fine as per other standard stacks like Linux.
> 
> It is not do data validation, but we check that the packet payload return back
> has the expected encrypted\decrypted data using open-ssl.
> Also for us it was mandatory requirement to check it.
> 
> For us, the current validation is enough, we don't support a lot of things in
> the crypto PMD currently, only one algorithm in the most basic modes.
> 
> For sure we will continue to add tests and to increase robustness.
> Also adding more features is in plan for future.
> 
> If you postpone it, it yours, we don't agree with it.
> 
Please fix the review comments by today, if you want it  to be merged in RC3.
IMO, the driver is not ready to be merged. 
I want to postpone it as it is not feasible to fix all the comments by RC3 timeline.
I believe all my comments are valid and need to be addressed.
Can you get somebody else(outside Nvidia) to ack your patch and counter my comments?
I will merge it without review based on that Ack.

Regards,
Akhil

  reply	other threads:[~2021-05-12  6:47 UTC|newest]

Thread overview: 278+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11  7:26 [dpdk-dev] [RFC] drivers: introduce mlx5 crypto PMD Matan Azrad
2021-04-08 20:48 ` [dpdk-dev] [PATCH 00/24] " Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 01/24] common/mlx5: remove redundant spaces in header file Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 02/24] common/mlx5: update GENEVE TLV OPT obj name Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 03/24] common/mlx5: optimize read of general obj type caps Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 04/24] common/mlx5: add HCA cap for AES-XTS crypto Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 05/24] common/mlx5: support general object DEK create op Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 06/24] common/mlx5: add crypto en field to MKEY context Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 07/24] common/mlx5: support umr en field in " Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 08/24] common/mlx5: support general obj IMPORT KEK create Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 09/24] common/mlx5: support general obj CRYPTO LOGIN create Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 10/24] common/mlx5: add crypto BSF struct and defines Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 11/24] common/mlx5: share hash list tool Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 12/24] common/mlx5: share get ib device match function Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 13/24] common/mlx5: support general obj CREDENTIAL create Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 14/24] common/mlx5: add crypto register structs and defs Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 15/24] common/mlx5: support register write access Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 16/24] drivers: introduce mlx5 crypto PMD Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 17/24] crypto/mlx5: add DEK object management Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 18/24] crypto/mlx5: support session operations Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 19/24] crypto/mlx5: add basic operations Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 20/24] crypto/mlx5: support queue pairs operations Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 21/24] crypto/mlx5: add dev stop and start operations Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 22/24] crypto/mlx5: add memory region management Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 23/24] crypto/mlx5: create login object using DevX Shiri Kuzin
2021-04-08 20:48   ` [dpdk-dev] [PATCH 24/24] crypto/mlx5: adjust to the multiple data unit API Shiri Kuzin
2021-04-13 18:02   ` [dpdk-dev] [EXT] [PATCH 00/24] drivers: introduce mlx5 crypto PMD Akhil Goyal
2021-04-29 15:43   ` [dpdk-dev] [PATCH v2 00/16] mlx5 common part for crypto driver Matan Azrad
2021-04-29 15:43     ` [dpdk-dev] [PATCH v2 01/16] common/mlx5: remove redundant spaces in header file Matan Azrad
2021-04-29 15:43     ` [dpdk-dev] [PATCH v2 02/16] common/mlx5: update GENEVE TLV OPT obj name Matan Azrad
2021-04-29 15:43     ` [dpdk-dev] [PATCH v2 03/16] common/mlx5: optimize read of general obj type caps Matan Azrad
2021-04-29 15:43     ` [dpdk-dev] [PATCH v2 04/16] common/mlx5: add HCA cap for AES-XTS crypto Matan Azrad
2021-04-29 15:43     ` [dpdk-dev] [PATCH v2 05/16] common/mlx5: support general object DEK create op Matan Azrad
2021-04-29 15:43     ` [dpdk-dev] [PATCH v2 06/16] common/mlx5: adjust DevX MKEY fields for crypto Matan Azrad
2021-04-29 15:43     ` [dpdk-dev] [PATCH v2 07/16] common/mlx5: fix cypto bsf attr Matan Azrad
2021-04-29 15:56       ` Matan Azrad
2021-04-29 15:43     ` [dpdk-dev] [PATCH v2 08/16] common/mlx5: support general obj IMPORT KEK create Matan Azrad
2021-04-29 15:43     ` [dpdk-dev] [PATCH v2 09/16] common/mlx5: support general obj CRYPTO LOGIN create Matan Azrad
2021-04-29 15:43     ` [dpdk-dev] [PATCH v2 10/16] common/mlx5: add crypto BSF struct and defines Matan Azrad
2021-04-29 15:43     ` [dpdk-dev] [PATCH v2 11/16] common/mlx5: share hash list tool Matan Azrad
2021-04-29 15:43     ` [dpdk-dev] [PATCH v2 12/16] common/mlx5: share get ib device match function Matan Azrad
2021-05-04 10:55       ` Thomas Monjalon
2021-05-04 11:30         ` Matan Azrad
2021-04-29 15:43     ` [dpdk-dev] [PATCH v2 13/16] common/mlx5: support general obj CREDENTIAL create Matan Azrad
2021-04-29 15:43     ` [dpdk-dev] [PATCH v2 14/16] common/mlx5: add crypto register structs and defs Matan Azrad
2021-04-29 15:43     ` [dpdk-dev] [PATCH v2 15/16] common/mlx5: support register write access Matan Azrad
2021-05-04 10:58       ` Thomas Monjalon
2021-05-04 11:32         ` Matan Azrad
2021-04-29 15:43     ` [dpdk-dev] [PATCH v2 16/16] common/mlx5: add UMR and RDMA write WQE defines Matan Azrad
2021-05-02  7:27     ` [dpdk-dev] [PATCH v2 00/16] mlx5 common part for crypto driver Matan Azrad
2021-05-04 17:54     ` [dpdk-dev] [PATCH v3 00/15] " Matan Azrad
2021-05-04 17:54       ` [dpdk-dev] [PATCH v3 01/15] common/mlx5: remove redundant spaces in header file Matan Azrad
2021-05-04 17:54       ` [dpdk-dev] [PATCH v3 02/15] common/mlx5: update GENEVE TLV OPT obj name Matan Azrad
2021-05-04 17:54       ` [dpdk-dev] [PATCH v3 03/15] common/mlx5: optimize read of general obj type caps Matan Azrad
2021-05-04 17:54       ` [dpdk-dev] [PATCH v3 04/15] common/mlx5: add HCA cap for AES-XTS crypto Matan Azrad
2021-05-04 17:54       ` [dpdk-dev] [PATCH v3 05/15] common/mlx5: support general object DEK create op Matan Azrad
2021-05-04 17:54       ` [dpdk-dev] [PATCH v3 06/15] common/mlx5: adjust DevX MKEY fields for crypto Matan Azrad
2021-05-04 17:54       ` [dpdk-dev] [PATCH v3 07/15] common/mlx5: support general obj IMPORT KEK create Matan Azrad
2021-05-04 17:54       ` [dpdk-dev] [PATCH v3 08/15] common/mlx5: support general obj CRYPTO LOGIN create Matan Azrad
2021-05-04 17:54       ` [dpdk-dev] [PATCH v3 09/15] common/mlx5: add crypto BSF struct and defines Matan Azrad
2021-05-04 17:54       ` [dpdk-dev] [PATCH v3 10/15] common/mlx5: share hash list tool Matan Azrad
2021-05-04 17:54       ` [dpdk-dev] [PATCH v3 11/15] common/mlx5: share get ib device match function Matan Azrad
2021-05-04 17:54       ` [dpdk-dev] [PATCH v3 12/15] common/mlx5: support general obj CREDENTIAL create Matan Azrad
2021-05-04 17:54       ` [dpdk-dev] [PATCH v3 13/15] common/mlx5: add crypto register structs and defs Matan Azrad
2021-05-04 17:54       ` [dpdk-dev] [PATCH v3 14/15] common/mlx5: support register write access Matan Azrad
2021-05-04 17:55       ` [dpdk-dev] [PATCH v3 15/15] common/mlx5: add UMR and RDMA write WQE defines Matan Azrad
2021-05-04 21:17       ` [dpdk-dev] [PATCH v3 00/15] mlx5 common part for crypto driver Thomas Monjalon
2021-04-29 15:46   ` [dpdk-dev] [PATCH v2 00/15] drivers: introduce mlx5 crypto PMD Matan Azrad
2021-04-29 15:46     ` [dpdk-dev] [PATCH v2 01/15] " Matan Azrad
2021-04-29 15:46     ` [dpdk-dev] [PATCH v2 02/15] crypto/mlx5: add DEK object management Matan Azrad
2021-04-29 15:47     ` [dpdk-dev] [PATCH v2 03/15] crypto/mlx5: support session operations Matan Azrad
2021-04-29 15:47     ` [dpdk-dev] [PATCH v2 04/15] crypto/mlx5: add basic operations Matan Azrad
2021-04-29 15:47     ` [dpdk-dev] [PATCH v2 05/15] crypto/mlx5: support queue pairs operations Matan Azrad
2021-04-29 15:47     ` [dpdk-dev] [PATCH v2 06/15] crypto/mlx5: add dev stop and start operations Matan Azrad
2021-04-29 15:47     ` [dpdk-dev] [PATCH v2 07/15] crypto/mlx5: add memory region management Matan Azrad
2021-04-29 15:47     ` [dpdk-dev] [PATCH v2 08/15] crypto/mlx5: create login object using DevX Matan Azrad
2021-04-29 15:47     ` [dpdk-dev] [PATCH v2 09/15] crypto/mlx5: adjust to the multiple data unit API Matan Azrad
2021-04-29 15:47     ` [dpdk-dev] [PATCH v2 10/15] crypto/mlx5: add keytag device argument Matan Azrad
2021-04-29 15:47     ` [dpdk-dev] [PATCH v2 11/15] crypto/mlx5: add maximum segments " Matan Azrad
2021-04-29 15:47     ` [dpdk-dev] [PATCH v2 12/15] crypto/mlx5: add WQE set initialization Matan Azrad
2021-04-29 15:47     ` [dpdk-dev] [PATCH v2 13/15] crypto/mlx5: add enqueue and dequeue operations Matan Azrad
2021-04-29 15:47     ` [dpdk-dev] [PATCH v2 14/15] crypto/mlx5: add statistic get and reset operations Matan Azrad
2021-04-29 15:47     ` [dpdk-dev] [PATCH v2 15/15] crypto/mlx5: set feature flags and capabilities Matan Azrad
2021-05-02  7:27     ` [dpdk-dev] [PATCH v2 00/15] drivers: introduce mlx5 crypto PMD Matan Azrad
2021-05-04 21:08     ` [dpdk-dev] [PATCH v3 " Matan Azrad
2021-05-04 21:08       ` [dpdk-dev] [PATCH v3 01/15] " Matan Azrad
2021-05-08 11:16         ` [dpdk-dev] [EXT] " Akhil Goyal
2021-05-09  7:46           ` Matan Azrad
2021-05-09  9:32             ` Akhil Goyal
2021-05-09 14:25               ` Matan Azrad
2021-05-11 17:24                 ` Akhil Goyal
2021-05-12  5:32                   ` Matan Azrad
2021-05-12  5:43                     ` Akhil Goyal
2021-05-10  8:49               ` Bruce Richardson
2021-05-04 21:08       ` [dpdk-dev] [PATCH v3 02/15] crypto/mlx5: add DEK object management Matan Azrad
2021-05-04 21:08       ` [dpdk-dev] [PATCH v3 03/15] crypto/mlx5: support session operations Matan Azrad
2021-05-08 12:44         ` [dpdk-dev] [EXT] " Akhil Goyal
2021-05-09  8:03           ` Matan Azrad
2021-05-09  9:21             ` Akhil Goyal
2021-05-09 14:25               ` Matan Azrad
2021-05-11 17:30                 ` Akhil Goyal
2021-05-12  5:51                   ` Matan Azrad
2021-05-12  6:47                     ` Akhil Goyal [this message]
2021-05-12  7:25                       ` Matan Azrad
2021-05-12  7:01                     ` Thomas Monjalon
2021-05-04 21:08       ` [dpdk-dev] [PATCH v3 04/15] crypto/mlx5: add basic operations Matan Azrad
2021-05-04 21:08       ` [dpdk-dev] [PATCH v3 05/15] crypto/mlx5: support queue pairs operations Matan Azrad
2021-05-04 21:08       ` [dpdk-dev] [PATCH v3 06/15] crypto/mlx5: add dev stop and start operations Matan Azrad
2021-05-04 21:08       ` [dpdk-dev] [PATCH v3 07/15] crypto/mlx5: add memory region management Matan Azrad
2021-05-04 21:08       ` [dpdk-dev] [PATCH v3 08/15] crypto/mlx5: create login object using DevX Matan Azrad
2021-05-04 21:08       ` [dpdk-dev] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data unit API Matan Azrad
2021-05-08 12:27         ` [dpdk-dev] [EXT] " Akhil Goyal
2021-05-09  8:05           ` Matan Azrad
2021-05-09  9:19             ` Akhil Goyal
2021-05-09 14:24               ` Matan Azrad
2021-05-11 17:34                 ` Akhil Goyal
2021-05-12  5:53                   ` Matan Azrad
2021-05-12  6:49                     ` Akhil Goyal
2021-05-04 21:08       ` [dpdk-dev] [PATCH v3 10/15] crypto/mlx5: add keytag device argument Matan Azrad
2021-05-08 12:31         ` [dpdk-dev] [EXT] " Akhil Goyal
2021-05-09  8:31           ` Matan Azrad
2021-05-09  8:56             ` Thomas Monjalon
2021-05-09 15:41               ` Matan Azrad
2021-05-09  9:17             ` Akhil Goyal
2021-05-09 14:23               ` Matan Azrad
2021-05-11 17:38                 ` Akhil Goyal
2021-05-12  5:57                   ` Matan Azrad
2021-05-04 21:08       ` [dpdk-dev] [PATCH v3 11/15] crypto/mlx5: add maximum segments " Matan Azrad
2021-05-04 21:08       ` [dpdk-dev] [PATCH v3 12/15] crypto/mlx5: add WQE set initialization Matan Azrad
2021-05-04 21:08       ` [dpdk-dev] [PATCH v3 13/15] crypto/mlx5: add enqueue and dequeue operations Matan Azrad
2021-05-08 12:18         ` [dpdk-dev] [EXT] " Akhil Goyal
2021-05-09  8:32           ` Matan Azrad
2021-05-04 21:08       ` [dpdk-dev] [PATCH v3 14/15] crypto/mlx5: add statistic get and reset operations Matan Azrad
2021-05-04 21:08       ` [dpdk-dev] [PATCH v3 15/15] crypto/mlx5: set feature flags and capabilities Matan Azrad
2021-05-08 12:13         ` [dpdk-dev] [EXT] " Akhil Goyal
2021-05-09  8:47           ` Matan Azrad
2021-05-09  9:14             ` Akhil Goyal
2021-05-09 14:19               ` Matan Azrad
2021-05-11 18:04                 ` Akhil Goyal
2021-05-12  6:07                   ` Matan Azrad
2021-05-12  6:55                     ` Akhil Goyal
2021-05-09 16:04       ` [dpdk-dev] [PATCH v4 00/14] drivers: introduce mlx5 crypto PMD Matan Azrad
2021-05-09 16:04         ` [dpdk-dev] [PATCH v4 01/14] " Matan Azrad
2021-05-09 16:04         ` [dpdk-dev] [PATCH v4 02/14] crypto/mlx5: add DEK object management Matan Azrad
2021-05-09 16:04         ` [dpdk-dev] [PATCH v4 03/14] crypto/mlx5: add session operations Matan Azrad
2021-05-09 16:04         ` [dpdk-dev] [PATCH v4 04/14] crypto/mlx5: add basic operations Matan Azrad
2021-05-09 16:04         ` [dpdk-dev] [PATCH v4 05/14] crypto/mlx5: add queue pairs operations Matan Azrad
2021-05-09 16:04         ` [dpdk-dev] [PATCH v4 06/14] crypto/mlx5: add dev stop and start operations Matan Azrad
2021-05-09 16:05         ` [dpdk-dev] [PATCH v4 07/14] crypto/mlx5: add memory region management Matan Azrad
2021-05-09 16:05         ` [dpdk-dev] [PATCH v4 08/14] crypto/mlx5: create login object using DevX Matan Azrad
2021-05-09 16:05         ` [dpdk-dev] [PATCH v4 09/14] crypto/mlx5: add keytag devarg Matan Azrad
2021-05-09 16:05         ` [dpdk-dev] [PATCH v4 10/14] crypto/mlx5: add maximum segments devarg Matan Azrad
2021-05-09 16:05         ` [dpdk-dev] [PATCH v4 11/14] crypto/mlx5: add WQE set initialization Matan Azrad
2021-05-09 16:05         ` [dpdk-dev] [PATCH v4 12/14] crypto/mlx5: add enqueue and dequeue operations Matan Azrad
2021-05-09 16:05         ` [dpdk-dev] [PATCH v4 13/14] crypto/mlx5: add statistic get and reset operations Matan Azrad
2021-05-09 16:05         ` [dpdk-dev] [PATCH v4 14/14] crypto/mlx5: set feature flags and capabilities Matan Azrad
2021-07-01 13:25         ` [dpdk-dev] [PATCH v5 00/15] drivers: introduce mlx5 crypto PMD Shiri Kuzin
2021-07-01 13:25           ` [dpdk-dev] [PATCH v5 01/15] " Shiri Kuzin
2021-07-01 13:58             ` David Marchand
2021-07-01 13:25           ` [dpdk-dev] [PATCH v5 02/15] crypto/mlx5: add DEK object management Shiri Kuzin
2021-07-01 13:25           ` [dpdk-dev] [PATCH v5 03/15] crypto/mlx5: add session operations Shiri Kuzin
2021-07-01 13:25           ` [dpdk-dev] [PATCH v5 04/15] crypto/mlx5: add basic operations Shiri Kuzin
2021-07-01 13:25           ` [dpdk-dev] [PATCH v5 05/15] crypto/mlx5: add queue pairs operations Shiri Kuzin
2021-07-01 13:26           ` [dpdk-dev] [PATCH v5 06/15] crypto/mlx5: add dev stop and start operations Shiri Kuzin
2021-07-01 13:26           ` [dpdk-dev] [PATCH v5 07/15] crypto/mlx5: add memory region management Shiri Kuzin
2021-07-01 13:26           ` [dpdk-dev] [PATCH v5 08/15] crypto/mlx5: create login object using DevX Shiri Kuzin
2021-07-01 13:26           ` [dpdk-dev] [PATCH v5 09/15] crypto/mlx5: add keytag devarg Shiri Kuzin
2021-07-01 13:26           ` [dpdk-dev] [PATCH v5 10/15] crypto/mlx5: add maximum segments devarg Shiri Kuzin
2021-07-01 13:26           ` [dpdk-dev] [PATCH v5 11/15] crypto/mlx5: add WQE set initialization Shiri Kuzin
2021-07-01 13:26           ` [dpdk-dev] [PATCH v5 12/15] crypto/mlx5: add enqueue and dequeue operations Shiri Kuzin
2021-07-01 13:26           ` [dpdk-dev] [PATCH v5 13/15] crypto/mlx5: add statistic get and reset operations Shiri Kuzin
2021-07-01 13:26           ` [dpdk-dev] [PATCH v5 14/15] test/crypto: add mlx5 crypto driver Shiri Kuzin
2021-07-06  8:47             ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-06  9:04               ` Thomas Monjalon
2021-07-01 13:26           ` [dpdk-dev] [PATCH v5 15/15] test/crypto: add mlx5 multi segment tests Shiri Kuzin
2021-07-06  7:48             ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-06  9:11               ` Shiri Kuzin
2021-07-06  9:37                 ` Akhil Goyal
2021-07-06 10:37                   ` Shiri Kuzin
2021-07-08 15:25           ` [dpdk-dev] [PATCH v6 00/15] drivers: introduce mlx5 crypto PMD Shiri Kuzin
2021-07-08 15:25             ` [dpdk-dev] [PATCH v6 01/15] " Shiri Kuzin
2021-07-08 15:25             ` [dpdk-dev] [PATCH v6 02/15] crypto/mlx5: add DEK object management Shiri Kuzin
2021-07-08 15:25             ` [dpdk-dev] [PATCH v6 03/15] crypto/mlx5: add session operations Shiri Kuzin
2021-07-08 15:25             ` [dpdk-dev] [PATCH v6 04/15] crypto/mlx5: add basic operations Shiri Kuzin
2021-07-08 15:25             ` [dpdk-dev] [PATCH v6 05/15] crypto/mlx5: add queue pairs operations Shiri Kuzin
2021-07-08 15:25             ` [dpdk-dev] [PATCH v6 06/15] crypto/mlx5: add dev stop and start operations Shiri Kuzin
2021-07-08 15:25             ` [dpdk-dev] [PATCH v6 07/15] crypto/mlx5: add memory region management Shiri Kuzin
2021-07-08 15:25             ` [dpdk-dev] [PATCH v6 08/15] crypto/mlx5: create login object using DevX Shiri Kuzin
2021-07-08 15:25             ` [dpdk-dev] [PATCH v6 09/15] crypto/mlx5: add keytag devarg Shiri Kuzin
2021-07-08 15:25             ` [dpdk-dev] [PATCH v6 10/15] crypto/mlx5: add maximum segments devarg Shiri Kuzin
2021-07-08 15:25             ` [dpdk-dev] [PATCH v6 11/15] crypto/mlx5: add WQE set initialization Shiri Kuzin
2021-07-08 15:25             ` [dpdk-dev] [PATCH v6 12/15] crypto/mlx5: add enqueue and dequeue operations Shiri Kuzin
2021-07-08 15:25             ` [dpdk-dev] [PATCH v6 13/15] crypto/mlx5: add statistic get and reset operations Shiri Kuzin
2021-07-08 15:25             ` [dpdk-dev] [PATCH v6 14/15] test/crypto: add mlx5 crypto driver Shiri Kuzin
2021-07-08 15:25             ` [dpdk-dev] [PATCH v6 15/15] test/crypto: add data-unit and wrapped vectors Shiri Kuzin
2021-07-15 15:08             ` [dpdk-dev] [PATCH v7 00/16] drivers: introduce mlx5 crypto PMD Shiri Kuzin
2021-07-15 15:08               ` [dpdk-dev] [PATCH v7 01/16] " Shiri Kuzin
2021-07-15 15:08               ` [dpdk-dev] [PATCH v7 02/16] crypto/mlx5: add DEK object management Shiri Kuzin
2021-07-15 15:08               ` [dpdk-dev] [PATCH v7 03/16] crypto/mlx5: add session operations Shiri Kuzin
2021-07-15 15:08               ` [dpdk-dev] [PATCH v7 04/16] crypto/mlx5: add basic operations Shiri Kuzin
2021-07-15 15:08               ` [dpdk-dev] [PATCH v7 05/16] crypto/mlx5: add queue pairs operations Shiri Kuzin
2021-07-15 15:08               ` [dpdk-dev] [PATCH v7 06/16] crypto/mlx5: add dev stop and start operations Shiri Kuzin
2021-07-15 15:08               ` [dpdk-dev] [PATCH v7 07/16] crypto/mlx5: add memory region management Shiri Kuzin
2021-07-15 15:08               ` [dpdk-dev] [PATCH v7 08/16] crypto/mlx5: create login object using DevX Shiri Kuzin
2021-07-15 15:08               ` [dpdk-dev] [PATCH v7 09/16] crypto/mlx5: add keytag devarg Shiri Kuzin
2021-07-15 15:08               ` [dpdk-dev] [PATCH v7 10/16] crypto/mlx5: add maximum segments devarg Shiri Kuzin
2021-07-15 15:08               ` [dpdk-dev] [PATCH v7 11/16] crypto/mlx5: add WQE set initialization Shiri Kuzin
2021-07-15 15:08               ` [dpdk-dev] [PATCH v7 12/16] crypto/mlx5: add enqueue and dequeue operations Shiri Kuzin
2021-07-15 15:08               ` [dpdk-dev] [PATCH v7 13/16] crypto/mlx5: add statistic get and reset operations Shiri Kuzin
2021-07-15 15:08               ` [dpdk-dev] [PATCH v7 14/16] test/crypto: add mlx5 crypto driver Shiri Kuzin
2021-07-15 15:08               ` [dpdk-dev] [PATCH v7 15/16] test/crypto: add data-unit and wrapped vectors Shiri Kuzin
2021-07-15 15:08               ` [dpdk-dev] [PATCH v7 16/16] test/crypto: add AES-XTS multi segment OOP tests Shiri Kuzin
2021-07-15 16:41               ` [dpdk-dev] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD Shiri Kuzin
2021-07-15 16:41                 ` [dpdk-dev] [PATCH v8 01/16] " Shiri Kuzin
2021-07-16 19:19                   ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-20  8:26                     ` Suanming Mou
2021-07-15 16:41                 ` [dpdk-dev] [PATCH v8 02/16] crypto/mlx5: add DEK object management Shiri Kuzin
2021-07-16 19:26                   ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-20  8:31                     ` Suanming Mou
2021-07-20  8:36                       ` Akhil Goyal
2021-07-20  8:49                         ` Suanming Mou
2021-07-20  8:55                           ` Akhil Goyal
2021-07-15 16:41                 ` [dpdk-dev] [PATCH v8 03/16] crypto/mlx5: add session operations Shiri Kuzin
2021-07-16 19:40                   ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-20  8:59                     ` Suanming Mou
2021-07-20  9:01                       ` Akhil Goyal
2021-07-16 19:43                   ` Akhil Goyal
2021-07-20  9:07                     ` Suanming Mou
2021-07-20  9:43                       ` Akhil Goyal
2021-07-15 16:41                 ` [dpdk-dev] [PATCH v8 04/16] crypto/mlx5: add basic operations Shiri Kuzin
2021-07-16 19:34                   ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-20  8:33                     ` Suanming Mou
2021-07-15 16:41                 ` [dpdk-dev] [PATCH v8 05/16] crypto/mlx5: add queue pairs operations Shiri Kuzin
2021-07-15 16:41                 ` [dpdk-dev] [PATCH v8 06/16] crypto/mlx5: add dev stop and start operations Shiri Kuzin
2021-07-16 19:44                   ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-20  9:08                     ` Suanming Mou
2021-07-15 16:41                 ` [dpdk-dev] [PATCH v8 07/16] crypto/mlx5: add memory region management Shiri Kuzin
2021-07-15 16:41                 ` [dpdk-dev] [PATCH v8 08/16] crypto/mlx5: create login object using DevX Shiri Kuzin
2021-07-15 16:41                 ` [dpdk-dev] [PATCH v8 09/16] crypto/mlx5: add keytag devarg Shiri Kuzin
2021-07-15 16:41                 ` [dpdk-dev] [PATCH v8 10/16] crypto/mlx5: add maximum segments devarg Shiri Kuzin
2021-07-15 16:41                 ` [dpdk-dev] [PATCH v8 11/16] crypto/mlx5: add WQE set initialization Shiri Kuzin
2021-07-15 16:41                 ` [dpdk-dev] [PATCH v8 12/16] crypto/mlx5: add enqueue and dequeue operations Shiri Kuzin
2021-07-15 16:41                 ` [dpdk-dev] [PATCH v8 13/16] crypto/mlx5: add statistic get and reset operations Shiri Kuzin
2021-07-15 16:41                 ` [dpdk-dev] [PATCH v8 14/16] test/crypto: add mlx5 crypto driver Shiri Kuzin
2021-07-16 19:55                   ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-15 16:41                 ` [dpdk-dev] [PATCH v8 15/16] test/crypto: add data-unit and wrapped vectors Shiri Kuzin
2021-07-16 20:06                   ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-20  9:24                     ` Suanming Mou
2021-07-20  9:50                       ` Akhil Goyal
2021-07-15 16:41                 ` [dpdk-dev] [PATCH v8 16/16] test/crypto: add AES-XTS multi segment OOP tests Shiri Kuzin
2021-07-16 20:10                   ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-16 19:05                 ` [dpdk-dev] [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD Akhil Goyal
2021-07-16 20:17                   ` Akhil Goyal
2021-07-20  8:13                     ` Akhil Goyal
2021-07-20  8:22                       ` Suanming Mou
2021-07-20  8:38                         ` Akhil Goyal
2021-07-20  8:41                           ` Akhil Goyal
2021-07-20  8:44                             ` Suanming Mou
2021-07-20 13:09   ` [dpdk-dev] [PATCH v9 00/15] " Suanming Mou
2021-07-20 13:09     ` [dpdk-dev] [PATCH v9 01/15] " Suanming Mou
2021-07-20 13:09     ` [dpdk-dev] [PATCH v9 02/15] crypto/mlx5: add DEK object management Suanming Mou
2021-07-20 13:09     ` [dpdk-dev] [PATCH v9 03/15] crypto/mlx5: add basic operations Suanming Mou
2021-07-20 13:09     ` [dpdk-dev] [PATCH v9 04/15] crypto/mlx5: add queue pairs operations Suanming Mou
2021-07-20 13:09     ` [dpdk-dev] [PATCH v9 05/15] crypto/mlx5: add session operations Suanming Mou
2021-07-20 13:09     ` [dpdk-dev] [PATCH v9 06/15] crypto/mlx5: add memory region management Suanming Mou
2021-07-20 13:09     ` [dpdk-dev] [PATCH v9 07/15] crypto/mlx5: create login object using DevX Suanming Mou
2021-07-20 13:09     ` [dpdk-dev] [PATCH v9 08/15] crypto/mlx5: add keytag devarg Suanming Mou
2021-07-20 13:09     ` [dpdk-dev] [PATCH v9 09/15] crypto/mlx5: add maximum segments devarg Suanming Mou
2021-07-20 13:09     ` [dpdk-dev] [PATCH v9 10/15] crypto/mlx5: add WQE set initialization Suanming Mou
2021-07-20 13:09     ` [dpdk-dev] [PATCH v9 11/15] crypto/mlx5: add enqueue and dequeue operations Suanming Mou
2021-07-20 13:09     ` [dpdk-dev] [PATCH v9 12/15] crypto/mlx5: add statistic get and reset operations Suanming Mou
2021-07-20 13:09     ` [dpdk-dev] [PATCH v9 13/15] test/crypto: add data-unit and wrapped vectors Suanming Mou
2021-07-20 13:09     ` [dpdk-dev] [PATCH v9 14/15] test/crypto: add AES-XTS multi segment OOP tests Suanming Mou
2021-07-20 13:09     ` [dpdk-dev] [PATCH v9 15/15] test/crypto: add mlx5 crypto driver Suanming Mou
2021-07-20 20:43     ` [dpdk-dev] [EXT] [PATCH v9 00/15] drivers: introduce mlx5 crypto PMD Akhil Goyal
2021-07-20 21:01       ` Akhil Goyal
2021-07-21  0:26         ` Suanming Mou
2021-07-21  1:14           ` Suanming Mou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW2PR18MB2284E81977C537C5D48F86AAD8529@MW2PR18MB2284.namprd18.prod.outlook.com \
    --to=gakhil@marvell.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=shirik@nvidia.com \
    --cc=suanmingm@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).