From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B2E1A0A0E; Tue, 11 May 2021 20:04:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E86A4003F; Tue, 11 May 2021 20:04:17 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 73BEF4003E for ; Tue, 11 May 2021 20:04:16 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14BHuXn9004515; Tue, 11 May 2021 11:04:15 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by mx0a-0016f401.pphosted.com with ESMTP id 38fw8y8dw7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 May 2021 11:04:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ejvWHTXzzO83l2xu5OSUHVvx8ja2U7SgsTNiBCE8tK3t0jLHr5skeZOT7fskNg9NE7Uky3XSbfCrZh5TgcuEhWA8+G1Gl3SdPA6QJ3SO+OLLihamNfAB4dpeUuNOY5xp/d+XqZ9+vaSxlG1mTta0+Sg5shzVwl1UovMeUFXgi+9ll4snrplSpeSWSIvQaDEVcvPzsFAlbu3Bgqs5lYK/H/VP6PNotth+lQDCXuJc+GgbT4Paat8gww5TR2y0txYd/I1qoZHciN2oSMs1MBe+jKDP7erl9IWYGCMAlKMc/z3QlUeAyinVLNW5zSVVIN9hAvLaDNmmNrKsoUP1bAzfuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KK7ZYbqhngk1jch1+YgFJD5Rf6H0c2xuokGgLAF7ejE=; b=OWC/LbguoXQ9E1M4IVGA/N6QuSsrUTGPLjdQbQStoynBWCxeSek/zKvX/NG7gJLe9tT3VQhUs5KhCh+K/ZJ2JGCm2u+CfdvaDkg/ZwSQt3MXgUGi2Ddhgi5uUQu5UA7bvnU2kunk3s0belcyoz0ntT/gL004rUkQ0miszmuVTHIEj29Ti67FiT+vlgQyW+haYLCqGbH1sQHs1FBGEW7sbjZXNgJSrozyitXFfd0krd/IbHE8kQD9qXjIbdl6q9FIjhJ6kDi4VkD8kJIlMRwXUEABiHOQdhjg8sYNXb+jPH80ORmvUYJTVH+9jCiq5S67ogrE0afIojH0ds4NREQGjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KK7ZYbqhngk1jch1+YgFJD5Rf6H0c2xuokGgLAF7ejE=; b=lptUcIXGq4pNAw1zyMpeN+iI7xnI71kwoIq3MInaXbwkrJU92ofdHcMfkh4Sxz0RkrxigCudd96ZT2lyBFhWdJdiz6lvvhfo8g9bep48KUtVUc7qEOMbfvxPgWpafGFs3IkkwlkBgOcUu4XP4p3iH6TFenPkKgGRl3evYWLrn9Y= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR18MB1680.namprd18.prod.outlook.com (2603:10b6:300:c7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Tue, 11 May 2021 18:04:11 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4129.025; Tue, 11 May 2021 18:04:11 +0000 From: Akhil Goyal To: Matan Azrad , "dev@dpdk.org" , NBU-Contact-Thomas Monjalon CC: Suanming Mou , Shiri Kuzin Thread-Topic: [EXT] [PATCH v3 15/15] crypto/mlx5: set feature flags and capabilities Thread-Index: AQHXQSnWsvz25MKtdkqt23wDGjSfNKrZdQEAgAFodoCAAAPToIAAWQeAgANc4mA= Date: Tue, 11 May 2021 18:04:11 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-16-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [171.48.51.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 825e5667-0209-4b86-a646-08d914a72e24 x-ms-traffictypediagnostic: MWHPR18MB1680: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4UOo6ReOXhM7gIiFLiZAB+09Zzz+1HZX2Pur88CuzfLtKdoxovJOoQC2IVdoZ+AqZVaO2HiztjzbE2XhlBNIFZcGA1LuGDaROFeNmN7lI9BG+Ik1f5B9yIU14vABsy6iUr9bSwUHP+SrL6LeH5lq9poVDlOzNnrFCS3EFsRdDohT6dkfioHUfEJDgDUWLJiQLXN8CZxxmXu7v8ggDXfgk325wBVozuhdq8s1GM/ED2YHS4QfiGDJCJFoTZqzg6p3iTncI2x8PWmxJjNtp+yVvVTtRF63bo4aAT+Nui+rb/yLg0TALw863Hn6HzPmHQbul7oJWfsuqauZGc9TyJF+CsC1E/UcQGqicw0xHXWCrEATz50amY0lGe/OMNF6IlmeL096YCVnYkKwD7z/ZbMJ8lsupfFbtucL7mFsV4gda+q19kobXOPWzwhdLEU/vPkyzaVqxRsu5INZQIacox47dbfAIevCt3ks4HQLR2AQQWgXqtrmV00zsHORN58xO93XzMUyPz2Ie0AhtUg3nk0bdkg0lL+T3HIvSEIOqBpnmYRuMxYhukC9bb/SGca4uKXxkjrOSxFjng//yM06PhhMh9mTsVWJyI/ikgVQU7KwKU0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(376002)(396003)(39860400002)(366004)(9686003)(33656002)(110136005)(54906003)(83380400001)(71200400001)(55016002)(478600001)(52536014)(122000001)(5660300002)(38100700002)(316002)(76116006)(66556008)(4326008)(64756008)(86362001)(66446008)(8676002)(8936002)(7696005)(26005)(66476007)(186003)(2906002)(66946007)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?BsOxfW7re6/LeHoXeL1y5Vcqx7y1B/AzWmZ/8+kmrZjA0KmJjOlLH2Kr3zTt?= =?us-ascii?Q?p1yebOnyVr8c9xmK8lO2NWQLYj+DHFz0rybseLVyyvD1LRHanCYGO2V6pEko?= =?us-ascii?Q?x4TLLIJoZHUzozgOw2x2fB22urPDrY3BYPm3T0bZ8rxR7y8y58gILRsb7sXz?= =?us-ascii?Q?eXeC1GQtke8ghr6df4Q2xta7h9sm8DXsu1uW3r5Vnd5/a5G42ygX+ygWg/kG?= =?us-ascii?Q?ixzawgc6Wre/FHBZVypvWwhw39NavhV0HYri2MnVgMyYhPQVzHhY/LLkmxYY?= =?us-ascii?Q?5jF+0wJTsv23pPX4FbkDFGNhtGtwbeUDJHnxjH6Z/kJN9Avqi0L58kTD9yRN?= =?us-ascii?Q?XTWMvCL5bhvcvER5yA+E1eqMtBX0Rnga9s0xmzmF00NbXrcFunw3Qo4pnyY2?= =?us-ascii?Q?b7bsQXnKvVR7haNuWIf630VKtgF3WalTwy2Vslgntgk1tK+4VS7lUIT/oEms?= =?us-ascii?Q?Nx5iHH8aC/CXtg0TjzZDEHzQHaabgDLOExTJNV4TuqdLcoFZesLSPVM1br3J?= =?us-ascii?Q?kFvehnY2EgCdkXCY473YAJ5wCpDvMFMvY+0LRUc+/asbSLayZ3q+cOrt5bt+?= =?us-ascii?Q?r3zfsQ9qQVLjSAnss41+CKT79ZmYLdLHSTO5pe/bDE+H2aJJzjyaQJonWQ4Z?= =?us-ascii?Q?o44E6cYWCwNwS+s5JtwPvztezAw9YKed+olSMHiWZqBcvtiFuVbJAjMngdLc?= =?us-ascii?Q?0ninIf1tjewp3qsFrUlWLXRgvcBugGsnS4VKCq5XvuFUbFk8jVz9+HEVjWOe?= =?us-ascii?Q?mlSD5HS8IHs0raIj8cgQUMzy94pPHY2cXH2xJhsJ1UENvx+t6AY9ZK4Y0IM3?= =?us-ascii?Q?BVUcavoPvZpugn/WpfoW0mOCvYCaBc2JF52CXnxZO33d1Fc0QvXXr+g0OzhS?= =?us-ascii?Q?L8MNgEZeSFVEuBzCeuXUgNHN0zIWFZ2K212U7LenMOrVIPKwH8WEOf3AHUNp?= =?us-ascii?Q?VDlEycOqHl91e13S63Jszs1A50n2RTNyw93Ow6CoZw3TMc/N4+8pDggJk2KQ?= =?us-ascii?Q?bFNxgP2R7iMAq2+hoxdYCByMxz1e2y4Voclx9jQ0q7TaieaFiOLH3BxY5Hey?= =?us-ascii?Q?OJJoD+acE1VoSjiB1jvDimIxsXeRSFx1SGASn0zo2BwBNv5xhcnHmrob9jqp?= =?us-ascii?Q?OeoizYG80YMGxNBJtJUDze/l83POhhp95NncCST2Hegpu4JQM/GPW0P7fJ69?= =?us-ascii?Q?JDH9oCeDbkD8lleQjjQEoNkjPi5PESV7Zf4epHejP/Rj7h/jdleXjbbF6KcT?= =?us-ascii?Q?Ys4ufu9kfRMhDxqK+ckCsB2xNF1GGPzJOQy/78nIy3zDmGr4KRby/WLqG3RG?= =?us-ascii?Q?hmk=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 825e5667-0209-4b86-a646-08d914a72e24 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2021 18:04:11.4724 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cUyo67iOTIkFiTpEuvh14+d/Qk47o3V4ELwUH0xCs3ZciFq5Lxp/0D897jOjleW2ZPLG1kY0/iGKI5nBZ+Gg7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1680 X-Proofpoint-GUID: zJpuH9xYLipcKO8r2BJT9rInKUVLip1l X-Proofpoint-ORIG-GUID: zJpuH9xYLipcKO8r2BJT9rInKUVLip1l X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-11_04:2021-05-11, 2021-05-11 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 15/15] crypto/mlx5: set feature flags and capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Matan, > > > > > +Prerequisites > > > > > +------------- > > > > > + > > > > > +- Mellanox OFED version: **5.3** > > > > > + see :doc:`../../nics/mlx5` guide for more Mellanox OFED detail= s. > > > > > > > > Since the driver is by default compiled off due to the dependency o= n > > > > external Libraries, I would recommend to add few lines here as well > > > > for compilation. > > > > Like to compile rdma-core and set PKG_CONFIG_LIBDIR. > > > > > > Why? all Mellanox drivers has the same external dependencies. > > > I added here link for the doc explains it well. > > > > This is a crypto PMD, not a NIC PMD. Somebody working on crypto PMDs, > do > > not really care about the NIC PMDs. > > Hence it would be convenient to have compilation information here as > well. > > You can refer to other document for details, but basic info should be a= dded > > here as well. >=20 > The link explains how to install OFED, this is only what the user need to= take > from the link. > The basic is to install OFED. > I don't see a reason to duplicate doc section which are exactly the same. As I compiled the PMD, it was not convenient to read the whole document. And it is not needed to compile linux and everything. I just needed rdma-core and set it in PKG_CONFIG_LIBDIR. The reason I am insisting here is, when somebody do small changes in Crypto library, he may need to do subsequent changes in all PMDs. For which compilation steps should be easily accessible in the PMD doc So that the patch can be compiled properly. Hence I just recommend to have 3-4 lines to enable the compilation In the PMD doc. > > > > > > > And I do not see any updates to the test application for testing th= is > driver. > > > > > > You can see update to l2fwd_crypto, we tested with this example for > > > the first stage. > > > Everything looks ok there. > > > > L2fwd-crypto is an app which only test data path with no packet validat= ion. > > It does not tell if your encryption is correctly done as per standards = or not. > > Did you test interoperability with l2fwd-crypto? > > All basic configuration tests are also not done, like cleanup etc of th= e PMD. > > I haven't seen a driver getting merge without the unit test application= run. > > Test app helps you comply with the way dpdk drivers are meant to be > > written. >=20 > We adjusted the l2fwd-crypto to the dataunit feature and wrapped keys. > We validated data integrity from the packet returns back from the crypto = net > port. > As I said, encryption\decryption with AES-XTS is working well. Do you test interoperability here? Encryption by MLX5 and decryption By another PMD/stack and vice-versa. Test app is supposed to have test vectors which will work on any platform. Hence data validation is done properly. >=20 > Now, is too late to update the test application to the above features, th= e > driver code is here for a long time, no one ask about the test adjustment= until > now. Can we defer to next release? I apologize for not asking it earlier. But th= is is kind of obvious for somebody working in DPDK. Please check that none of the PMD is merged without test app in the past 3-= 4yrs. >=20 > We can add the adjustment to increase validity for the next release to al= l the > remaining crypto apps (test\test-crypto-perf). >=20 > For now, we have one validation with l2fwd-crypto And any user can run it > and see how to use mlx5 driver. The user cannot be sure of the basic things of a crypto PMD are in order or= not. As l2fwd-crypto does not test every basic thing. For eg. Session deletion, PMD stop, PMD close, PMD restart, setting up multiple sessions(l2fwd support single session). Running datapath of a single use case is not sufficient for a PMD. This is a POC and it need to comply with the environment. I hope the doubts are clear now and we are OK to defer to next release. Regards, Akhil