Re: [dpdk-dev] [PATCH 5/6] test/crypto: dynamically build blockcipher suite

[Akhil Goyal <gakhil@marvell.com>]

Hi Ciara,

Nice work. I have below comment on the output of the results.

++ more crypto PMD maintainers.

> In the existing implementation, the blockcipher test cases are being run
> and reported as one test case per type, even though multiple test cases
> are hidden in each. For example, "test_AES_chain_all" runs 46 test cases.
> Each blockcipher type should have a testsuite instead.
> 
> The blockcipher testsuite is dynamically built, depending on the
> blockcipher type chosen. The testcase struct is modified to allow
> running a testcase with data, which is used for data required when
> running each blockcipher testcase.
> 
> The blockcipher testsuites are added dynamically to parent testsuites
> as sub-testsuites where needed.
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
When I run the patchset, The output I got is 
+ Sub Testsuites Total :       24 
 + Sub Testsuites Skipped :      2
 + Sub Testsuites Passed :      22
 + Sub Testsuites Failed :       0      

Is it possible for you to give more details in the end like 
Number of tests passed/failed/skipped/unsupported as well for each of the suite.

The reason is that, people normally check the report in the end.
For example: 
Crypto General(A/X passed, B/X skipped, C/X failed)
//one line for each of the suite.


Regards,
Akhil