From: "Stillwell Jr, Paul M" <paul.m.stillwell.jr@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wang, Haiyue" <haiyue.wang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "Zhao1, Wei" <wei.zhao1@intel.com>,
"Wang, Haiyue" <haiyue.wang@intel.com>,
"Liang, Cunming" <cunming.liang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support
Date: Mon, 16 Mar 2020 18:54:41 +0000 [thread overview]
Message-ID: <MW3PR11MB4538AFBE201FCD850045377FE0F90@MW3PR11MB4538.namprd11.prod.outlook.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E70611547E0B06@SHSMSX103.ccr.corp.intel.com>
See my responses inline.
Paul
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Saturday, March 14, 2020 6:50 PM
> To: Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>; dev@dpdk.org; Ye, Xiaolong
> <xiaolong.ye@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>
> Cc: Zhao1, Wei <wei.zhao1@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>; Liang, Cunming <cunming.liang@intel.com>; Wu,
> Jingjing <jingjing.wu@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support
>
> Hi Paul:
>
> > -----Original Message-----
> > From: Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>
> > Sent: Saturday, March 14, 2020 12:19 AM
> > To: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org; Ye, Xiaolong
> > <xiaolong.ye@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Yang,
> > Qiming <qiming.yang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> > Cc: Zhao1, Wei <wei.zhao1@intel.com>; Wang, Haiyue
> > <haiyue.wang@intel.com>
> > Subject: RE: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support
> >
> > I'm confused. Shouldn't the DCF be a separate driver since it is a VF,
> > not part of a PF? You are starting to combine PF/VF code and I'm not
> > sure if that is the correct way to go.
>
> From DPDK's view, DCF is NOT a VF driver, actually it behaves like a PF driver
> with control path only and it share most exist PF driver's API implementation
It *is* a VF. The only way this will work is if the VF has the trust flag set and then it can become the DCF. You can't set the trust flag on a PF I don't think. That's the only way this will work because the kernel driver code has checks on the admin queue messages to see if the message is from a VF. If it's not a message from a specific VF, then the message will get rejected.
> , That's why we combined it with exist PF driver, so when the module
> driver/net/ice is compiled into a library, it can be probed as a PF driver or DCF
> base on device ID at runtime.
> And the is not special in DPDK, for example, the module in driver/net/i40e
> can be probed as i40e pf driver or i40e vf driver.
> DCF take SR-IOV's mailbox as a message channel to communicate with the
> backend kernel driver, so iavf virtual channel is reused here, so we also need
> to link iavf share code.
>
> And I agree, its always better if we can separate 2 different things while
> decouple all the common code into a share library to avoid duplicate code
> copy (just like we did on iavf share code) But in this case, a lot of code
> refectory is required , so far we just take the simple way, we may improve
> this in future.
>
> Thanks
> Qi
>
> >
> > Paul
> >
> > > -----Original Message-----
> > > From: dev <dev-bounces@dpdk.org> On Behalf Of Haiyue Wang
> > > Sent: Monday, March 9, 2020 11:50 PM
> > > To: dev@dpdk.org; Ye, Xiaolong <xiaolong.ye@intel.com>; Zhang, Qi Z
> > > <qi.z.zhang@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Xing,
> > > Beilei <beilei.xing@intel.com>
> > > Cc: Zhao1, Wei <wei.zhao1@intel.com>; Wang, Haiyue
> > > <haiyue.wang@intel.com>
> > > Subject: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support
> > >
> > > A DCF (Device Config Function) based approach is proposed where a
> > > device bound to the device's VF0 can act as a sole controlling
> > > entity to exercise advance functionality (such as switch, ACL) for rest of
> the VFs.
> > >
> > > The DCF works as a standalone PMD to support this function, which
> > > shares the ice PMD flow control core function and the iavf virtchnl
> > > mailbox core module.
> > >
> > > This patchset is based on:
> > > [1] https://patchwork.dpdk.org/cover/66417/ : update ice base code
> > > [2] https://patchwork.dpdk.org/cover/66472/ : iavf share code update
> > >
> > > Depends-on: series-8843
> > > Depends-on: series-8855
> > >
> > > v2:
> > > 1. update the iavf patchset link.
> > > 2. split more patches for making this work be more understandable
> > > 3. fix the log function usage, devargs checking from v1.
> > >
> > > Haiyue Wang (7):
> > > net/iavf: stop the PCI probe in DCF mode
> > > net/ice: add the DCF hardware initialization
> > > net/ice: initiate to acquire the DCF capability
> > > net/ice: handle the AdminQ command by DCF
> > > net/ice: export the DDP definition symbols
> > > net/ice: handle the PF initialization by DCF
> > > net/ice: get the VF hardware index in DCF
> > >
> > > doc/guides/nics/ice.rst | 47 ++
> > > doc/guides/nics/img/ice_dcf.png | Bin 0 -> 39168 bytes
> > > doc/guides/rel_notes/release_20_05.rst | 5 +
> > > drivers/common/Makefile | 1 +
> > > drivers/net/iavf/iavf_ethdev.c | 43 ++
> > > drivers/net/ice/Makefile | 6 +
> > > drivers/net/ice/ice_dcf.c | 651
> > +++++++++++++++++++++++++
> > > drivers/net/ice/ice_dcf.h | 61 +++
> > > drivers/net/ice/ice_dcf_ethdev.c | 321 ++++++++++++
> > > drivers/net/ice/ice_dcf_ethdev.h | 33 ++
> > > drivers/net/ice/ice_dcf_parent.c | 344 +++++++++++++
> > > drivers/net/ice/ice_ethdev.c | 9 +-
> > > drivers/net/ice/ice_ethdev.h | 8 +
> > > drivers/net/ice/meson.build | 8 +-
> > > mk/rte.app.mk | 1 +
> > > 15 files changed, 1528 insertions(+), 10 deletions(-) create mode
> > > 100644 doc/guides/nics/img/ice_dcf.png create mode 100644
> > > drivers/net/ice/ice_dcf.c create mode 100644
> > > drivers/net/ice/ice_dcf.h create mode 100644
> > > drivers/net/ice/ice_dcf_ethdev.c create mode 100644
> > > drivers/net/ice/ice_dcf_ethdev.h create mode 100644
> > > drivers/net/ice/ice_dcf_parent.c
> > >
> > > --
> > > 2.25.1
> >
>
next prev parent reply other threads:[~2020-03-16 18:54 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 14:14 [dpdk-dev] [PATCH v1 0/4] " Haiyue Wang
2020-03-09 14:14 ` [dpdk-dev] [PATCH v1 1/4] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-09 15:38 ` Ye Xiaolong
2020-03-10 2:19 ` Wang, Haiyue
2020-03-10 3:37 ` Ye Xiaolong
2020-03-10 4:26 ` Wang, Haiyue
2020-03-23 1:50 ` Wu, Jingjing
2020-03-23 1:55 ` Wang, Haiyue
2020-03-09 14:14 ` [dpdk-dev] [PATCH v1 2/4] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-09 16:25 ` Ye Xiaolong
2020-03-09 14:14 ` [dpdk-dev] [PATCH v1 3/4] net/ice: add the DCF framework Haiyue Wang
2020-03-10 4:17 ` Ye Xiaolong
2020-03-10 5:09 ` Wang, Haiyue
2020-03-10 5:23 ` Ye Xiaolong
2020-03-09 14:14 ` [dpdk-dev] [PATCH v1 4/4] doc: add release notes for Intel ice PMD Haiyue Wang
2020-03-09 15:22 ` Ye Xiaolong
2020-03-10 2:16 ` Wang, Haiyue
2020-03-09 15:36 ` [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support David Marchand
2020-03-09 16:20 ` Ye Xiaolong
2020-03-09 17:57 ` Thomas Monjalon
2020-03-09 19:34 ` Kevin Traynor
2020-03-10 2:00 ` Wang, Haiyue
2020-03-10 7:48 ` Thomas Monjalon
2020-03-10 9:36 ` Ferruh Yigit
2020-03-10 14:11 ` Aaron Conole
2020-03-10 14:09 ` Aaron Conole
2020-03-10 6:50 ` [dpdk-dev] [PATCH v2 0/7] " Haiyue Wang
2020-03-10 6:50 ` [dpdk-dev] [PATCH v2 1/7] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-13 5:27 ` Ye Xiaolong
2020-03-10 6:50 ` [dpdk-dev] [PATCH v2 2/7] net/ice: add the DCF hardware initialization Haiyue Wang
2020-03-10 6:50 ` [dpdk-dev] [PATCH v2 3/7] net/ice: initiate to acquire the DCF capability Haiyue Wang
2020-03-13 5:51 ` Ye Xiaolong
2020-03-13 6:19 ` Wang, Haiyue
2020-03-13 6:04 ` Ye Xiaolong
2020-03-13 6:10 ` Wang, Haiyue
2020-03-10 6:50 ` [dpdk-dev] [PATCH v2 4/7] net/ice: handle the AdminQ command by DCF Haiyue Wang
2020-03-10 6:50 ` [dpdk-dev] [PATCH v2 5/7] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-10 6:50 ` [dpdk-dev] [PATCH v2 6/7] net/ice: handle the PF initialization by DCF Haiyue Wang
2020-03-13 7:59 ` Ye Xiaolong
2020-03-13 8:03 ` Ye Xiaolong
2020-03-16 4:52 ` Wang, Haiyue
2020-03-13 14:06 ` Ye Xiaolong
2020-03-13 14:11 ` Wang, Haiyue
2020-03-10 6:50 ` [dpdk-dev] [PATCH v2 7/7] net/ice: get the VF hardware index in DCF Haiyue Wang
2020-03-13 7:01 ` Ye Xiaolong
2020-03-16 5:58 ` Wang, Haiyue
2020-03-13 16:19 ` [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support Stillwell Jr, Paul M
2020-03-13 16:25 ` Wang, Haiyue
2020-03-13 16:50 ` Stillwell Jr, Paul M
2020-03-13 17:05 ` Wang, Haiyue
2020-03-13 17:47 ` Stillwell Jr, Paul M
2020-03-14 1:57 ` Wang, Haiyue
2020-03-15 1:49 ` Zhang, Qi Z
2020-03-16 18:54 ` Stillwell Jr, Paul M [this message]
2020-03-17 2:35 ` Wang, Haiyue
2020-03-16 5:52 ` [dpdk-dev] [PATCH v3 " Haiyue Wang
2020-03-16 5:52 ` [dpdk-dev] [PATCH v3 1/7] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-16 5:52 ` [dpdk-dev] [PATCH v3 2/7] net/ice: add the DCF hardware initialization Haiyue Wang
2020-03-16 5:52 ` [dpdk-dev] [PATCH v3 3/7] net/ice: acquire and disable the DCF capability Haiyue Wang
2020-03-16 5:52 ` [dpdk-dev] [PATCH v3 4/7] net/ice: handle the AdminQ command by DCF Haiyue Wang
2020-03-16 5:52 ` [dpdk-dev] [PATCH v3 5/7] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-16 5:52 ` [dpdk-dev] [PATCH v3 6/7] net/ice: handle the PF initialization by DCF Haiyue Wang
2020-03-16 5:52 ` [dpdk-dev] [PATCH v3 7/7] net/ice: get the VF hardware index in DCF Haiyue Wang
2020-03-26 3:03 ` [dpdk-dev] [PATCH v4 0/7] add Intel DCF PMD support Haiyue Wang
2020-03-26 3:03 ` [dpdk-dev] [PATCH v4 1/7] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-26 3:28 ` Wu, Jingjing
2020-03-26 3:03 ` [dpdk-dev] [PATCH v4 2/7] net/ice: add the DCF hardware initialization Haiyue Wang
2020-03-26 3:03 ` [dpdk-dev] [PATCH v4 3/7] net/ice: acquire and disable the DCF capability Haiyue Wang
2020-03-26 3:03 ` [dpdk-dev] [PATCH v4 4/7] net/ice: handle the AdminQ command by DCF Haiyue Wang
2020-03-26 3:03 ` [dpdk-dev] [PATCH v4 5/7] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-26 3:03 ` [dpdk-dev] [PATCH v4 6/7] net/ice: handle the PF initialization by DCF Haiyue Wang
2020-03-26 3:03 ` [dpdk-dev] [PATCH v4 7/7] net/ice: get the VF hardware index in DCF Haiyue Wang
2020-03-26 4:11 ` [dpdk-dev] [PATCH v4 0/7] add Intel DCF PMD support Zhang, Qi Z
2020-03-26 5:05 ` Ye Xiaolong
2020-03-26 5:26 ` Wang, Haiyue
2020-03-26 7:15 ` [dpdk-dev] [PATCH v5 " Haiyue Wang
2020-03-26 7:15 ` [dpdk-dev] [PATCH v5 1/7] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-26 7:15 ` [dpdk-dev] [PATCH v5 2/7] net/ice: add the DCF hardware initialization Haiyue Wang
2020-03-26 7:15 ` [dpdk-dev] [PATCH v5 3/7] net/ice: acquire and disable the DCF capability Haiyue Wang
2020-03-26 7:15 ` [dpdk-dev] [PATCH v5 4/7] net/ice: handle the AdminQ command by DCF Haiyue Wang
2020-03-26 7:15 ` [dpdk-dev] [PATCH v5 5/7] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-26 7:15 ` [dpdk-dev] [PATCH v5 6/7] net/ice: handle the PF initialization by DCF Haiyue Wang
2020-03-26 7:15 ` [dpdk-dev] [PATCH v5 7/7] net/ice: get the VF hardware index in DCF Haiyue Wang
2020-03-27 2:56 ` [dpdk-dev] [PATCH v6 0/7] add Intel DCF PMD support Haiyue Wang
2020-03-27 2:56 ` [dpdk-dev] [PATCH v6 1/7] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-27 2:56 ` [dpdk-dev] [PATCH v6 2/7] net/ice: add the DCF hardware initialization Haiyue Wang
2020-03-31 8:50 ` Ferruh Yigit
2020-03-31 12:17 ` Wang, Haiyue
2020-03-27 2:56 ` [dpdk-dev] [PATCH v6 3/7] net/ice: acquire and disable the DCF capability Haiyue Wang
2020-03-27 2:56 ` [dpdk-dev] [PATCH v6 4/7] net/ice: handle the AdminQ command by DCF Haiyue Wang
2020-03-27 2:56 ` [dpdk-dev] [PATCH v6 5/7] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-27 2:56 ` [dpdk-dev] [PATCH v6 6/7] net/ice: handle the PF initialization by DCF Haiyue Wang
2020-03-27 2:56 ` [dpdk-dev] [PATCH v6 7/7] net/ice: get the VF hardware index in DCF Haiyue Wang
2020-03-27 15:26 ` [dpdk-dev] [PATCH v6 0/7] add Intel DCF PMD support Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW3PR11MB4538AFBE201FCD850045377FE0F90@MW3PR11MB4538.namprd11.prod.outlook.com \
--to=paul.m.stillwell.jr@intel.com \
--cc=beilei.xing@intel.com \
--cc=cunming.liang@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=wei.zhao1@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).