From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2E2B42B95; Thu, 25 May 2023 06:17:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 355D640DDB; Thu, 25 May 2023 06:17:59 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 809E940A82 for ; Thu, 25 May 2023 06:17:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684988276; x=1716524276; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=o+HwEtUCtcA3M/+Nlnl2zBo8FUAlQQzrs/AdIudy6uc=; b=gdCQj67tNUJ8D03/e2l2/bHUD4qtDA3x8u0a/JJrKpKII+BH0JYMtaXm lMoqb3jg1YvwvkuNdw8l9C3kR6iAnJQ6AEIm+3dPmWSRZs6sMlDQtYrzW 6wCs8qdedESW0Z0lvbEmL1TgLvH9dA8gUEjboOIf4lbdryd13mus4cxLe qyDCn+hoQ8OmHxdIDtojFK3pW+IgNoqTutmjHTbrjbGFD1e20iCBt+j25 WFfkHJoGWga9DGTp0VdvdzI21701rWeMHFbjKWdRTz3jTrEtLUVHK7lJ7 HqhZgB8LTBVlcBh2gRuebgIYCtV4LEDum6R87xcvN/QDFnzy9ZW4JBaSW w==; X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="338350735" X-IronPort-AV: E=Sophos;i="6.00,190,1681196400"; d="scan'208";a="338350735" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2023 21:17:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="682173601" X-IronPort-AV: E=Sophos;i="6.00,190,1681196400"; d="scan'208";a="682173601" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 24 May 2023 21:17:52 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 21:17:52 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 21:17:52 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 24 May 2023 21:17:52 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 24 May 2023 21:17:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D/laZioWv98R1fqaoA2pnCaHUmxJObuc85jh8SFzbLZuqUzLEB/KFGoBxhG9VDl9pBJaXSZT6ztftaHKj0zSLmIMXzAoKS+EOJYc1Dp6/hp/25/YWjIrfxmAPHx0g/uITsc69zfrBFARakOZajUH0qJQl0ezgVS+1w1DJNkW6+/1LfbbZ1zF3D2JUrvhyS2yjyqi1zDcG+2xeQHqJYIAYhdSHB8W3W8Vp5B7HRFkXzI86ttb4Z7oMn1Zri6PFn1l9q0/hAmHtLAba6YrU6dme5Jxm/EjZRnz17vDX1UbIO2v8/3he+j4w6DPGyxWpXjD+e60Cc1VU+Fnp/PLJtChJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XHWlZSs7gKPNkVAhNY0O47Rm4iKz+t0c3dXFr5U0zMg=; b=AV50unG2+fFC2naTq35ulylwGWjWu+jTfsUCLXIY1BCx4y2V3/+Am8VNY/x3G6DEH2ZirEGXLqi5ITE/HiukXFypDEI6IXuy8HrEMFWCEU7xV5OBKP62e13XQgP1bua87zs8P5Go5KQ1o0sDGFLGqCAD05Wb7e1k3ee99MvUCBP0oe7NdTxQtxJaaHCc0W/iHfSakbF955YHWTaKyQ+cPeNY5gkzgJT3HVaUNI+xOwwuBjnXCIeoTS1+GubPnkOUf8EFK6hWa030FrIbSkXHYlLXr6OKWk8WC69AqiaBizK8YqKM1YptKMRGWS2dl75LTmAjYsbpGMASJIidaYU2nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4587.namprd11.prod.outlook.com (2603:10b6:303:58::7) by DS7PR11MB6269.namprd11.prod.outlook.com (2603:10b6:8:97::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.16; Thu, 25 May 2023 04:17:49 +0000 Received: from MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::5666:142:4f22:1a30]) by MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::5666:142:4f22:1a30%7]) with mapi id 15.20.6433.015; Thu, 25 May 2023 04:17:49 +0000 From: "Wu, Jingjing" To: "Xing, Beilei" CC: "dev@dpdk.org" , "Liu, Mingxia" Subject: RE: [PATCH v3 08/10] net/cpfl: enable write back based on ITR expire Thread-Topic: [PATCH v3 08/10] net/cpfl: enable write back based on ITR expire Thread-Index: AQHZiidS3hxokzZV9U+ONpSzuK57x69qasUQ Date: Thu, 25 May 2023 04:17:49 +0000 Message-ID: References: <20230519051055.106893-1-beilei.xing@intel.com> <20230519073116.56749-1-beilei.xing@intel.com> <20230519073116.56749-9-beilei.xing@intel.com> In-Reply-To: <20230519073116.56749-9-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW3PR11MB4587:EE_|DS7PR11MB6269:EE_ x-ms-office365-filtering-correlation-id: 5cccd815-5b9a-4f8c-6184-08db5cd70049 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5VbU2I+IPCD2JzgqGZo0SFyQM4xEKt5U2XT8cb28RwtTqMKSwrJZvCash7k5cQGoF8KlwnppUhKvi1ssNt6csC2Ra5KlfnT2WMM0IG+oU9bVPEeINvTLqpmgeJgL52CIRXpSEGHdVpIf3xnKTwptZXBEJyJDOwWVn+8SAFj+9hIAY+YiHXWeCTrkyJTWArPRRB7nUH7Wsblc/1R9SmIU1zmVrCbcMMouwtVJKcPaLU/cX9s1SvBPHCmLUcwzx6pQBntngJvgBTCZQwX5YvRFxHBCVLGK7Xp2hugPmSlWEZkJIk6QbBSexPoTrIYKWCWd16TwCayMK54zc+5RexlmpA3vT9PSsIvSpNObSbINvUqjlSbT25nZFmg3GrvyDpqyLSSQYWSmU6K4d2gIXMK+kvyDxGKiRGt98uKOMB6e3k5hNFsyUlzruGRKMp5huvKcQ0QXrQdMnvi2pHWe5j/jrCJOHEesxBFYqsTFJLaTpRjgiypJbGWngFCKWh3XBwNTfZjSZWKqwdLzHy+TZyoVMygR5ljuczss/vWcs+VDLQ1ivEXTo4rl0D/UgtBTKolhJuucJdgHYzbgjSjKTHchduQ/+vymLPkDhvPMIjxywVlzhjBSY/qZVYgGkcvih8fA x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4587.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(39860400002)(366004)(136003)(376002)(346002)(451199021)(76116006)(64756008)(66946007)(66556008)(66446008)(66476007)(6636002)(4326008)(8676002)(8936002)(6862004)(5660300002)(52536014)(107886003)(316002)(71200400001)(54906003)(478600001)(41300700001)(7696005)(38100700002)(122000001)(55016003)(82960400001)(2906002)(9686003)(33656002)(186003)(83380400001)(6506007)(38070700005)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5XhdzMU5a5md0LZSEoQYAYjZ7tfvf2qmYsO8bXGtOhlbZmeH6tC1Fs6DcIYS?= =?us-ascii?Q?kJ9gxJ4+zn0CeRFeK3AcPluHLuKHt7vr/YBRy2fOkWJ0iQ+AfChR0DSEcg2K?= =?us-ascii?Q?Lg9Bqd7BbvltXtkDNYMQTR7xICiJhiOglts96nN5EoQhzTLkhMLS9aQWdXrJ?= =?us-ascii?Q?L7LVQ6V6R3kVSEn1KJ2VoC0iZsuLAZembn24xJzGdnrGFjENg7+YVR5q1u78?= =?us-ascii?Q?uRk4G9Xz4p5pA3NxgYT8Ks/4hQLOFa1xdQC5UuDt6nXoDgb7Cj0+tGbWhv3+?= =?us-ascii?Q?0sOi/3NvR0LZZYuJ23bL4qpRDc3s5dgSxQmplqRrgCkdLBz5ZIOjuQj1F/XJ?= =?us-ascii?Q?XLwkEGWdvdSOU24M3lLf6EZ47IzUfDv5vbezOnY3IqkXfYUm6FIzF/w6eR7N?= =?us-ascii?Q?J0EDN78q6WylF1kgwrbQyieuZnGo+YXBF1EekL8KGj2RavkFvoDtCBb18FzF?= =?us-ascii?Q?fpMjsapoKktdIN+9DZf4RTuEVpRyVy/2W8Cv5Gnnf2UMtoRQqUqn1xdy6qid?= =?us-ascii?Q?rb2xOTmhRxBasdEhG5HvQN9306+wCAqJE2qWpSsneW4EE+sWkxNX+26uQoUe?= =?us-ascii?Q?wm/Bxtjdvc28IZOt8eXEzwS/ALtTbCna89YIJRVs1181iBwcANjhlgQOqcuH?= =?us-ascii?Q?78DZxIyEuXKNzS1yfarIjUqudSD2f4MwKWjWKy5Y1EkofAxwBcQT6svOZt+I?= =?us-ascii?Q?iNEKUEfRfnar+7x3Ya4FDzxckRGJGLB571xu+RpqYQzqdkOINb45HV3Juww+?= =?us-ascii?Q?Amx0wrYYVi9/gu4ghzuKkyNnBs5ffK+A5RQCsIRGfMILPxRzLUTPoQaVMMa2?= =?us-ascii?Q?Js7wS0N0pdmHoCBpGZ+eWVvQneWidqKlwRVe+/aftDnowf8kZJSKYC96HO6o?= =?us-ascii?Q?tesV/DK4XU2n5r0xSs/YV9gkdZtuzTklZGxDFZ/cfZ8vyoPmg+EH2ErKjz36?= =?us-ascii?Q?sO35EOqoxuK5NAAkM+hGmOR2ZmjK2tdd3l7DFyveVEnOg4p/w/Dliq+btp3o?= =?us-ascii?Q?9nsADTGlGCxi/d9x5JMa186LWAQucw26S8xTf9mq8NzjlDpio3D4w29uiP36?= =?us-ascii?Q?U43y/vg3zPU/6ET3kn6z/ONXSs2L+syrvat7vcws9bIEZHHus2+WmOQCzDP1?= =?us-ascii?Q?B1PbN+nwxALyAlB1sRGjVuwJ3T+wgG/7s6nRWpmuZFi4H9yiSYe6aHZ4eNQG?= =?us-ascii?Q?03Cs4e11meKWlDzK+wqF9wtncQ8pZ+wWVpvW/u23MocUROdkWZcchzMVSb7d?= =?us-ascii?Q?i4pNBzfp6LeiZmnvyM5oGz1uPOlbP72UH7qexBirSzCBtQVPh+rXQCszGQLz?= =?us-ascii?Q?bx0Y5RPigMt01SCCaJ7nUFAoneI4y7XxDlIVxYguk8EPmDzdQ6RDC/YyXgjR?= =?us-ascii?Q?spaQNRIiIZsqsU2YwCZQgUodnLvWtL15+9NL6fQw+ZgyDU4qIaD2cla9vTU3?= =?us-ascii?Q?HOC5eJoJyrKnRROm94MWvLdVPm0k3Wuaw69haetfIx5N+Dz/KTWnAxGRdL9F?= =?us-ascii?Q?DXCOMLCD3PuylQhOACeIJHjeZ28/8U2xSFi5/Fj0GUMsiwrqh+XnuPYYw7Zx?= =?us-ascii?Q?FSHx9TzU2124PukJT1/PBBADmEhOBms3Y6Mw5NjhcoCuoTNEwVVo75AyZ9hy?= =?us-ascii?Q?NHc6lCwwI0WgrhAVt1DgxxbwgJBLzUDcqPu3uIr+v3fC?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4587.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5cccd815-5b9a-4f8c-6184-08db5cd70049 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2023 04:17:49.5215 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eTZQW1Ro/Y7H77GrIC7f/Dn9tyCpUxHzwrYmZN00vYsbocEZgJULBWGPaN/Gl8nVQe8S+D1bPaJDClTvIJg0fg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6269 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > idpf_vport_irq_unmap_config(struct idpf_vport *vport, uint16_t nb_rx_que= ues) > { > diff --git a/drivers/common/idpf/idpf_common_device.h > b/drivers/common/idpf/idpf_common_device.h > index 112367dae8..f767ea7cec 100644 > --- a/drivers/common/idpf/idpf_common_device.h > +++ b/drivers/common/idpf/idpf_common_device.h > @@ -200,5 +200,9 @@ int idpf_vport_info_init(struct idpf_vport *vport, > struct virtchnl2_create_vport *vport_info); > __rte_internal > void idpf_vport_stats_update(struct virtchnl2_vport_stats *oes, struct > virtchnl2_vport_stats *nes); > +__rte_internal > +int idpf_vport_irq_map_config_by_qids(struct idpf_vport *vport, > + uint32_t *qids, > + uint16_t nb_rx_queues); >=20 > #endif /* _IDPF_COMMON_DEVICE_H_ */ > diff --git a/drivers/common/idpf/version.map b/drivers/common/idpf/versio= n.map > index 25624732b0..0729f6b912 100644 > --- a/drivers/common/idpf/version.map > +++ b/drivers/common/idpf/version.map > @@ -69,6 +69,7 @@ INTERNAL { > idpf_vport_info_init; > idpf_vport_init; > idpf_vport_irq_map_config; > + idpf_vport_irq_map_config_by_qids; > idpf_vport_irq_unmap_config; > idpf_vport_rss_config; > idpf_vport_stats_update; The same, split common change with net one? > diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethde= v.c > index c2ab0690fc..3b480178c0 100644 > --- a/drivers/net/cpfl/cpfl_ethdev.c > +++ b/drivers/net/cpfl/cpfl_ethdev.c > @@ -730,11 +730,22 @@ cpfl_dev_configure(struct rte_eth_dev *dev) > static int > cpfl_config_rx_queues_irqs(struct rte_eth_dev *dev) > { > + uint32_t qids[CPFL_MAX_P2P_NB_QUEUES + IDPF_DEFAULT_RXQ_NUM] =3D {0}; > struct cpfl_vport *cpfl_vport =3D dev->data->dev_private; > struct idpf_vport *vport =3D &cpfl_vport->base; > uint16_t nb_rx_queues =3D dev->data->nb_rx_queues; > + struct cpfl_rx_queue *cpfl_rxq; > + int i; >=20 > - return idpf_vport_irq_map_config(vport, nb_rx_queues); > + for (i =3D 0; i < nb_rx_queues; i++) { > + cpfl_rxq =3D dev->data->rx_queues[i]; > + if (cpfl_rxq->hairpin_info.hairpin_q) > + qids[i] =3D cpfl_hw_qid_get(cpfl_vport- > >p2p_q_chunks_info.rx_start_qid, > + (i - cpfl_vport->nb_data_rxq)); > + else > + qids[i] =3D cpfl_hw_qid_get(vport->chunks_info.rx_start_qid, i); Looks like cpfl_hw_qid_get and is used cross files, how about defined it a= s inline or Macro in header file? > + } > + return idpf_vport_irq_map_config_by_qids(vport, qids, nb_rx_queues); > } >=20 > /* Update hairpin_info for dev's tx hairpin queue */ > -- > 2.26.2