From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E68842B8E; Wed, 24 May 2023 16:38:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6D9A4067E; Wed, 24 May 2023 16:38:35 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 2A2CD400EF for ; Wed, 24 May 2023 16:38:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684939114; x=1716475114; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=w0x989f9aPx1+HHGK8DsJNtv3zWj9jwZ8SRfYDNfv/M=; b=YXLPMi7H2YJZ2RgY0Ad1cVTtlstZ51CgIYDKThrwa2JRjVA25sPw+Igj OMv5+JKEr9RVsQUaAwpgMzhcOmFkIS+o5CFuk9q3YdEp7kf5N8Ny85fAZ QkP31vVROxYU2Vg3YZ/Kk7lzykZHi5bALl0mBRqZecDV727FM1jmeShqC Fp9j+lo+844fTxP9HEmjWhgDdtKdvnIdeEO5omw+7ZbyZVwZeDRwbJVZb YXhKRskE+nsndkA4vS/YCOnNK4R/o1DToYViH9k5ciN4BKGpkF+kEFFHG o4DxxnX9FpvEPUMsZFfAcH+73eFKVNrl8kbRW8Vlq+loBrOaZV4yMJAjr w==; X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="333206882" X-IronPort-AV: E=Sophos;i="6.00,189,1681196400"; d="scan'208";a="333206882" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2023 07:38:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="828620779" X-IronPort-AV: E=Sophos;i="6.00,189,1681196400"; d="scan'208";a="828620779" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP; 24 May 2023 07:38:30 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 07:38:31 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 07:38:31 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 24 May 2023 07:38:31 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.48) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 24 May 2023 07:38:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qyfthz+svvTvDkXFeljyOZB5QWXX/CuI35vShjUFyci6n9ZdVuWaGJU0NoR2O+yEVlhxP/4CtURtty4sFbT4nDBgougGytdilVxIEh1MqfwkpBXyi48KvOHh7J1M824M3kicM/p1VJRdpf+OU2vTwu4HATmc/n7KzeSq+v7GQEf8xNHtWa/+Liz3RS6+kP2yivAn3bBU4F488v2Uw+S84BdnIKNygS7+wOqmWm0HD5qeccP3jPhKnRI4JoVvpLeupA7Eth24M3jWiWLO2Of3RsuNxyj7OdoUDxCvbEBQfg7RZgAM11L6kvKq5fuCzf3x4EQ0PthT64Uj0gr+ci3ztQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nM/TE0d6PSDhaMYZSbVAbxbkKn5Mt+gzYMUeAf0RkWQ=; b=LPcTHaWsUpG2wtN19tyjty1BwJivXtwpuAofx/Jdgo7oC0Gnf57g93zeaER6gG8Akk0+FyJiLPa7o/53Utcimg7e8Pq3VUqHy85FaPTk2I6QA2rWHFL66Rxwa2coMNj9pndc6vYQ8uno9hrk8ocKdszE+KSLd5Sk6z0j28x2rtSayoVUOyJCbRNvqW6InF+6waD8tu/YGBlouTlL5+HMud6v9TdpIv560Ct9siZkjtBLFDis5qpHXKe51pdIe3HfXX3ahCYhK7jR3h3EMJxeUFRw3H0dZkUxkjK+fPvuU/fM25z8JQQnrKVxDcw3z7G+tIKlmwslcTCAU5P4W4MSZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4587.namprd11.prod.outlook.com (2603:10b6:303:58::7) by DM4PR11MB8091.namprd11.prod.outlook.com (2603:10b6:8:182::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Wed, 24 May 2023 14:38:24 +0000 Received: from MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::5666:142:4f22:1a30]) by MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::5666:142:4f22:1a30%7]) with mapi id 15.20.6433.015; Wed, 24 May 2023 14:38:23 +0000 From: "Wu, Jingjing" To: "Xing, Beilei" CC: "dev@dpdk.org" , "Liu, Mingxia" Subject: RE: [PATCH v3 04/10] net/cpfl: add haipin queue group during vport init Thread-Topic: [PATCH v3 04/10] net/cpfl: add haipin queue group during vport init Thread-Index: AQHZiidLMW5fDTb6f0eTXPQXywP+W69phfNg Date: Wed, 24 May 2023 14:38:23 +0000 Message-ID: References: <20230519051055.106893-1-beilei.xing@intel.com> <20230519073116.56749-1-beilei.xing@intel.com> <20230519073116.56749-5-beilei.xing@intel.com> In-Reply-To: <20230519073116.56749-5-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW3PR11MB4587:EE_|DM4PR11MB8091:EE_ x-ms-office365-filtering-correlation-id: 8f48dbc8-6f46-44e2-cefb-08db5c648742 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bv3ChBRMv1lKblA12RvlgoGgwIM+GehqYYZ+zd83tOuVk1W3xzUbueGXKYEDUMx4DuCQZehAMhrZuDcdm4kPjVJJX7s9QWbgI2C54UCJob8fhHEmu3XG5iF5NguCZz75g4ezqU8lRCOW+5jfAehD2ViEZVxufrtEohqmuxGcF2VTV5+W6mU4DNto7YExg9S/gWdqUZRwTKlq8CcPpTJ5gY45lFacNRdUGs43C1dQe1jYU2Vq/568RPQ/IaAWViRaeLuedQ3y8VijLAq/KOcfrAsJNbBgsWoodGsDXDti8Q3za0ACsn3euP40dFnh3nuXUQZT2ddtqvWU8uAXKIsJtTbhufaVBGCSbYFrRkAn+iJMDTlAfhhx089GfC2TyBBL/XAuWPMa8xnTwMZUZuu1q+kOYlugY76+fCMCPucJmyPHKgF7YMyZRGtu3ADATaQ2BKk/CsBtuyeOn1hV2oSdRXJgQJvMmtOlyiAlp4NCaG/GvNvLuMDalo+8KhkmL7A8IgIiL63ZXl7ajcPF+Z44orTTXXFZyKg2Itqs/QJaVJ55d+KIKxjpltAu0Wlg/Qkvqaqz3kNoR5KumPeDDQ4Mz0wia71XtFxOb62ymVPuATVwI2MFsg/F/sI58UXJ6kHl x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4587.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(39860400002)(366004)(136003)(346002)(376002)(451199021)(9686003)(55016003)(6506007)(38100700002)(186003)(82960400001)(107886003)(122000001)(33656002)(5660300002)(64756008)(7696005)(478600001)(54906003)(6862004)(76116006)(71200400001)(86362001)(8676002)(52536014)(66446008)(66946007)(66556008)(66476007)(38070700005)(8936002)(316002)(4326008)(6636002)(41300700001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N52p92WaYzbFvEA5JRF8mx2HM1IpazPgKDcchTUMQ+wClnus0hATR4RrH5R+?= =?us-ascii?Q?muXHKqR+8hcKRnRBUF9kQNjXWZhv2rQb+t7Mtm+U/TYph3//s/egSEhoSOKL?= =?us-ascii?Q?wsUUVas06OT6IF6jqij+ui0rkAC9B0aH9BPrQZoF5/ZdLb6xr42A2CJvDzN0?= =?us-ascii?Q?99tSddawDJpWirwRUsXs6BwgRBQxaTtMJQ1pZRE2R4EkG5KASKQ6yl3AraMO?= =?us-ascii?Q?KceF8Hq+0Y9r7r9y1ApIcxiZFr7MnbgVnUcY6HPsCXVHntz304x+t6a9aDGi?= =?us-ascii?Q?dUQhUWsduxuKf6xlq6QbniFeOtaEsLMzG9klVbIU1VPQG4IjlmWT1+Ud2p5M?= =?us-ascii?Q?N8REHYeUM/3FDbIpmDz61J7ZgnqB2sCmTtCmJuqTd2JWI1NSoJi/f+s/3+KL?= =?us-ascii?Q?dcX5GiakU/heiUsz/sJX4KykivF2o884K9w5spLDs2mIdvn24iordi9Iat3j?= =?us-ascii?Q?qs6UbbrSetrevwF4c65EeLFI8T1lFLMl9glMoueuAyJ/d5ceOSe55pk3tYg2?= =?us-ascii?Q?E3KgWLwaxu0eCjcuB+k3vtTjdSFFoeK4f6kyCUQDL9ZCE/8+09zjvKIHYKh3?= =?us-ascii?Q?tHf6FImkugj4SLC5A/1+hc8eKVEvxxKfGgr9c8Phh3cGisWx8sF7PuzluGV4?= =?us-ascii?Q?PkPgrLKgKflEJ2+4wXIXxi5mYTsGt88hwd1tXvklBfHjnmXt+OQvJdXmUXet?= =?us-ascii?Q?pTthOaS1bKN2uny5rimkKzFBBsfetU3mVz5KrrkRVIW7+N7/Z8sKxwwL+nFK?= =?us-ascii?Q?fufH1A/97JINytPu9Vz4LiRPgC548kXNXTfOhTHe22EHbkSdQM9gp8SB4iNo?= =?us-ascii?Q?zMscISKRUZ06kJ55dOb+BLCBySL8dBnYil0UkStNa4Vju1KhldyjjnuwE5pn?= =?us-ascii?Q?3MD4jX63EM2G0U80cAiDYecJO0/vFHdjYi3Rx/8UdnlJuMxmVfyGSanWvanW?= =?us-ascii?Q?IySYLClZDQh9QPN0KH7/2C376WL6pL24YFpUZPELrCMfXWZQtVc8kOSwxICj?= =?us-ascii?Q?0nqJOHvvk/WXqywJ57o8BWbNV9v9b7NUaQKQBna58oWn3Dr1nEwQih9zv+cK?= =?us-ascii?Q?7Gt6efrAggCOfNvEs6L4d2MIvwAleZY4ctHJzyZK0KVkyHV/nn/ozgKhUKZi?= =?us-ascii?Q?TTFuxOZgmn8IDWiZg0aqopn4dUuiDJy6JcE6gQWvqhF5KErvo7U4dBwt0aVn?= =?us-ascii?Q?JKzhJVAqpvrgQiHbY+BuAuXztQYi9/99GH24ST5DAVjEpWnHm0xCabiKSwha?= =?us-ascii?Q?V0mW9Ba3c5d4jksC3bBH337hV652khfPjEwjW86zzxP16PmTRRB4GJXZcAtl?= =?us-ascii?Q?hQWO042m3SEa8QSiLtDg1Qj1+XdPLEijoa/V+VzFHfJeuQgVSjxXvt/7cVid?= =?us-ascii?Q?VWPqkEvnEgqMuRm7M1e6NTYSJL9tRcSy4nJYX20gwdonzEZ5EpAnfXOhqpxq?= =?us-ascii?Q?etq0ZkaNRZoh+uARYxhzRyPi1MXzCq8yut8RGGGnrMH0yGFG2B5iV1FUG4O6?= =?us-ascii?Q?X4cojZV2e7zw9wwfA+8PzD44cOOOK9KHOX1ns9ST476YMSEX/stYRZtW5Lor?= =?us-ascii?Q?a934MYYKcSPWhyh4SZ0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4587.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f48dbc8-6f46-44e2-cefb-08db5c648742 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2023 14:38:23.8510 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: km8hfdUDS90GQE5VCjlWZqV2s6U0dbuh4WpLOpik8486KuxEdxRktTK+YsDJG9fLjZSPvsfmpjMuYaxWioOWqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB8091 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > static int > cpfl_dev_vport_init(struct rte_eth_dev *dev, void *init_params) > { > @@ -1306,6 +1414,8 @@ cpfl_dev_vport_init(struct rte_eth_dev *dev, void *= init_params) > struct cpfl_adapter_ext *adapter =3D param->adapter; > /* for sending create vport virtchnl msg prepare */ > struct virtchnl2_create_vport create_vport_info; > + struct virtchnl2_add_queue_groups p2p_queue_grps_info; > + uint8_t p2p_q_vc_out_info[IDPF_DFLT_MBX_BUF_SIZE] =3D {0}; > int ret =3D 0; >=20 > dev->dev_ops =3D &cpfl_eth_dev_ops; > @@ -1340,8 +1450,28 @@ cpfl_dev_vport_init(struct rte_eth_dev *dev, void > *init_params) > rte_ether_addr_copy((struct rte_ether_addr *)vport->default_mac_addr, > &dev->data->mac_addrs[0]); >=20 > + if (!adapter->base.is_rx_singleq && !adapter->base.is_tx_singleq) { > + memset(&p2p_queue_grps_info, 0, sizeof(p2p_queue_grps_info)); > + ret =3D cpfl_p2p_q_grps_add(vport, &p2p_queue_grps_info, > p2p_q_vc_out_info); > + if (ret !=3D 0) { > + PMD_INIT_LOG(ERR, "Failed to add p2p queue group."); > + goto err_q_grps_add; > + } > + ret =3D cpfl_p2p_queue_info_init(cpfl_vport, > + (struct virtchnl2_add_queue_groups > *)p2p_q_vc_out_info); > + if (ret !=3D 0) { > + PMD_INIT_LOG(ERR, "Failed to init p2p queue info."); > + goto err_p2p_qinfo_init; If it is failed to add p2p queue group, the device init will quit? I think it should be better to continue initialization just without p2p cap= ability. > + } > + } > + > return 0; >=20