From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C168742B95; Thu, 25 May 2023 07:26:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 951F040DDB; Thu, 25 May 2023 07:26:26 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id CA4BC40A82 for ; Thu, 25 May 2023 07:26:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684992385; x=1716528385; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Pk73PMos93gNj7cTE9CU1+LFo02ARLpFRBFiFwlKKLg=; b=EawrTJNkA7EO/X7/9nPlfmbDM0V/jZu8RdbrUWQ4ttpka1vxoLvMrQet clBf9r2p1i+tZvc9Ui2rUlXZimXWdFWi0nzM/yhPQffm+/45elBllvlg0 JcvOriFoD0NWz4BI8m2Al34Ud3W3OWKvLzKhUWxDOgMc27LNJ6qVloMU2 AHmEk29XGXfruMmuA0uLiFY/mYRtlTaknsaBqeXh8VM34AFOZMQrRz0Pl 8bpFiHiVegzk78TKOyNLzSqF6kV4/cgYn08XEn/06CrVjynQdHctY8gKg CHRXtA58hnb+43vZur/vh2zahLyR+mjG5EJ15LM4GnV4VUPBjxccq1Y0u w==; X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="333405377" X-IronPort-AV: E=Sophos;i="6.00,190,1681196400"; d="scan'208";a="333405377" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2023 22:26:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="828898750" X-IronPort-AV: E=Sophos;i="6.00,190,1681196400"; d="scan'208";a="828898750" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 24 May 2023 22:26:19 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 22:26:18 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 24 May 2023 22:26:18 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 24 May 2023 22:26:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UiLbdsRBUhhLVf3b+RVEDNM+/oDZjoDR/Luyn4WQFVmwHTEccMr+tg3NGl+ighYrMV0XbJYIoeKyfawiysJbapiFTGbxXMN92r+0cOglN+n4vQfLzTykleKiErk/S+e8zN23UwHSsN69sTW3n4mH6qWqoCXz7BxQOw9A4ZfNy1eEoXiRN4m5Bz8kADufKNETJQ8CzzwVro7Z8v0UbnWMBuUl05wFtoGIUKcKKFCo6dq4ZWO2CbJUZoO67a4gmCc9McuiiQdSZJ3WVLrgVMS9t09gvt1quFzw9kDqZlcCO6R04HGLqo54U5MymX7ElPqFniLiyDmPMiA6lE9xCA57pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZHCuHboOEUNNbRzx1CPyn6YYZDrq7QrzvuIaBE65BQ4=; b=IqWL3TBq8qNTolkLj77AV1V+S2WTCJQN1MIHAGgh1NhQDMzA1zfi9oTNA7JMpTLBBhBg0Q6c98smxc7j+6OMfl6fxsFVdBL9sd+qK33nMsrxCBB6iPptIAmQ8IcM15XORCa0vSNyunRL/KUpkQP05OcMLHyxJp6RSwkrCS8Jmu5Jf2jQYv/c/XvtCmZ917Ib1oMSOb80bi3hm1wSYr64ELZtK9tCXmQAWDoboU0mqmHC5hlcQ2av7GvVftJGPX5t4TW+ez6cxAG6qweOnwvKEoMS5odd73r/ychi/QA4Afeaki/ekblukY4EOj+wMGZicKxaG4iLlqXkYr2CMcPmow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4587.namprd11.prod.outlook.com (2603:10b6:303:58::7) by DM4PR11MB5375.namprd11.prod.outlook.com (2603:10b6:5:396::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.16; Thu, 25 May 2023 05:26:11 +0000 Received: from MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::5666:142:4f22:1a30]) by MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::5666:142:4f22:1a30%7]) with mapi id 15.20.6433.015; Thu, 25 May 2023 05:26:11 +0000 From: "Wu, Jingjing" To: "Xing, Beilei" CC: "dev@dpdk.org" , "Liu, Mingxia" , "Wang, Xiao W" Subject: RE: [PATCH v3 09/10] net/cpfl: support peer ports get Thread-Topic: [PATCH v3 09/10] net/cpfl: support peer ports get Thread-Index: AQHZiidWE1qUmEVUDk+xknRZuYYFQK9qfg0g Date: Thu, 25 May 2023 05:26:11 +0000 Message-ID: References: <20230519051055.106893-1-beilei.xing@intel.com> <20230519073116.56749-1-beilei.xing@intel.com> <20230519073116.56749-10-beilei.xing@intel.com> In-Reply-To: <20230519073116.56749-10-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW3PR11MB4587:EE_|DM4PR11MB5375:EE_ x-ms-office365-filtering-correlation-id: 677bb09e-98b2-465b-8e97-08db5ce08d24 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2wMZOT2DKgz50JpsyggHvCSR9QF69kCBt+Xiv/ovk5u4C7b90madDUaAJxCMvrUM1NczaJ+g42OJ3dmgjWMQgdQ/UfjiNPOYj+EjP+3Bm0TNu1njtWelocsxlOvhynR0BazuyoUifhCbawEykk9T2tzqBJcbb0byHMflxfIxsWWi0q3YllWRSh7kgKtvTicZ2YhLYYCPpdnZQoLMchs0lOV/d565M/CDR+ySLMeFx3gT32BPwfZjzrQFVnU9M2MRDUpqfu3B5CUyaGeH4ZcJBL1PxjRk1FO22JjS2QK5Y96Z1CtlpLTXU5UebxfM63zSavzUoGEs2Y4LMQxFz1xZsrxNTzbjzy3vErFmvY53Mh0k/9Supb7lDm++CXMJ4OS/S5jyRMwXSBSeKJ/sKJUSRmBDuTiwlO7Voz/zAewVVC8GXslgvvCRjcVDzDpeWIHbeJyrwF0ZHiHbuuQafPsTTMDjNXTQ2XN13UNU6A3WykcC3Ufx2n70zNY1Jjd+xrvb2vPW7K1jIVKbFwE3p0ekraaLXHOIYIJ8OndDsR0je8AgHvkba/Ynp571pfPbKO9QQmd6M9SFy8DCjcre31HMoH06NCyWxgT8R53GcRxtYk7oCheO+FuuUYN9UDPKCZjg x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4587.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(396003)(346002)(376002)(136003)(366004)(451199021)(186003)(53546011)(6506007)(9686003)(2906002)(55016003)(83380400001)(71200400001)(316002)(66556008)(66476007)(66446008)(64756008)(4326008)(6636002)(66946007)(76116006)(82960400001)(38100700002)(7696005)(41300700001)(122000001)(86362001)(54906003)(33656002)(478600001)(38070700005)(107886003)(5660300002)(52536014)(8936002)(8676002)(6862004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3i32b5slS/HQEgYwjReNU6Q5C+vs8znhwcMekOiOvYLjD8q2UfbpMOIjeKCD?= =?us-ascii?Q?xixjMxI6Co4k2dvy7HTZWm7fG+4M3ZFaQj7QXtiPuyQnzyRvHqLlcXhLuXbB?= =?us-ascii?Q?fXvTU480VMD12P5zHm/vpx4VK92+ScWUZopk9gigeKn+d4JPL6n5A+wbwcOr?= =?us-ascii?Q?DQVWao8WwzL7BoMkwNEf8yNdeBQ3nihVW8enCp14SOr6gxXW5IfkM9l2B9zt?= =?us-ascii?Q?s5eDt/+auBoUEBd3MD/gTB82eMMyNAQxl1L7BVnc03B+KeA6fDieSvipt5iU?= =?us-ascii?Q?6YUVJfX8V4i8yZwJ8LUrYVoRN6Rx2axI/XSN8EkPcfOFHoZYPKrylKbcvZC0?= =?us-ascii?Q?EzSSJRwZUjciahp5zJOkx76n6BLCcgWYbxeOtzWiBiYxXgijhUaqvzYSmLaD?= =?us-ascii?Q?m9TS9WbvlZgrGIn45HzjL80/kclltTH9nBuDsrZNXjOnHAamEYnhk19XosvC?= =?us-ascii?Q?NeBUlrTzw7XP8uBOiaSqvqyv3IqO5rifwEvExDn3tK/ozQO2xXCkF7O9dwFR?= =?us-ascii?Q?92mnX2aZ67QEDqdc/RANIYHXE25ojsXZZfbWtSpFX3p3gelt1hk7ICxyv9/z?= =?us-ascii?Q?UEPZQ2NRTQFVg4eUs98qxHHYNJrp4hrKL8Qyj0kpaOzfjAGgwze+ePWt+FVe?= =?us-ascii?Q?bv6pD+qniA+ei828JMgfjOSkzPqVTanzSI86RKBmPSvbucRpSBpnvPvhVvVD?= =?us-ascii?Q?W4kZ1fiOluPVrHmwRp/zbf8Xo/6DUJi+KRQI8gKbLdCw5rGqBTysR4+oXG+O?= =?us-ascii?Q?J0hmBdfzqB6KJiO9MB+90jlGlHYBOEHMxNZPf6nVMYaODC3OGtpgKAYUZsUE?= =?us-ascii?Q?sMZ8+7YKetEXUBDsE0Xk9tWA2QOyWusw9XGjRNwcmYn/2mkMl8CoYAjq16aa?= =?us-ascii?Q?f13OfcB+WwLo+hARZZZtuhhFZsRkV10jvain72yvNLZwwLU/WdIy1BWPkd8k?= =?us-ascii?Q?lj4wWyi1WeSUQHd0eh4Rlqqpn4EP4IsYQXkNPwMxP1IWP/+HqDkXuXvWUc2X?= =?us-ascii?Q?OzJKxcDv4VCxAHDw/WC5a6WOYhzUo69nud++QrFn6vfO/dJCr543FuCd4vZj?= =?us-ascii?Q?1ow35kfECxmZ2I2lZeY4Yu6aOe3ZMZCEJhUrUZG/TpkchWwHsISrmASnAnBr?= =?us-ascii?Q?bbgA55you+5/SXznuC2E1UEIBEVNkdQ9mytRJYz79X1ZparPyYsRzw3WwCx3?= =?us-ascii?Q?J5EUJCiR2Z1kv0CHVV0Ix+jBBwsvIJFOX/RQm08k9HLYf6JlSnCstk+BkruD?= =?us-ascii?Q?TaW7h96l5q0zDNtXKL8L57YFJdlUhdt6BHuj207A34iN06xTuNm6CADNGCGh?= =?us-ascii?Q?onn9HhMVFN4/FYl44Z8hppG4yv5M4Rr7dLDjfC48FzKWXYIaILZ72h0HRcQZ?= =?us-ascii?Q?YLuy7ydkS4yXRts0Mj5yoXGM+bQXZy+alua9zjqGh+ZWvP2F2mZdPYuEyY5g?= =?us-ascii?Q?Y/P6xQcy/fas0IwgSg6T2EZHjwEAbsk6wj78C0oIJdfi8xMd2eMUcaKeiCCw?= =?us-ascii?Q?f1Nn1hMVO7grbjeKw3VMpdWGGRzjp+vZcQDd8UaWKoff4t+SND3ubFlhuFCJ?= =?us-ascii?Q?G0Z3GaIB8KB2UneMvdnLv5xdlpJtEKyPYdskMq692CX2Ojfmxxg8w+pXNPlh?= =?us-ascii?Q?uPT0yE6zaa3LirY4jdJB3uHF7Fv7+jPsZpm2uyNOT6C6?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4587.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 677bb09e-98b2-465b-8e97-08db5ce08d24 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2023 05:26:11.3194 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oG4GqajSY8JzRjpA2A5evS1QWhgIsSS8RdxF+vqpr+tDpVSgEfSwWJCJtTGIofVUnt/xX1nz/X8RcNh0Y/KpUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5375 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Xing, Beilei > Sent: Friday, May 19, 2023 3:31 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Liu, Mingxia ; Xing, Beilei > ; Wang, Xiao W > Subject: [PATCH v3 09/10] net/cpfl: support peer ports get >=20 > From: Beilei Xing >=20 > This patch supports get hairpin peer ports. >=20 > Signed-off-by: Xiao Wang > Signed-off-by: Beilei Xing > --- > drivers/net/cpfl/cpfl_ethdev.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) >=20 > diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethde= v.c > index 3b480178c0..59c7e75d2a 100644 > --- a/drivers/net/cpfl/cpfl_ethdev.c > +++ b/drivers/net/cpfl/cpfl_ethdev.c > @@ -1069,6 +1069,39 @@ cpfl_dev_close(struct rte_eth_dev *dev) > return 0; > } >=20 > +static int > +cpfl_hairpin_get_peer_ports(struct rte_eth_dev *dev, uint16_t *peer_port= s, > + __rte_unused size_t len, uint32_t tx) > +{ Param len is used to identify the size of the peer ports array. You should use it, and check if peer_ports is null. Otherwise will cause in= valid access. * array length > + struct cpfl_vport *cpfl_vport =3D > + (struct cpfl_vport *)dev->data->dev_private; > + struct idpf_tx_queue *txq; > + struct idpf_rx_queue *rxq; > + struct cpfl_tx_queue *cpfl_txq; > + struct cpfl_rx_queue *cpfl_rxq; > + int i, j; > + > + if (tx > 0) { > + for (i =3D cpfl_vport->nb_data_txq, j =3D 0; i < dev->data->nb_tx_queu= es; i++, > j++) { > + txq =3D dev->data->tx_queues[i]; > + if (txq =3D=3D NULL) > + return -EINVAL; > + cpfl_txq =3D (struct cpfl_tx_queue *)txq; > + peer_ports[j] =3D cpfl_txq->hairpin_info.peer_rxp; > + } > + } else if (tx =3D=3D 0) { > + for (i =3D cpfl_vport->nb_data_rxq, j =3D 0; i < dev->data->nb_rx_queu= es; i++, > j++) { > + rxq =3D dev->data->rx_queues[i]; > + if (rxq =3D=3D NULL) > + return -EINVAL; > + cpfl_rxq =3D (struct cpfl_rx_queue *)rxq; > + peer_ports[j] =3D cpfl_rxq->hairpin_info.peer_txp; > + } > + } > + > + return j; > +} > + > static const struct eth_dev_ops cpfl_eth_dev_ops =3D { > .dev_configure =3D cpfl_dev_configure, > .dev_close =3D cpfl_dev_close, > @@ -1098,6 +1131,7 @@ static const struct eth_dev_ops cpfl_eth_dev_ops = =3D { > .hairpin_cap_get =3D cpfl_hairpin_cap_get, > .rx_hairpin_queue_setup =3D cpfl_rx_hairpin_queue_setup, > .tx_hairpin_queue_setup =3D cpfl_tx_hairpin_queue_setup, > + .hairpin_get_peer_ports =3D cpfl_hairpin_get_peer_ports, > }; >=20 > static int > -- > 2.26.2