From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79A3CA0544; Fri, 18 Nov 2022 07:24:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1778A4067B; Fri, 18 Nov 2022 07:24:36 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id ED27C4021F for ; Fri, 18 Nov 2022 07:24:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668752674; x=1700288674; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8nQip/+lT0RhcMFgP6wTeIZrkj3T6eV/z3ZjUkZ3LHc=; b=f5K+ARnvTna5QzfBtDkw7reUCKwJkDyZXy+kXRTtK0HJwXGkO0Pp+ZrN yY18RM5Yd/YqJj9wdDId9ex+cx5dwkN7zi92ZANEJN/FllBKzcioRxDQO VCZGuoivvCm2ftvYzJWa08bbeDeVI20NMV1L4xmhcOjwP9O2p5+pT0Jze LT+axRSZE/zEmMzr32LodHjPDvxs++5OVvKQnVoTE+TsP1PXSuT7CJLku VEMQIse3JkTcxvoL/YXQ5JW314zPp4s2T7grJDKhMjB4b+UN9HwjrvRcu vLxydrjYM/jdgEnYx3gKykquaLiSKnGkZP6VMxmE0gAcqPK8tN6WEOZn6 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="339902693" X-IronPort-AV: E=Sophos;i="5.96,173,1665471600"; d="scan'208";a="339902693" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2022 22:24:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="745868634" X-IronPort-AV: E=Sophos;i="5.96,173,1665471600"; d="scan'208";a="745868634" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 17 Nov 2022 22:24:32 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 17 Nov 2022 22:24:32 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 17 Nov 2022 22:24:32 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 17 Nov 2022 22:24:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kDKE0sKKA/lDySWtdgWfVOFwUSa6FwuXFCapozLs5FlsDhwSON9mUP3Pwc6rY08cz1lXUtH/Dc1KxHE+FAW+6Mhod4DachMYsHB9h8W4Xw2CVqd13+cLLVAlHhJryvGa7xQLpAxr8R5hR0sJE3MmZzdb6DVxBbUq8eaDddJdg92FXAQMDG89sXdkdHBTJGBx3QTwcw9krccvjtqg//S6KakCgTsrB5zHhjGWnVjddoMTMN0I93dI+6DI2ScBGF1BwLjt5EzUIl9nFo7+ldZobupt4zz1nzDTSagSNtOI+QL6aMlhXGCVX2ad0M73ujf1u4SwvoAvqb4qQESKvWAmdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2e3svi6DRn+5VX0NZrSxhywnkk2ACK2oflC8C5JjM/M=; b=UHSq0DEcXcVTxu96I74FABdBWUWHDbaZnwakNaCyi/+5YmkWqWQFZqvNnMEURzdbC10FuPdgWN2KSQt8OCL79MboG6grsr9ZU/am9RLJcX4Qq4ggH8tuE731Kzcgh5lBHwdrvlmRpv8e25E7e+Qrol5aibJU44qz+2+zs1vaFQoxPXg1p6UeCzBC6v4Ddu1oOKzVyiQqx3vXZwZkPkEr5/crWkQmJFcmhdEDANmusKr1h3EHF5PYItv5u4bizQPB0HjgsCx9ncYR9NLc3Un5xNyAmTOfNm1sc08GdIRrpwywB3fQYOxePZq0Z8iRbOqNgLJvuc8HPS3pcZJ4ofxk2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4587.namprd11.prod.outlook.com (2603:10b6:303:58::7) by BL1PR11MB5954.namprd11.prod.outlook.com (2603:10b6:208:385::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Fri, 18 Nov 2022 06:24:25 +0000 Received: from MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::a68:491a:2114:5ede]) by MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::a68:491a:2114:5ede%7]) with mapi id 15.20.5813.018; Fri, 18 Nov 2022 06:24:25 +0000 From: "Wu, Jingjing" To: "Xing, Beilei" CC: "dev@dpdk.org" , "Peng, Yuan" Subject: RE: [PATCH v2] net/idpf: fix crash when launching l3fwd Thread-Topic: [PATCH v2] net/idpf: fix crash when launching l3fwd Thread-Index: AQHY+m2Cv5nvRpvQWUev13LQXrzcpK5EN6Kw Date: Fri, 18 Nov 2022 06:24:25 +0000 Message-ID: References: <20221117100054.13836-1-beilei.xing@intel.com> <20221117101509.14472-1-beilei.xing@intel.com> In-Reply-To: <20221117101509.14472-1-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW3PR11MB4587:EE_|BL1PR11MB5954:EE_ x-ms-office365-filtering-correlation-id: dbf178f3-85f3-4482-8244-08dac92d8a12 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ftxeWDFCSvak4FJ/3nMubZRz2uNQEoVA/bmbQslLPm4g8c11wQcYkojDihWWOTzCrBd1uJ0RUvBVN1LaE4HEIegbMNaP9T4MGCB1lr/VAgmwgdSV3ai+aDJCpwSbyjuUqlJa8FzSXB4n/pzlEYjYT2GuJ+MzLs9Ic9Bw9M6ZGLQcAlHpG7IXR5g0SB2EHVeyQlHSYA/gsuN+KANIs5atuu62u37HpHUkyFATDj+jmzwASUc/ZexMpuWYovDINqIoASbJik2qFlUBGg1A+wYDPbSg3jRdHs3OWjVB++57qkWxR4dPAKB/2Xpe+pMJrDkEe29lNsrzzoNyPcb5Pl9vPhx+HDcfnIlKhff1+KV+HSKcFPKbGWonAaZdvY5/4V0rOE/EFYeuAuhm21bGHnWXcAK4IWfTvLz6LDvBL5AL08OXxD+xAgHRbUDLMJT9haKi7QLSHU/FUT8y31XiDrHiAdsJ7LzyKyZi7/GMQcarJvYH2WZtWsyPtbbezFKsWxLHJVJJYvEfRu84uhCAPbNqHm6w4494taXV4XcDPjyi7fVIBYsSfLjZWsiEt6o0cw3if0imnagrlOwBJjZhEIXmg/Xsa/AwOXvm/OEabaGreVHsbVEjM49S+Dix1ckXNFJXYxSTqSFigPododYf+IwubpK9zXG0uOwG+RO4tg0rWYD0RKoWmrkfQl7t0BEewNYwX1rrpbQIGQzQFPT+xVyprMZAXqlirbYkOW4DKICnWFo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4587.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(136003)(366004)(396003)(39860400002)(346002)(451199015)(71200400001)(26005)(54906003)(316002)(6636002)(6506007)(86362001)(478600001)(122000001)(38070700005)(82960400001)(38100700002)(186003)(9686003)(7696005)(33656002)(107886003)(55016003)(4744005)(6862004)(66899015)(52536014)(8936002)(4326008)(2906002)(8676002)(5660300002)(41300700001)(64756008)(76116006)(66946007)(66476007)(66556008)(66446008)(32563001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qDp3ArA7QDNMGTDZfPOXEGLDeyQZxq1VZ5bhLbNCudzqhXfnXkpl5lPr4fy6?= =?us-ascii?Q?NHBS76+xwvO8iNxLBcCxz+qUlx/+T9bS5vdxCkkV0wW9brK5TkVwME2GSxa7?= =?us-ascii?Q?/bNMjOsrQ3hYTvYWH6igPsNiKXqyTsqTsHuz/d7pOFX+BsNEeE/47dvngD3u?= =?us-ascii?Q?65emuwluhhKwzgFzY93DeZPTyNpcCtplJtP8fc4yAtvShDuNe0QqQmrJIoUF?= =?us-ascii?Q?zwW1F4BOL8u7GLl4Pp6QJek0CctqwYyHPanqtG89a0N9dyxW+PvTqDjIAlGR?= =?us-ascii?Q?MaYXYnKBpZ83i31POOIqpMjw7BAU3YWb8WIK3alJmLVNHpNCb2F4O4mNUgOP?= =?us-ascii?Q?36HU29YfMDaF2RoINIOuBYsUG5Aqc9F796awtJ2AP/KheY8zWPRHtnY+jhEX?= =?us-ascii?Q?tjqFVPre9ccHu1pkuPdzPCPpeEip1yisR4S6a2I4tuo9uJE8B4SvhBkLK4QX?= =?us-ascii?Q?A7A/fnU3ljipKIst7sTQ0HzZNaFs3pFYU5UaluadbH9iUu6NAwZegKugDupd?= =?us-ascii?Q?e28E6ASRbPcTCdPNyK8WAa1RoIiqG9xBMxk/0416IeBtaaSLum1eD64MheU5?= =?us-ascii?Q?9DVFCF1GVfP/BwINU9Kl1E6w26PtmqBjC0abLkfOUCF7mtIzaB0SD28zN1yG?= =?us-ascii?Q?KmGkbP3XOvkb8QYChEFysKiFdgC0KuocGkZXrMoLhAQwZjMxmyQV5joo8KO4?= =?us-ascii?Q?9p/V0lg6DT24B7D4235jBVFwNZTrQboyKrwG/hsraoTkPSIT5teCOfQ82U+0?= =?us-ascii?Q?zcxKjPOIC12m6Pzen5LbgA8rMw26eviUqNjLl1VkemiAB2fn3yqqkh6PNdYj?= =?us-ascii?Q?2zTxZAvCgAknJlsNJxAkxyCMfOw+r2fIUqtEvXtj70hl3RM1mE8OznNKV7xd?= =?us-ascii?Q?h8ZuJUy0jn+SOhL546VdD4sSIJ3Wgr8amOkM7SrB4hI/e3B5s1Gr7ZXG9X9w?= =?us-ascii?Q?MTri1e961nQkq/yUkZUinzXqc7jfEmxZ9q/wA0JN2m4zGlHd944o7rtYRXeb?= =?us-ascii?Q?clrX13t/Xwp8lcXSi+FyanrZ/HT9IXjyK5DzueglyeTN5Zp/YyTULfi/wxLw?= =?us-ascii?Q?2mw2ikSO12kxAY0lYpWV8rC3NL0anAS+H5OJK8YFHqge/5qKsIRPfTYTVRQg?= =?us-ascii?Q?h39jrv2TLGCAKpH7lxjuLH2Yilez4pIEIwJ26p0ZUvCI93STqEQqQZPUIwmU?= =?us-ascii?Q?ZIgEdW0UkzwFqUu90BkQaLmByM0+766RGpr3HZ/j4qxb3W3XNwJlPjFKtXol?= =?us-ascii?Q?uzoACezkNOTTp2GzNzbIdU4CLpgpS1xGrIzrZqxc6N0jPuHRw3r/NxHnAoF6?= =?us-ascii?Q?CQMpUGLrKhpr2bQhBBo68zZaEoj2EtNlgUnyVeUJsmTco4ZMhfcHm8pj3DYK?= =?us-ascii?Q?HKYfQdiLXrf3ErDQHvk3RY4BwVqXtqpy+CiGCTJpdQACOzN8Y1/6YQirhOG/?= =?us-ascii?Q?ZV2l9P0JN9wwNTLVSKLXH5sHs6s/B9jYm62iWtjZjNaJ/YzcYrnil+XHUimU?= =?us-ascii?Q?2ooc3FOPT8guY71Q45aw+3yLiDbhquM1Ew0cMqAwZTweY9oEMOVi2Q9xwK6z?= =?us-ascii?Q?N6Ac0PXuHQtFzbZMa4s82Rawk627yTsdYHMf2hxc?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4587.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbf178f3-85f3-4482-8244-08dac92d8a12 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2022 06:24:25.2901 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qm9oiYOEJIJw5bfkYiGwrZiXHnYJnKjK6/96yjo8aLjTBMsjT0zOBlwKvghLZIv9hmmNeE7MUNm7swKV7XpjGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5954 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > - > if (conf->txmode.mq_mode !=3D RTE_ETH_MQ_TX_NONE) { > PMD_INIT_LOG(ERR, "Multi-queue TX mode %d is not supported", > conf->txmode.mq_mode); > diff --git a/drivers/net/idpf/idpf_vchnl.c b/drivers/net/idpf/idpf_vchnl.= c > index ac6486d4ef..88770447f8 100644 > --- a/drivers/net/idpf/idpf_vchnl.c > +++ b/drivers/net/idpf/idpf_vchnl.c > @@ -1197,6 +1197,9 @@ idpf_vc_dealloc_vectors(struct idpf_vport *vport) > int err, len; >=20 > alloc_vec =3D vport->recv_vectors; > + if (alloc_vec =3D=3D NULL) > + return -EINVAL; > + Would it be better to check before idpf_vc_dealloc_vectors?