From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A9A9A04B5; Tue, 12 Jan 2021 07:45:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 48CAA140E7F; Tue, 12 Jan 2021 07:45:12 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 69228140E6A for ; Tue, 12 Jan 2021 07:45:11 +0100 (CET) IronPort-SDR: il9ruQSp+RA0GIDcqwcy4kjwCLMzMgD1qOM7ZvDQfj0CbrIYAEb1YfBWZysOsJhkS/knUrR/6P fPLto72n7hXA== X-IronPort-AV: E=McAfee;i="6000,8403,9861"; a="196613061" X-IronPort-AV: E=Sophos;i="5.79,340,1602572400"; d="scan'208";a="196613061" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 22:45:10 -0800 IronPort-SDR: HHeJ7p7Lym4bTTnhO71ROJPBcE0V2EXhtJ6FQOEUCGQ4vkn0KvP1K2TIpX7ky2xC/pKe2b2IkC e8bK5LDqBVmw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,340,1602572400"; d="scan'208";a="569003218" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 11 Jan 2021 22:45:10 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 11 Jan 2021 22:45:09 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 11 Jan 2021 22:45:09 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 11 Jan 2021 22:45:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mUkqb5GtJtkec37T6jCEqIfLyDFGjB/o0G2NFXExb3+YRmjK5a08cr4Ytx4F3sZE0ox39usL+hnQNT9QYQAE0vD4vkzYGuaVFYbIihMkC1yhDvTcMAUYgB8jvWM5MzATF8CGtFS4ZrAX8R/xcXpEaI2s1CUQK02qgw8deBIRLg1zXortnxJKM8BTN6FF5KyQmqkhYcrx5VjLFmYTbqWQTACom1d7HqNoJrnJXURuyThIOQl7/EasdjqDGMdhT4latQ138fQbpMtghyHChBkJqDH9YrgWeBaKQnvIRm8x+kNU6m6r5Q+uUO235aGSdzsn/Xzuh5FnLvXlS0E4hR2tTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+etF79Xk1rY612QfYlkCFFVZO64+3bJMtThSo7GwW9s=; b=YawUc+/gPV4gUWYCVQ8blpfSloPcu6uBYxwoYl0AT+thn4XFELQkdPTYeRqm3ozOh6YnMXRECW/CN0Pb1H/o7vCaGFK6jRC2do6KwHE/SXyiVTBvviZrZdGbLiji7cywHVHNqhJo+0Rwqrmoh8qNNTSgeVlZDlVkqFB43Q80S771rNE/jv7V7dx8vFdh6yawyk/YfD8v+dAjQUwc1EHHMhklGJe6YL/HqOg09lvam9SYvKlkuV/ZM/rJVBjvP8WbIqeMu+PxzmUVP8ZhCuXIW9m9AY/usueVJ8sKJNfbEYG/yivVFRVXdSVAewrCFtAKtsHdmXqg/34UtiQXDbRCvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+etF79Xk1rY612QfYlkCFFVZO64+3bJMtThSo7GwW9s=; b=sqMbpqWqjF0+en/YW70Sn2rqp9E3N1mukv5Zf0Pg6+n9WJEGLeK6EFUbWv7N4aISujQXR8N98YOc1jkSMkzIsOEei7nGyu/wvSXd/Qm/4iS8D+5+mm5EtuTLSK/kbBcZHVz4q9lRBHo8IOLrgW673jt87NgwE5KPSDscNGoRZXc= Received: from MW3PR11MB4587.namprd11.prod.outlook.com (2603:10b6:303:58::7) by CO1PR11MB5108.namprd11.prod.outlook.com (2603:10b6:303:92::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Tue, 12 Jan 2021 06:45:09 +0000 Received: from MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::58a3:c2e5:a891:2881]) by MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::58a3:c2e5:a891:2881%7]) with mapi id 15.20.3742.012; Tue, 12 Jan 2021 06:45:09 +0000 From: "Wu, Jingjing" To: "Xing, Beilei" , "dev@dpdk.org" CC: "Xia, Chenbo" , "Lu, Xiuchun" Thread-Topic: [PATCH v3 5/5] net/iavf: fix vector mapping with queue Thread-Index: AQHW5NDkuqv6nuPc5kmIgdOtgzwc1aojibcAgAAJUrA= Date: Tue, 12 Jan 2021 06:45:09 +0000 Message-ID: References: <20210107074533.15465-1-jingjing.wu@intel.com> <20210107082718.33748-1-jingjing.wu@intel.com> <20210107082718.33748-6-jingjing.wu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e56d87ab-bd27-4fc9-c235-08d8b6c59aa2 x-ms-traffictypediagnostic: CO1PR11MB5108: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TZC5ojP6GbVOfvzxBLzo9EtvxorsFeHGrI9XYqJUQWj6w93pZjLAXyxei48eksHKCNMnTIeDkrM+bFM4QXtcPYZJbv7sXrt4qBYdRwep09ix6huepfS9OCXQfmeHj/aKy8P3osD7wIgbs72wyKzE7lhwecp0Ii3QIQlB+YGl/Vc/NLJ+ZmJdoVqfYSLgBzFyXv/ma2WnhutfSold/yqIhoHagtjPDOFjBNiz6/A58ohpr1KEV4ihLaCWHEUN4PzdgKKjHK8sfOpk39ZFaY13kDhmbsCUVDd9lQF6ZcJ2lrP2JOnxEcVgi5uT6lx8EU1hXWg5uDV/EX7sE9tfny2y4iQHcF+1bgBwbRdKfjaWwNKlZ5uPbspXrybxxDRK2G7yuGDhNWVdIgKDplK7YVwu+ewR/8+iPGfp/qT0Z0m0JQMAC8EUnaz+feDj7uNjeRR7LDHiPcK9Q+XTuSDKJwCJOA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4587.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(39860400002)(136003)(396003)(346002)(66446008)(66476007)(76116006)(66556008)(64756008)(316002)(8676002)(107886003)(66946007)(9686003)(5660300002)(52536014)(33656002)(83380400001)(26005)(71200400001)(6506007)(53546011)(7696005)(4326008)(86362001)(54906003)(110136005)(2906002)(55016002)(186003)(478600001)(8936002)(966005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: ct4fy8+G0CMESl+dkYRDKf6fzPNRdaVCuMAkzdnB96sPJIuUhTsWG3qhIkkOKNqDLRuGSIq0kQvB5EUDLPoAy2R3vRk9IiKRb+CoEitL6GCHdR0wmGmxuFl933zkE5He4WE3He5bRf8KaqdHZFMTRvEBxi7r2p8DHOwpLA+x4wNgOKUoltz0DDw1y3ZEw+0RmKYwoAMi2ixOU8qXl/NlCyMNgn+lIWbZDSE15ZdvdPPlzwq4r1K43FufRqagthrO6vFyGoX8GwglhcsU/G/Hw0bsmqv6G5j4kzjB7/4rxakmQ7sV+n7yfQsGuYelX9tGTIdB8Ec9Re/BtNEJv+Qdcd6/VfJG8plzuyZoU3OdhE4Q/mDpwzc0doJsQtHm432fhcIjoOc1C63qo8RCZ94jjJ/ckflGOgSagzOVEv0UkA/pxn+3lejFWBI2XHnkqNTe82tns0aTLe7Fx/Bg0uG3UNT0ombe3riQHnWMo+5vLA6aBWP6V5zv3U+WvFSKzypZ+nW8QlzJJFlFRHMkRcawpVqZjpItBQAfo8bmVFObZ/MG9hY0J9qRba0/QKjymoNFnF6i3lyx+RBPgJwBRDYfYL/p4+yQzxNWujyHzUaXk1cqeOmk0JUA/Ar36Jj+Vv7Ml8XuiVMrS405oohDwDYp+BBlnVpGVDn1EMpRin5DrT6+aiZJvnrv1U/UqTukJi9g5N2s4wDv84vamTzA/U/No9zW86m9QNYnkISNAsPIEoY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4587.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e56d87ab-bd27-4fc9-c235-08d8b6c59aa2 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2021 06:45:09.1000 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: twvueV2J8jKS52ebXq3hh9k551yNZqRuAooH3WsMdKakwuyW6I4WY+xoVJpXfbrXsdCAoeuDwMqqpKXxF9/dLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5108 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 5/5] net/iavf: fix vector mapping with queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Xing, Beilei > Sent: Tuesday, January 12, 2021 2:11 PM > To: Wu, Jingjing ; dev@dpdk.org > Cc: Xia, Chenbo ; Lu, Xiuchun > > Subject: RE: [PATCH v3 5/5] net/iavf: fix vector mapping with queue >=20 > Seems the patch is conflict with patch > https://patches.dpdk.org/patch/86202/, please help to review. Thanks. Looks like the similar fix. Will comment that patch and drop this o= ne if that is merged. >=20 > > -----Original Message----- > > From: Wu, Jingjing > > Sent: Thursday, January 7, 2021 4:27 PM > > To: dev@dpdk.org > > Cc: Wu, Jingjing ; Xing, Beilei > > ; Xia, Chenbo ; Lu, > > Xiuchun > > Subject: [PATCH v3 5/5] net/iavf: fix vector mapping with queue > > > > Fix the vector mapping with queue by changing the recircle when > > exceeds RX_VEC_START + nb_msix; > > > > Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") > > > > Signed-off-by: Jingjing Wu > > --- > > drivers/net/iavf/iavf_ethdev.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/iavf/iavf_ethdev.c > > b/drivers/net/iavf/iavf_ethdev.c index 06395f852b..b169b19975 100644 > > --- a/drivers/net/iavf/iavf_ethdev.c > > +++ b/drivers/net/iavf/iavf_ethdev.c > > @@ -570,7 +570,7 @@ static int iavf_config_rx_queues_irqs(struct > > rte_eth_dev *dev, > > /* If Rx interrupt is reuquired, and we can use > > * multi interrupts, then the vec is from 1 > > */ > > - vf->nb_msix =3D RTE_MIN(vf->vf_res->max_vectors, > > + vf->nb_msix =3D RTE_MIN(vf->vf_res->max_vectors - > 1, > > intr_handle->nb_efd); > > vf->msix_base =3D IAVF_RX_VEC_START; > > vec =3D IAVF_RX_VEC_START; > > @@ -578,7 +578,7 @@ static int iavf_config_rx_queues_irqs(struct > > rte_eth_dev *dev, > > qv_map[i].queue_id =3D i; > > qv_map[i].vector_id =3D vec; > > intr_handle->intr_vec[i] =3D vec++; > > - if (vec >=3D vf->nb_msix) > > + if (vec >=3D vf->nb_msix + > IAVF_RX_VEC_START) > > vec =3D IAVF_RX_VEC_START; > > } > > vf->qv_map =3D qv_map; > > -- > > 2.21.1