From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A750A034F; Tue, 1 Mar 2022 10:38:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 989FA40DF6; Tue, 1 Mar 2022 10:38:42 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 66769407FF for ; Tue, 1 Mar 2022 10:38:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646127520; x=1677663520; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qendz+KYf4u4Nc7zBx8j8xz/1TUUqiP412sQ6RvKZu0=; b=Gxbc4VO70FMhjqkODKuVdP00EDtqZamUH4qEWuLfWqDy5OoGos35TitT 8TOp94img0YgZLEOQ1vQ/cMndgS7cPYsOcC0+NbnhLQjKVVEZr3AqF/A/ r8Bq0uPrQhmdDrF972kTZrwuJLBqJ/3TYtzBczbHVRqukPF3YdCf6y81H Pu0gwPAmgbzRZHbY1VK7HnDIwwJiaWO5NB0tilgqYuHyCVRiKId9nJdg7 mwFS6St9zHHZT6KmlI+OPDIjasbyhismbj/CZ0VyiS9RwW1VoFkWsmE7S SNZOuKSokNEiF06IjbIYvrradU0X7ZyUvtwHK4qXT/fZQPHRBKxTn7jVp w==; X-IronPort-AV: E=McAfee;i="6200,9189,10272"; a="236607250" X-IronPort-AV: E=Sophos;i="5.90,145,1643702400"; d="scan'208";a="236607250" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2022 01:38:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,145,1643702400"; d="scan'208";a="507742111" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga002.jf.intel.com with ESMTP; 01 Mar 2022 01:38:39 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 1 Mar 2022 01:38:39 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 1 Mar 2022 01:38:39 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 1 Mar 2022 01:38:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lH3xm448Ihe5v0eYO4+RQRb1cpCz109fwHVk8vq4CVnZcsvlMBOgU0/ghN9gMoHfViGYZaW+LljHAl2VrHYh9pi2N/NOs8S9gm3BEHhEK+gZM+9IgdZ+TisY424CL6HHzUiS50bvtii9rHOlJ+Ke2rWJ0i1XnJEjR+bztQCZ8ho4T33Uy4G2evre3LdTL8yaFBsfSm9+FZuBqSf4rpfksHACefMugF1Q2lDfaZzQJFiD2Q6tZRipJND5Dvr86JzpsJvkK8c6R6IF1ECBwOeLaGg45nmInVttZS1WXm2kDMBr64j4BJb/6ZIQgrlPEI6tAqG4PmoFh4sFZwgbyE1ALg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UzmRFCilVcIRaFVhDCHCfoU16i/FIMAl4Ua5tMN1dLs=; b=R2bC5A+tzNB0DOr2LzEXUgWqBbBWLX5G7REU2gsUSPjXcspcXpDQRJwsSAau7eJ9yIeO82KywUnqhNRsygjimJpOewdg6WWG/xHVEmG7uPI3D4T0fL70z4nv36Z26OInoTWQDYzWAa28MA/zLCVpQ2YTb0VH+b87VZ8q90pJVWlxgOw5lZn61xc2furAcdWKCMN9ov04LvFcddTto6KFJLhgbTzLpsYN0COJOmI0sugS+chLU5kepW9wxoBq6mV6oqXGzpcN24c5zKO3GrPzB1H1sU38CPRhuoCCn5NkKRkdlIxOjgPtY6DVfx34es2R+SrskA2r/l9iW5fj34FPYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4665.namprd11.prod.outlook.com (2603:10b6:303:5d::12) by MWHPR11MB1870.namprd11.prod.outlook.com (2603:10b6:300:10f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Tue, 1 Mar 2022 09:38:29 +0000 Received: from MW3PR11MB4665.namprd11.prod.outlook.com ([fe80::451e:ece:98ea:2786]) by MW3PR11MB4665.namprd11.prod.outlook.com ([fe80::451e:ece:98ea:2786%8]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 09:38:29 +0000 From: "Wu, WenxuanX" To: Thomas Monjalon CC: "Yang, Qiming" , "Zhang, Qi Z" , "dev@dpdk.org" , "david.marchand@redhat.com" , Harman Kalra Subject: RE: [DPDK] /lib/eal: fix failed to stop device monitor error Thread-Topic: [DPDK] /lib/eal: fix failed to stop device monitor error Thread-Index: AQHYHyX+WldMV4ZK10eoFg4Ma6G6WayRW6iAgBkGF3A= Date: Tue, 1 Mar 2022 09:38:29 +0000 Message-ID: References: <20220211084131.72606-1-wenxuanx.wu@intel.com> <2445962.TLnPLrj5Ze@thomas> In-Reply-To: <2445962.TLnPLrj5Ze@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 382ecc38-6b2f-43ab-00b5-08d9fb673e79 x-ms-traffictypediagnostic: MWHPR11MB1870:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +m/8Pw+62p0TYQeWfh3Z7PqDsOH6L0VIzcuD8Xs846ZSnSAD5veJvC2SdCoyT28TfR07m8i5ODTmQChFCu960zdMd3B16cUTz+Pt7g5zyz2zyFg82BbLIx3cXL2AyGyroCG91la/NBdaU8WD/CQnyoV2Wa67i+QMbJSXcLutvqjYRBZqd0FB/dekaMNxQzjGPXvbAofHMwoGRSYG0UwNnw5l8p++jnlWk4YSip/WqL9kEiIJYo+hFAPWjBcRibv3M6hU/essKjLdER71a1BTwPNQBKZRCENVsyKIYloat08kgQLxbjQf2zf/eHQlkpweDtfvQGCHkK7D0hQOLohkB5pIJzl+uHRUIUapLHLbCjmdvnW0Omxw7zE7tCpKN1tbfamnnNjLgC6bgJRbpaWnhVVhh5fTAwtqNoaV7tG1rDeqrgXfaX9pv5NyEgJ5HKKIuxtmNX6G1ikHZUgeAV2BnYD0rnm84de5IlhGQtjCLWVftHG/CRVE/RoHRKrLcRhDM5HYigvrR0+KWYWhJD/+jvNyGESofFvMWB5lMjhdjC/fiacZb7RQP9UNjW1MEmBKg+MrjOH9YMKu+o3Tr+wNqMgA50EJNIBnI3xd7WwWh67jOhYSMMsM8XFmvjrJkW5LSEti8k4A70cirgQb1SC9iWkuOp5i73oA28ecr/+ORLF3URxMxuerTM9f0tn8PH6H9o0wzciK5ZNwiylWvpjIEQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4665.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38100700002)(7696005)(83380400001)(82960400001)(55016003)(38070700005)(9686003)(316002)(53546011)(54906003)(71200400001)(6506007)(6916009)(508600001)(33656002)(2906002)(5660300002)(76116006)(26005)(66476007)(66446008)(8676002)(86362001)(66946007)(4326008)(186003)(64756008)(66556008)(52536014)(8936002)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?R3haL1AyNURkL2k0ekRIQUNRbUQydzVDejR1OEJPZ0ZkMlA4TkVTZ0gz?= =?iso-2022-jp?B?Q0xoUzhiSyt1ZCtKY2lVVWFwcnU0WVY2SXp4aG5QSzdkSENNWUkxMm1y?= =?iso-2022-jp?B?MXlmNGdIODFCVmNjNEhZMFEyRTdFRGYwN3crVk5xeC9xZVNSN25mV1U5?= =?iso-2022-jp?B?VzBZZVl4OXQzN01GSkJQbFFHQ2RxWmllekZGeEo1enhqQTFmdjZKeGVW?= =?iso-2022-jp?B?RmttcU1UTy95MjVyWFVoendQbDcxRzJzOHliR0dHNUVjOHJlb3Q4aXht?= =?iso-2022-jp?B?OXdFV3VkN0lackFDM2IrdmUwWXo5NkZhcE5Ka09tL1U4R2ltV3VkWU43?= =?iso-2022-jp?B?RnZtSjZBbVh6bTY0NVl2bDJtKzh6aCt1U0U0aUdiYmY5TU9FZ0xxRFJz?= =?iso-2022-jp?B?M0VZMVV1WVd0QWNzY1Zka1NiYnJ6bXNFbTFjc2Z0MHBQbDI3ZEJZUDZ2?= =?iso-2022-jp?B?V0RLMDJKbVpkaG5Od2ZxVEliT3JiUEpuS0VvNGRWRDI4ZVp6WlhFS2Jw?= =?iso-2022-jp?B?aExUdkp2US9teEpPQXdWYVc4RUMwM0tsNGsvWXAxeVV4NTFmYUV5Mytn?= =?iso-2022-jp?B?RWJSRFBvdFpIdWREVllaSzFXM0N3LzE1NkI2cWhkaXJKMDNMWTl4M3Za?= =?iso-2022-jp?B?VERjMzVyYXorSjQ5VXg3azduTWRDc3ROZUh0dkVjdEx3eDZ6eW4vMWd5?= =?iso-2022-jp?B?eTlUdTBmUFZDQ0JKZFZ5RUZGcXUrNG9SWEpoTVl1NkloQ2pDbGNTWGRE?= =?iso-2022-jp?B?MGxLelZ0UFdneWoxL0JKREtnNDdBTTFzalorMGl2c25lM2ZuSnFGalZy?= =?iso-2022-jp?B?bTZWa2l3NDd4My8vbW1qRnhRVEQ4T3RVTGdiS0VFMUI2aVNORFFML0Vo?= =?iso-2022-jp?B?NVAzN0dLeUh4TmxsbVc4ZkVWN1ZjZWpVcGxBNGFLaHNSazh4RzlScEx1?= =?iso-2022-jp?B?WkdaeVZDN3Axb2R4VFpUZGZCRWpOZlpVLzdGV09FOXhuVVRWdGswbU80?= =?iso-2022-jp?B?QWZrdktPaFRjMU82SmE3WVJvZlR1aTF2RXBWNElDME5FakdOcHVTc2Yv?= =?iso-2022-jp?B?RTF0WDhac2hVQmlGeCs3cUxibkNRSE9ndnFjOW1ZTUNnNUx0SFU4MFdY?= =?iso-2022-jp?B?aUd4ZjIxWDB3dENTRDM2MWI0VHFXcGI4M2k3ZkM1QXNzeW1LUzNTVHFZ?= =?iso-2022-jp?B?TUpqL1AwamNVWURXTGhJZzViVnFKMDloWTQxWU9LVWdJUm5WN0srTm5B?= =?iso-2022-jp?B?Vk1BZEtzK2dUWXc4TkpCSGFnNlNvZmdIc0RGZG5LdEsvbEV2anF2U3lK?= =?iso-2022-jp?B?cU5OM1pqY1JJUzdyMXZWSHBYWElpRDFmODVveVNCLzBXU1k4TFFoOTJh?= =?iso-2022-jp?B?eXhoR2NpYTBVVVNOdG8yNE1FM25OMzdMeHV6VHREYW42djJnSkFmQ2Ev?= =?iso-2022-jp?B?NUpKd0lydEluRW5jRVlJdlRra0JDT1JGTXBkU1dCR1FWYlV4dGxXSXpv?= =?iso-2022-jp?B?UU9vUFFwa3FSc0kwc2pCa2VzOXdKbE4zTy9CSjhZc2I3aXRJcURSRWd0?= =?iso-2022-jp?B?WjVZUHhQTzFveEJHRHVxMWtoZDgzeVk0VkVJZ1U3NGlDN1RyRVlMRXJS?= =?iso-2022-jp?B?Q2V0YW8zK09jK3MwZ0FTTHFqdzdXTlNUQzJJMFI0WXFyVTlWWVdkSnY1?= =?iso-2022-jp?B?Ty8rcFVVSCs3WXgxcE5RV1FDaDRKSzFSbTYzMmxBVlFpUXhFTnZac2J1?= =?iso-2022-jp?B?UHo2YkRVS0VydVlKcnBmcHBwTGV4WldPZ3dwdDJaRHhFZ0ozZERPOFZt?= =?iso-2022-jp?B?U1BuS2VYb2s3a3k5TFV5ODBwaC9keHk3Zngvck1WSzRwRTV3OUExN3pY?= =?iso-2022-jp?B?N0lVQWdKNUpkalU1d3hQY3lZc09FbkRKU1BvUkhEK0Y4QTZncC8vNkhi?= =?iso-2022-jp?B?WmRSd0twMzJvajBheitUN0o4WnU3bnovaGRDYVhhczZQdFdCWHArT0c2?= =?iso-2022-jp?B?STNmdUVJbWtaR0ZWc1JVOC9wdkdsdVpnQWZ1Z2gzNloxVEhPUzEyejVk?= =?iso-2022-jp?B?Tm95NkRCYmpyZ1BCVDRrZ1NoUHNVVFc2T3UvL2svNnhtelhMZUhJOVZi?= =?iso-2022-jp?B?RnZiSEFYckM4a3NXNXBYVHFXSWN6YytBV1AxekpJdlhscEl4aWdMR2ph?= =?iso-2022-jp?B?WWtsZkQreFM2SFp2bmhacEdkektXcGtBRWxraWhoaTIxTG4wSkRHblht?= =?iso-2022-jp?B?elljb2JQZ2tib0pBblQ1YTc5M2hnanJhVHJ4ZUdaMVFzUzRTVU9vNmZN?= =?iso-2022-jp?B?eGRyWWN4SVZIeUpGeTgzNGpnTlhSalhxakE9PQ==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4665.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 382ecc38-6b2f-43ab-00b5-08d9fb673e79 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 09:38:29.6862 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bqCDCAO48PQdpIRtJfyUY7xgYsFhkuNmPZrPHBwBXTsHcc6mHKLbJM5/pbeKpBq5UMTBjddsn8Pt29o6Qtd+Zg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1870 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Let's start a talk about this patch. > -----Original Message----- > From: Thomas Monjalon > Sent: 2022=1B$BG/=1B(B2=1B$B7n=1B(B13=1B$BF|=1B(B 19:30 > To: Wu, WenxuanX > Cc: Yang, Qiming ; Zhang, Qi Z > ; dev@dpdk.org; david.marchand@redhat.com; > Harman Kalra > Subject: Re: [DPDK] /lib/eal: fix failed to stop device monitor error >=20 > +Cc Harman, maintainer of interrupt subsystem. >=20 > 11/02/2022 09:41, wenxuanx.wu@intel.com: > > From: Wenxuan Wu > > > > The ret value in rte_dev_event_monitor_stop stands for whether the > > monitor has been successfully closed ,and should not bind with > > rte_intr_callback_unregister,so once it goes to the right exit point > > of rte_dev_event_monitor, the ret value should be set to 0. > > > > Also ,the refmonitor count has been carefully evaluated ,the value > > change from 1 to 0 ,so there is no potential memory leak failure. > > > > Fixes: 1fef6ced07f3 ("eal/linux: allow multiple starts of event > > monitor") Cc:stable@intel.com > > > > Signed-off-by: Wenxuan Wu > > --- > > lib/eal/linux/eal_dev.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c index > > bde55a3d92..4646e8a550 100644 > > --- a/lib/eal/linux/eal_dev.c > > +++ b/lib/eal/linux/eal_dev.c > > @@ -384,6 +384,7 @@ rte_dev_event_monitor_stop(void) > > close(rte_intr_fd_get(intr_handle)); > > rte_intr_instance_free(intr_handle); > > intr_handle =3D NULL; > > + ret =3D 0; > > > > monitor_refcount--; > > > > >=20 >=20 >=20 >=20