From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36696A00C3; Wed, 7 Dec 2022 07:53:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 291B741181; Wed, 7 Dec 2022 07:53:55 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 00249410D7 for ; Wed, 7 Dec 2022 07:53:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670396034; x=1701932034; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=3PF8hovaJuPuo5jv8ZrkTeaZG4qdgjhT9Ru4Qyc2ZJ4=; b=kbBigjg+NB6UoxPK45keOPlp4kFOerQraAJKKItXPkp000EHumybNUvm P3jaHpAYTcZ/N93ST/wMfnMdNKvHkWUWzfpp0FdhDY63RccQlLmqeUGVg WMoRlu2A696QOd/vEKxLbATGPo/AyhL978ZTrfKDXim8vJG6DyiyOni2P 55Gv6LqS9AhioSUsD2PlHZTh6swVrtX6BZBVvjxAnX/y18HKuI5eqsaP7 OzIeJdLOBmBC7dCySCZFLvQc7UPMWHXUVvTLU5c3BJOUmImRRLM8ABYRO MgcEiwwnZ67J+CWaqmor9lE8ZWDc3aGxkfVjga42m+xeyNQt7Qp8FHdhR Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="316833478" X-IronPort-AV: E=Sophos;i="5.96,223,1665471600"; d="scan'208";a="316833478" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2022 22:53:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="788781354" X-IronPort-AV: E=Sophos;i="5.96,223,1665471600"; d="scan'208";a="788781354" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 06 Dec 2022 22:53:53 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 6 Dec 2022 22:53:52 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 6 Dec 2022 22:53:52 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 6 Dec 2022 22:53:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ff3+xnRfbnlH7ddsjt2FZzeP5wFHf8XcQUdbjQkK/NeJheKhwEdzlPdpqQunJpJvdsjHNxkOSU1mi8WJRu9hUol5EfmTZQUG98qpeqHgFvQ5JPBYk7rHeqbCfDmLukirtIA6lGWiajRKr90vQa8chlOs8GvgJPK37ruKjPkDWX/v0DT2Np1X6waOIO/E0p1nhn4DU/6A36yGvHphnebb7LfPlL42hXDapiKmSreyVYCRR8I5XsBErZBT85xCE9tEjT862CyeW0Vaq5Jd/t5wlUeFzKPRk//ws+lj112skdkqjX2+5MyCkNGpBgCum2GsuxUvyMX2LsjKg0WK4LYkFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=38aNF+4vRSGMOS6V2nWskn2KnXtCHc9hZAQl/krcIA4=; b=AE/mijA3LQ+Wr70NSFB13yDB2tbBRIulb+bM+7Qgr2XSYj7gKqa2waGfyHnC/vHL1cX28oEOfUtZyY4x885BK5xwYyX0oLRPWd5CYyNICMo43AIrmS3I7XbwTKCFAGsmyh6vlylWgFKdKMH4jXXYuegURX6b+GPyi4S5LH6JEmFYjqg77qY+cQ+zOAfa5umV5iquxzQuZrC8NZAhXnr1usU1viHDXstuEZiXbzF59Tfy5vE+23biU0GwRwK93nlggC2FUxlMcWmmYqavavMcOTpb1w8FY7anJoUb0/REjOrFX81qrkd+6hBi6HH+dGgY2nl4GMQ8PzXFaiE7O69Juw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5911.namprd11.prod.outlook.com (2603:10b6:303:16b::16) by DM4PR11MB7397.namprd11.prod.outlook.com (2603:10b6:8:103::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 06:53:50 +0000 Received: from MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::8d97:12d3:1a3b:1561]) by MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::8d97:12d3:1a3b:1561%8]) with mapi id 15.20.5880.014; Wed, 7 Dec 2022 06:53:50 +0000 From: "Kundapura, Ganapati" To: "Gujjar, Abhinandan S" , "dev@dpdk.org" , "jerinj@marvell.com" , "Naga Harish K, S V" CC: "Jayatheerthan, Jay" Subject: RE: [PATCH v2 4/5] eventdev/crypto: fix overflow in circular buffer Thread-Topic: [PATCH v2 4/5] eventdev/crypto: fix overflow in circular buffer Thread-Index: AQHZBVDLVZFk/w9Op0myIuumaeGSIK5hFCaAgADycZA= Date: Wed, 7 Dec 2022 06:53:50 +0000 Message-ID: References: <20221130171014.1723899-1-ganapati.kundapura@intel.com> <20221201064652.1885734-1-ganapati.kundapura@intel.com> <20221201064652.1885734-4-ganapati.kundapura@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5911:EE_|DM4PR11MB7397:EE_ x-ms-office365-filtering-correlation-id: cdc2e3f6-00e6-44f3-5ac2-08dad81fcc1c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rmgfNo64Hh/d1VeTaTBwh17/23YvI6KfNuDjtLkXoPUu9dhAmV3DtlWvk6LWZguvr9Zm6o3ScD7UdYyCYPZXCiXAQW5xXvpz3CTxBZ3MlTxBfjMR359p7CZ+VctsfBrGFt9I+fBn8k/CQCW61E7bO7j/GvywgL75bvqr1A7cOjAXBdrD5BiwoWT+J4ugVkNB+mwvlV+vNfsfIN7AwETNugQ/WVnJU5b7K+5rPZHdsS6+9/el+bGHfbzQT5qIo2PK1Ps/FMRB0NpScApTk+C2gd+ZbwAulzX0VcunvfVtQfDUtMf6yPutzRBkBBK8ucvrS/yuLwXEHM3OSQD/Rx/ND8rXUOgVY8kW88VWDOTHqTmmYr3ReeTNMflKoI4sZm5z9jt4pfBDhtD0zcGzwS4cx0OE776jqp+bggSzVDpHAiVi9GMCJFuMzuFUs/hchaasBX+HzMbVhNyJyaR4mSaS1P9oboQzRU6b+gmKm7AK5I824VwLFsYRVckIjmLwU2o36SlriUg/ILp9rFAQg2MkfvPTRxPLpWJ86O9erJKvXxgAT6MSIjeC+KorInid1vXit3igoyFOW+UugjzuE/awkKVQ5oXF/GJCSlssApAVw5BKkWlBpJonrI91ndtWZuEhfqEMmFfmMEv63GfFZVoJlNj9fBxFu9rQCbKGGVi3RI00YUTCBPTAg36oN2tgPFC9MSLf6+cLtFkFt231DqiNcA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5911.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(376002)(136003)(39860400002)(366004)(346002)(451199015)(41300700001)(38100700002)(38070700005)(186003)(2906002)(82960400001)(5660300002)(83380400001)(122000001)(107886003)(8936002)(52536014)(478600001)(7696005)(53546011)(66946007)(55236004)(66476007)(6506007)(71200400001)(76116006)(86362001)(66446008)(26005)(66556008)(64756008)(8676002)(9686003)(316002)(33656002)(110136005)(4326008)(55016003)(6636002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6wVnwKJisdhUbvUfSpERIfz4FvP25sGCLCmmoU4qZ9n9rk+XVH/Oi1zUoUnz?= =?us-ascii?Q?RbGT8n+UUsE7RAgsLl+gCri7d3e8J/V8nHThGwz9FAKiiW3wejz5nHzNDLFK?= =?us-ascii?Q?RWIK69gqD+r/U5eqQmdrv2Vi/ejVTJ1o6M/e3f50lDMDEIUGJvPixjaBjxhM?= =?us-ascii?Q?38tfzXOc8xpjhVIE5BLEas035BKhwW9pIE3gGzpfixsRrHY3pC4uOZyOMqoL?= =?us-ascii?Q?xZtfYVs8Np2iYVWKVqgTqqsrOZafhQki68tCpTrG5qt6lslsI/iqaRpLzBOR?= =?us-ascii?Q?Q+UOkTRzIs3ZF86ex18sQPKlUgsetRAe1JpZ2Q0fY0WczO8WKBDgtHigKObQ?= =?us-ascii?Q?AXuNeOn3ZjNebDfw0j+0vCMtd0owF6P9h5sHiofrzczuu1M9p3COo1XEBpCW?= =?us-ascii?Q?bvTOuNRaj9H2N63/YsuRpFKd/YcWoJU68XINEcGwYSk/cSEFV2kOaqFcA2YM?= =?us-ascii?Q?CWE4NUB87kZtQnuTyr5Ix7rtdj80Ik4qJDJBrQ0LrGMjb00dFeSwjz/RIrvR?= =?us-ascii?Q?cmYFOS7b8A+z2JjtC9C4clu1pyfGsu3XMizEtRYb88Ni7iUldQDR3nfl9XoL?= =?us-ascii?Q?f4dgQmvFxFiTpJkoOh0b8LDdzlqd1aXlj9+i6gp+kPuz+8dps8E+M9jGQKkZ?= =?us-ascii?Q?YqExQD2xLl7MjviQwJJP5gc2S/9dsaKngsGlTP1NB3diiq6KjM5et+DhXSQx?= =?us-ascii?Q?Yi6GISIcLw46+ptngDaPg0YBFHiZS4IcWqeLZFafB+r8UFAFQ913pfRqUTPE?= =?us-ascii?Q?Yj9USOn36FvhNzgDLZu0KDD96q1nFboeCM46S5tCuVzcaeF4mPBqIc9ljPQz?= =?us-ascii?Q?5WivYp9TqQlFkuu0UkjboJgLp3xKirM1ajghxJ3RCkfue60f8vkzAxYxyuC7?= =?us-ascii?Q?WFV+fw6omq/aIs0x5rn4grY8RcZkm9HEBNSm8Iw7CgGQ9ck4z00PDBHKrCcX?= =?us-ascii?Q?VzoPctMGxwG69j3JgCOhpdS4WAA45amlIcmN254KrzaDfrZ/ZaobB9rdM6cV?= =?us-ascii?Q?109Zn6STsJLBC7TkOKL+LqMgwFb/WKRLb89pe7dsPOP3cNlBl2WIBtKZzH1p?= =?us-ascii?Q?8Hzn2eh78EjURPKbls2rrHk2zP8xmKOxiyet9VIFWxyI9NxKDacEA7CPyD16?= =?us-ascii?Q?E0iwFtPVOlM7iNakntOL4I86iPUJC3P8dQiQqLJyvaffSdagzDfRMLiFJ897?= =?us-ascii?Q?OGgh2oGAaQOozZrQX9KdV4AUYd3Ag9cyEhQ10KAzidckqUHH6YTUfO/orDzs?= =?us-ascii?Q?FvaT/dAQMea7fx4VCZRvJJWQ3JfUwA/ud3JlBB3R0SxeVrjSBeTrznOGyE48?= =?us-ascii?Q?g08ZW3kMT3izezT9sVsxwKBIVRIKv/7cr2LL9T5j4afzEDkpGn3gu0qMkvLY?= =?us-ascii?Q?STgS08MdHl+5QRhTzsG7FFrDV71wFrjSRE/rcvMyjBj9Kss5ZcTrDNEYC5Nj?= =?us-ascii?Q?Byk3hmO38lZkE70jXeeUXmRN/bqvIz+6VQwQ3Vc1BGiHQQT2u7EPKlTdyXyb?= =?us-ascii?Q?2oWqsgxybsnpdNIhenviHlO6/iPADwBUQeuELbM1yDHS2L3oC+a+K1V/3Dro?= =?us-ascii?Q?EPjU2+cr8mz7pgwQdpPeJ8B2AXQv6vatE7YRgFYkF3U7J0lnp0ncqN7fMsFk?= =?us-ascii?Q?nA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5911.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdc2e3f6-00e6-44f3-5ac2-08dad81fcc1c X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2022 06:53:50.5873 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6pHyRWGpM5GxIhFQlvxgg+tvGXRQxnA2/LC1FWhD825vsgzuldMG1ajA+9IFnERW6ym5xqbBhmyOghdB7/vPVqgd2sLdFlvaRPRtnxoGq74= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7397 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Abhi, > -----Original Message----- > From: Gujjar, Abhinandan S > Sent: Tuesday, December 6, 2022 9:56 PM > To: Kundapura, Ganapati ; dev@dpdk.org; > jerinj@marvell.com; Naga Harish K, S V > Cc: Jayatheerthan, Jay > Subject: RE: [PATCH v2 4/5] eventdev/crypto: fix overflow in circular buf= fer >=20 >=20 >=20 > > -----Original Message----- > > From: Kundapura, Ganapati > > Sent: Thursday, December 1, 2022 12:17 PM > > To: dev@dpdk.org; jerinj@marvell.com; Naga Harish K, S V > > ; Gujjar, Abhinandan S > > > > Cc: Jayatheerthan, Jay > > Subject: [PATCH v2 4/5] eventdev/crypto: fix overflow in circular > > buffer > > > > Crypto adapter checks CPM backpressure once in enq_run() This leads to > > buffer overflow if some ops failed to flush to cryptodev. > Adapter is agnostic to hardware, replace CPM with "crypto device" >=20 > Rephrase the commit message by adding:- > In case of crypto enqueue failures, even though backpressure flag is set = to > stop further dequeue from eventdev the current logic does not stop > dequeuing events for max_nb events. This is fixed by checking backpressur= e > just before dequeuing events from event device. >=20 Updated in V3 > > > > Checked CPM backpressure for every iteration in enq_run() > > > > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") > > > > Signed-off-by: Ganapati Kundapura > > --- > > v2: > > * Updated subject line in commit message > > > > diff --git a/lib/eventdev/rte_event_crypto_adapter.c > > b/lib/eventdev/rte_event_crypto_adapter.c > > index 72deedd..1d39c5b 100644 > > --- a/lib/eventdev/rte_event_crypto_adapter.c > > +++ b/lib/eventdev/rte_event_crypto_adapter.c > > @@ -573,14 +573,15 @@ eca_crypto_adapter_enq_run(struct > > event_crypto_adapter *adapter, > > if (adapter->mode =3D=3D RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) > > return 0; > > > > - if (unlikely(adapter->stop_enq_to_cryptodev)) { > > - nb_enqueued +=3D eca_crypto_enq_flush(adapter); > > + for (nb_enq =3D 0; nb_enq < max_enq; nb_enq +=3D n) { > > > > - if (unlikely(adapter->stop_enq_to_cryptodev)) > > - goto skip_event_dequeue_burst; > > - } > > + if (unlikely(adapter->stop_enq_to_cryptodev)) { > > + nb_enqueued +=3D eca_crypto_enq_flush(adapter); > > + > > + if (unlikely(adapter->stop_enq_to_cryptodev)) > > + break; > > + } > > > > - for (nb_enq =3D 0; nb_enq < max_enq; nb_enq +=3D n) { > > stats->event_poll_count++; > > n =3D rte_event_dequeue_burst(event_dev_id, > > event_port_id, ev, BATCH_SIZE, 0); > @@ -591,8 +592,6 @@ > > eca_crypto_adapter_enq_run(struct event_crypto_adapter *adapter, > > nb_enqueued +=3D eca_enq_to_cryptodev(adapter, ev, n); > > } > > > > -skip_event_dequeue_burst: > > - > > if ((++adapter->transmit_loop_count & > > (CRYPTO_ENQ_FLUSH_THRESHOLD - 1)) =3D=3D 0) { > > nb_enqueued +=3D eca_crypto_enq_flush(adapter); > > -- > > 2.6.4