From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 803624410E; Thu, 30 May 2024 13:42:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FC1C40608; Thu, 30 May 2024 13:42:02 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id AAB99402E4 for ; Thu, 30 May 2024 13:42:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717069321; x=1748605321; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=w7dgieKXD0WmEbZS9aX7Vve4UFtQBtsyAB4X9OxzfUk=; b=foRXA5fLqOiA9//fZRBeqxdJiNzFs2efUG0FS+BwV31h1XfUJ2I+X6BF muj2OvcmiDC1RUyTAgWsmlfzd+m8sGbUo7K63WpyBO0nSKW8Vp7RQZWG5 MQzVPl7oCGFDgR78FU8iC9iyemCuAQp3/7VC+uRm7lQKI+S8kzHjggma8 D5cYA8i+aa9cIvn1iHoL6ncdIq6TkSUi+CNmgK5iwhbUKRYx7UlLK+vOQ y9fRIqvkVG8rO2viu1XLgSjbWP8JnBDflkwMN2rA8EqFuDr7H9n5KhVMh zpYeq4kyXrIXyFMMxbKvUmHKv/rMTDGYISUlH6PH1+ODSX56pPX+VCEwR Q==; X-CSE-ConnectionGUID: W+MKQGLVQIaxd0Jw9BUTNQ== X-CSE-MsgGUID: 6kyfT4uyRAqAhmiPujH3qQ== X-IronPort-AV: E=McAfee;i="6600,9927,11087"; a="31044913" X-IronPort-AV: E=Sophos;i="6.08,201,1712646000"; d="scan'208";a="31044913" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2024 04:42:00 -0700 X-CSE-ConnectionGUID: P1608pdHSZ6QdYhzdOfYCQ== X-CSE-MsgGUID: 8eX/Zpj4QdGwuP4D2w1bYw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,201,1712646000"; d="scan'208";a="66980605" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 May 2024 04:41:59 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 30 May 2024 04:41:59 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 30 May 2024 04:41:58 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 30 May 2024 04:41:58 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 30 May 2024 04:41:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OTHagzvGSBRRF1BTOCLoG9Dt3X1/mA4Rca9YJNtQfcpyT6GC+y5Ychw0ZrCEdsQOJfurQEOsCygf5Dpp6MkVcu/zAmU3V2stAPL8H0kS2+lkvJh1Px4cKly48Msl6oyEB1+nbeVUMPNUOA+XnK64VZmGTt3q8kuBE40v7H2xnujCKu+e11Fq1SxVEkO8bPPd6OuTmGE5nIqcddSkC2WTAQbyKydDykyORMIYUfV8lN3dufO1fw5KVndM6sW+fiNMwfBFaS+qqJh0A8CW9oPiLmUOMGvYgcA4bt75URswgx0rFtzP+0kCIBD9Ojj1RT7OShL1RpVVQUMJwCSPsik+9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w7dgieKXD0WmEbZS9aX7Vve4UFtQBtsyAB4X9OxzfUk=; b=nDdAW2Yo7vLTluSH2LZ/hvSEnpohxXGFLol13sfk+pkmi8m5y1jO3Oy6tBraQijo0gWNI4UXjYNQ0zOumcmyE/Y52HpaCEgnIqIEAbxc8VEoibR1aHpeMZUR4TJ4A7MSZMT0Y3lAnpQewL9lHDa/V9zfUijVVNZ7lQ5bXqEIOa7zWUg8nr8aJ7W0P6oeAsVfW7pRaIZrFN2wb6PFSpMmoZpPXaIz+Dy+KJRaYvFFmTVsLSXsDvJJc8s5n+2bKLEmXKv7sSkEZ0qXIal8+6dgOjZG37gKVa/3/r5RIav3l19saMJ31+7htSQCfLPBUhDZBnbFko8vuW/HFFteN9v1wA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5911.namprd11.prod.outlook.com (2603:10b6:303:16b::16) by MN2PR11MB4678.namprd11.prod.outlook.com (2603:10b6:208:264::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.22; Thu, 30 May 2024 11:41:56 +0000 Received: from MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::1d00:286c:1800:c2f2]) by MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::1d00:286c:1800:c2f2%3]) with mapi id 15.20.7633.018; Thu, 30 May 2024 11:41:56 +0000 From: "Kundapura, Ganapati" To: =?iso-8859-1?Q?Morten_Br=F8rup?= , Akhil Goyal , "dev@dpdk.org" , "Gujjar, Abhinandan S" , "ferruh.yigit@amd.com" , "thomas@monjalon.net" , "Richardson, Bruce" , "fanzhang.oss@gmail.com" , "ciara.power@intel.com" Subject: RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro Thread-Topic: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro Thread-Index: AQHasdY+VQlBT0PFPEGB76JakVCKkLGvbqWAgAAvM4CAAANMgIAAB2sQ Date: Thu, 30 May 2024 11:41:56 +0000 Message-ID: References: <20240416081222.3002268-1-ganapati.kundapura@intel.com> <20240529144025.4089318-1-ganapati.kundapura@intel.com> <98CBD80474FA8B44BF855DF32C47DC35E9F4D7@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F4D7@smartserver.smartshare.dk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5911:EE_|MN2PR11MB4678:EE_ x-ms-office365-filtering-correlation-id: d35250d5-fdc5-47f5-3d20-08dc809d8235 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|1800799015|376005|366007|38070700009|921011; x-microsoft-antispam-message-info: =?iso-8859-1?Q?FvP81M98mxHFpA92fKCgkRVcZ56PUj00t/nlThMK8WCHSSVUdo8ocp1i1S?= =?iso-8859-1?Q?0ZmckU51IJvOpCcpf0Dw5FlVKz2j25sNTcDtXwrluENqt1/ry+iiilhuBY?= =?iso-8859-1?Q?jCGpbpZzPgJ7U53bHTHe3BWaauBZpuUd92fAYOPl3JGaX6MbEjUyM7XS3q?= =?iso-8859-1?Q?0OFHODrebkIrH3Oyd6OgxBID0hUGE5pYEJQjiwA90U30r17fVdtd2nNN4z?= =?iso-8859-1?Q?SiCmR9pU2McHfzNk6qe3L5I4Y+sk2xl3jYbbO9ZTHkeecrV9A8tMI7AhGz?= =?iso-8859-1?Q?wP8/XlXY+77LQLTHzqM4LPZIBVJMXVwMCdSi951ZD5iKBIbzaPNHdZgkF7?= =?iso-8859-1?Q?WfkV148kIX0Mej5HZ6BsHfyAXdBwvavqt5PJtFx/vTprvjqcGWIbaOVl/4?= =?iso-8859-1?Q?4i8UvPapLZCDMr0fKRQIsMo6xhab/yFtcyueqXM9rwdNa/icqzrwFkQ/Ir?= =?iso-8859-1?Q?prFupjRsINP5iLlC48XpP8fUE/aXlGctpp1l7lfGti1p0rwuoyAsg8cysE?= =?iso-8859-1?Q?yxDNzzRJoFZrVWUwxbnitk4aGbKbpr/2UukehfAkYOe9QQyh1sol2ikGzy?= =?iso-8859-1?Q?6GM75eUjaNYU7u2zZ0zOLCKNuavGW01ki4ZWKF4zNPP4sSwbWuySm2SqFM?= =?iso-8859-1?Q?JE5taKgNheexw320TCE94ZHPnvGI1OK0pn130m2P2mcK6OPG6h2XxgBSc+?= =?iso-8859-1?Q?9ohTR9V6T+RYzVGVxjGofzuY/ikLa47bCe4uBHIfi3bPa2Nhg1obkW7T8t?= =?iso-8859-1?Q?Nt2R0ciqBgZ0d8Yb6sR5zn506AjqAYvwA2KWp33WRfYFypI+oxPE9WcpW6?= =?iso-8859-1?Q?R9Nagu/SPwwiVFnduZSofrD7gme3rz8apDYJpqsaYJuS5eCUcWCtwye6WW?= =?iso-8859-1?Q?jReJehv6y295mS0/BdfHCOR5GN8O46S/0EiX68tCLWz3r3KsJTASJuNZ1z?= =?iso-8859-1?Q?sfTQ06qh0Yx0BQAZh8nO+0MgiWTHZDrdRGvcux6Kv/T5FCE0N7FipISW5z?= =?iso-8859-1?Q?2ATYrvMJEMVUCtgJFSTxx73HGFwKeaasF9Nzyq5/ieRLRwaOgiovDepQBu?= =?iso-8859-1?Q?aY89HBi6gQ+hp07M9P+YTH479fdV7M/Sj6PVztKuOhHkTEtl2tXfn7kXnm?= =?iso-8859-1?Q?k23Pnu+/o6VR/KQMnUz0suajx7ldy897ceohmbZz3Lu5KjueFRYrR01KxW?= =?iso-8859-1?Q?ujJ/4ZsQDNeu1QpSUvVFTkCIgNznCEIsOvPyQtPkAjHuPJ9UjWjiFEA57h?= =?iso-8859-1?Q?62JpRbGiIt5O3tb93isGAxvQXUWAcDAgf8iDCbbUFO0N8aFdc2lL7tLfpo?= =?iso-8859-1?Q?1/9iZa+qYlSrsm5Sg6WzRv+hQ3at582VftX03utFunV7QaQ=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5911.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007)(38070700009)(921011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?cjIW2VB0advgGDEmFoK+PQqC3M+wD2maFxUbxWAEu9P2G8gHw4npwLSFj0?= =?iso-8859-1?Q?bH1IjaDzB1EiGm0fcb/5R6BOIFW61MiiJnZuJXFBZ/msEw1ZFwl/qBRGL3?= =?iso-8859-1?Q?Y5JuWsdvrCCnONgiOsvPm8ZHU+dBQtFKuArz974Dp2FMfJukorbLLnsEp5?= =?iso-8859-1?Q?jSnhVjtXgtJUIKWnuFMcQ3N3dciOGwvTKoEbD2aNcIS8b/9mud8zBITYUU?= =?iso-8859-1?Q?QvpKEKvJySSR1ZZ9vLbZHa5kBhgPtG54uNTL3drfqhYip556sudqHmkydb?= =?iso-8859-1?Q?FbMgVJd708Qtyzz6qCgu+/ddCZalgaFrvQ+eas9xRIDf1cISi2J7OmjaAj?= =?iso-8859-1?Q?ryieFP9zEPeBGJsPX8NCfifcDsXrvstj/detlx/XG7BtJeAe2i/ZHExggT?= =?iso-8859-1?Q?xRjTy/XHkc6VOcj0mh0Ph9X7B3rNjUC5cybf7o/R/Pv9tIdZF27MkTIcMO?= =?iso-8859-1?Q?MOWxdVV/y4LfeeN6Iae7yR7ydc626d3+AziZz+nBJUxTeaJSUIhiGdQQOv?= =?iso-8859-1?Q?RF54ExD51RHQNScZqjxmQRwCQHCy7G/Atrf981qzzw54V8Wpd2PFQS+BTW?= =?iso-8859-1?Q?OtM5trjvPv/NrwzMaTYVnNx3EJFRp8LGX6IW819vyyodHgavrJc0sR5drS?= =?iso-8859-1?Q?KnoG7stsJ1uusXBPe1J1rHQ2ZSDndUXjxeS1N3TuLC+snvtvCw4IFT9ug6?= =?iso-8859-1?Q?OJC/BwY2KKVWmnU4sVQy117a2cqmaSE99uJ8cwgjcs/ikB3EzKD8gqok18?= =?iso-8859-1?Q?noJzgPV1+7OlnQ8w+edOe2H8CH/4WmvHXXA7kTphKjNmz1OIH/rMdU6qB6?= =?iso-8859-1?Q?kz+t5rVlfRudLnJJzTb3xdPcUXmD1SxZK4Ke7NmeFrfs5pLBhKKFFuzAcG?= =?iso-8859-1?Q?u6+AS/SxYJbH0dxxhnUL/mju/04AQ/EHhZQJdYXDyA9cB3QTjH8NerMPFi?= =?iso-8859-1?Q?I9am0xJ88k2aXBcBdMpeSo3unxdZJf7nr3zlcI4YQKHLC//6BE/P6coX9n?= =?iso-8859-1?Q?PtVdBhxOHFZtznpmxhU9ar8H+L01a2Rhha6PXZTvj4g5y1tPtRgF3NIBVg?= =?iso-8859-1?Q?jcAir0Q8/kJDFrXd940rb/Dkd88J3CQ5J3utHF7nYQHIlte4m7kmo7Gd5V?= =?iso-8859-1?Q?JOLcO2bQQdGew4Us2u4qNJPqvfud8f4PMEpQRhvuPF1sKGZxeVDwOnvJCL?= =?iso-8859-1?Q?gV8NPLH3oUveq0zHNhH5Auy3WVM/oCzo0zrL2XymQTZx3S7gWNC3X2xh6D?= =?iso-8859-1?Q?34vL1QiP4GK+rNSECh2wHDccWrVR+jSVOejfx6JIUA0jYQvRXTYB4IX3Lv?= =?iso-8859-1?Q?euGlqz1YJHPwbRy9udWplzRPTWqVLVfvmTvwaT6aUxmbGVj58+7cxQpzZP?= =?iso-8859-1?Q?LQ+hHyYb7ON5/owjNQUO87y2iIQyMG0H8i/OZrbg6P/Gr5yfZ3u20quzx8?= =?iso-8859-1?Q?QtiNmm3YN/79pjmqFE1b3iWMNiwuPLLDKIJC1XUcKGKL5mZZRCCpDCQZdt?= =?iso-8859-1?Q?YuYB5Tc0hfCD4yFbwGOgYxQg0CKZnkzwxYs8UOuWbbc8Vmxma1WIioHw4A?= =?iso-8859-1?Q?PVQ/YbqYUUpEPkB+4+kVqR+AAGbvWTDCRhXz/0d9v1qkc66HPXaeUk8C4X?= =?iso-8859-1?Q?bbS1g23E2eXKKhJDn+1Ffen1OoZoXgYqLv6Bcx2iCZDuq2bZsHJxOlQw?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5911.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d35250d5-fdc5-47f5-3d20-08dc809d8235 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2024 11:41:56.2085 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yDpyK9jr5OjSvavX//oWvJWRb8+cD4FTCDKYzlq7qo73WVveoluJZyNMvU0Hmwy0NluLn7Ekcb6bRHFqoXf5tD2Cclt1qKdZUmu1ph57VkQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4678 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Morten Br=F8rup > Sent: Thursday, May 30, 2024 4:44 PM > To: Akhil Goyal ; Kundapura, Ganapati > ; dev@dpdk.org; Gujjar, Abhinandan S > ; ferruh.yigit@amd.com; > thomas@monjalon.net; Richardson, Bruce ; > fanzhang.oss@gmail.com; ciara.power@intel.com > Subject: RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsett= ing > crypto callbacks macro >=20 > > From: Akhil Goyal [mailto:gakhil@marvell.com] > > Sent: Thursday, 30 May 2024 13.02 > > > > ++ Morten for comment on #if vs #ifdef > > > > > > Subject: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on > > > > unsetting > > crypto > > > > callbacks macro > > > > > > > > Crypto callbacks macro is defined with value 1 and being used with > > > > ifdef, on config value is changed to 0 to disable, crypto callback > > > > changes still being compiled. > > > > > > > > Used #if instead of #ifdef and also wrapped crypto callback > > > > changes under RTE_CRYPTO_CALLBACKS macro to fix build issues when > > > > macro is unset. > > > > > > > > Fixes: 1c3ffb95595e ("cryptodev: add enqueue and dequeue > > > > callbacks") > > > > Fixes: 5523a75af539 ("test/crypto: add case for enqueue/dequeue > > callbacks") > > > > > > > > Signed-off-by: Ganapati Kundapura > > > > --- > > > > v2: > > > > * Used #if instead of #ifdef and restored macro definition in > > > > config > > > > * Split callback registration check in a seperate patch >=20 > The DPDK convention is #ifdef, not #if. > Ethdev also uses #ifdef, e.g.: > https://elixir.bootlin.com/dpdk/v24.03/source/lib/ethdev/rte_ethdev.h#L61 > 12 >=20 > PS: Personally, I prefer #if too. But we should set personal preferences = aside, > and follow the existing convention in DPDK and use #ifdef. Irrespective of RTE_CRYPTO_CALLBACKS value set to 0/1, #ifdef RTE_CRYPTO_CALLBACKS returns true always.