From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2973440A4; Thu, 23 May 2024 10:54:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF24F40272; Thu, 23 May 2024 10:54:40 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id 803AE4025C for ; Thu, 23 May 2024 10:54:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716454479; x=1747990479; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Ava9VkYnzyKVUDVgRbqIG1nlZ/DI047K6zwHyp5udQ0=; b=UXpRCQm9EtGNjWhDyM4dEMtfe1I30vgUIRy3dBylnh+eEpijhUjTVi7D UdZUkf7YJTw0RafquvD0yXMTHAWM+yLi8wYA+m8ud8T+8LExW7PM4kLuw rBoVB8NqJHsIsmNUPfPtTAm0MHNgByHlGNPhqtNGRNX4QLcuSUP5OoUKA XcgFAh7Ch5C5l11r2ZW8z9pA16UxGnRkDfKH9kdSBJ8I4MltrJt46RSF8 vKCD49JUP9p8mJBv1WrSowSPo6hATLnsaCrMNjvWPTzOkTnByhN6ImZUd MPKE4I1p8gY2XeDthxKO8oJMwg+iyhEAZslOgEU2rKyaWc/4xFB1zrwCK A==; X-CSE-ConnectionGUID: 4VE/QLbQS2Sd7UN617XqPQ== X-CSE-MsgGUID: d2muaSbXT4m3MVNWslAsNw== X-IronPort-AV: E=McAfee;i="6600,9927,11080"; a="16545566" X-IronPort-AV: E=Sophos;i="6.08,182,1712646000"; d="scan'208";a="16545566" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2024 01:54:38 -0700 X-CSE-ConnectionGUID: 1GZfe37hTqGWi70EAX49FA== X-CSE-MsgGUID: sh2+JF/2Q9GE87+ysrNS+g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,182,1712646000"; d="scan'208";a="71002160" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 May 2024 01:54:38 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 23 May 2024 01:54:37 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 23 May 2024 01:54:37 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 23 May 2024 01:54:37 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 23 May 2024 01:54:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ObAS1hLhTIPcaKOcBr5/XlglG4WHRRsQVkaq1WRTGERlpx+lzvwCwSBjk3G7AwPclM81ztNRABih6HcB00Fq/SWA9bFb5h7C/7X6DVBMH4Y3cyjRoKW1AzXDKJ+n/PX+sTjACB8tta7ykLTmdbCiUEA5MnMIDYy/AysvUwKGyrPO8MJLe0Ca8U99dXTjXAB3DY7D1wrr4BLfwefg/ydIspP5IouTTLjGQnXSPIz706EuyXkr5wVyB7uktwfuiHUxsDprsQbmFIwrrg68tLC5pJYyffUtcj5O04WJmj2LRCGhQkh4nuVG02XpY+mc32878x6lXdeuFOKvi02S9MqeWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZSVS3KZcpotG0dyPi0dr1kFxTM5zc5ktR0JFYeHlxVc=; b=PlOCYaHmHFmNWRkjxX9RuuXp2Cuh/2Q/QEZckHORPe37KLH8LE/Xw80zGATI6gOuhKBSWf7TQuV2IHcBVkYoAOhUZey5TEs0dxBu/FuhhXIWmjzsPMeXBjXl75BtaU0ZpEmklhF7jJ0PlvJvGu0DUCZ7XUfn9aXeSCh2XwmCR8FgXHLWmAOOyFqrSLdzKqV+CLHzoQkjuD5uUIISa7iR17E8AeR+WnmijCgomDF0h9dgakc5kOxi1Q5dCH4phm73/Z5DMYlOdD0XUEPCkrQb+5r9hQzVZJkqXL41G2ILI7sEIHpJRI+MrIGGcTjVfy6fxfA5UFzfClO3prdyBcwU9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5911.namprd11.prod.outlook.com (2603:10b6:303:16b::16) by PH0PR11MB5029.namprd11.prod.outlook.com (2603:10b6:510:30::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.22; Thu, 23 May 2024 08:54:34 +0000 Received: from MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::1d00:286c:1800:c2f2]) by MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::1d00:286c:1800:c2f2%3]) with mapi id 15.20.7611.016; Thu, 23 May 2024 08:54:34 +0000 From: "Kundapura, Ganapati" To: Akhil Goyal , "dev@dpdk.org" CC: "Gujjar, Abhinandan S" , "fanzhang.oss@gmail.com" , "'Power, Ciara'" Subject: RE: [PATCH v1] crypto: fix build issues on crypto callbacks macro undefined Thread-Topic: [PATCH v1] crypto: fix build issues on crypto callbacks macro undefined Thread-Index: AQHaj9XgIxDDCslMeECklgxt3xrjUbFsWIwAgDbP4yCAAAOeAIAAUm8AgAAOZYCAAEFdAIAA7fnw Date: Thu, 23 May 2024 08:54:34 +0000 Message-ID: References: <20240416081222.3002268-1-ganapati.kundapura@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5911:EE_|PH0PR11MB5029:EE_ x-ms-office365-filtering-correlation-id: 8a1d625f-4307-4893-1615-08dc7b05f7d8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|1800799015|366007|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?Ukl+O6lSyix5IOTdpZ6b2a+SNNuSl+INaqorCJUXqIW6dKQ/mlLqztjVNURP?= =?us-ascii?Q?wDlWZZpT25Xth1hadLUf9yBlJANxQLK4XT77XltWDUlBZiJcuc6UKKvpTAZU?= =?us-ascii?Q?P2eLSiRgga/ExuXW0AwzNpyEX68qzbZuNoqqfXeCmLVDCBCAY0L9rQB1bS0N?= =?us-ascii?Q?riSJZM/jGWrDAFrgbm8AvWGDAptYaZEoXyW3EEjtGBSCVCKuzCojvtnNjLM6?= =?us-ascii?Q?wcnvyh4v/dXYYVe7qFWdfnlyM6Eg/wC55Fqx+RJvuUTW5do/UxXkldEwcL4x?= =?us-ascii?Q?/p61RkAd8op+/Fd/IUyXi8VbVNkzFJYXZf9M1TSzWKbBPSuv1UEn4SXEdexD?= =?us-ascii?Q?F9Yf11vyUUIfVlZ3vd2OGlCEOa1RFBGeOpkd1bZ4iapf+7+XE1woiLT2KjWe?= =?us-ascii?Q?7nJcipNbTG83LMSXeZq2HnPIT67x+dSswyPZ/0+tbKeOXn7TBoo7/DvuKr33?= =?us-ascii?Q?u/1QaBDwfamvNbXbSz/X+1/2A2yPi6yAQd88yM+gVfh+zHCWF/zZU6HLR00y?= =?us-ascii?Q?D4oXnsZmPWlfVvsvFpRtk1Id1p1JirIchujrT+038RvbWtD1sSYmLsGmVs+e?= =?us-ascii?Q?X8aX8wg7CVkLqRmurlrSiijcWty5JVhj4gExpSZ6N726H+czCiGDlgCEZesh?= =?us-ascii?Q?E2kAvXjMJKZb/bAKrH8rqKc8hNzdEy+gnfrLn5HmUP7bdBJ0HgTPNTliUypX?= =?us-ascii?Q?MCwUJb0e2LuW4FgJ8H5BdJPTAI6xZ40FuxfgS7fI5OlS+cxlTLFKXMVkV9Yf?= =?us-ascii?Q?ih1emRB+vMvM4z6oqyLfgeYSHYKYxeVRHopqXZnbk4mboXrRJwWVJJi8peOa?= =?us-ascii?Q?7cO/qJbvuFjVUwcG746Ur4AsiUQ2aaxIr7f3fkWGqCqO9tAvLnkD3amp42Ik?= =?us-ascii?Q?3Ya1bGMPesoUAc+wT91vPkkJxJLI62XQzkFa5gQ4p44JZu1WVBJvwTu5JpII?= =?us-ascii?Q?rpuH2+HrozWAntCIb5kzcMEG0j1l/KeaZRZVtXPpSvHqFwg4xYg6Gv2fO3zT?= =?us-ascii?Q?gk3m97CznBO7Fc5v3llvog+SeXYdsLIcyBFsnAOVb+HUJ+oCnBpySLln57V2?= =?us-ascii?Q?5IBrcuHgsfWzsHdH74elm+ozZZI6AQLl9dSRp9ErIM2yT3cFqs6J9SB/aV+b?= =?us-ascii?Q?4ZyqkxFSls0BD0g9lKxSgpKqk4XhrGvHWQd2dMNjsOKmuc7YeJINFv0Nj82u?= =?us-ascii?Q?UlSbQro3cfTIag0S+1XhZd6kRMHXiLhIFilEeMD3U7agv8ZkYW86UFfv/f8O?= =?us-ascii?Q?PHI788xsKhuih3PlXHollyQPgASk/NxCVFUNdmrkvAOm2TssQ29yZFHOTxGU?= =?us-ascii?Q?HIGqgcmxOpMBy5+6kWt0jPLC8WyUHMDRlyHJAl6T89zUPA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5911.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gkfynimsi2ODH+DNWcN+v8qDWqDT6wcr4vWijlj2f3YV5Omzvx92tsHVu1DI?= =?us-ascii?Q?+pFReIn7bwGEmrZSD9Ojhmt4etfV2N/1ZfefMwks5UiBno4rBwOdnWexIhRR?= =?us-ascii?Q?PB7S3Cl3L1hvNklpmjft9hT5Atcilpgh4+5qIYGfJ1rMaEcw4tfx3SupA7Ev?= =?us-ascii?Q?ShoN1qHvnhhTHhog55HtKyvxms+h6jCfJM1mVULiKBBlLNLj2Y2+rVHGm9Zy?= =?us-ascii?Q?2oCik7nlYdiTQ9Wzz1FdEJLYzfpD/IPabmVfiZdxYJNJzLHhVf5vKavo2Tvy?= =?us-ascii?Q?MJ65QTCYJQV5oNvFLv8LbDJT6seIoNcYPQjMdj+3G+yI3MSJ0z9P0+dPS6Dl?= =?us-ascii?Q?ATZDDxq45mcG0l71bPAQlVrrgBXoH/DIObP+nMgo1A664CUOJatPtJ7i1BTK?= =?us-ascii?Q?o+EiQ2FNUgs8U5MmQwAhsTml1h5l/hV6TJ3TL8v9MTILxKI3ea9OfRU10Ts1?= =?us-ascii?Q?WC27VMP9he8r2lOCjnQR89wMxeqW6hlYpU3q+KNfVKhi0KO/zs4YPlq4ZEda?= =?us-ascii?Q?g/XgwZyVfSbFl+Z9YxXsOf/KS5y+HN2RNKxP2Jk04eEPI6av1frOYBolMk8x?= =?us-ascii?Q?JWe7++/QS20dPDqlD9J+FJ2iM6NTuqYcFxokO5aPrKUoRqiCF4+MDvAMDdKK?= =?us-ascii?Q?1E5OdrSSvlOlcDohUmo6PEX8bFS79E5dm3rianA1q0vSOxvjUg958iJaEF1h?= =?us-ascii?Q?ckiu/QdjbAwxY/MRkfNNrNjbd6cUfgqwl9HP920rDS2diTKKXeToSIAPa9SJ?= =?us-ascii?Q?CqjfnHlVa2a3qP9d7Re70N8NHsGpJpohsgNciY/biGQZofn6Bx0ld+ujbCgr?= =?us-ascii?Q?jYfd6kkOCUlKMmMzJEjnLwxZj8/5Pt3xkdg1xLwT83NRz8zB2th6y/z0rEuh?= =?us-ascii?Q?S2HBPsOWGo8Gs861A/Wqw4SXHvXae+CL+lcjqTEmAST2e4z8G7FHSvWB7WPq?= =?us-ascii?Q?0G/8Zb/knNwPBMK/ST/pJXIerohsQbSmcPDaphnhsHenOFBgMTl6gD7Zyx99?= =?us-ascii?Q?3lHw9mRCvpLUwo/PqdWCrvL9dHKYb1SjdV+UG5ywAZ/+npMqMYLgxfuq8vos?= =?us-ascii?Q?ILoKiZRcY79Q0iFCWxMu6gi/8UCq82v+IkBNpIvhLRe7QPYH4/hJGl9smJc2?= =?us-ascii?Q?FlcQ3uIohvBCnLxvNcQpsB5htOpGEaFT6zAqyydZuipBsQNsK1OF9ikmMTS+?= =?us-ascii?Q?zevQX+tzQzghm24rOGAPC0zczLcA1jvMDFel7Gwnr5sFw5msY6Je15t8HCEE?= =?us-ascii?Q?ywG9bpn4Zl5KjRauo8BqGvVBEvTS+17IgyE/cePZClkL7q0CYGIEQB4PWGDa?= =?us-ascii?Q?16gQjfsS0ET3ita7yNcKOop/mdIt3cdTm7YweiTWl57lfJZ+Yk2CZ9+so+ug?= =?us-ascii?Q?/Mv5NiVL3MOVNo8DCyzjkTeZ2YvK1JW5nF/f7lTaRS6bj67/5pk/yfsEG6BW?= =?us-ascii?Q?f1YWZTaDP/S6hPcb1zT6yyoe15sxb6nLx6lbNuJtdn0e/MbyzmLCps4OPMhf?= =?us-ascii?Q?jt6wZJv0jELLgOx2WJbHOigkW3gOiUQbc7KNzsMqcoH1D8Cv1ktQnN4HGCBm?= =?us-ascii?Q?2DN88A8Pc8iPlfQfiNCA2zjfTqoAm53qSCaEjxvvICC0/EDUb2XJ2TN4KV7l?= =?us-ascii?Q?uA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5911.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a1d625f-4307-4893-1615-08dc7b05f7d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2024 08:54:34.2699 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2V6nHqy7g8Mcp5TsCO3HL6oGxUm7OxMjBx3sA4RJnRYDwIy9h4sfALAoSWpi3zI/vzUGeOnltIhcGKA0wbsFXJ63mqrE4wp7NTBVWzyDh2U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5029 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil Agreed that callbacks are not getting called if not NULL PMD as it is de= signed to be run for NULL PMD. Tested your patch with qat pmd and callbacks are getting called. Both the p= atches can go in. + ------------------------------------------------------- + + Test Suite : Crypto General Unit Test Suite + ------------------------------------------------------- + CRYPTODEV: rte_cryptodev_configure() line 1150: Invalid dev_id=3D4 CRYPTODEV: rte_cryptodev_configure() line 1150: Invalid dev_id=3D255 CRYPTODEV: rte_cryptodev_stop() line 1247: Device with dev_id=3D0 already s= topped + TestCase [ 0] : test_device_configure_invalid_dev_id succeeded CRYPTODEV: rte_cryptodev_queue_pair_setup() line 1370: Invalid queue_pair_i= d=3D1 CRYPTODEV: rte_cryptodev_queue_pair_setup() line 1370: Invalid queue_pair_i= d=3D65535 CRYPTODEV: rte_cryptodev_stop() line 1247: Device with dev_id=3D0 already s= topped + TestCase [ 1] : test_queue_pair_descriptor_setup succeeded CRYPTODEV: rte_cryptodev_queue_pairs_config() line 1088: invalid param: dev= 0x7fb24d547940, nb_queues 0 CRYPTODEV: rte_cryptodev_configure() line 1175: dev0 rte_crypto_dev_queue_p= airs_config =3D -22 CRYPTODEV: rte_cryptodev_queue_pairs_config() line 1103: Invalid num queue_= pairs (65535) for dev 0 CRYPTODEV: rte_cryptodev_configure() line 1175: dev0 rte_crypto_dev_queue_p= airs_config =3D -22 CRYPTODEV: rte_cryptodev_queue_pairs_config() line 1103: Invalid num queue_= pairs (2) for dev 0 CRYPTODEV: rte_cryptodev_configure() line 1175: dev0 rte_crypto_dev_queue_p= airs_config =3D -22 CRYPTODEV: rte_cryptodev_stop() line 1247: Device with dev_id=3D0 already s= topped + TestCase [ 2] : test_device_configure_invalid_queue_pair_ids succeeded CRYPTODEV: rte_cryptodev_stats_get() line 1695: Invalid dev_id=3D88 CRYPTODEV: rte_cryptodev_stats_get() line 1700: Invalid stats ptr CRYPTODEV: rte_cryptodev_stats_reset() line 1723: Invalid dev_id=3D44 + TestCase [ 3] : test_stats succeeded CRYPTODEV: rte_cryptodev_add_enq_callback() line 1428: Invalid dev_id=3D64 CRYPTODEV: rte_cryptodev_add_enq_callback() line 1435: Invalid queue_pair_i= d=3D2 CRYPTODEV: rte_cryptodev_add_enq_callback() line 1422: Callback is NULL on = dev_id=3D0 crypto enqueue callback called CRYPTODEV: rte_cryptodev_remove_enq_callback() line 1495: Invalid dev_id=3D= 64 CRYPTODEV: rte_cryptodev_remove_enq_callback() line 1503: Invalid queue_pai= r_id=3D2 CRYPTODEV: rte_cryptodev_remove_enq_callback() line 1490: Callback is NULL + TestCase [ 4] : test_enq_callback_setup succeeded CRYPTODEV: rte_cryptodev_add_deq_callback() line 1566: Invalid dev_id=3D64 CRYPTODEV: rte_cryptodev_add_deq_callback() line 1573: Invalid queue_pair_i= d=3D2 CRYPTODEV: rte_cryptodev_add_deq_callback() line 1560: Callback is NULL on = dev_id=3D0 crypto dequeue callback called crypto dequeue callback called crypto dequeue callback called CRYPTODEV: rte_cryptodev_remove_deq_callback() line 1634: Invalid dev_id=3D= 64 CRYPTODEV: rte_cryptodev_remove_deq_callback() line 1642: Invalid queue_pai= r_id=3D2 CRYPTODEV: rte_cryptodev_remove_deq_callback() line 1629: Callback is NULL + TestCase [ 5] : test_deq_callback_setup succeeded + ------------------------------------------------------- + + Test Suite Summary : Crypto General Unit Test Suite + ------------------------------------------------------- + + Tests Total : 6 + Tests Skipped : 0 + Tests Executed : 6 + Tests Unsupported: 0 + Tests Passed : 6 + Tests Failed : 0 + ------------------------------------------------------- + + ------------------------------------------------------- Thanks, Ganapati > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, May 23, 2024 12:06 AM > To: Kundapura, Ganapati ; dev@dpdk.org > Cc: Gujjar, Abhinandan S ; > fanzhang.oss@gmail.com; 'Power, Ciara' > Subject: RE: [PATCH v1] crypto: fix build issues on crypto callbacks macr= o > undefined >=20 > > Hi Akhil, > > My patch addresses build issue on setting RTE_CRYPTO_CALLBACKS to 0 > > and Checks for callback registered or not from the next node instead > > of head node as callback head node is always valid pointer. > > > Agreed but your patch cannot be verified without the fix as the callbacks= are > not getting called if using PMD other than NULL.