From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C88BA00C3; Wed, 7 Dec 2022 07:53:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05BF0410FB; Wed, 7 Dec 2022 07:53:25 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 25F24410D7 for ; Wed, 7 Dec 2022 07:53:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670396003; x=1701932003; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=eujfvjgevu/y2e8BRRmx46luKBeFO7nM0qQ5zWC8+Yg=; b=NbX9x+l/KEIZBD5WYfvKPHn6E2QOVINsNt8nPh+MWTIIo3bE+9Be9b/C fVmfEXTUGV3HXA7F/Ueiekr4cgcALuNqWXQrz2eeiwZrJ5TpG8PjVCsxB GlYqUEYhB4SQuQTyok+oMj8VPyNSwvVUkkE7aCzvAdVpg8WGv5ZoDjQR+ DT1uEroV4zEfP5P6GZetrhCM/AcbQbOsQbwITdGjhO7zD7eaYGxeK05ec PZzc4RCd8/f1uu4cmbzajDI5RhRh11pEVVZl4M4YtdJWw5ESd9QwRVdBF kIBRos+T7mo+efY9gigCwqArLyNeJZjriWca3e/x7lJKnXvWTDTIiR5ga g==; X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="296515550" X-IronPort-AV: E=Sophos;i="5.96,223,1665471600"; d="scan'208";a="296515550" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2022 22:53:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="646496677" X-IronPort-AV: E=Sophos;i="5.96,223,1665471600"; d="scan'208";a="646496677" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 06 Dec 2022 22:53:19 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 6 Dec 2022 22:53:19 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 6 Dec 2022 22:53:19 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 6 Dec 2022 22:53:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mcvyr119TsxmZIubvfd86E3UQQaFgGY9DvdxZ/9EiXtCuwQEUnq8Ee/KWjrtn+JNvEqKad6t/9Dsb+a90j7xFCBU32kCZQXvTdBcSvXuK9TQUQSqzCxjxvsQX5agminLxU/ahhnVwjjuev6tXACv1cyMkKpIT3NhJvR70v3QRUhXAged6VKMM6/dQyp519G1qgqEdhta7cPzRYZM33aNrlumKIZfudOz2Myl9BHDdgNIICeIYelMucNdy4/nLKxm3H8X2LLjrEZh4MOP1NJVhXPiPBYe2LsPfsKsvhnVPqKn99xJmCaA5DCvrGsyT0wS2fPw/wZTzttQYWZdeSkIqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nuzb6xRVjfPZXm5bLmy73cBiLFDx2WGwgu7Cuda7uTE=; b=e/uCIcVI4FX39u5/FfztG9zNHGtGZewHpI0p4nqyLZ6bZOSNvcYkua1UC4FaMwHE68lg5yGcA1xBwOW3WOLohpN0iwWwpLgoLbWJnpVb8dS5HpwPrvaFGFtpNeAh5jRCnO35FIXOZKqDfWAa8690u9sy+yVm6zdydQ++CzVuQqbmI29aJqIO6JPmTMk1qoMXkjrP4yiALWIfGCyEZuFicQAcAAvP0/JCTAOpJRJ26OaTD7yDRZCxeaJRHja+9DVoMCOziifoiru1Ezd3KPtCWKtxBM/98mah2fefJNWWx3EvXIxK3/WcfKNJkzm5breMdxhhKGP1IM4s0nFuk6qepQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5911.namprd11.prod.outlook.com (2603:10b6:303:16b::16) by DM4PR11MB7397.namprd11.prod.outlook.com (2603:10b6:8:103::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 06:53:17 +0000 Received: from MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::8d97:12d3:1a3b:1561]) by MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::8d97:12d3:1a3b:1561%8]) with mapi id 15.20.5880.014; Wed, 7 Dec 2022 06:53:17 +0000 From: "Kundapura, Ganapati" To: "Gujjar, Abhinandan S" , "dev@dpdk.org" , "jerinj@marvell.com" , "Naga Harish K, S V" CC: "Jayatheerthan, Jay" Subject: RE: [PATCH v2 1/5] eventdev/event_crypto: process event port's impl rel cap Thread-Topic: [PATCH v2 1/5] eventdev/event_crypto: process event port's impl rel cap Thread-Index: AQHZBVDLnscAl6aj9kOOQ6CPbBo1jq5hCJIAgAD91hA= Date: Wed, 7 Dec 2022 06:53:17 +0000 Message-ID: References: <20221130171014.1723899-1-ganapati.kundapura@intel.com> <20221201064652.1885734-1-ganapati.kundapura@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5911:EE_|DM4PR11MB7397:EE_ x-ms-office365-filtering-correlation-id: bf8d3e53-8a52-47af-b77c-08dad81fb855 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ohfHBp/aV8R+vPJ5/dCd+Q6gVOVim5+5MjHLkba2xhKiK1nRy5gQJ7wyoUgScG9ljWHRF7MLASpeofs1/a0mKV+Qc1jHNbcsjIqx4astDQ3Xm/wJih8NBy+Bxx/sNlNaKiX9/30+T5oex1sxK8k3yCoDMGHnvm4OOGKWlHGtPx4oE6dMLAX/IHOgjhJrcQALwFvIfBwbOvE/2Km2xZ1NkHW0wzzNHAsYrdDWpaKC960RnG8iyEYsJllECO/MFtTCVCbh5y9Lm6WIOTeVvXHZpMyPiBQBCt6/vTfZXHlNUJr3taDw6x58pUOyQ3lpnNafLU+Ohj855AR9MmY51/k0OxW8Fp0kSMSjAWqQrtxASgh3mzNfolmXk/Nu9e87rIpHSyN4lfEQ+Z4JfAHf4rmeuACV0g36G1rIPFMYFYBXSblnULocKAN7GUgVGyJTT0aXZiaKaMge4Y1fwjUh2vMeSIHr5qV2XcWiII5U9WczdZoNLH8nUZisFvWH6oo/uRk5wUSG/Vi9N6lFyOUxXjABcgKIkiU4TEWUPwG0EeYGU8BtcAz1OX6fD1QACKnnoBo6lO+HxfOdXL5jnw5I+AfXaTpqwh/KvssLQTlOyXU9GYSjyzRJ8i9ZhtYpzrHxYiaHTY98FYLg49/ULUHSNJ1Y7P9xtoAd1xPF6MREL7Mr5xbADjHf8nT0XnPILluyiOGDik5px6oRVOWSFYgWTpDIwA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5911.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(376002)(136003)(39860400002)(366004)(346002)(451199015)(41300700001)(38100700002)(38070700005)(186003)(2906002)(82960400001)(5660300002)(83380400001)(122000001)(107886003)(8936002)(52536014)(478600001)(7696005)(53546011)(66946007)(55236004)(66476007)(6506007)(71200400001)(76116006)(86362001)(66446008)(26005)(66556008)(64756008)(8676002)(9686003)(316002)(33656002)(110136005)(4326008)(55016003)(6636002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yC/S0XqBLi1c7L4vbaBTgZcjGIK1pRD7KwP/QdgcP74AnO6RcDh3Q2KHGJTx?= =?us-ascii?Q?3+VLnD6Uz1bJPb0nj4oyiZ0SkKLEwyrVPLNxPBKfp1FFvUMB0dHp2zktMs2v?= =?us-ascii?Q?WvwLWbs+sIpoDVqTURTZKEKorEGKrdbcjQc9pXioRs/LkkwjW2ws+b7UYU88?= =?us-ascii?Q?gDqnUJmTT9JIsXBacQqfq63icumrZoVapdaIRMI2WhqSsuLETuffl3uTUPdD?= =?us-ascii?Q?+JyL1gmFEiMPfQcLMRLh9ZUKdA/sOWSPTpqDBRGKuBwWBuD+mHyx1Cyu+LyR?= =?us-ascii?Q?zoGIgFi0Q6KcNlWSQ5mJsR1vnfHG/M9Y9klBZ2A8ggZXBH8ANg0JRbrTNoWh?= =?us-ascii?Q?Hq6DXudn6Oljp3M2eEJbJPT5ukRzm+uGO9m9rQ7bMUbYHOMwbasjE67x8kQi?= =?us-ascii?Q?NnuJj0X+0xsWS6u2ln0aUv+FuVqRVlsdZhzLRaNox2EBf9BliTKwOLavFpP6?= =?us-ascii?Q?gQsaqTcYualMTNS1V0lqo0jDHGmHMzHevfmbIJh0DSUxVZNXHw0mEjLppSxl?= =?us-ascii?Q?Gh7xHGjZ3LZSMGBQq2fh54ZdobPMGDNU7qdeTiR9enK/Goi49Le3r6A2GkXd?= =?us-ascii?Q?wmD3mEc28U5exrdSVkOHVWzNq17YchPvymCzPDAhdhlT4Ag9HeBkS3FSJzHy?= =?us-ascii?Q?mLaO0vfVHDaAnKVMA21bheYUvJoJNcK19i52uklhEWFNalhuzPXhl826S/PK?= =?us-ascii?Q?llF6ddsp6+NbmCaEyyhHkKkbk76wXa51JnAJvPlAGjI9g1I3pHUgtKkh3Orc?= =?us-ascii?Q?JQKkGMJvqtg/t8GtC2zWzCj4z9Hd5lFZmKU8uBb0mzDfRqpxZR9Clalr4+bv?= =?us-ascii?Q?n6I8wLwk4pRDsNj/CoQzZyVaDq11nC/DGcGOntzx00FMSY7n8liy9CReDbWj?= =?us-ascii?Q?DOznr0SHUMdwPm6lv1aIrD+0VBkzrxRWty28Q/QzADae+NUVAhVj8NB7/VI1?= =?us-ascii?Q?wyI0vuHsmerOLGXi1pNNVVk1murURtHgqrRmuRGcnutco9pplW+paYWchPI7?= =?us-ascii?Q?AJ4aRhG+fd4NyO3a3d87XRQyJIjDZ7Sktev+5LiJ1pqEcBqC7pUnyv6Fm1tn?= =?us-ascii?Q?M0LX/g2nXYuMMRloz5xtLobtmwyQPivskpzdlNUw9LRM9mQjQfBXMiG8jfBU?= =?us-ascii?Q?8YiGDPf9dmcIWCRaaY5bo8JBssExr7thxxEjo5S3+WdP3MmZOiAPYbHTbMoB?= =?us-ascii?Q?wzt3cRrPdC4X4yBK3gysiuEVbIHmRLoTENAJyNaSSqYX75m7REPqwgjn5oSJ?= =?us-ascii?Q?D8nyc7hmC707zxKcPEzzo3upy/0bseUGd9wvbcHKqxORJxrf7Nzs0aQJ5FYB?= =?us-ascii?Q?ShU5RhlzQXO1HG+2YAexRZY3lwVI1ok2dV25l7XrYCMYHYg6KtyS1pLgGu4p?= =?us-ascii?Q?E6mit52soO363p0mFZrTgxAGamSFJCHtzorAEcN4u/uJ5LnSnwXKdxlJ2VoF?= =?us-ascii?Q?OIMxVoifcxVaR62q5B0eiZbRKj3imKzHRrNHbR7tAIhUvkIjfF2u3/Pmt654?= =?us-ascii?Q?xFATys+9kMWlu9Pp+Wmqo1Uqiz28HOxVcVFncwrZK/rlEZJYHvyIV9ADr5Tl?= =?us-ascii?Q?m8nhkiP0PV7mgD0Zgf4+t+OlOwxWff9ZO2uQIHp+DPgI2Y0Q1cyyMedUhB/H?= =?us-ascii?Q?oA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5911.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf8d3e53-8a52-47af-b77c-08dad81fb855 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2022 06:53:17.4245 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cA17cK/NvXVNSiaflNwE09w6H2iQ71yg4NztqYKi8A91IXnScvSy/gB80T9QbXUNBsjrQPv0uX+gmEhA3Ft+d3JzgntRrHLMWjhUULaJUu8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7397 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Abhi, > -----Original Message----- > From: Gujjar, Abhinandan S > Sent: Tuesday, December 6, 2022 9:14 PM > To: Kundapura, Ganapati ; dev@dpdk.org; > jerinj@marvell.com; Naga Harish K, S V > Cc: Jayatheerthan, Jay > Subject: RE: [PATCH v2 1/5] eventdev/event_crypto: process event port's > impl rel cap >=20 >=20 >=20 > > -----Original Message----- > > From: Kundapura, Ganapati > > Sent: Thursday, December 1, 2022 12:17 PM > > To: dev@dpdk.org; jerinj@marvell.com; Naga Harish K, S V > > ; Gujjar, Abhinandan S > > > > Cc: Jayatheerthan, Jay > > Subject: [PATCH v2 1/5] eventdev/event_crypto: process event port's > > impl rel cap > > > > In the current implementation adapter queries event device's > > capability for implicit release support. > > > > This information is used to decide whether events are enqueued back as > > NEW or FWD events. > > > > This patch updates the adapter to query the port caps for implicit > > release to decide on events enqueuing back as NEW/FWD events. > > > > Signed-off-by: Ganapati Kundapura > > --- > > v2: > > * Updated subject line in commit message > > > > diff --git a/lib/eventdev/rte_event_crypto_adapter.c > > b/lib/eventdev/rte_event_crypto_adapter.c > > index 3c585d7..1c0a22b 100644 > > --- a/lib/eventdev/rte_event_crypto_adapter.c > > +++ b/lib/eventdev/rte_event_crypto_adapter.c > > @@ -53,7 +53,7 @@ struct event_crypto_adapter { > > uint8_t eventdev_id; > > /* Event port identifier */ > > uint8_t event_port_id; > > - /* Store event device's implicit release capability */ > > + /* Store event port's implicit release capability */ > > uint8_t implicit_release_disabled; > > /* Flag to indicate backpressure at cryptodev > > * Stop further dequeuing events from eventdev @@ -320,7 +320,6 > @@ > > rte_event_crypto_adapter_create_ext(uint8_t id, uint8_t dev_id, { > > struct event_crypto_adapter *adapter; > > char mem_name[CRYPTO_ADAPTER_NAME_LEN]; > > - struct rte_event_dev_info dev_info; > > int socket_id; > > uint8_t i; > > int ret; > > @@ -361,17 +360,6 @@ rte_event_crypto_adapter_create_ext(uint8_t id, > > uint8_t dev_id, > > return -ENOMEM; > > } > > > > - ret =3D rte_event_dev_info_get(dev_id, &dev_info); > > - if (ret < 0) { > > - RTE_EDEV_LOG_ERR("Failed to get info for eventdev %d: > > %s!", > > - dev_id, dev_info.driver_name); > > - eca_circular_buffer_free(&adapter->ebuf); > > - rte_free(adapter); > > - return ret; > > - } > > - > > - adapter->implicit_release_disabled =3D (dev_info.event_dev_cap & > > - RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE); > > adapter->eventdev_id =3D dev_id; > > adapter->socket_id =3D socket_id; > > adapter->conf_cb =3D conf_cb; > > @@ -837,6 +825,7 @@ eca_init_service(struct event_crypto_adapter > > *adapter, uint8_t id) > > struct rte_event_crypto_adapter_conf adapter_conf; > > struct rte_service_spec service; > > int ret; > > + uint32_t impl_rel; > > > > if (adapter->service_inited) > > return 0; > > @@ -866,6 +855,17 @@ eca_init_service(struct event_crypto_adapter > > *adapter, uint8_t id) > > > > adapter->max_nb =3D adapter_conf.max_nb; > > adapter->event_port_id =3D adapter_conf.event_port_id; > > + > > + if (rte_event_port_attr_get(adapter->eventdev_id, > > + adapter->event_port_id, > > + > > RTE_EVENT_PORT_ATTR_IMPLICIT_RELEASE_DISABLE, > > + &impl_rel)) { > > + RTE_EDEV_LOG_ERR("Failed to get port info for eventdev %" > > PRId32, > > + adapter->eventdev_id); > You need to free memory allocated for adapter + adapter->ebuf before > returning error Updated in V3 > > + return -EINVAL; > > + } > > + > > + adapter->implicit_release_disabled =3D (uint8_t)impl_rel; > > adapter->service_inited =3D 1; > > > > return ret; > > -- > > 2.6.4