From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9106145502; Thu, 27 Jun 2024 12:19:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81C0640B8F; Thu, 27 Jun 2024 12:19:36 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id 91BAB402C6 for ; Thu, 27 Jun 2024 12:15:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719483316; x=1751019316; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2UqL2c+ZwCwIn0Di5cI/zXoRioV3ZnHzT0nQ7mag/5c=; b=SMeN88kLb3XKkKxAA3CvA9ifaMG4vaTZbsqj/4LXoYt1a6n0nddtwr7K 7ovdDt+6BsxzP9sPOa4r3h5m/fM9HjJ4JZ/8zBf6jmzQhKRmW3l0KyhB1 CffNpVbHWCnBIuTUZ+KlG+wmq7/4YatIeQm6JOudshlRi658OjIheMT+a Pxhkp+FcmXZ1LmD1/AvbFIRDqJtazJRbEjjKxYgaCO9/9rt/JG8ImmO0E 5TJ16RILDYJqHRGc7nemXbQZ1CC7g+yO6DvZn0yGGN+jIjX+o2xRoVNgD 9dRTugSOJ3tasY85dca9BrIFfY6ZuIwuOa286KM6zKfW++ZHbJiRaX2w6 A==; X-CSE-ConnectionGUID: zshRwwWgS3i7WwKoteQmLw== X-CSE-MsgGUID: piQ1OcTAQD2nsKR/F0zj6w== X-IronPort-AV: E=McAfee;i="6700,10204,11115"; a="16729079" X-IronPort-AV: E=Sophos;i="6.08,269,1712646000"; d="scan'208";a="16729079" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2024 03:15:15 -0700 X-CSE-ConnectionGUID: Z0XZJsiOSsWoJZCLwd66uQ== X-CSE-MsgGUID: 0i41PG3uRi+wFWEKAv5Azg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,269,1712646000"; d="scan'208";a="44153241" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Jun 2024 03:15:14 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 27 Jun 2024 03:15:13 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 27 Jun 2024 03:15:13 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 27 Jun 2024 03:15:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hYtyH87B/qJfhXZGpSMjyCPVyIx61yA32sIOKP26iRNrkjBhPG4198molncPqd6m4GKD1GO87eZXa4UA2zvJb8plQ5Os0IRzdlFqRHmPRi4ibcqjA+YF1uDrSzibJGId8ho0SyyqIkKbes1VMdmHpKKVjCtrNWzxKrRjoxIayP4B6Rv6dw6eZ4Og+GI8bp0Y0jmbdBtLev2mcxGDyLb3ZSBOjPStM554/C0qmUQ5o3HPnljNTrLPQ7FVX7N3sGxSwiz4X0pZPPa42oXjDAcM53JeBbntEOH21EQep7RVzHsPZ0/UJHsz2wSJO9EvBmV6MfIcxyhYhSAEkr1v3dasgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RSc0tdTLEMcGL1ddEdMCecqXsdQffQuR4RwLa+38Rps=; b=O4gwdadIM3WpFk+0Y8Es15CsXtR9pc42N8kU/ib0113TLs4CFSONGgJaXJjBZISrYs5sHuaZf3wWRn9XDNs07BWhhYUh2The1mNtnMcpALuOQPfNUeqdjbHxEavwcMzYrVXFi+0X9GxKV1jhzMaNrerKyZhAtDs15MXP/ikwataOBy5eP8adcAycbKqfE7Mh7C3Fmcx1QFIhN4QGpmQpOPkFbmzRs+pcj9uVqsbsrsiek17b397w3UtjbTkj2q2ETvGAWHdqqZfPhnTfd28MIcSFzjvHap7WnGvIRA3qx9rhQJx6CbzOo0+4E+jGod8NiEUsaqKicdI0aulswYZs/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5911.namprd11.prod.outlook.com (2603:10b6:303:16b::16) by DM4PR11MB7205.namprd11.prod.outlook.com (2603:10b6:8:113::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.26; Thu, 27 Jun 2024 10:15:09 +0000 Received: from MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::1d00:286c:1800:c2f2]) by MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::1d00:286c:1800:c2f2%3]) with mapi id 15.20.7698.033; Thu, 27 Jun 2024 10:15:09 +0000 From: "Kundapura, Ganapati" To: Akhil Goyal , "ferruh.yigit@amd.com" , "Richardson, Bruce" , "mb@smartsharesystems.com" , "thomas@monjalon.net" CC: "fanzhang.oss@gmail.com" , "Senthil, Bala" , "Gujjar, Abhinandan S" , "Mcnamara, John" , "dev@dpdk.org" Subject: RE: [EXTERNAL] [PATCH v3 1/2] cryptodev: fix crypto callbacks on unsetting callbacks macro Thread-Topic: [EXTERNAL] [PATCH v3 1/2] cryptodev: fix crypto callbacks on unsetting callbacks macro Thread-Index: AQHayBR6AJYM4AScUUmQw+0Ks8YQirHbI/IAgAA/ceA= Date: Thu, 27 Jun 2024 10:15:09 +0000 Message-ID: References: <20240529144025.4089318-1-ganapati.kundapura@intel.com> <20240626220028.2260003-1-ganapati.kundapura@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5911:EE_|DM4PR11MB7205:EE_ x-ms-office365-filtering-correlation-id: 1c35b302-2ab9-4d6c-3b9b-08dc9692066a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?CSX+3+9wKFm1zGDShnJhUJqtAcWqiU+265T2IOQTo8/BTlFReJr2bBgn0w/D?= =?us-ascii?Q?zNmQdHLA3UGpLwr4a0YqDMUg45OsGpIaChGDzaMQLkJCUySzFQAcAeiQDLq1?= =?us-ascii?Q?BFiQj9NCZTP8Tq8Z24E4B6fuuuDCDzVw3sDHLwdy+itOCjWQFjEf5KTxT9cy?= =?us-ascii?Q?U4RJDUBPDcRLLpJRyALds50ciNQP/kQqek/BkTaf+QAsnQoovgCa+s2J7V3q?= =?us-ascii?Q?mo69wyRvasOSBGg7i2twRKwMWY8YgBJssw636m5Vu0DoVpV07PeLzWE45/1m?= =?us-ascii?Q?2PoWLj7qMm0YvAoOTuwERR3EK/gDqqsz5onp0+ipNe7MG5ATxLDuI/5wl9Mf?= =?us-ascii?Q?AgtxuOhoiSp+0UFlZvjHFeyM/A+WlpDKRprnR8MMXj9XMoO+6TiKkWg1gH9j?= =?us-ascii?Q?gA0OyauYJXFynes3PdzbQMgWdjm/Hr4XT1gy+weM2QKwjn8rUm3yAIhb7Jiy?= =?us-ascii?Q?MvEe6D1kOa9SvA21BMHQcEDN3jVbXvZZ+OMgw0NWj2+E471LjFYl4Aq0/r+h?= =?us-ascii?Q?3v1/qZ/3+fOPm4uEN2uJqxIGV8qhcG8ePgl8ykQqyQ3xcV/9DdRzkpwkSN8N?= =?us-ascii?Q?GmJBTAI1q8U+P0xTq5+RapujuDL0qn6m8vz5rld2dDmnSSCGZgz7Xc+JCJRt?= =?us-ascii?Q?3qA3qKq87tlPr0Ufwbw2CoL1w7Iw5rOcDLjglPbfFc9ZS4Ij2hKWyrOa4Kb1?= =?us-ascii?Q?+/L5944WbObSjh3Ke9W0ScUz5wFwfHRW3prc3nAe6jc8AFxW4wzUuQaKK1Uu?= =?us-ascii?Q?fJBpnS0ciL35RW0zP3RaPueSIvqUMgOZKl8ZFGzmrR0e4DRLZR6b/AjV8AQH?= =?us-ascii?Q?HRGUcMJcLdzHMpYKYbXZxs+aLTA2T3Y3J47QQ9NGDQOH5/TOce7fxpunAw3G?= =?us-ascii?Q?fUHCCkZuKUz5smDH1OPEk4pjXF7mHOuFgPHCaoUMTV1lR+yVcWGC9aqO9sAY?= =?us-ascii?Q?9Rlg4EmVYfpEX73zHOidF5LS0c4RSTPssTy/UY97gbmPr4NaGlvDtnJhhHQb?= =?us-ascii?Q?NliZw+PszCuwRAvSGtgjdR9o4h0PjqlCBjQT8lQTf4ynjfE+eTuz/ndgdEKW?= =?us-ascii?Q?KT16evolE4GroNKWthlw5Y+YK/3LZeS1ikyNstsufN8u1fIRqoivV2tRXlpO?= =?us-ascii?Q?NoLfjhNfYrvrrvHXyRRu6A+0WkPsqjY2G84bJPOXINCmYEq2dcnubNlE+MRr?= =?us-ascii?Q?lG9DyYT+WotdHW5mSxKzfcOjQlbhlB64WdU0kAYEbQCriEqwyQVhH0rciUug?= =?us-ascii?Q?7NZKcN/DojSehs6se8hDXOEf5xBedpPqV9VrAIvflmo885IBmTxK6IY7nNRY?= =?us-ascii?Q?M41QpFJ9GH70Ko1VGpMlJlQe/Al9swhxG0D12BDPfB4br483sHqPvZLeRRfv?= =?us-ascii?Q?mqaVM3OEDKDtliqoAP18KFS2g8O8hGcToSspwkLQEV98FDFreA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5911.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oSeP0ztITWkUDLYAoV3qRqc0rXbzLI8KNEBS1+pJSK7Htv594JkTKPL6qyTl?= =?us-ascii?Q?TiFRRptJK8VQ68g4VAXl+/RthUoUdZB3QrpAvJ2kA60FlxoVN4bgpJKW61Tl?= =?us-ascii?Q?zt1q91rN1ENjJYKdKPGJOJmvrVlQ/xbbBX//Lt2U6g+KVh18tFBmQwXcgTV7?= =?us-ascii?Q?pTDHlvdsAllNOqtAI+mPjcDJbLUF/qNJKJirU9C7hrS8MxzCqc+etqMgIGJ/?= =?us-ascii?Q?91iiyEW54mlasWsAx02HR9Qawqny6g0XguuqSRLFfZuGXI22a2kiezZVAJIo?= =?us-ascii?Q?1RYs7g3PBHYBXY9ZUF+LcUiP+vATjt1x3vwX9nirO818KTtBMgF4e/JeSZBB?= =?us-ascii?Q?PfwV+t0ciNvHvQwYJbnVy0l2R4CV0FIZAnWX2YtqzIe6oicHFr0V+zAl39jO?= =?us-ascii?Q?850+48Qn6uK/KUvLG00pcFaCBccEiuGdvt6/lwBpxkRSyLw4pQLFKFICRZwq?= =?us-ascii?Q?w2Uhmr5YCZYmeIqmpoH9zN1+94quyp6B2VRr6qUPAPr7n0O4dOW1+QOIQHP5?= =?us-ascii?Q?mebG4evxOtAcUKDxtUBFwveVrXRJ036oibOm4emJDIzihsMtHZywlE8bTi5l?= =?us-ascii?Q?0TY8aXfO6KrLbc2rDU/Cyvp0Nab5lpfjhFebstf9oWmIKmHs1ZkkBuTUxL6u?= =?us-ascii?Q?nawzX8jiKeNY2tZoYQWX7qfAfzcudM97cRu84NIptFBF8PHieXG2dNbOiubg?= =?us-ascii?Q?6CaxA85EHc3flGF+WaG4Bbo0fFek4PDbzum1nWKFGknFfCxs7qICChDO1GN2?= =?us-ascii?Q?SBqxw/JygvYHQ8Tcu4zU+5XyhZoHhm3c7ToERViLa2+Zk9lugzEqXNvMKzZm?= =?us-ascii?Q?1hmqQL45f7eDqeP87+cquGSISTrgEkqeIcAKmNud8ff68EiCl/s8mIdbi9MU?= =?us-ascii?Q?sUSXokPtefG1Oqxb+/JYNESyA58cuWBfjcOzkR+WVuD0gufWHPKp198zVPs3?= =?us-ascii?Q?b6cfLW6r+iW5TYgpELXx62py1mdQuFKQZYAvw6q45MPToIQIqc/MQmSj/hKu?= =?us-ascii?Q?Ki+S6eHmBoT3TbXqur+ddBfW4ha1o8V5Yeteggq/K8Wng1w0qmeZGkSJzagf?= =?us-ascii?Q?F8Kg0eUIkz83RH64kAq/Gs9CXqZce37rlHOTc2w+EtdjvEhwrnXoUZa21ZIw?= =?us-ascii?Q?k4ty4u5QYlu2rpNYI27L+eRSWPwUyDlmlqUPG0/wP2HTpPRU7Dq99wtT5OEs?= =?us-ascii?Q?Wwdcp8/Sk2X5PrdkkbsX9OyMz0lvHUdvYNpR9J99LLNU4L7lvXoLseHAhbJs?= =?us-ascii?Q?bmBz5vSetoLnIQofHT0N8g3tyrjjaZG51N9WDGzmBOi4p5oLghzc/h/me8WY?= =?us-ascii?Q?9g2kRqBTYpyF5iF4TJsR+fhi+HQ8pZRqW3bShCUqwP+6yXfdtdYYcqjhffIm?= =?us-ascii?Q?630m38bH7BvCs1986lNTlxLMEdVfXgqzA9Hu2kGCSZDm0YcbDPMGxdESHTDO?= =?us-ascii?Q?Tm5WZOWwriioqITQfDhVGureoarfWxpwPg12F5O6cipvBATNVRRbRe7kxr9L?= =?us-ascii?Q?7TiWFVuoP37J8enD1sFV6W7hp43X6W7zCs4dMyto/V22mF8iKSPYzp2EAltg?= =?us-ascii?Q?JvXqn3B3viT/932mCTy6+1ckaQ6Aqn90xMb+e68U7p4VxypalfGNNKsCuf7V?= =?us-ascii?Q?XQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5911.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c35b302-2ab9-4d6c-3b9b-08dc9692066a X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2024 10:15:09.6475 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: agNMzK5KCiMVje/x9gQdYw9PqivZKNsnZSasbppD+mMUXFHorfkeGnHZL14VbLm528GvENhAlvQt4PpJ4LMuQFx3Rsdp6cAAR8bFzleCKk8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7205 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, June 27, 2024 11:50 AM > To: Kundapura, Ganapati ; > ferruh.yigit@amd.com; Richardson, Bruce ; > mb@smartsharesystems.com; thomas@monjalon.net > Cc: fanzhang.oss@gmail.com; Senthil, Bala ; Gujja= r, > Abhinandan S ; Mcnamara, John > ; dev@dpdk.org > Subject: RE: [EXTERNAL] [PATCH v3 1/2] cryptodev: fix crypto callbacks on > unsetting callbacks macro >=20 > > Crypto callbacks APIs are available in header files but when the macro > > RTE_CRYPTO_CALLBACKS unset, test application need to put #ifdef in its > > code. > > > > The test application should be able to build and run, regardless DPDK > > library is built with RTE_CRYPTO_CALLBACKS defined or not. > > > > Added ENOTSUP from the beginning of the APIs implementation if > > RTE_CRYPTO_CALLBACKS macro is unset/undefined. > > > > Fixes: 1c3ffb95595e ("cryptodev: add enqueue and dequeue callbacks") > > Fixes: 5523a75af539 ("test/crypto: add case for enqueue/dequeue > > callbacks") > > > > Signed-off-by: Ganapati Kundapura > > > > --- > > v3: > > * Added NOTSUP from the beginning of the APIs > > > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > > index 94438c5..7dca2c9 100644 > > --- a/app/test/test_cryptodev.c > > +++ b/app/test/test_cryptodev.c > > @@ -118,6 +118,18 @@ struct crypto_unittest_params { > > for (j =3D index; j < index + num_blk_types; j++) > > \ > > free_blockcipher_test_suite(parent_ts.unit_test_suites[j]) > > > > +#define TEST_SKIP_LOG(cond, msg, ...) do { \ > > + if ((cond)) { \ > > + RTE_LOG(ERR, CRYPTODEV, "%s line %d: " > > \ > > + msg "\n", __func__, __LINE__, ##__VA_ARGS__); > > \ > > + RTE_TEST_TRACE_FAILURE(__FILE__, __LINE__, __func__); > > \ > > + return TEST_SKIPPED; \ > > + } \ > > +} while (0) > > + > > +#define TEST_SKIP(a, b, msg, ...) \ > > + TEST_SKIP_LOG(a =3D=3D b, msg, ##__VA_ARGS__) > > + >=20 > This can be moved to app/test/test.h > Also can we rename it to TEST_ASSERT_SKIP? Removed this macro >=20 > > /* > > * Forward declarations. > > */ > > @@ -14754,7 +14766,7 @@ test_enq_callback_setup(void) > > > > struct rte_cryptodev_cb *cb; > > uint16_t qp_id =3D 0; > > - int j =3D 0; > > + int j =3D 0, ret; > > > > /* Verify the crypto capabilities for which enqueue/dequeue is done. > > */ > > cap_idx.type =3D RTE_CRYPTO_SYM_XFORM_AUTH; @@ -14794,6 > +14806,7 @@ > > test_enq_callback_setup(void) > > /* Test with invalid crypto device */ > > cb =3D rte_cryptodev_add_enq_callback(RTE_CRYPTO_MAX_DEVS, > > qp_id, test_enq_callback, NULL); > > + TEST_SKIP(rte_errno, ENOTSUP, "Not supported, skipped"); > > TEST_ASSERT_NULL(cb, "Add callback on qp %u on " > > "cryptodev %u did not fail", > > qp_id, RTE_CRYPTO_MAX_DEVS); > > @@ -14802,6 +14815,7 @@ test_enq_callback_setup(void) > > cb =3D rte_cryptodev_add_enq_callback(ts_params->valid_devs[0], > > dev_info.max_nb_queue_pairs + 1, > > test_enq_callback, NULL); > > + TEST_SKIP(rte_errno, ENOTSUP, "Not supported, skipped"); >=20 > Why do we need to check for ENOTSUP at multiple places in the same > function? > This can be checked at the first usage only. Checked for ENOTSUP only for first usage >=20 > > TEST_ASSERT_NULL(cb, "Add callback on qp %u on " > > "cryptodev %u did not fail", > > dev_info.max_nb_queue_pairs + 1, > > @@ -14810,6 +14824,7 @@ test_enq_callback_setup(void) > > /* Test with NULL callback */ > > cb =3D rte_cryptodev_add_enq_callback(ts_params->valid_devs[0], > > qp_id, NULL, NULL); > > + TEST_SKIP(rte_errno, ENOTSUP, "Not supported, skipped"); > > TEST_ASSERT_NULL(cb, "Add callback on qp %u on " > > "cryptodev %u did not fail", > > qp_id, ts_params->valid_devs[0]); > > @@ -14817,6 +14832,7 @@ test_enq_callback_setup(void) > > /* Test with valid configuration */ > > cb =3D rte_cryptodev_add_enq_callback(ts_params->valid_devs[0], > > qp_id, test_enq_callback, NULL); > > + TEST_SKIP(rte_errno, ENOTSUP, "Not supported, skipped"); > > TEST_ASSERT_NOT_NULL(cb, "Failed test to add callback on " > > "qp %u on cryptodev %u", > > qp_id, ts_params->valid_devs[0]); > > @@ -14830,24 +14846,35 @@ test_enq_callback_setup(void) > > rte_delay_ms(10); > > > > /* Test with invalid crypto device */ > > - TEST_ASSERT_FAIL(rte_cryptodev_remove_enq_callback( > > - RTE_CRYPTO_MAX_DEVS, qp_id, cb), > > + ret =3D rte_cryptodev_remove_enq_callback(RTE_CRYPTO_MAX_DEVS, > > + qp_id, > > + cb); > > + TEST_SKIP(ret, -ENOTSUP, "Not supported, skipped"); > > + TEST_ASSERT_FAIL(ret, > > "Expected call to fail as crypto device is invalid"); > > > > /* Test with invalid queue pair */ > > - TEST_ASSERT_FAIL(rte_cryptodev_remove_enq_callback( > > - ts_params->valid_devs[0], > > - dev_info.max_nb_queue_pairs + 1, cb), > > + ret =3D rte_cryptodev_remove_enq_callback(ts_params->valid_devs[0], > > + dev_info.max_nb_queue_pairs + 1, > > + cb); > > + TEST_SKIP(ret, -ENOTSUP, "Not supported, skipped"); > > + TEST_ASSERT_FAIL(ret, > > "Expected call to fail as queue pair is invalid"); > > > > /* Test with NULL callback */ > > - TEST_ASSERT_FAIL(rte_cryptodev_remove_enq_callback( > > - ts_params->valid_devs[0], qp_id, NULL), > > + ret =3D rte_cryptodev_remove_enq_callback(ts_params->valid_devs[0], > > + qp_id, > > + NULL); > > + TEST_SKIP(ret, -ENOTSUP, "Not supported, skipped"); > > + TEST_ASSERT_FAIL(ret, > > "Expected call to fail as callback is NULL"); > > > > /* Test with valid configuration */ > > - TEST_ASSERT_SUCCESS(rte_cryptodev_remove_enq_callback( > > - ts_params->valid_devs[0], qp_id, cb), > > + ret =3D rte_cryptodev_remove_enq_callback(ts_params->valid_devs[0], > > + qp_id, > > + cb); > > + TEST_SKIP(ret, -ENOTSUP, "Not supported, skipped"); > > + TEST_ASSERT_SUCCESS(ret, > > "Failed test to remove callback on " > > "qp %u on cryptodev %u", > > qp_id, ts_params->valid_devs[0]); > > @@ -14869,7 +14896,7 @@ test_deq_callback_setup(void) > > > > struct rte_cryptodev_cb *cb; > > uint16_t qp_id =3D 0; > > - int j =3D 0; > > + int j =3D 0, ret; > > > > /* Verify the crypto capabilities for which enqueue/dequeue is done. > > */ > > cap_idx.type =3D RTE_CRYPTO_SYM_XFORM_AUTH; @@ -14909,6 > +14936,7 @@ > > test_deq_callback_setup(void) > > /* Test with invalid crypto device */ > > cb =3D rte_cryptodev_add_deq_callback(RTE_CRYPTO_MAX_DEVS, > > qp_id, test_deq_callback, NULL); > > + TEST_SKIP(rte_errno, ENOTSUP, "Not supported, skipped"); > > TEST_ASSERT_NULL(cb, "Add callback on qp %u on " > > "cryptodev %u did not fail", > > qp_id, RTE_CRYPTO_MAX_DEVS); > > @@ -14917,6 +14945,7 @@ test_deq_callback_setup(void) > > cb =3D rte_cryptodev_add_deq_callback(ts_params->valid_devs[0], > > dev_info.max_nb_queue_pairs + 1, > > test_deq_callback, NULL); > > + TEST_SKIP(rte_errno, ENOTSUP, "Not supported, skipped"); > > TEST_ASSERT_NULL(cb, "Add callback on qp %u on " > > "cryptodev %u did not fail", > > dev_info.max_nb_queue_pairs + 1, > > @@ -14925,6 +14954,7 @@ test_deq_callback_setup(void) > > /* Test with NULL callback */ > > cb =3D rte_cryptodev_add_deq_callback(ts_params->valid_devs[0], > > qp_id, NULL, NULL); > > + TEST_SKIP(rte_errno, ENOTSUP, "Not supported, skipped"); > > TEST_ASSERT_NULL(cb, "Add callback on qp %u on " > > "cryptodev %u did not fail", > > qp_id, ts_params->valid_devs[0]); > > @@ -14932,6 +14962,7 @@ test_deq_callback_setup(void) > > /* Test with valid configuration */ > > cb =3D rte_cryptodev_add_deq_callback(ts_params->valid_devs[0], > > qp_id, test_deq_callback, NULL); > > + TEST_SKIP(rte_errno, ENOTSUP, "Not supported, skipped"); > > TEST_ASSERT_NOT_NULL(cb, "Failed test to add callback on " > > "qp %u on cryptodev %u", > > qp_id, ts_params->valid_devs[0]); > > @@ -14945,24 +14976,36 @@ test_deq_callback_setup(void) > > rte_delay_ms(10); > > > > /* Test with invalid crypto device */ > > + ret =3D rte_cryptodev_remove_deq_callback(RTE_CRYPTO_MAX_DEVS, > > + qp_id, > > + cb); > > + TEST_SKIP(ret, -ENOTSUP, "Not supported, skipped"); > > TEST_ASSERT_FAIL(rte_cryptodev_remove_deq_callback( > > RTE_CRYPTO_MAX_DEVS, qp_id, cb), > > "Expected call to fail as crypto device is invalid"); > > > > /* Test with invalid queue pair */ > > - TEST_ASSERT_FAIL(rte_cryptodev_remove_deq_callback( > > - ts_params->valid_devs[0], > > - dev_info.max_nb_queue_pairs + 1, cb), > > + ret =3D rte_cryptodev_remove_deq_callback(ts_params->valid_devs[0], > > + dev_info.max_nb_queue_pairs + 1, > > + cb); > > + TEST_SKIP(ret, -ENOTSUP, "Not supported, skipped"); > > + TEST_ASSERT_FAIL(ret, > > "Expected call to fail as queue pair is invalid"); > > > > /* Test with NULL callback */ > > - TEST_ASSERT_FAIL(rte_cryptodev_remove_deq_callback( > > - ts_params->valid_devs[0], qp_id, NULL), > > + ret =3D rte_cryptodev_remove_deq_callback(ts_params->valid_devs[0], > > + qp_id, > > + NULL); > > + TEST_SKIP(ret, -ENOTSUP, "Not supported, skipped"); > > + TEST_ASSERT_FAIL(ret, > > "Expected call to fail as callback is NULL"); > > > > /* Test with valid configuration */ > > - TEST_ASSERT_SUCCESS(rte_cryptodev_remove_deq_callback( > > - ts_params->valid_devs[0], qp_id, cb), > > + ret =3D rte_cryptodev_remove_deq_callback(ts_params->valid_devs[0], > > + qp_id, > > + cb); > > + TEST_SKIP(ret, -ENOTSUP, "Not supported, skipped"); > > + TEST_ASSERT_SUCCESS(ret, > > "Failed test to remove callback on " > > "qp %u on cryptodev %u", > > qp_id, ts_params->valid_devs[0]); > > diff --git a/lib/cryptodev/rte_cryptodev.c > > b/lib/cryptodev/rte_cryptodev.c index 886eb7a..8a45ad7 100644 > > --- a/lib/cryptodev/rte_cryptodev.c > > +++ b/lib/cryptodev/rte_cryptodev.c > > @@ -1491,6 +1491,10 @@ rte_cryptodev_add_enq_callback(uint8_t > dev_id, > > rte_cryptodev_callback_fn cb_fn, > > void *cb_arg) > > { > > +#ifdef RTE_CRYPTO_CALLBACKS > > + rte_errno =3D ENOTSUP; > > + return NULL; > > +#endif >=20 > This should be ifndef at all places. > Did you test this? >=20 Updated that for testing but missed to restore it while posting. Yes, tested and retested with the latest patch(v4) + Test Suite : Crypto General Unit Test Suite + ------------------------------------------------------- + CRYPTODEV: rte_cryptodev_configure() line 1148: Invalid dev_id=3D7 CRYPTODEV: rte_cryptodev_configure() line 1148: Invalid dev_id=3D255 CRYPTODEV: rte_cryptodev_stop() line 1241: Device with dev_id=3D0 already s= topped + TestCase [ 0] : test_device_configure_invalid_dev_id succeeded CRYPTODEV: rte_cryptodev_queue_pair_setup() line 1364: Invalid queue_pair_i= d=3D1 CRYPTODEV: rte_cryptodev_queue_pair_setup() line 1364: Invalid queue_pair_i= d=3D65535 CRYPTODEV: rte_cryptodev_stop() line 1241: Device with dev_id=3D0 already s= topped + TestCase [ 1] : test_queue_pair_descriptor_setup succeeded CRYPTODEV: rte_cryptodev_queue_pairs_config() line 1086: invalid param: dev= 0x7ffbd873e940, nb_queues 0 CRYPTODEV: rte_cryptodev_configure() line 1171: dev0 rte_crypto_dev_queue_p= airs_config =3D -22 CRYPTODEV: rte_cryptodev_queue_pairs_config() line 1101: Invalid num queue_= pairs (65535) for dev 0 CRYPTODEV: rte_cryptodev_configure() line 1171: dev0 rte_crypto_dev_queue_p= airs_config =3D -22 CRYPTODEV: rte_cryptodev_queue_pairs_config() line 1101: Invalid num queue_= pairs (2) for dev 0 CRYPTODEV: rte_cryptodev_configure() line 1171: dev0 rte_crypto_dev_queue_p= airs_config =3D -22 CRYPTODEV: rte_cryptodev_stop() line 1241: Device with dev_id=3D0 already s= topped + TestCase [ 2] : test_device_configure_invalid_queue_pair_ids succeeded CRYPTODEV: rte_cryptodev_stats_get() line 1701: Invalid dev_id=3D88 CRYPTODEV: rte_cryptodev_stats_get() line 1706: Invalid stats ptr CRYPTODEV: rte_cryptodev_stats_reset() line 1729: Invalid dev_id=3D44 + TestCase [ 3] : test_stats succeeded USER1: test_enq_callback_setup line 12993: rte_cryptodev_add_enq_callback()= Not supported, skipped + TestCase [ 4] : test_enq_callback_setup skipped USER1: test_deq_callback_setup line 13098: rte_cryptodev_add_deq_callback()= Not supported, skipped + TestCase [ 5] : test_deq_callback_setup skipped + ------------------------------------------------------- + + Test Suite Summary : Crypto General Unit Test Suite + ------------------------------------------------------- + + Tests Total : 6 + Tests Skipped : 2 + Tests Executed : 6 + Tests Unsupported: 0 + Tests Passed : 4 + Tests Failed : 0 + ------------------------------------------------------- + >=20 > > struct rte_cryptodev *dev; > > struct rte_cryptodev_cb_rcu *list; > > struct rte_cryptodev_cb *cb, *tail; > > @@ -1556,6 +1560,9 @@ rte_cryptodev_remove_enq_callback(uint8_t > > dev_id, > > uint16_t qp_id, > > struct rte_cryptodev_cb *cb) > > { > > +#ifdef RTE_CRYPTO_CALLBACKS > > + return -ENOTSUP; > > +#endif > > struct rte_cryptodev *dev; > > RTE_ATOMIC(struct rte_cryptodev_cb *) *prev_cb; > > struct rte_cryptodev_cb *curr_cb; > > @@ -1630,6 +1637,10 @@ rte_cryptodev_add_deq_callback(uint8_t > dev_id, > > rte_cryptodev_callback_fn cb_fn, > > void *cb_arg) > > { > > +#ifdef RTE_CRYPTO_CALLBACKS > > + rte_errno =3D ENOTSUP; > > + return NULL; > > +#endif > > struct rte_cryptodev *dev; > > struct rte_cryptodev_cb_rcu *list; > > struct rte_cryptodev_cb *cb, *tail; > > @@ -1696,6 +1707,9 @@ rte_cryptodev_remove_deq_callback(uint8_t > > dev_id, > > uint16_t qp_id, > > struct rte_cryptodev_cb *cb) > > { > > +#ifdef RTE_CRYPTO_CALLBACKS > > + return -ENOTSUP; > > +#endif > > struct rte_cryptodev *dev; > > RTE_ATOMIC(struct rte_cryptodev_cb *) *prev_cb; > > struct rte_cryptodev_cb *curr_cb; > > -- > > 2.6.4