From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EADF4410E; Thu, 30 May 2024 13:40:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E455440608; Thu, 30 May 2024 13:40:06 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by mails.dpdk.org (Postfix) with ESMTP id B27DC402E4 for ; Thu, 30 May 2024 13:40:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717069205; x=1748605205; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=putZOaYfqBIxNhrRVdxRTgsUdpDfz5IyjDK9uymEiAE=; b=TSwSW/TdQcasqYFY+wU6igiaDxswiMrq0UK9w0M6iBdFkMBHfJnbEeY3 VCm+aU2w9wY1potecK0thvPrEplIz/GYIp6nhdqCGUYn/iotI0xEHC7aI tF+Vk6syN67cayd0r6GTuJ+cUIAqdIUmgXgSk2nhzO2H4elzlpXp0aKoP I5QIKU8OYwdEmLIJ9s+wKENuogRRwz5KnWTTAr51K2LmjUs8bV58+WrV6 Ost9H3O2meWeI5T6Q8AecimbT4UCYdSGf5/6GopKaRSgqZaKFfqUBEnc1 9gIH22DQekR4AwkniPQw6ZdO8dUua1pZghViXpC7EGYV9gEsegPi9gnjF A==; X-CSE-ConnectionGUID: iw9UVqoiR/quNkG65o2lzQ== X-CSE-MsgGUID: K4tNU0QAR3uHuyRb0vJ4Fg== X-IronPort-AV: E=McAfee;i="6600,9927,11087"; a="13418738" X-IronPort-AV: E=Sophos;i="6.08,201,1712646000"; d="scan'208";a="13418738" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2024 04:40:04 -0700 X-CSE-ConnectionGUID: W0QYwbZMSVOjA2FtRr9whg== X-CSE-MsgGUID: gQfQaZiBSUOheVUO3Ovlgg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,201,1712646000"; d="scan'208";a="35777085" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 May 2024 04:40:03 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 30 May 2024 04:40:03 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 30 May 2024 04:40:03 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 30 May 2024 04:40:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YaHUIeLUv0DeHR1iD1QKPWTlPf0/30zsKfT4NLPDlRcOhfcqyKD/jnGoG2fa3ciHGuhIYBU/JT/Rsvr39ebgKVwITBajUdgvMhcdbJVZpiAeyosXQUvE5KxzlzNP7o6M2f8yZVuw/itTd9tgnnNd2vxf9osZi5+kKEVblDJAedyW4VeGwF6SOebGSfyPKJfIzcr24sQ8E6tBr1+fDbN+DH6BuT5VpF4uyTeoXP64ZttwZW8Fw59degPl7ThBxbeaTAigifoR9FQ+vgL0A4JHH9PYwqRa6UfC+KMa63f4a0NaPNnXNZ0Iv5j79uggSiE6kr5KxHA8esA92iy1G3/TWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y1gw/UGwdE7GLi0F3KfU1HlT6DqmYskPn5K6PaIiWTo=; b=cIodo8AS7iWH9zCmwjZvULiT9DXD6td9A/knSqEYFB9/p3mnC5T7qJEZW1nnr0PImga5+0knhwGkT87ZtnKOz+4Te/8aVETL6R9Gzkv2D0Fy+THJNZPhCs8bykJVm8X3dA0lYwoycp8ze3oqgzIuM1eBzYgXXhQrgGx4s31j4YnAImm9fvYF7qEvJqmgJjM5HndyLmfaax3GvIAM5pyX7fBIJ+PZ3yvhYJy1y7JXnA0YSw3Bo7C5lyNZ2RqeSC1P4KSrb5jMFetEy60A/C9vLiVx0+lfrw3VPnqp+GvFg2WecGqg4dVGVs+YWy/INtkmZ4O0pMermh0gsOhsbhJ2tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5911.namprd11.prod.outlook.com (2603:10b6:303:16b::16) by SJ1PR11MB6084.namprd11.prod.outlook.com (2603:10b6:a03:489::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.21; Thu, 30 May 2024 11:40:00 +0000 Received: from MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::1d00:286c:1800:c2f2]) by MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::1d00:286c:1800:c2f2%3]) with mapi id 15.20.7633.018; Thu, 30 May 2024 11:40:00 +0000 From: "Kundapura, Ganapati" To: Akhil Goyal , "dev@dpdk.org" , "Gujjar, Abhinandan S" , "ferruh.yigit@amd.com" , "thomas@monjalon.net" , "Richardson, Bruce" , "fanzhang.oss@gmail.com" , "ciara.power@intel.com" , =?iso-8859-1?Q?Morten_Br=F8rup?= Subject: RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro Thread-Topic: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro Thread-Index: AQHasdY+VQlBT0PFPEGB76JakVCKkLGvbqWAgAAvM4CAAAlH0A== Date: Thu, 30 May 2024 11:40:00 +0000 Message-ID: References: <20240416081222.3002268-1-ganapati.kundapura@intel.com> <20240529144025.4089318-1-ganapati.kundapura@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5911:EE_|SJ1PR11MB6084:EE_ x-ms-office365-filtering-correlation-id: fb9b5d0c-7664-4d23-faa6-08dc809d3d55 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|1800799015|366007|376005|38070700009|921011; x-microsoft-antispam-message-info: =?iso-8859-1?Q?d20FWFCTXi1W4QONuxJjtuSjX36SepJ3itpwMDKcWskAWzGnjLlLwkLpdx?= =?iso-8859-1?Q?y3EUmNDqaHBu9ri1mvL2jwMI4JnipNYHSmwYBqUFrACjkOVGNuU/0LcHyS?= =?iso-8859-1?Q?nf5D4dJYFbQ6qWiIpdDAipdLU2dPR/6jFxJKtNtZEY9EYqZ+qNR03yYXbh?= =?iso-8859-1?Q?bFtCxUrKjHS6PSbsznAA5/HUdFHqLz/iGKe8mw+difsoUIwaHepzdUTcvm?= =?iso-8859-1?Q?TLJszXL5o8IGiqfMUMRnOUQ+4bW9/MavTxDjsAFwrl3A6WegGCBZPTSW95?= =?iso-8859-1?Q?GEZnjUALeIV8bpUkM/+AE1n5FnFBHGc7RER0Meyz/JzZocb7brqr4d+C62?= =?iso-8859-1?Q?nWM+EkojRbNZt2F783xrHlar+VoN3oSIy/2gpNGQRjHeRFi/hC8dMdP7hy?= =?iso-8859-1?Q?nRGDsQ8+qlTKgW0pA1ou42iUXu1dELwQ47vbNvCY3+i+Kf4KAPqQLnzbKx?= =?iso-8859-1?Q?kZhuFNo7E58LhKgZpxYbXdTjYaP4i1GVsOBZMxjBCKfshs6wOFhw557eG1?= =?iso-8859-1?Q?KhKNyC4GwbSCeZUv00FTSxRORJtwOepC+Q7F+4feMAS3bfUz0ukxV3VubP?= =?iso-8859-1?Q?oqU4JHyRScgASxskf9HzOudvVQf6bcZw0F/B6Hpf2LK/rnMMruaIJzhFVi?= =?iso-8859-1?Q?s1lMhCjQfaqR1jm6k1kykHgbEgoGphZW1xw848Zm5Un5Y0uAvXhkScvHjD?= =?iso-8859-1?Q?uwBHj/8vURS1O3GCnPUmBBKKIpjxy6jmtHjb9bb0Y9idXlmyltS0rFjIN4?= =?iso-8859-1?Q?En/kjgQ1rgxwotswtdmeyHwe/ca6Nj8Sv4E3l7MnB/8NtTcvaWEe+svuot?= =?iso-8859-1?Q?ER6cOgq2ontLCrWgnUKGga2mmqDQVfdbxqZ7TiOth6SZcTWdPQBYdAoOUh?= =?iso-8859-1?Q?ZyVKg7Vc8EWM0G5rNBmVg2dfop7PHiBll51h0I0diZbwLYEWRH8umau1Lj?= =?iso-8859-1?Q?NlWZpMysVn0yEflcggI9EnUnfqCKpo+NEA+GZIdlMfL0ZsBqf/qBLuBYHw?= =?iso-8859-1?Q?Cg3jv05pTgubW4S6V1AKdJNjfdTZqGgN7MGlTgbInQCwNFkP2HWWB/3GTk?= =?iso-8859-1?Q?etjLx/RpL7RCi36C/xkvoQDngFsIrv5Synya7L4Vl3jfHDkOQfedARUgah?= =?iso-8859-1?Q?0+kulwZjgrlEJbjuxRQ61ftm2ve/K66shgCPtfQn3b9XxlDg80QrDx2+1P?= =?iso-8859-1?Q?hLOtu/+jBm72vpV7tmeF5230KhX/Ucxudw33fNyeUoyzGnUKFEuvZDB9gc?= =?iso-8859-1?Q?RazhydPbvx/LhxaaAb4gzXlntDFRlLKxN+Jcys/wQnBb/kRNhDtqgKdtrd?= =?iso-8859-1?Q?pUwG5msEuNmXqp/j29Tojmxg7XdrnKoRg30qd2cyn0NHK8dhDSPWzCHAJu?= =?iso-8859-1?Q?pPrb4m25uEBlytMXrbirVrQU1qYgNeCK4W1UG7jLbdo6FE8eWO994=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5911.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005)(38070700009)(921011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?8QtOHRVfpgyjW4GlsayEuTltOeOF5dZMrUYoJn76j4ShhaSYDyQlI3aJvQ?= =?iso-8859-1?Q?y395DpmDJJHUYV5dM3F2gRKteaITsWZYyhPO/wekoLSJ5NePv97wt1mBqU?= =?iso-8859-1?Q?XIIp6vEMv2cOaqxpN/dMhEVPpHZsRd/K9Ucq1AEUYn5y1a+ApPR0+ydc2Y?= =?iso-8859-1?Q?ufiANZ07UowrRLkyXW1N5/R2KmgXeNqdxoYkB/AEoKXAtPTAITVVSJGN+2?= =?iso-8859-1?Q?BsA1MRaHaNmMCo5fTMJ8EsBj/uipaEwEu5rc6x7ukuH3+WBsopKECveCuG?= =?iso-8859-1?Q?nVsyCUjFJPA8EJRNMpCZwDCOPVyyUfMN30oqKE2ZTkmtuy/VJHAc/rYBIT?= =?iso-8859-1?Q?vAYUUfg1Ow5+1gP8ZedOebSc7mYVoELSvxTSbqJLghQPLIHxg/wUmu8IYR?= =?iso-8859-1?Q?a4jtZrCJ9ani7xAfyRHq8m73nTELVLCED27SSyDihdG+ALHe6hYdx9h2Bs?= =?iso-8859-1?Q?/qh1ze5uPac4dkC0FtUrxgZWr+FiyX+NTTccAcBwqQ7IvS4XGKpQJKeDnG?= =?iso-8859-1?Q?YgI3jR8lNDTJWmsVk++j2GlUmCp3cdPxXVVim2h8wcgm8/wXDNlvksltaA?= =?iso-8859-1?Q?0EhXrejFuaLeAvGgiqi8alpmZ54GoUO3Ow0uTaH7sOY0JvR48I4eNqJPU/?= =?iso-8859-1?Q?5ADV3p0pdMWAlRts5GNcfVOzV+ibx+e/BSbY6zKOm3Zpc9oqVpc7tt0tJj?= =?iso-8859-1?Q?9ZfO0RNbWgzSBzf0X68Hc3aO6i8YQ2Fw+Mx6ry/beeq+WBCAi0nzybtxT+?= =?iso-8859-1?Q?J7yGaIMl4EuOVLrca6nlE/i0wIKAHpEYn2dfeV8RYeLOHBYQRDg/+SLuZb?= =?iso-8859-1?Q?RoB4y+VuoZL++y1cP2YYoPxxbeZ58LqG1xgbiiS740AuIX3WhYGh1jccxA?= =?iso-8859-1?Q?xPiK7F4jocvrqRR97xGy14VwUAJraQ8EYpP/+bx5WRPhuKNRbGy+/D5wek?= =?iso-8859-1?Q?t70T9dCXJ4tBwnQ9PHY7MlPqTZSsmMi67kXu2owUhzsHiO590rIikY1bsL?= =?iso-8859-1?Q?v8SCsnP/WqVCJUG462jOSItjErprTttUZVJunT/mtd7eYlqFPYJcNCF2Rg?= =?iso-8859-1?Q?09/0OznjacqYWo6X9z50UCbDc+hX7BEcLtPJWMZztR3qYqYcvrjHZHPD1x?= =?iso-8859-1?Q?C+Z2xFH8YK57c36YsXkYXT+GcsKewAOeZYhwlq+4FmnfqjVkh0Ym9aWLHY?= =?iso-8859-1?Q?zrFjZQpvT3WmuwSz4r2g0UscAANhBrVHyBNn28zU9wLe+htuCkht8r44eq?= =?iso-8859-1?Q?Ihfse1BMSyaOFCdvBMCUmEtCmEq0O2eJGNJHF/73xk5LoUqByK65FgvMKW?= =?iso-8859-1?Q?gfdQ6IsYG5pt56r5F9eCD2j8kLeMvSgNX+rEyZAhpF6kscSsh1rV63fGA+?= =?iso-8859-1?Q?54I2Ivu0RGBe1nLuZ9xisPi/c3c2GOH8xlLRk6ZJl41boBtI/pg9Bckw9k?= =?iso-8859-1?Q?0LSrO/s3jufWvCLKNaVURG9TwawhWtl/pNEzION5JqpeOVQQE0WDx84HnM?= =?iso-8859-1?Q?NfDBfapOTRcut5iqEJbUwdsLJtrP8hUvRQsWNQqK4UsZYZ00OzgHP+sKh8?= =?iso-8859-1?Q?mtd7ITc0eDH+bAfMxYoRK5NAMIm9bNRSK+d5d6BlYtsb/pi3OC4nPLU0SF?= =?iso-8859-1?Q?f2WkpAGooghCVe3AglarIpKmH9IbT58ApHNeVJ/IclTuul/gs8xampTw?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5911.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb9b5d0c-7664-4d23-faa6-08dc809d3d55 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2024 11:40:00.6565 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hDoXpf9+uQkvjvqZlxTh71mgnVYvRn5ey2oAdOf/Jd/r2BL9IIg3JmFHABkN2uPgCkaRtCxk8ccV/wgHDyELcuaFfRHK0f5fV3wO16PEJwo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6084 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, May 30, 2024 4:32 PM > To: Kundapura, Ganapati ; dev@dpdk.org; > Gujjar, Abhinandan S ; ferruh.yigit@amd.com; > thomas@monjalon.net; Richardson, Bruce ; > fanzhang.oss@gmail.com; ciara.power@intel.com; Morten Br=F8rup > > Subject: RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsett= ing > crypto callbacks macro >=20 > ++ Morten for comment on #if vs #ifdef >=20 > > > Subject: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on > > > unsetting crypto callbacks macro > > > > > > Crypto callbacks macro is defined with value 1 and being used with > > > ifdef, on config value is changed to 0 to disable, crypto callback > > > changes still being compiled. > > > > > > Used #if instead of #ifdef and also wrapped crypto callback changes > > > under RTE_CRYPTO_CALLBACKS macro to fix build issues when macro is > > > unset. > > > > > > Fixes: 1c3ffb95595e ("cryptodev: add enqueue and dequeue callbacks") > > > Fixes: 5523a75af539 ("test/crypto: add case for enqueue/dequeue > > > callbacks") > > > > > > Signed-off-by: Ganapati Kundapura > > > --- > > > v2: > > > * Used #if instead of #ifdef and restored macro definition in config > > > * Split callback registration check in a seperate patch > > > > > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > > > index 1703ebc..72cf77f 100644 > > > --- a/app/test/test_cryptodev.c > > > +++ b/app/test/test_cryptodev.c > > > @@ -14547,6 +14547,7 @@ test_null_burst_operation(void) > > > return TEST_SUCCESS; > > > } > > > > > > +#if RTE_CRYPTO_CALLBACKS > > > static uint16_t > > > test_enq_callback(uint16_t dev_id, uint16_t qp_id, struct rte_crypto= _op > **ops, > > > uint16_t nb_ops, void *user_param) @@ -14784,6 > +14785,7 @@ > > > test_deq_callback_setup(void) > > > > > > return TEST_SUCCESS; > > > } > > > +#endif /* RTE_CRYPTO_CALLBACKS */ > > > > > > static void > > > generate_gmac_large_plaintext(uint8_t *data) @@ -18069,8 +18071,10 > > > @@ static struct unit_test_suite cryptodev_gen_testsuite =3D { > > > TEST_CASE_ST(ut_setup, ut_teardown, > > > > test_device_configure_invalid_queue_pair_ids), > > > TEST_CASE_ST(ut_setup, ut_teardown, test_stats), > > > +#if RTE_CRYPTO_CALLBACKS > > > TEST_CASE_ST(ut_setup, ut_teardown, > test_enq_callback_setup), > > > TEST_CASE_ST(ut_setup, ut_teardown, > test_deq_callback_setup), > > > +#endif > > > TEST_CASES_END() /**< NULL terminate unit test array */ > > > } > > > }; > > > > #if may not be needed in application. > > Test should be skipped if API is not available/supported. > > It's needed otherwise application developer has to check the implementation= for supported/not supported or else run the application to get to know whether api is supported or not. > > > diff --git a/lib/cryptodev/rte_cryptodev.c > > > b/lib/cryptodev/rte_cryptodev.c index 886eb7a..2e0890f 100644 > > > --- a/lib/cryptodev/rte_cryptodev.c > > > +++ b/lib/cryptodev/rte_cryptodev.c > > > @@ -628,6 +628,7 @@ > rte_cryptodev_asym_xform_capability_check_hash( > > > return ret; > > > } > > > > > > +#if RTE_CRYPTO_CALLBACKS > > > /* spinlock for crypto device enq callbacks */ static > > > rte_spinlock_t rte_cryptodev_callback_lock =3D > > RTE_SPINLOCK_INITIALIZER; > > > > > > @@ -744,6 +745,7 @@ cryptodev_cb_init(struct rte_cryptodev *dev) > > > cryptodev_cb_cleanup(dev); > > > return -ENOMEM; > > > } > > > +#endif /* RTE_CRYPTO_CALLBACKS */ > > > > > > > @@ -1485,6 +1491,7 @@ rte_cryptodev_queue_pair_setup(uint8_t > dev_id, > > > uint16_t queue_pair_id, > > > socket_id); > > > } > > > > > > +#if RTE_CRYPTO_CALLBACKS > > > struct rte_cryptodev_cb * > > > rte_cryptodev_add_enq_callback(uint8_t dev_id, > > > uint16_t qp_id, > > > @@ -1763,6 +1770,7 @@ rte_cryptodev_remove_deq_callback(uint8_t > dev_id, > > > rte_spinlock_unlock(&rte_cryptodev_callback_lock); > > > return ret; > > > } > > > +#endif /* RTE_CRYPTO_CALLBACKS */ > > > > There is an issue here. > > The APIs are visible in .h file and are available for application to us= e. > > But the API implementation is compiled out. > > Rather, you should add a return ENOTSUP from the beginning of the APIs > > if RTE_CRYPTO_CALLBACKS is enabled. > > With this approach application will not need to put #if in its code. API declarations wrapped under the macro changes in next patch.