From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDCD64617E; Mon, 3 Feb 2025 09:35:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB5DE40B91; Mon, 3 Feb 2025 09:35:31 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id 3963C40264 for ; Mon, 3 Feb 2025 09:35:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738571730; x=1770107730; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=6nxPfK+tWauOXz6DzJLFInqDFzyYXRZ/9D/JaQ0UdVI=; b=lw1YWcYBCmd4RZlPebIROi9mgn3eyuUBoA95tgt9gT1A902h5MKgR8uS kZWasqeptbx0fquO+l5vxoCu7DVpqnbWYkKpu0zicjJgygUXYZS/gm+LF mZJRbqre1a1taM9QKtQacSndOhZsqW1Ek4tUXYGOSjYH/dgQEWd79NvVV PANT8/0IU6K+4RQkyUhJEpWc9SsrZ8Nbt33N2HE8QQ0R+QNwYrEhzjgoq AYWIUDsZ5JuKnWE7KPjo1WrfmuLPNxzd7NyNuMoHK0rekvlwx1eV32gCf Zb04wxST6E64hVACY63TZD7ybyvvDdwU8mou1IHO+ITX+UMZrwGgpxNFD g==; X-CSE-ConnectionGUID: 8OPRJCmbQzWoMPXyuQfbDg== X-CSE-MsgGUID: eZfpeIVQT5OtLHC/ElfDpg== X-IronPort-AV: E=McAfee;i="6700,10204,11334"; a="38762957" X-IronPort-AV: E=Sophos;i="6.13,255,1732608000"; d="scan'208";a="38762957" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2025 00:35:29 -0800 X-CSE-ConnectionGUID: l/aD/h2xSiKFLPy5fKxs5g== X-CSE-MsgGUID: b3PQ7JobTzCADdt0IHmmJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,255,1732608000"; d="scan'208";a="110807198" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Feb 2025 00:35:28 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Mon, 3 Feb 2025 00:35:28 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Mon, 3 Feb 2025 00:35:28 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Mon, 3 Feb 2025 00:35:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=S2edRqnUb0sBLElXDQFRRbA1eUL3E1ITQsew1ronTchfDijXGq3lhY4o2LTZIc2q2BULprqQxD5Mm5+axi1pj6ZwhEwYl54YPQILXg+FksCiTNMI7g7LGWaKsxfReCF89pQzVNa3c92dCtigGuSoDRDxzi6VIWgU4JWqIfWQOyZt7zMrNIk1R6P74BHN7chPZBg3DmoM5pWOx1YuF46mtOtQgeCcxBfb53tMxHsnWwpa1PL1b5Ev91IkOFiwWN8D3Kky5PWfpkxtG/q0PkNNTHuCqGJxvVywX3i3E7gwrCyAL5Kt2K9KtOBmUVYRiv3AbgzJ/FMoedgcpANO6+gnNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qC2K7eAyFMmDNOQF14oL08E4pCKeMAtXcC+moZxN7fI=; b=SP4yGNBg7Jf2uCC4OcekB3t3d5u8rhhqkK7CzGIIc3W4dbEY+9RXaRmOOZgEcyyvFvqA493VQLcQTrbrHdqgwNCGtyBWo17CFuPkmYAgFcn9gvu9HW4Mau7kPULQS5PiJc2ACFIjO1o9H4RrJ3xYeudlp7SjyxgO0JNA31H+guZx1XADvWpll1Ds1HeQm1coOefFX/BpGVOM6hZ89p9ByXkDTIJ8MCEbGIJUjgOLgQTB5hapVH602W8lHqG6Z4gBOZ3h04x/k9fX8rxleT0woySqgOcWEVDb5YVRGTtWRWR0YHpVzmfJURy2Ks70zowhxCmSDIODofrAJ8y/PyZ2/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5911.namprd11.prod.outlook.com (2603:10b6:303:16b::16) by PH7PR11MB6606.namprd11.prod.outlook.com (2603:10b6:510:1b1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.23; Mon, 3 Feb 2025 08:35:10 +0000 Received: from MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::1d00:286c:1800:c2f2]) by MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::1d00:286c:1800:c2f2%4]) with mapi id 15.20.8398.021; Mon, 3 Feb 2025 08:35:10 +0000 From: "Shetty, Praveen" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Wu, Jingjing" Subject: RE: [PATCH v3 2/4] net/idpf: re-enable unused variable warnings Thread-Topic: [PATCH v3 2/4] net/idpf: re-enable unused variable warnings Thread-Index: AQHbcylplefHLLtrMECqTRAvCsuqS7M1Rn+Q Date: Mon, 3 Feb 2025 08:35:10 +0000 Message-ID: References: <20250128163649.343336-1-bruce.richardson@intel.com> <20250130151222.944561-1-bruce.richardson@intel.com> <20250130151222.944561-3-bruce.richardson@intel.com> In-Reply-To: <20250130151222.944561-3-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5911:EE_|PH7PR11MB6606:EE_ x-ms-office365-filtering-correlation-id: bc68ad9f-45ce-43e5-7af0-08dd442dabfc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?AcmnD33ulV9vieecsj5tx2QR9uVbSV/Fd9vfUgIrSG0xp9SzZVnuRinGcwe3?= =?us-ascii?Q?R1t0NeJI4RI+EDMWZ0XGTSaDxVI0AvuHCsPFx/6ho15luhzvcBeU0QCuUa+n?= =?us-ascii?Q?RpzGTm7HydFc30je2Vl5K+Md4djPQBZvj3NRyU1frDdA8sSz0Upt5pc317K+?= =?us-ascii?Q?Rg9BLbx7OE6uDomefXTmHGxTF5hkiKsopLRYi3Xl+QZ99QJvi9InUKVC2pZB?= =?us-ascii?Q?RGkzWP5L00JB+omi703ilxPowQAaVTjsvL+Swm8B8b1UlaIRWasd01Z8k2GI?= =?us-ascii?Q?T7Z6n7mbluO/F6qdUyJTWyKnSfWWxtcM4bmbGh6tJ6J74QxgLn/jvTH5+WyX?= =?us-ascii?Q?qt1rRRKGPKeRY2P+Yqo7NpzNZ1pnids+OuWfnF3qWwHiTUrH+QQSSL3wv8DD?= =?us-ascii?Q?BEF3fvUOZlEzWOdG/sNq0wTySTdWrIZNS6r7mby8aexbUKPvWqNnzkJ5G5dF?= =?us-ascii?Q?wbM3qvWKbFZ9GMcxGh//IQt1wsOaa0kjwUIj5RdA0X24NaWfNLQYAZa3icv6?= =?us-ascii?Q?acQrVWxB7psasXnNFn3+ydjgPhn+kfIiDepW5YTZxGglCLVELoin4u1zUOhx?= =?us-ascii?Q?RgtHnv909yoa0Qw22nYWO36YI+bBHzhc0LR32GXhh2HVuxZHr0ATIR8GdFib?= =?us-ascii?Q?O4o5MBvUtsunahws4eesktqpHA72b9v/8n52za5SeBQOZQlJuDaiEeUk+2dG?= =?us-ascii?Q?6hZtIyvmRwppfJxlmGdH9ZYJtwKlkVYELgVwHmutx3ktewCmlfbfhuwI6CBL?= =?us-ascii?Q?dBSLRC7wilWv4Vti+krmG3teRF7N1144iJCHlTLGxgWfy3x8OxFe+lapAR49?= =?us-ascii?Q?OsZTA5sd7I/tTrgMmxJ/T+v75xrLxjHs2kqdw5z3wL830+e2Xe8qoqiZxgJr?= =?us-ascii?Q?tAyuPfCnLXlNgDG23Fi/J3pyE31pZ7onze6PWQ0AuGrjkcaXVhHHpScKyKF+?= =?us-ascii?Q?nY8KnxznvI1ybuR8vauGsUnZppfKfnWVqTQy8/OeVFg37poe0pcIB3XCiF1J?= =?us-ascii?Q?IbGpwNnhGQpB0A3ocQeS2LUEhOy7wrPHQaktPVguSZc6ohn1GTf1faLabo4j?= =?us-ascii?Q?oMNAGdujLoO0b4AAV1YmQmzekcNGmJJhFe80XlR87UfA6XLHmxUXSpg9/aoh?= =?us-ascii?Q?XUSudkd5I3Wf1MQiGdYFK+OfGk+MDtm1eUeMy14AAR/3u6PVtkGgPv6jRIK8?= =?us-ascii?Q?NUypTeLZ2CAwkEUIhnz+12rbmKHfAEwXna8raeBmXwoU+OoqkNcfdOHKg5jX?= =?us-ascii?Q?hGzbqStr9pycWZTK4YomuO09zzkc3/w/dOIhJEfqSG2Tz+fLPYqxhSAS8oc1?= =?us-ascii?Q?+mjK0HgeukQYkJ4sbE5G187GQCxej7kHgglyQ8znpmySqWLbTohWJc26gjKS?= =?us-ascii?Q?VJ3E6sBAFDPEtpHHFqe/J10o+ZCyMsUjKCNIxPR6xem98jXEmNtTE0Gm2xP8?= =?us-ascii?Q?SlyT9206BwOR/aYeKOBdRtDrjPU9PoqD?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5911.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ccuCcqVk3b0sPYYypMH7s06JHEDcSA8xiv5jNKewaPf20izMS5sqSQfYg21E?= =?us-ascii?Q?lXlnrUAbChiwNRPOt4b4MFxAPepqgX/+ZRnZbe/EYs2+xHynKkVcPfNPIMgv?= =?us-ascii?Q?ita07VCMhumtBn1Fvn3Ep9rYxYJ6Re7n4BS2xP6TAsrmqArSQaqBPvJvSfOK?= =?us-ascii?Q?DNZpd6HSmsd7de94LoA2/KCJinszQj/yuTrS2VNEX7tAkPL/ucFPor+4QGxm?= =?us-ascii?Q?2UTJQTO/w7T9dcmDPqkBWTkksoPSJSl80HtOEnihvhj/hnU5q/CbfA1SHzmI?= =?us-ascii?Q?FtjXrHlhvcfrlSIvEdNhisG7TCNOC5JSUyJU2aaB/dbvmWAEqkJ54fokOAI8?= =?us-ascii?Q?uI5UPNJncJ9MMHxIaeHe5HSkvuNRfeNoUzB6LVcqH4rQkWA1QyXuynlOEdCT?= =?us-ascii?Q?m4yp3eX2Xu6Lo+ht0CmkyB66DdoSjuB1nKyN5cn8VzRftKeA+9e2cGRS1DEk?= =?us-ascii?Q?N4JAc072TEVHVCT0Slzs6TGO5She/oWKKsH2qO7amSKRW6JW+8gAr3maK3de?= =?us-ascii?Q?i1pWjx5vYwg5TsEOrQGoXQuSgKuEomJhWnRg9Djp3uOmLnbqIH/8CXtZCULF?= =?us-ascii?Q?1P1XjHXKC0APC3VkgQbkQbOcYZnPjOPBohdf60qTVy18XMncInAbmz3bxUrY?= =?us-ascii?Q?dwXNGjIabSwzh/8pIMk5dKGUzdCT2mlzePg2ejoJvBmZwpU3AEjYbnFjWBL5?= =?us-ascii?Q?VCGNBe/h5/x+YPI7p0w5bbjKrlbbC0ltWqFMOKX+48dwMShlCUTSUp1JNttN?= =?us-ascii?Q?2fZXw4bPf+HmIaJdr84/fXjlo7EL63k4lGkGZCvIrlxsxkO/JUZe+6VcYULy?= =?us-ascii?Q?/24otznSa93W0eWraaKGe1c7C9VYoZkDG+GKV2wtkNJ4t4JxVXxqW2Ct6kJ3?= =?us-ascii?Q?Y5OAddG4NkhwU5ja+/su85wioWpaz35mh2QPNZyayGoPF4XQ0h8P0ke6Lz3V?= =?us-ascii?Q?ClK4gbpgOCzFwYqimA3HHdN3B0QMTNf2Dn3qrAVufr4ngtA3AVLJH/fHrzvr?= =?us-ascii?Q?pyhXa38e3dKKws21Gn1nLbDkdkr9NBoaTc6YHUKBdBes8fySYiLnmWLePFk/?= =?us-ascii?Q?it50h2Rya1BNsxuXU+Wp8bRrsKLd3vVDEHaipCBnwdQuXC1xR5QAwOg5MZgM?= =?us-ascii?Q?FPPZkXvX9LoV1IprAeGVlpgqJRiGoYcWc9PGtdRzLaCZ22Tr3PFiYYpuE3j/?= =?us-ascii?Q?wvHZj+KdhklyfbxbPvz08jVwjUJWfRV8shUUeCWiI3vd0NuAOQ2fl9KL9f6r?= =?us-ascii?Q?bLe+AdExES0x/O/9VLCu9uwQ8SFUR84OdyajpNU1ZcpuVWQePOZA9PPpS/XY?= =?us-ascii?Q?/2w09FjNWLwhqkk8XMAaO6lbpWlMm6CFfsYOCumpfFwhoHdMbLvg6vYR7B6T?= =?us-ascii?Q?IGaUClJsUB4xQGKUgfrrrv6kd+aDjA/TE+CxTRw2174eDtC4MyKEmdjZwLxs?= =?us-ascii?Q?A0cQD+f35fVo7Hu0YcYbfJ/IXKCS9Up2MRm0nJoLAKLmn7irRZmPbC9hL2ag?= =?us-ascii?Q?DQWIKpKzN5D5A9RbXVrk8tQkDOFHH7xp9fd1hv4XIMELGk93eVI9FUT3W1N/?= =?us-ascii?Q?MzFrlwkOHE0pxNhUxeiQrl7YcICvUH0IIM4IRiey?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5911.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc68ad9f-45ce-43e5-7af0-08dd442dabfc X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2025 08:35:10.5812 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c1nET8ohj4Xzd4/JZAiHpVuSJV6yWRc2qKn38vbs0fEjSUDjTbGAMS6mql7cc+3Ht6sodK/iHOdfuCbfU3KsYwbIrnMFcDgo3XJl2whc3Ck= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6606 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The idpf driver was being built with warnings disabled for unused variables= . However, while the warning was being disabled in the base code directory,= all suppressed warnings were in the main directory. Therefore, just remove the unused variables and re-enable the warnings. Signed-off-by: Bruce Richardson --- drivers/net/intel/idpf/base/meson.build | 9 --------- drivers/net/intel/idpf/idpf_common_rxtx.c | 2 -- drivers/net/intel/idpf/idpf_common_virtchnl.c | 4 ++-- 3 files changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/net/intel/idpf/base/meson.build b/drivers/net/intel/id= pf/base/meson.build index f30ec7dfc2..7316e0a805 100644 --- a/drivers/net/intel/idpf/base/meson.build +++ b/drivers/net/intel/idpf/base/meson.build @@ -5,12 +5,3 @@ sources +=3D files( 'idpf_controlq.c', 'idpf_controlq_setup.c', ) - -error_cflags =3D [ - '-Wno-unused-variable', -] -foreach flag: error_cflags - if cc.has_argument(flag) - cflags +=3D flag - endif -endforeach diff --git a/drivers/net/intel/idpf/idpf_common_rxtx.c b/drivers/net/intel/= idpf/idpf_common_rxtx.c index a04e54ce26..9b17279181 100644 --- a/drivers/net/intel/idpf/idpf_common_rxtx.c +++ b/drivers/net/intel/idpf/idpf_common_rxtx.c @@ -1178,7 +1178,6 @@ idpf_dp_singleq_recv_scatter_pkts(void *rx_queue, str= uct rte_mbuf **rx_pkts, struct rte_mbuf *last_seg =3D rxq->pkt_last_seg; struct rte_mbuf *rxm; struct rte_mbuf *nmb; - struct rte_eth_dev *dev; const uint32_t *ptype_tbl =3D rxq->adapter->ptype_tbl; uint16_t rx_id =3D rxq->rx_tail; uint16_t rx_packet_len; @@ -1310,7 +1309,6 @@ idpf_xmit_cleanup(struct idpf_tx_queue *txq) uint16_t nb_tx_desc =3D txq->nb_tx_desc; uint16_t desc_to_clean_to; uint16_t nb_tx_to_clean; - uint16_t i; =20 volatile struct idpf_base_tx_desc *txd =3D txq->tx_ring; =20 diff --git a/drivers/net/intel/idpf/idpf_common_virtchnl.c b/drivers/net/in= tel/idpf/idpf_common_virtchnl.c index de511da788..0ae1d55d79 100644 --- a/drivers/net/intel/idpf/idpf_common_virtchnl.c +++ b/drivers/net/intel/idpf/idpf_common_virtchnl.c @@ -362,7 +362,7 @@ idpf_vc_queue_grps_add(struct idpf_vport *vport, { struct idpf_adapter *adapter =3D vport->adapter; struct idpf_cmd_info args; - int size, qg_info_size; + int size; int err =3D -1; =20 size =3D sizeof(*p2p_queue_grps_info) + @@ -1044,7 +1044,7 @@ int idpf_vc_rxq_config_by_info(struct idpf_vport *vpo= rt, struct virtchnl2_rxq_in struct idpf_adapter *adapter =3D vport->adapter; struct virtchnl2_config_rx_queues *vc_rxqs =3D NULL; struct idpf_cmd_info args; - int size, err, i; + int size, err; =20 size =3D sizeof(*vc_rxqs) + (num_qs - 1) * sizeof(struct virtchnl2_rxq_info); -- Looks good to me. Acked-by: Praveen Shetty 2.43.0