From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAC36424CD; Thu, 20 Jun 2024 16:34:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C33FD402D2; Thu, 20 Jun 2024 16:34:57 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mails.dpdk.org (Postfix) with ESMTP id 34700402B1 for ; Thu, 20 Jun 2024 16:34:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718894096; x=1750430096; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=GkydPSNYujw4iYChWDHyq957n88pINxDuwn4DbxG2vg=; b=mbfYEbDY09FFBnqQX4hCBRZX8bIzAy+jefxt8FBw5bQDnv8zKktQdI6U jHX2O1mqDWc2DmwPc+nUbzoKa5iglzZGaBg/vp7/szriEE85wSchE6BNZ +SRqws3xtYcBDGfOLCXe1/KrF+pDnv8t9eDn66h3Z0Eh+Mkn7ePU+ck3T MJBTVwji2lWyIkCbDGQpkqAa9+1ybMiW1q1A6IbduhgnRtB/gFV5mmaW+ FklxJH7qYflAH7/Kn1KzMqb5Y2al5X/Zpmy8/xtkXm6mO4q5jWiouSc9S Mz5KncjKlX12ys/YvFcX3y/2W8hDP7FPd0xUabnPpHjazPlMMAg3U7uQA A==; X-CSE-ConnectionGUID: V8yoGFZgS5edZwoSlznDDg== X-CSE-MsgGUID: 8JaIrfuRT9CV3K6fMbF7xA== X-IronPort-AV: E=McAfee;i="6700,10204,11108"; a="33414466" X-IronPort-AV: E=Sophos;i="6.08,252,1712646000"; d="scan'208";a="33414466" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2024 07:34:54 -0700 X-CSE-ConnectionGUID: CTs19pE3TeSEflrLFGZQmg== X-CSE-MsgGUID: ex6NiayIRF6ny6RvMFjwKg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,252,1712646000"; d="scan'208";a="47199747" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Jun 2024 07:34:54 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 20 Jun 2024 07:34:53 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 20 Jun 2024 07:34:53 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 20 Jun 2024 07:34:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kjv+o0PqOmeQ3t/sFr1vQIqOZ2i9kXpnlgMYNxg0XOaB4K2IpNYmchm7Rj0V+MOGCb9BvJc+QE3FRXgrTzZImQ5lgGHBJHUVXbMX6rRSAU4LS0F0/v+i7riRYX2K1oU3wq0kIYLIq4KuaBwEqHZkedcPUQzKXlm1vJxDjAHQQbR36fiDX9hmMV8KQTQAi781gcFlRrqplzMRrvUtemrs0vcK4hzPB0cgiXBWILNSq3fn2hh7X3qiDN+M03TPgOZZG+YDMdqdmvEBBb+YUSxe0Jgti4sPD55GY9fpnDHvGWmYxpFRBf1Kc6greF0OlsSHz/ezXC47+Src8osSinDffQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O6fhCs/H120Emv7cHxxYkjUGsi9xkcUtLw56hrBQZ4Q=; b=PijdkKwYrIflgkGEog9OLQIQ5H2PR83ZQ8Sa8J384+on+5xcf25clZN3x9ZRhIpT169PIQtC6NK1eSc2NPB+rharIxFh2XVA6SlQ+vmmsV375YvADhxgqQsoW63Ayd9ytPNo6tzTFjhxlPX+1Vxs69whSLUPhUUqtzKgHqVPp4bXbList6LvD0l62wsRk4o8ARTXVf1+YY6JmNGGY/0KadwFaL8NQfDm6fUf97EUpoht7RttLPMv47BqatAd9ha1p6k4cnW06qFZoSUd+ej2jj3Lpb632RLZ18ve400/jyRhTealA4bTUsUbo01LtHMvyO3BACg04uyHPgFwiyB5FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5911.namprd11.prod.outlook.com (2603:10b6:303:16b::16) by MN6PR11MB8145.namprd11.prod.outlook.com (2603:10b6:208:474::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.21; Thu, 20 Jun 2024 14:34:49 +0000 Received: from MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::1d00:286c:1800:c2f2]) by MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::1d00:286c:1800:c2f2%3]) with mapi id 15.20.7698.020; Thu, 20 Jun 2024 14:34:49 +0000 From: "Kundapura, Ganapati" To: Akhil Goyal , "dev@dpdk.org" , "Gujjar, Abhinandan S" , "Mcnamara, John" , "Richardson, Bruce" CC: =?iso-8859-1?Q?Morten_Br=F8rup?= , "ferruh.yigit@amd.com" , "fanzhang.oss@gmail.com" , "thomas@monjalon.net" Subject: RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro Thread-Topic: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro Thread-Index: AQHasdY+VQlBT0PFPEGB76JakVCKkLGvbqWAgAAvM4CAAAlH0IAAA0yAgAAm7yCAAAfO0IAKr4qAgAuLvACACsWzkA== Date: Thu, 20 Jun 2024 14:34:49 +0000 Message-ID: References: <20240416081222.3002268-1-ganapati.kundapura@intel.com> <20240529144025.4089318-1-ganapati.kundapura@intel.com> <98CBD80474FA8B44BF855DF32C47DC35E9F4DC@smartserver.smartshare.dk> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5911:EE_|MN6PR11MB8145:EE_ x-ms-office365-filtering-correlation-id: fef34fed-af76-4667-f720-08dc9136239e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230037|376011|1800799021|366013|38070700015; x-microsoft-antispam-message-info: =?iso-8859-1?Q?PKe+KdLw163jaE7Gh77o6+D503OQUQmG/stpG2ErciKgOHUzmpXF0yE9wG?= =?iso-8859-1?Q?2lIe0waA0O3gsfV73oz9Do/zQqaSA6J91OoGv5bHmU5ejfRGfw4rGW1QVa?= =?iso-8859-1?Q?UrcKclj6y6Bi0Zi672IdvZwnCDuvTcJTzHoluuL+SmyyEzdNcqG4goWRb1?= =?iso-8859-1?Q?qrFSsNmNE/ExFilbT3LBqBP1lhlWkI+KTNrgrtEBc1Oh6v9ddXKDO7Jgec?= =?iso-8859-1?Q?ZWuppuGUnLF5oNkkvTKmgHxY08f6E/WROaaBvq34KM4tSN4xBVYY6q6roI?= =?iso-8859-1?Q?VW4+OMUiXZBbRvhmcnzxFUlvo18DdF3Nrqk4kKBSvnv3JEg8LWxQ/zUTEy?= =?iso-8859-1?Q?A8yr9FdtU5Faq4jtZTUmbaHJQqBItdkf3nWaUfnFJFXF1QMLuBoZkwP1WU?= =?iso-8859-1?Q?FStuikyW+9Wa+K64byGcEjsuQz3DpWYZRvfg4Kh3G802pSFTH+U3r5zssV?= =?iso-8859-1?Q?7CzSbQevm9iqc68y4BssSqYf/j4f+nZQDFLLOQbdsWj4kXZ/B1ZV/t5V1k?= =?iso-8859-1?Q?GUi2FRVvhEGGdSYcvz0YRdCi1jv8tvIH9ZI90+PqAyHGm6BmkdLS7Wjvr8?= =?iso-8859-1?Q?K9qlLy4t5ChJsuTPJhtzIEVVGCK3dvdZsizUKVrC+iNxire4tTvEVZLUWe?= =?iso-8859-1?Q?CjcL4B3r3OAiAXxqEkcFxmfTEc8C/ykCX78YEONEcvZ65HxhCpKecXNgWm?= =?iso-8859-1?Q?BNnMoFkXTAAdSrwMSERauXBrky9FEYGInp3OVDWrMRjFSS3BhO7KDSY5KK?= =?iso-8859-1?Q?EfcS+wTaFJVxzxRanZIZoaVCxu3OYQZqGqFNuF+x4sIMNCPLFvRi289EUh?= =?iso-8859-1?Q?QqHMlUkpCf5NsxzjSJEbyKvL+J4lWH3Yy1Q2M2OfeOyPiT9Yp0C881rhBx?= =?iso-8859-1?Q?ar2DvxnAFWkbVxvI+tKyCtji8Z81oRa6cHRMjzeH2br/e9xydKHbO7GZug?= =?iso-8859-1?Q?1SDpzY1jGWbIyVDkgujKQ1j8OlcKuKKYQmyjPm9bFHlODi+Y9KNg5l3gSV?= =?iso-8859-1?Q?ZUIB6dsS30XKiHDPEOsjas+NhS4T+Ws26VNmljJc4tszxRQRhjg7sWF00N?= =?iso-8859-1?Q?tgtLjs24uBrs5NKp0vN7O4D3p+n/0K+CZ7OrxsWuXlAWxmBDuQ3ymHjjrD?= =?iso-8859-1?Q?RsIL2Muy9xWBVAmGkXGxsowdBLbTiIEY1fxzU1gMKwQmaJWric8RKwHdRc?= =?iso-8859-1?Q?dUf+BIh9HXmzFMr4EqBGE8fnh7cqi5+9MTkw8C61qMayn633nnvN0CXl7I?= =?iso-8859-1?Q?qJ/K2FQkXDL21nHnBg9mW95KFQhjwN/r683UfVt5+lIWuNBJOj3mmUCErf?= =?iso-8859-1?Q?NoOQmrjJBvoMoYxqWHljbIzBcsrTjpfNnqaPDCywEhLaW+6bTIk+fMHKke?= =?iso-8859-1?Q?e12SEDosp32P2RlGVJZB0I8L7WyeCur4mfwKSf7Su8wP7JxV6jlXU=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5911.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(376011)(1800799021)(366013)(38070700015); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?IAIe8B++agpb10zwbMjvHlkqdK6lvVTDFg9UsKlViP6ZFp4whpZCQFgvKv?= =?iso-8859-1?Q?YajU37WQ4XFvb/rIzN1ckdImlIfEwqzPDcVlX2HgwzpoHB0XtrlQkENhFu?= =?iso-8859-1?Q?5gl1O0jHz3RKfR0LEmcyQmrdNQBLVZuqQI8Yikn6UenpI6X6VyZbS4K54A?= =?iso-8859-1?Q?fG9r753DYL55JHlNEWvxbiTmI0vH5/c2B5K1KtWuUuepyup5aJPjQ132PS?= =?iso-8859-1?Q?a9G4n8vNGt/DtzTMdJ0oxKEO0Px7cdAZHQpVJ8LPJe42eHgTrFzrPF33Cs?= =?iso-8859-1?Q?H9Liwk9izGE5hVVIrpeVjg1FlkFZt7e0hfqdRxPcapceZQpBhfZlWpD6ff?= =?iso-8859-1?Q?9Yo7OP7GKrYFQQBX2/e8al7o2J4qQ2xXYRVo1bjuyFK2cJsId1+p/maHQE?= =?iso-8859-1?Q?E8OFO6pDFfwa2mnvLa8rd1MjS+DV6RlEs8jtauZ7eZ3bludvkHaF4LCNY6?= =?iso-8859-1?Q?0aHBogTqmcVnZJ0dvTLZZcUW9Hn0mMaHHdlW7cM9QQ3slewpNwg8x9lDZ8?= =?iso-8859-1?Q?G+H71lx+/7LvDi+Gus21hpdYLO44ZCSbXh1g6kibOSiDT72iCz7/BH2E+U?= =?iso-8859-1?Q?BOz8YnXIapuHePPKLNwV9dD7Q68MHcSALbQVseTgHujuly9Yv2XjUl3kzU?= =?iso-8859-1?Q?wa+nOimxIumisX7hOi0Hh5DfQpxBT/y4MDoPk6DstDL9FJW3cGrVfZ6pB9?= =?iso-8859-1?Q?3PQHFwl0Or2I0ePhPK01HJwjkLtDjmE8lOdPv3eFQrPuFgVWhHYYDBkfFs?= =?iso-8859-1?Q?E9F2yx7ItvvxOSdV7p5qogg/thPgwOFUBJv9RiCg8zmDITTIIJ/VxPQV7c?= =?iso-8859-1?Q?UG/tuSeh8lN3dzhzVchEVgKfNptHeMZCjnRPY39o9Zde8b3XA0xyuUmcL5?= =?iso-8859-1?Q?OWEJhySu894uxq4f5Zjz0m+Go2nV3NYYvzW7z+1n5UZIDi9thvvGQ4TbZQ?= =?iso-8859-1?Q?+QYalEVX+e4EFSTC08wM+Qgi/HTkpIowaTyNcS4m/kwRneF3C6V5DIhqCr?= =?iso-8859-1?Q?7GVG/c7RDo0a0MwLe2c1uk4iU29Utu2VOFP4qsSU3WUQ44aldGqoHHxqob?= =?iso-8859-1?Q?fcWcYPkZTWUk5rAWg43xpp28F4rUrzF+FB1VUAgy0T0DzcQS+ZqTBcW12G?= =?iso-8859-1?Q?Yx4bMPgXGWUm/Xyvr+UklRC+q4FoO/gwvH/I8jUwfQKODnrM/9FFWEkXRX?= =?iso-8859-1?Q?xwViVVk++NmKRulnjLy8bv2p2EribjeVnvBWSrgJpRaNNQon6QgXoGILwW?= =?iso-8859-1?Q?CPpA4EQ9EqnFSU1hzslIe+E/vBP/yR8mqk3zvUQrkzaL+9It8b+nBIxFCp?= =?iso-8859-1?Q?BzxGV10wcn7TI3AWqeRrD/VjRVn9ejRHo7MNFRaSX+oMAmL0rAnbQdsXhE?= =?iso-8859-1?Q?xnHb92gViTYWLuhVh4NTX7KmrcmsrhQYVNHEdphaLzyU2J/kmryTRas701?= =?iso-8859-1?Q?t8dOckVk8HvhwfzWcuuDo5/6CCjaeMIGPHHZqR3+w/YTq+ORaxv06gBncQ?= =?iso-8859-1?Q?aonf/7HCGohfJDt0VXHKv1qARz6o3aeCYEWSNFwVPiYk3FFMTNZgQhuEVz?= =?iso-8859-1?Q?MpazOjoKj49RoGGBa0frZi4pir0tYkbB2Am4wG3jBtxnmkknFuZgtxpOv/?= =?iso-8859-1?Q?PxcHToUov5tQjpslyCrHHGXmzk2xnp/4HBXJqfVipSkCLyA1C3QdoTJw?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5911.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fef34fed-af76-4667-f720-08dc9136239e X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2024 14:34:49.1594 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zmhkUL4OUCEg8ETLbvZsnbU7ooNvAJwfg20ZshciMB0+XXx7AzMmvbTUeloiv44E/jXs6wayIjjvbnnHdlNG4s/vy5jo60vpFbMLKTxvTvc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8145 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, June 13, 2024 11:34 PM > To: Kundapura, Ganapati ; dev@dpdk.org; > Gujjar, Abhinandan S ; Mcnamara, John > ; Richardson, Bruce > > Cc: Morten Br=F8rup ; ferruh.yigit@amd.com; > fanzhang.oss@gmail.com; thomas@monjalon.net > Subject: RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsett= ing > crypto callbacks macro >=20 > > > > From: Kundapura, Ganapati [mailto:ganapati.kundapura@intel.com] > > > > Sent: Thursday, 30 May 2024 16.22 > > > > > > > > Hi, > > > > > > > > > From: Akhil Goyal > > > > > Sent: Thursday, May 30, 2024 5:17 PM > > > > > > > > > > > > > #if may not be needed in application. > > > > > > > > Test should be skipped if API is not available/supported. > > > > > > > > > > > > > > It's needed otherwise application developer has to check the > > > > > > implementation for supported/not supported or else run the > > > > > > application to get to know whether api is supported or not. > > > > > > > > > > > > > > > > Application is always required to check the return value or else > > > > > it will > > > > miss the > > > > > other errors that the API can return. > > > > Currently RTE_CRYPTO_CALLBACKS is enabled by default and test > > > > application checks the return value of the APIs. This patch fixes > > > > build issues on compiling the DPDK with unsetting > > > > RTE_CRYPTO_CALLBACKS. > > > > > > > > > > > > > > diff --git a/lib/cryptodev/rte_cryptodev.c > > > > > > > > > b/lib/cryptodev/rte_cryptodev.c index 886eb7a..2e0890f > > > > > > > > > 100644 > > > > > > > > > --- a/lib/cryptodev/rte_cryptodev.c > > > > > > > > > +++ b/lib/cryptodev/rte_cryptodev.c > > > > > > > > > @@ -628,6 +628,7 @@ > > > > > > > rte_cryptodev_asym_xform_capability_check_hash( > > > > > > > > > return ret; > > > > > > > > > } > > > > > > > > > > > > > > > > > > +#if RTE_CRYPTO_CALLBACKS > > > > > > > > > /* spinlock for crypto device enq callbacks */ static > > > > > > > > > rte_spinlock_t rte_cryptodev_callback_lock =3D > > > > > > > > RTE_SPINLOCK_INITIALIZER; > > > > > > > > > > > > > > > > > > @@ -744,6 +745,7 @@ cryptodev_cb_init(struct > > > > > > > > > rte_cryptodev > > *dev) > > > > > > > > > cryptodev_cb_cleanup(dev); > > > > > > > > > return -ENOMEM; > > > > > > > > > } > > > > > > > > > +#endif /* RTE_CRYPTO_CALLBACKS */ > > > > > > > > > > > > > > > > > > > > > > > > > @@ -1485,6 +1491,7 @@ > > > > > > > > > rte_cryptodev_queue_pair_setup(uint8_t > > > > > > > dev_id, > > > > > > > > > uint16_t queue_pair_id, > > > > > > > > > socket_id); > > > > > > > > > } > > > > > > > > > > > > > > > > > > +#if RTE_CRYPTO_CALLBACKS > > > > > > > > > struct rte_cryptodev_cb * > > > > > > > > > rte_cryptodev_add_enq_callback(uint8_t dev_id, > > > > > > > > > uint16_t qp_id, @@ -1763,6 +1770,7 @@ > > > > > rte_cryptodev_remove_deq_callback(uint8_t > > > > > > > dev_id, > > > > > > > > > rte_spinlock_unlock(&rte_cryptodev_callback_lock); > > > > > > > > > return ret; > > > > > > > > > } > > > > > > > > > +#endif /* RTE_CRYPTO_CALLBACKS */ > > > > > > > > > > > > > > > > There is an issue here. > > > > > > > > The APIs are visible in .h file and are available for > > > > > > > > application to > > > > use. > > > > > > > > But the API implementation is compiled out. > > > > > > > > Rather, you should add a return ENOTSUP from the beginning > > > > > > > > of the APIs if RTE_CRYPTO_CALLBACKS is enabled. > > > > > > > > With this approach application will not need to put #if in = its code. > > > > > > API declarations wrapped under the macro changes in next patch. > > > > > > > > > > No, that is not the correct way. Application should check the ret= urn > value. > > > > > And we cannot force it to add ifdefs. > > > > Test application is indeed checking the return value. Ifdefs are > > > > added to avoid build issues on compiling with RTE_CRYPTO_CALLBACKS > > > > is turned off Which is on by default. > > > > > > The test application should be able to build and run, regardless if > > > the DPDK > > library > > > was built with RTE_CRYPTO_CALLBACKS defined or not. > > > > > > The test application should not assume that the DPDK library was > > > built with the same RTE_CRYPTO_CALLBACKS configuration (i.e. defined > > > or not) as the test application. > > > > > > > Even ethdev callbacks also doesn't return -ENOTSUP on > > > > setting/unsetting RTE_ETHDEV_RXTX_CALLBACKS config. > > > > > > That would be a bug in the ethdev library. > > > I just checked the ethdev source code > > > (/source/lib/ethdev/rte_ethdev.c), and > > all > > > the add/remove rx/tx callback functions fail with ENOTSUP if > > > RTE_ETHDEV_RXTX_CALLBACKS is not defined. > > > Please note that some ethdev callbacks are not rx/tx callbacks, and > > > thus are not gated by RTE_ETHDEV_RXTX_CALLBACKS. > > > > Hi Ganapati, > > Can you send a new version incorporating above comments and work on > > similar lines as ethdev is currently doing. > > > > I believe as Morten pointed out, use of ifdef is as per DPDK > > convention, So better move it that way. > > We can discuss later if we can incorporate these in meson options. > > > Any update on this? Working on it, will post the patch soon. Thanks, Ganapati