From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43540A034C; Fri, 25 Feb 2022 14:51:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC2204115C; Fri, 25 Feb 2022 14:51:16 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 2B5084068B for ; Fri, 25 Feb 2022 14:51:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645797075; x=1677333075; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=XHFUNZbtus/kNL4JFzEsspQs0zVSUwfiygzbXF/g6t0=; b=PMamXlYxcCP87xzZb31N3Lnu9g+UzIa4zPw2u9JtMr9w19Yp9g22ADfs taUHErzqPf8Y/ZSCboRygWpRBg/vtpsS40lWjS4eBcF4MML3Ql25tqUds Ya7GB+QKkX7CW1az9qCsLAMSkVf7hTFrNErxUxOWJyTXKI86cvzOW76wB JXIBQNXWPSuvuyzkGGcG6buamL1Yo0BQU0V9+tXkbFhvu7gOLk5dE1bk4 +yj4PbVtrrC1nkG+Uv2HbYOLczdm81EAekTkLoobTAaNgluj1Jl5mvaTx OfWtujDwapuQTJSk//RVK0OSiXHYCrJizcct6vxWltZiSjS83wiT3mPPt w==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="233121372" X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="233121372" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2022 05:51:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="684656921" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 25 Feb 2022 05:51:13 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 25 Feb 2022 05:51:13 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Fri, 25 Feb 2022 05:51:13 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 25 Feb 2022 05:51:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ma3yFOpD71LWIb5xeaAKR7O00VufNDd7TRRi04M7opPpNU6Azcj8HV3n2gMGHWtLxp5m8HMNgRjIk6pv4yJxrnowgxqcffvecScW3A76UuGWvymxHOTuJDhh8NbU3Q4ys9csmNqzcdJVKSBdNQxok1RRP57B6woJC/n481SL9jaDU+FikaGfrSokjyZpiPVbSVgE+dd6MIsjO3JP2sPV59MERG15TLSNzfweiLNvYOJ6LCBhPaQkd1xEjHySoIK7fIDjbQwLhJFqXWiXF7OzIbdooQze4sCEc+BFsOWKSMbdDPlwOoqmXNYonSEjHr/fZB5mZ79Cur5m3QeNXeukOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=heixzhRRN6wAuVkk81lkbBGHDev7RNng+gICq8IEDZo=; b=eEfFoIjGuFZStp7wRNKL+1UjAGOHqcK2bSCDhnbmfIFxQts8jcX7MnVgZ9vBitTfP/uB5kth8Q0+kEBngX1w+pE4RKl38VBe4EAV1gm9PrRk3CIEBl3YbQ6ciZq49KaQ0rVETrEYuZsXaTrGa4iAaJGLaQu3z4findjkkqxlEIh0/iBcfCxxVvPq+185mQlg7SJZC7y6n6DY3YQ5JfILt9wVPN/lssazcUrw+OIUln6nqv4/21mqHLQ3RmtPItSV6owxvqxAFjbOVeZ0gg529CIXbXEqLJlNFTR2suudcijhBPAiinSlGKk8P4lpzeAqK1Dvk+EH2Q9CfcF+4kkRfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by SA0PR11MB4735.namprd11.prod.outlook.com (2603:10b6:806:92::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Fri, 25 Feb 2022 13:51:11 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::a599:b969:5072:71cb]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::a599:b969:5072:71cb%4]) with mapi id 15.20.5017.026; Fri, 25 Feb 2022 13:51:10 +0000 From: "Zhang, Roy Fan" To: Akhil Goyal , "Ji, Kai" , "dev@dpdk.org" CC: "chandu@amd.com" Subject: RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine Thread-Topic: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine Thread-Index: AQHYJL3fzorTyI6whkivVlDilup5NayjGKsAgABGG4CAAE7eAIAAazkAgAAFqYCAADIYAA== Date: Fri, 25 Feb 2022 13:51:10 +0000 Message-ID: References: <20220218094408.49290-1-kai.ji@intel.com> <20220218115124.57745-1-kai.ji@intel.com> In-Reply-To: Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 448ed245-b39c-40d9-82e6-08d9f865e199 x-ms-traffictypediagnostic: SA0PR11MB4735:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KpuINwApKLdsWux5NO9V3C1jyRCahgvTzoi0OJ/bIigi7+diqO//p+MaUPQNOuxihWj5g2idqaUnye4dfLW7kCUcFL6zDWGWNEAWbfQKFLI6h54X90RjbYYIlQ8c0UP5T/qybu58xMVL4l5gO8AtFyoHm59CFn0UWH8NEzC83izk3B70EnIFvGNz3s70CtRnlxc6OaoWMXiidBrE2nmzf8zu2/RkWn5Ui5BD7qzXhMOx9AT1sXX8gJyWt88e6uRao2E0EJ4Y+CJFl7UcgoFkyeIkx+2Hjw16E2Lrtu8WZs6+mn0l1b1Jp2Egj/S7kigRv7ohvv0sAr7bmiotj7A/Js5eOPOUaVXsep5/C9mx2P88MzlDf/iZ+8c740VBbRd6/XuUFNTmk6UCDnQP98OJXJuLAyEQgabu3RLCsaCS3N758zNYQhTxpjf6Ouy4hxvwgfEtHVcwBapHkzpP3L/j3qlymzKCGfz4nK3LoD74inGdViAsyxGbed/GA/7zNFqQ9svG1A5m4saOssIo52aMIS5eO2xjYh3F4fs8bk5J/P+enlpQuQWQeZ8j/Obr+bdYjbS21NhDM/h9MsCUe4vRDwEFgfSDLWawF3Pex4kDzeAhQhQw/lBWQ5GTdc90v7ES4VhZE8HXLgsbggXkwyTWwCQ22Fver5Yc1aAmfUPp27uWoUuEv9YgaVNejMpF3dTkDHAWRDkr8tTLJ9yjh8bbWA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8676002)(4326008)(52536014)(55016003)(76116006)(66946007)(66556008)(66446008)(66476007)(64756008)(186003)(26005)(8936002)(5660300002)(316002)(6506007)(508600001)(53546011)(110136005)(7696005)(122000001)(82960400001)(38100700002)(83380400001)(38070700005)(71200400001)(86362001)(33656002)(9686003)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?LueOnyFYPsp2AOQ8OkwwTwev0jBIVYe8uGwn0SkhFVTyS0yfb2YM4xzm?= =?Windows-1252?Q?iv/DZuOXW1rsScAPZTqS52I2YnToKhVxXr/8yUbWRwhvseOF5tZ+5tT1?= =?Windows-1252?Q?7SRNPnsxaMcm1FCKW3B3bpg0H1WR0nMzcmU43NYZF5EX/6tzCZN37Iz5?= =?Windows-1252?Q?1M8aj8Z7soBvPu5hLpvk0d5v30yuckYsRc/0ez2h0H1CvnKe9drIzx4y?= =?Windows-1252?Q?xt1jNNWliCS0k/0oTyTK9fw7TpJEodH0cNm8Qh/5NFz9YcFBzHbiyzWU?= =?Windows-1252?Q?CHg3+Hj0r0Hl7o4K4cdEL9hO/IKZxgreWJP6bgHHkZGrAOBZVDOb4KGQ?= =?Windows-1252?Q?bruFXIBh8c2dl6sAYD8OPEq7E9UWolIaU/fN4cvFtLTKr9PBUzl73jDF?= =?Windows-1252?Q?gy8pV5Jcr4o89Sk976+vBzJ1kX8oeg8ss+looXyzu6Brf+Il3/tpRS00?= =?Windows-1252?Q?HeUE39ebJHM/hhj4qkiPm98YfAIJPdYWgMeJ9Aa2JcjD4l3H6xuBHykB?= =?Windows-1252?Q?z51qeh+c78fuDAGryLkBSkHPTjPhSIRZZsHTPOUJ+JU85g1qZtOkWJjj?= =?Windows-1252?Q?b4j3uEG10Qr3FNn1kOpLQsoTt+SFc7Xg4eAMzhY4yi6+V7aM5qsn/RIV?= =?Windows-1252?Q?zOywfAVif04oPCqnkiRET+LP7rvz/VPnQgjgM/6L68rLXUmtp8y0LHDe?= =?Windows-1252?Q?UCaTwwAIbdY/ZoGlaCbmGhDt1zuf7pZTdHZJj2cla9cN8iVDCvADOCxV?= =?Windows-1252?Q?cWNBS60T7BWRP0luGB9rWs3WxrYA2CYFvbOoiVQOFg1yDxBHE40FHCQB?= =?Windows-1252?Q?2MvosdJ69IR/F7z36EDrHpzkxckUbrpE1H53j1+VdP9bdLWITXbwMzJB?= =?Windows-1252?Q?+7oik9YA7daD7KSlPNVSNHiT20NhFl5ywKlH/1TQVY3o0s0TpKE3l4xk?= =?Windows-1252?Q?w8nwdf40WwNbt4m3WeTkMDRfrp5yF+fCxt8Qf4/ceK8cm0gIaBbTT2sR?= =?Windows-1252?Q?DQzEBAJcv1G0PJFle7xU/KArzgH/+7aQaz4kyOGSTMHtiC4QsSf5vcFM?= =?Windows-1252?Q?EUTxAHABRDmGGxBWcRyzP0bOQ1I7i5TW8hHsp6loeWwM2e+7W8rcctLC?= =?Windows-1252?Q?2xqlZ1WfdvJzq2/WrEE3NU98aAShJFEismvzvQnEVNgbYtx1PSoeI4+d?= =?Windows-1252?Q?ZqMTAWGVD6u0vP1tp/sMe6YwfegE+BbNx7lMVoyctP73xS894jLnYzU+?= =?Windows-1252?Q?gidr6ZbSss7FFxdV6cWxON0v9Omao6gRSczeOIE2RTTH0n18FSmmF8Nw?= =?Windows-1252?Q?aaozzhhCHZYeczK1gosRoGy7kIbpiZyjvfqaZMfFg3+S/6n4adRznEif?= =?Windows-1252?Q?AJfBLS+8wOw1kCRszu4PpQ4rwuJYCnkD1BmCydowxcEQDV/9RYvCuuQD?= =?Windows-1252?Q?cUMT3gy+YbqFkSoneXUCUemrnakLAyqO4pLXKYDbC0RffFtflS04D/8N?= =?Windows-1252?Q?lKiyUjXVm+Fb0aOlBiKgDOIyyOrYQZrzuhFIC7C4wowYckCiR5qaj7QT?= =?Windows-1252?Q?ElAtst0UNHrrq6T9jjRU6RgBx6cxzNw24xzi//z1JmKy9gcx+vdfb3zp?= =?Windows-1252?Q?SEQXE/OlA0JXzkR8VGghfLSMuIiD7ibdHMwkusxsrYURh0jgWrM7ihq0?= =?Windows-1252?Q?PrUT39BiSMBL9kMbmLerEY1+fRkww8K3CFLk2c8nSqd5B69QaTF/Ltc8?= =?Windows-1252?Q?lSZjAvRDTN6GPrL3NNo=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 448ed245-b39c-40d9-82e6-08d9f865e199 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2022 13:51:10.9017 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G9v8y2sam3Zby9Q3z41JK2zrWlmhSrBP2ZruxPseZqpZDQA4ecEv51NSUTS7APfgiu53vt/q9BcZyGnxJ2+ISQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4735 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: Friday, February 25, 2022 10:40 AM > To: Ji, Kai ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on s= ym > crypto routine >=20 > Hi Kai, > > > > The warning messages are deprecated APIs warnings from openssl , not > > compiler warnings from gcc, the integrity of DPDK remain the same. > > Alongside openssl pmd, the ccp and qat pmd also raise the same type of > > warnings once openssl 3.0 installed. > > > > In the current intel roadmap, we will try to support 3.0 API fully for= openssl > and > > qat pmds by the end of year, so this patch is the first step. > > I think the warning messages are safe to stay, Unfortunately the fix cc= p > pmd > > driver is out of our reach. > > >=20 > When DPDK is compiled with openssl 3.0. I am seeing these errors in > compilation. > So, compilation is broken and we cannot take this patch as is. > We have few options, > - fix all of these errors, > - add exception in meson.build for ignoring these errors. > - disable/skip compilation of PMDs if openssl version is >3.0 >=20 > Adding only one type of APIs does not make sense, if the driver is not > compiled. >=20 > In file included from ../drivers/crypto/openssl/openssl_pmd_private.h:12, > from ../drivers/crypto/openssl/rte_openssl_pmd.c:16: > /usr/local/include/openssl/dh.h:223:27: note: declared here > 223 | OSSL_DEPRECATEDIN_3_0 int DH_generate_key(DH *dh); > | ^~~~~~~~~~~~~~~ > ../drivers/crypto/openssl/rte_openssl_pmd.c: In function > 'process_openssl_rsa_op': > ../drivers/crypto/openssl/rte_openssl_pmd.c:2068:3: error: > 'RSA_public_encrypt' is deprecated: Since OpenSSL 3.0 [- > Werror=3Ddeprecated-declarations] > 2068 | ret =3D RSA_public_encrypt(op->rsa.message.length, You are right. We will defer the change to next release so we can send alon= g with the asym openssl change Kai is working on. But since we have your atte= ntion I would want to drag Chandubabu's attention too as there are three PMDs us= es deprecated openssl lib APIs: openssl, qat, and ccp. Adding a suppress flag = to meson build file won't resolve the problem - we need to resolve them before the A= PIs are gone for good. >=20 > Also, avoid top posting of comments!