RE: [PATCH v2] examples/fips_validation: add parsing for xts

["Zhang, Roy Fan" <roy.fan.zhang@intel.com>]

Hi,

> -----Original Message-----
> From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> Sent: Tuesday, June 28, 2022 2:12 PM
> To: dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; Dooley, Brian
> <brian.dooley@intel.com>; Anoob Joseph <anoobj@marvell.com>; Archana
> Muniganti <marchana@marvell.com>; Jerin Jacob <jerinj@marvell.com>;
> Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> Subject: [PATCH v2] examples/fips_validation: add parsing for xts
> 
> Added function to parse algorithm for AES XTS test.
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> ---
> v2:
>  - build failure fixed if no jansson lib available.
> ---
>  examples/fips_validation/fips_validation.c    |   4 +-
>  examples/fips_validation/fips_validation.h    |  16 +-
>  .../fips_validation/fips_validation_xts.c     | 141 ++++++++++++++++++
>  examples/fips_validation/main.c               |   5 +
>  4 files changed, 164 insertions(+), 2 deletions(-)
> 
> diff --git a/examples/fips_validation/fips_validation.c
> b/examples/fips_validation/fips_validation.c
> index 324abccb14..f181363ef7 100644
> --- a/examples/fips_validation/fips_validation.c
> +++ b/examples/fips_validation/fips_validation.c
> @@ -463,7 +463,9 @@ fips_test_parse_one_json_vector_set(void)
>  	else if (strstr(algo_str, "CMAC"))
>  		info.algo = FIPS_TEST_ALGO_AES_CMAC;
>  	else if (strstr(algo_str, "AES-CBC"))

As David suggested - this looks to be a fix - I believe he is right.
I will let Akhil to decide.

> -		info.algo = FIPS_TEST_ALGO_AES;
> +		info.algo = FIPS_TEST_ALGO_AES_CBC;
> +	else if (strstr(algo_str, "AES-XTS"))
> +		info.algo = FIPS_TEST_ALGO_AES_XTS;
>  	else
>  		return -EINVAL;
> 
<snip>
Other than that,
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>