* [PATCH] app/compress-perf: optimize ops pool allocation
@ 2022-02-23 13:33 Raja Zidane
2022-02-24 20:13 ` Zhang, Roy Fan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Raja Zidane @ 2022-02-23 13:33 UTC (permalink / raw)
To: dev; +Cc: matan, stable
An array of the size of total operations needed for the de/compression is
reserved for ops while enqueueing, although only first burst_size entries
of the array are used.
Reduce the size of the array allocated.
Fixes: b68a82425da4 ("app/compress-perf: add performance measurement")
Cc: stable@dpdk.org
Signed-off-by: Raja Zidane <rzidane@nvidia.com>
---
Acked-by: Matan Azrad matan@nvidia.com
app/test-compress-perf/comp_perf_test_cyclecount.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/app/test-compress-perf/comp_perf_test_cyclecount.c b/app/test-compress-perf/comp_perf_test_cyclecount.c
index c215547291..a3f6404eb2 100644
--- a/app/test-compress-perf/comp_perf_test_cyclecount.c
+++ b/app/test-compress-perf/comp_perf_test_cyclecount.c
@@ -175,7 +175,8 @@ main_loop(struct cperf_cyclecount_ctx *ctx, enum rte_comp_xform_type type)
/* one array for both enqueue and dequeue */
ops = rte_zmalloc_socket(NULL,
- 2 * mem->total_bufs * sizeof(struct rte_comp_op *),
+ (test_data->burst_sz + mem->total_bufs) *
+ sizeof(struct rte_comp_op *),
0, rte_socket_id());
if (ops == NULL) {
@@ -184,7 +185,7 @@ main_loop(struct cperf_cyclecount_ctx *ctx, enum rte_comp_xform_type type)
return -1;
}
- deq_ops = &ops[mem->total_bufs];
+ deq_ops = &ops[test_data->burst_sz];
if (type == RTE_COMP_COMPRESS) {
xform = (struct rte_comp_xform) {
--
2.21.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] app/compress-perf: optimize ops pool allocation
2022-02-23 13:33 [PATCH] app/compress-perf: optimize ops pool allocation Raja Zidane
@ 2022-02-24 20:13 ` Zhang, Roy Fan
2022-02-24 20:14 ` Zhang, Roy Fan
2022-03-04 9:33 ` [EXT] " Akhil Goyal
2 siblings, 0 replies; 4+ messages in thread
From: Zhang, Roy Fan @ 2022-02-24 20:13 UTC (permalink / raw)
To: Raja Zidane, dev; +Cc: matan, stable
> -----Original Message-----
> From: Raja Zidane <rzidane@nvidia.com>
> Sent: Wednesday, February 23, 2022 1:33 PM
> To: dev@dpdk.org
> Cc: matan@nvidia.com; stable@dpdk.org
> Subject: [PATCH] app/compress-perf: optimize ops pool allocation
>
> An array of the size of total operations needed for the de/compression is
> reserved for ops while enqueueing, although only first burst_size entries
> of the array are used.
>
> Reduce the size of the array allocated.
>
> Fixes: b68a82425da4 ("app/compress-perf: add performance measurement")
> Cc: stable@dpdk.org
>
> Signed-off-by: Raja Zidane <rzidane@nvidia.com>
> ---
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] app/compress-perf: optimize ops pool allocation
2022-02-23 13:33 [PATCH] app/compress-perf: optimize ops pool allocation Raja Zidane
2022-02-24 20:13 ` Zhang, Roy Fan
@ 2022-02-24 20:14 ` Zhang, Roy Fan
2022-03-04 9:33 ` [EXT] " Akhil Goyal
2 siblings, 0 replies; 4+ messages in thread
From: Zhang, Roy Fan @ 2022-02-24 20:14 UTC (permalink / raw)
To: Raja Zidane, dev; +Cc: matan, stable
> -----Original Message-----
> From: Raja Zidane <rzidane@nvidia.com>
> Sent: Wednesday, February 23, 2022 1:33 PM
> To: dev@dpdk.org
> Cc: matan@nvidia.com; stable@dpdk.org
> Subject: [PATCH] app/compress-perf: optimize ops pool allocation
>
> An array of the size of total operations needed for the de/compression is
> reserved for ops while enqueueing, although only first burst_size entries
> of the array are used.
>
> Reduce the size of the array allocated.
>
> Fixes: b68a82425da4 ("app/compress-perf: add performance measurement")
> Cc: stable@dpdk.org
>
> Signed-off-by: Raja Zidane <rzidane@nvidia.com>
> ---
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXT] [PATCH] app/compress-perf: optimize ops pool allocation
2022-02-23 13:33 [PATCH] app/compress-perf: optimize ops pool allocation Raja Zidane
2022-02-24 20:13 ` Zhang, Roy Fan
2022-02-24 20:14 ` Zhang, Roy Fan
@ 2022-03-04 9:33 ` Akhil Goyal
2 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2022-03-04 9:33 UTC (permalink / raw)
To: Raja Zidane, dev; +Cc: matan, stable
> An array of the size of total operations needed for the de/compression is
> reserved for ops while enqueueing, although only first burst_size entries
> of the array are used.
>
> Reduce the size of the array allocated.
>
> Fixes: b68a82425da4 ("app/compress-perf: add performance measurement")
> Cc: stable@dpdk.org
>
> Signed-off-by: Raja Zidane <rzidane@nvidia.com>
> ---
> Acked-by: Matan Azrad matan@nvidia.com
Please use proper syntax for acks
Applied to dpdk-next-crypto
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-04 9:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-23 13:33 [PATCH] app/compress-perf: optimize ops pool allocation Raja Zidane
2022-02-24 20:13 ` Zhang, Roy Fan
2022-02-24 20:14 ` Zhang, Roy Fan
2022-03-04 9:33 ` [EXT] " Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).