From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1DFFA0093; Thu, 23 Jun 2022 10:46:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A5CF4069D; Thu, 23 Jun 2022 10:46:38 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 4C0E54067B for ; Thu, 23 Jun 2022 10:46:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655973996; x=1687509996; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vW3yHhwoL4VI+L5Vc5r2LXUVod7gZtI5hlM+ywNkqCE=; b=CR/R0brmx7CehJlBen1IbkDBPsKXIUyFrqGXXksOd69614MmSFP0ddOG N+Cnnnv5zsQz6EG7PEPWMZQniWN7ywHwNK5QpIywPXAmn3Ef2XcWePalM QBUZIxAxSgNDLj4GgQtZrI80n5nB3Og4pdZXK7aVPjVSAP7kp3CBpZYzG gEI/cwJTGWBLzd2X4V3DCW/6WIm1GcshiUvCCJYKp9ufG/xIwFLQeemMt +wE52hlnJHAVwmnyKst3ULL9HGGJKu8bsP9oKWMuO8tt8fvMXf5/XBAKA PAoY+rS7W+qVCbJ74vvPW7Jxa93OfbBVLXmJaak544Fbtd2ueOab4lnF7 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10386"; a="280711177" X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="280711177" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 01:46:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="656082832" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga004.fm.intel.com with ESMTP; 23 Jun 2022 01:46:35 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 23 Jun 2022 01:46:34 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 23 Jun 2022 01:46:34 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 23 Jun 2022 01:46:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EHPd1yI1khGjn1S6fRVyxhLzX0MsmDQmJ1FFHZKwO4vLv6hhoraTZeLbdICo7Y+r7CSx0f4WG7rMYhEPntg4WjM8Ad6O6ruTWqRKVxr4C7+W4uKIpO9qvRuyygpc2qD5NzAd6WIhBQadK+2yCx5Uxb/K7bmi0kpy0yb2W8Yb+Qq8wOHAKMBvDlamh06CqMS94hv6PfjxZlGp0608h//Pa3FuJPBeeNbudLo+193pzNwbb6LNKxruIfkvikmEl7EmGcNz/EzMhqm240U610rm16xrq7RJFwimQ8YOr4GDEViYQpWSOzNFc1YhXZ7LxrrrHZRFvHRk6Yn2jNV/ZrmjYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TaxBaqN7pVOY7q4/TfXpVNZQiXCb3R+btPYL4MVkdh4=; b=SL079ilFwmCfh+UQFDR3H4USKzFJ34LokyQDKjmtO9upX892X2QPdWAIok8Z1W67HHqJLWPSm4sRF58RFfsftvCQbCisWYplggiW2FXbylgXvXAHf3lg/WcEwwyX0/Y31aRs74Hop7vKqcTvZwqlmMQ0H3edtFxSoxoeqrlBDjxUhzbMAjtfsauLsdIadYNsC1vPmSKz7J5dirU0Uz7/U+ElE6kSDf9//B+S6HVbPZ2pmENdaDMW/PEUHQp8FQGhAUjN3CRfdkgUEW9yQRJvwRNoEnHG+A0P/mOiPoMhfMaTq7ASOrqkwTmaqZg2+nO+vekhg7fRlwne0TnTjWYRnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by DM6PR11MB3497.namprd11.prod.outlook.com (2603:10b6:5:6e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Thu, 23 Jun 2022 08:46:33 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::6537:6de6:7337:1b87]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::6537:6de6:7337:1b87%6]) with mapi id 15.20.5353.016; Thu, 23 Jun 2022 08:46:33 +0000 From: "Zhang, Roy Fan" To: Rahul Bhansali , "dev@dpdk.org" , "Nicolau, Radu" , Akhil Goyal , Ruifeng Wang CC: "jerinj@marvell.com" Subject: RE: [PATCH v2 2/2] examples/ipsec-secgw: add support of NEON with poll mode Thread-Topic: [PATCH v2 2/2] examples/ipsec-secgw: add support of NEON with poll mode Thread-Index: AQHYgh4GVn6tr4fvMk6Fesg0iYWZKa1ctldA Date: Thu, 23 Jun 2022 08:46:32 +0000 Message-ID: References: <20220524095717.3875284-1-rbhansali@marvell.com> <20220617074241.3260496-1-rbhansali@marvell.com> <20220617074241.3260496-2-rbhansali@marvell.com> In-Reply-To: <20220617074241.3260496-2-rbhansali@marvell.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4771ec02-dbbe-43e7-6b64-08da54f4dfd9 x-ms-traffictypediagnostic: DM6PR11MB3497:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: w1MRWjGu9iE/axYESuR8rGqOTIs5gRm66rPzZG185zuhI2zdDw/KDmHhiLCF8mM/vVVd+66zi3rEA2SW28qcSJ05IjH5yKxCv+8kfQVlvR788CUIW4AWGPWuL9WH0ppP5i9sRRtS5eF4cQal8eHGJ1+Nr3fcep6IDW98Xue0dqfQGlJu4jr6sedK5PLlaLeMguHEMzkuvvd4l9yyB13NbGjQS2PQRF8NE9/FKSW4bk3mkVMnIoj9/+YUv9yFaRZDvqOXsOR+RHpznZdUZh3MzQMkiNcYWHLcz3hsSj90pNkAKyXROqklmqGX32YXyYuq83zAyPiFHP+rjl4nuDlKivYubmDl43Gd4im2H67F/55h87c7x1zLfMcwLVdt+smg/3sz9HdTkhwnRVOxCKOERbzOgeI5tUrCMjCKGAfQvI4xSgnrwQJ/TXF7812g8MRP5ZMfVHIZL0heZQ4XkKR+Aa2Bg9e02WAVpLupsSdFFQ0L0IefXo0SpUI8TPuEcmf/VFdSfpWUzh3DTQmhEiOcSFxiwjY80NM+Cg75POdXw0XRHZeXJpmTXn8aOVHQqPLGiZbX8no+XUfZgo1TDSsmjZEcm1ZxyuP8iIaj7f58ji+vLdjm/+xO11CEtVCV6HOSSZr9LpbVUHFBcT1NsvqEjLNW0QNeQEdS2Zm4CyrAJeujybZWQvZYEljxRhAoQwsSWC/wR1YVErR4Sl1GcTs1BZkQoXRh7MwHg65+1SM0GSgxvUSGCAlv/6ngw9RLeylfgwAJgiJ78wbxg8w9Fuffmg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(136003)(376002)(39860400002)(346002)(396003)(26005)(9686003)(82960400001)(53546011)(41300700001)(7696005)(122000001)(186003)(83380400001)(38100700002)(66476007)(8936002)(52536014)(4326008)(66446008)(86362001)(66946007)(110136005)(2906002)(64756008)(6506007)(5660300002)(33656002)(478600001)(38070700005)(55016003)(8676002)(66556008)(316002)(76116006)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?IlrbZjZzRjFb1ukgnWCy3JKL3VX3GzDENrUTGNlcay86QmoC2k6I2LcM?= =?Windows-1252?Q?q4PUCd4N3pHzlG+F6gzzvAgjhZTnCDcN6HnVNwBrDb1Vq0S4VA2SxPqE?= =?Windows-1252?Q?OIhTQsFwUx4U2xrBbcf8BE7oN9BToWg/E5bx9XjNc2hLicGt2aZG67d3?= =?Windows-1252?Q?YqrOeAgxe3foBXV2BbU2eXThEakISHMW2MOrja+scnEpK6OpV/YAlyEm?= =?Windows-1252?Q?UsegU5k6r0HsyOnOVkraIjgVe4DhJTDRL7fTPdwiJ7WfpcHI+641fDXO?= =?Windows-1252?Q?6bE8JRb9jlo97W2a6Ha8d17NfmsdJpG8veC31mE4CE6snGB7tYSTMHPB?= =?Windows-1252?Q?2y+nUQ1vKohWj2FQt6ce4Wx1d86u8dP0a7f46lzodce3+t9Gb/WUS22q?= =?Windows-1252?Q?lBqoJb0h4+IPU+9rV+cAE1IFHCtJJOa07iha2NNLIwfqH50CiA+KQ7Wr?= =?Windows-1252?Q?9bnr39Zfptkkqs/+Mv05hB76eG7Nv5HBKEQatHeXwKs76pwqtTS/xNkW?= =?Windows-1252?Q?y/p5PGEHjHe7oM6Kc+ggIDNE3XiaSukYuMA5D/4sc9wZ453snZVTg3nq?= =?Windows-1252?Q?PJO8Ch9IbHGDTpjYmEIBH42gL1gdBUTwPuZ5wIURuwdNsRwlQpLa9+eP?= =?Windows-1252?Q?R5OReAO/fCWKTUcxRit+6+VpUV+yFieY9pyx6uoWNfUrSOkGWM4PWR90?= =?Windows-1252?Q?axR9O7eNPOmOOiUmLYH43gel4y+kszpe4CkiXLWUcx8PTLjncHFEk58Y?= =?Windows-1252?Q?dq8DUDQKgjlGKDUBqZAFIz80C+ay+PnHX3TbBexG0/zz8ZGRohZdtH9m?= =?Windows-1252?Q?xdoNAe+jUrRmBwJWfEsXCHK5UxB3txKqMmJY39mAm0028XX0PiFEStcm?= =?Windows-1252?Q?Ra5lDIxvwzCjKYnaLSGu1SaZ1WH4gMEykcZkMIOXQidZwBgay40lvozG?= =?Windows-1252?Q?AYJVS8hjPokGGDmM4DtXoaIeWEFHEcB7rGsxC1WU9902en9Vrj/TvA7u?= =?Windows-1252?Q?TjlgpdnHH6YNmXZY62DqkXcNjto9oUyFLdLYBdlogdry1/Mmt58POyfO?= =?Windows-1252?Q?K47+r34jezx/mX3i+JqETp9kUoaIjfWKzGxyUHdSYehNghHV3gjco68f?= =?Windows-1252?Q?jteur015TSWyuOl6MGLSaPcTUi/rNnyMyEYY1dQpE0Zj54pyrZfHGG3y?= =?Windows-1252?Q?cslA3NrAibGLJ4IQ8ZjI93p1xd2TgFA3BHVUuPYznkMUhejIo0fIoku4?= =?Windows-1252?Q?dV/pfgJcz6Qq8bM+7GLkAa2u70d9gw/ehJE2Tc4a0ylo/78tl8g+fACP?= =?Windows-1252?Q?Awd0A/aRoksMCwV+io3Q4W5SdAzjcdbbR0cBrxjtSoo12iz0s5jN7dTW?= =?Windows-1252?Q?7UsS5MD+HghAbB6GHpqG5LWg6wlDCXmPgN2xu09LIpdhOBwhnV+vPt3f?= =?Windows-1252?Q?CnLLnjfc7DaBIr5k7QVbJmOTTGx9cpfsRPqKa2DW6rYzVARQGQ8I/yqE?= =?Windows-1252?Q?u2kcq9jPJ/cXM1hjJihoGiYgKWWAVqhPuuV1Hfco8BWeWOIQXBGvPcUc?= =?Windows-1252?Q?7RrM8hI9ZVa+1Kwh4MiNLDB75Yui8Q12MNr2WfV4DNzlVOH/SIWp4wuI?= =?Windows-1252?Q?HEMYmxMYAuFRmrqk5/RcC0GMgSpadDG1epVmA8XpqRxj9OQnHc2W4PWO?= =?Windows-1252?Q?NyUcb2W4nEJDMBCBOdRcSdlw6Tswk/ni?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4771ec02-dbbe-43e7-6b64-08da54f4dfd9 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2022 08:46:33.0042 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b+vRsg6MuPuKd/RbkjrEOaXx2024Fc/uf9/7OVQIpgOrkYlhZLxgZORoOlJfSwYSy0hG41BLyEtgmk+tZQeZZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3497 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Rahul > -----Original Message----- > From: Rahul Bhansali > Sent: Friday, June 17, 2022 8:43 AM > To: dev@dpdk.org; Nicolau, Radu ; Akhil Goyal > ; Ruifeng Wang > Cc: jerinj@marvell.com; Rahul Bhansali > Subject: [PATCH v2 2/2] examples/ipsec-secgw: add support of NEON with po= ll > mode >=20 > This adds the support of NEON based lpm lookup along with > multi packet processing for burst send in packets routing. >=20 > Performance impact: > On cn10k, with poll mode inline protocol, outbound performance > increased by upto ~8% and inbound performance increased by > upto ~6%. >=20 > Signed-off-by: Rahul Bhansali > --- --snip-- >=20 > static inline void > @@ -1403,6 +1420,8 @@ add_dst_ethaddr(uint16_t port, const struct > rte_ether_addr *addr) > return -EINVAL; >=20 Fan: I failed to understand why do we need to overwrite address to do an ad= dress copy here. Was it a bug? > ethaddr_tbl[port].dst =3D ETHADDR_TO_UINT64(addr); > + rte_ether_addr_copy((struct rte_ether_addr *)ðaddr_tbl[port].dst, > + (struct rte_ether_addr *)(val_eth + port)); > return 0; > } >=20 > @@ -1865,6 +1884,12 @@ port_init(uint16_t portid, uint64_t req_rx_offload= s, > uint64_t req_tx_offloads) > portid, rte_strerror(-ret)); >=20 > ethaddr_tbl[portid].src =3D ETHADDR_TO_UINT64(ðaddr); Fan: Same here=20 > + > + rte_ether_addr_copy((struct rte_ether_addr *)ðaddr_tbl[portid].dst, > + (struct rte_ether_addr *)(val_eth + portid)); > + rte_ether_addr_copy((struct rte_ether_addr *)ðaddr_tbl[portid].src, > + (struct rte_ether_addr *)(val_eth + portid) + 1); > + > print_ethaddr("Address: ", ðaddr); > printf("\n");