From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
To: "Poczatek, Jakub" <jakub.poczatek@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Xia, Chenbo" <chenbo.xia@intel.com>
Subject: RE: [PATCH v3] vhost/crypto: fix build with GCC 12
Date: Wed, 22 Jun 2022 09:26:25 +0000 [thread overview]
Message-ID: <MW5PR11MB5809C3E9C341BC04AB0E3F38B8B29@MW5PR11MB5809.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM4PR11MB54402F0B2FFA91A2F52259908BB29@DM4PR11MB5440.namprd11.prod.outlook.com>
Hi Maxime,
I know it is over Tuesday so we understand you merged the patch already.
But any suggestions? Should we raise a Bugzilla for this problem?
BTW we reverted the patch and the test finished no problem.
Regards,
Fan
> -----Original Message-----
> From: Poczatek, Jakub <jakub.poczatek@intel.com>
> Sent: Wednesday, June 22, 2022 10:02 AM
> To: Maxime Coquelin <maxime.coquelin@redhat.com>; David Marchand
> <david.marchand@redhat.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>
> Subject: RE: [PATCH v3] vhost/crypto: fix build with GCC 12
>
> Hey everyone,
>
> When running a Virtio performance test on a VM using VHost with this patch
> applied,
> VHost gives the following error message:
>
> > VHOST_CONFIG: (/tmp/vhost) read message VHOST_USER_SET_FEATURES
> > VHOST_CONFIG: (/tmp/vhost) negotiated Virtio features: 0x0
> > VHOST_CONFIG: (/tmp/vhost) read message VHOST_USER_SET_MEM_TABLE
> > VHOST_CONFIG: (/tmp/vhost) guest memory region size: 0x80000000
> > VHOST_CONFIG: (/tmp/vhost) guest physical addr: 0x0
> > VHOST_CONFIG: (/tmp/vhost) guest virtual addr: 0x7f17c0000000
> > VHOST_CONFIG: (/tmp/vhost) host virtual addr: 0x7f94c0000000
> > VHOST_CONFIG: (/tmp/vhost) mmap addr : 0x7f94c0000000
> > VHOST_CONFIG: (/tmp/vhost) mmap size : 0x80000000
> > VHOST_CONFIG: (/tmp/vhost) mmap align: 0x40000000
> > VHOST_CONFIG: (/tmp/vhost) mmap off : 0x0
> > VHOST_CONFIG: (/tmp/vhost) read message VHOST_USER_SET_VRING_NUM
> > VHOST_CONFIG: (/tmp/vhost) read message VHOST_USER_SET_VRING_BASE
> > VHOST_CONFIG: (/tmp/vhost) vring base idx:0 last_used_idx:0
> last_avail_idx:0.
> > VHOST_CONFIG: (/tmp/vhost) read message VHOST_USER_SET_VRING_ADDR
> > VHOST_CONFIG: (/tmp/vhost) read message VHOST_USER_SET_VRING_KICK
> > VHOST_CONFIG: (/tmp/vhost) vring kick idx:0 file:37
> > VHOST_CONFIG: (/tmp/vhost) reallocated virtqueue on node 1
> > VHOST_CONFIG: (/tmp/vhost) reallocated device on node 1
> > VHOST_CONFIG: (/tmp/vhost) virtio is now ready for processing.
> > USER1: New Vhost-crypto Device /tmp/vhost, Device ID 0
> > VHOST_CONFIG: (/tmp/vhost) read message VHOST_USER_SET_VRING_CALL
> > VHOST_CONFIG: (/tmp/vhost) vring call idx:0 file:38
> > USER1: [VHOST-Crypto]: Session 1 created for vdev 0.
> > USER1: [VHOST-Crypto]: Incorrect virtio descriptor
> > USER1: [VHOST-Crypto]: Failed to process sym request
> > USER1: [VHOST-Crypto]: Incorrect virtio descriptor
> > USER1: [VHOST-Crypto]: Failed to process sym request
>
> Due to this, performance test hangs and never finishes.
>
> Kind Regards,
> Jakub Poczatek
>
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Tuesday 21 June 2022 10:31
> To: David Marchand <david.marchand@redhat.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>
> Subject: Re: [PATCH v3] vhost/crypto: fix build with GCC 12
>
>
>
> On 6/16/22 16:46, David Marchand wrote:
> > GCC 12 raises the following warning:
> >
> > In file included from ../lib/mempool/rte_mempool.h:46,
> > from ../lib/mbuf/rte_mbuf.h:38,
> > from ../lib/vhost/vhost_crypto.c:7:
> > ../lib/vhost/vhost_crypto.c: In function ‘rte_vhost_crypto_fetch_requests’:
> > ../lib/eal/x86/include/rte_memcpy.h:371:9: warning: array subscript 1 is
> > outside array bounds of ‘struct virtio_crypto_op_data_req[1]’
> > [-Warray-bounds]
> > 371 | rte_mov32((uint8_t *)dst + 3 * 32, (const uint8_t *)src + 3 * 32);
> > |
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > ../lib/vhost/vhost_crypto.c:1178:42: note: while referencing ‘req’
> > 1178 | struct virtio_crypto_op_data_req req;
> > | ^~~
> >
> > Split this function and separate the per descriptor copy.
> > This makes the code clearer, and the compiler happier.
> >
> > Note: logs for errors have been moved to callers to avoid duplicates.
> >
> > Fixes: 3c79609fda7c ("vhost/crypto: handle virtually non-contiguous buffers")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > Changes since v2:
> > - fixed 32-bits build,
> >
> > Changes since v1:
> > - refactored copy function,
> >
> > ---
> > lib/vhost/vhost_crypto.c | 123 +++++++++++++++------------------------
> > 1 file changed, 46 insertions(+), 77 deletions(-)
> >
>
> Applied to dpdk-next-virtio/main.
>
> Thanks,
> Maxime
next prev parent reply other threads:[~2022-06-22 9:26 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 10:16 [PATCH 00/12] Fix compilation with gcc 12 David Marchand
2022-05-18 10:16 ` [PATCH 01/12] common/cpt: fix build with GCC 12 David Marchand
2022-05-20 20:23 ` Stephen Hemminger
2022-06-10 13:11 ` David Marchand
2022-06-13 11:40 ` [EXT] " Ankur Dwivedi
2022-06-16 9:30 ` David Marchand
2022-06-16 11:59 ` Ankur Dwivedi
2022-05-18 10:16 ` [PATCH 02/12] crypto/cnxk: " David Marchand
2022-05-20 20:24 ` Stephen Hemminger
2022-05-18 10:16 ` [PATCH 03/12] crypto/ipsec_mb: " David Marchand
2022-06-02 9:50 ` Bruce Richardson
2022-06-10 13:07 ` David Marchand
2022-06-11 15:34 ` Stephen Hemminger
2022-05-18 10:16 ` [PATCH 04/12] net/ena: " David Marchand
2022-05-20 20:28 ` Stephen Hemminger
2022-05-21 9:49 ` Morten Brørup
2022-05-21 16:23 ` Stephen Hemminger
2022-05-22 20:30 ` Morten Brørup
2022-06-11 15:34 ` Stephen Hemminger
2022-05-18 10:16 ` [PATCH 05/12] net/enetfec: " David Marchand
2022-06-10 13:08 ` David Marchand
2022-06-13 5:22 ` Sachin Saxena (OSS)
2022-06-14 8:16 ` Sachin Saxena (OSS)
2022-06-11 15:35 ` Stephen Hemminger
2022-05-18 10:16 ` [PATCH 06/12] net/ice: " David Marchand
2022-06-11 15:36 ` Stephen Hemminger
2022-05-18 10:16 ` [PATCH 07/12] net/ice/base: " David Marchand
2022-05-18 10:16 ` [PATCH 08/12] net/qede/base: " David Marchand
2022-05-20 20:29 ` Stephen Hemminger
2022-06-21 23:17 ` Stephen Hemminger
2022-06-22 15:42 ` David Marchand
2022-05-18 10:16 ` [PATCH 09/12] vdpa/ifc: " David Marchand
2022-05-18 11:48 ` Wang, Xiao W
2022-06-11 15:36 ` Stephen Hemminger
2022-05-18 10:16 ` [PATCH 10/12] vhost/crypto: " David Marchand
2022-06-02 10:08 ` Bruce Richardson
2022-06-14 9:22 ` David Marchand
2022-06-14 9:25 ` Bruce Richardson
2022-06-16 9:27 ` David Marchand
2022-06-11 15:36 ` Stephen Hemminger
2022-06-16 9:32 ` [PATCH v2] " David Marchand
2022-06-16 14:53 ` David Marchand
2022-05-18 10:16 ` [PATCH 11/12] app/flow-perf: " David Marchand
2022-06-02 10:21 ` Bruce Richardson
2022-06-08 9:03 ` Wisam Monther
2022-06-08 12:20 ` David Marchand
2022-06-13 7:49 ` Wisam Monther
2022-06-11 15:37 ` Stephen Hemminger
2022-05-18 10:16 ` [PATCH 12/12] test/ipsec: " David Marchand
2022-06-02 18:41 ` Medvedkin, Vladimir
2022-06-03 7:45 ` David Marchand
2022-06-03 7:56 ` Bruce Richardson
2022-06-03 9:41 ` David Marchand
2022-06-03 15:57 ` Medvedkin, Vladimir
2022-06-11 15:38 ` Stephen Hemminger
2022-06-16 9:33 ` [PATCH v2] " David Marchand
2022-06-17 12:06 ` David Marchand
2022-06-20 9:07 ` [EXT] " Akhil Goyal
2022-06-20 15:06 ` Medvedkin, Vladimir
2022-06-16 14:46 ` [PATCH v3] vhost/crypto: " David Marchand
2022-06-17 13:59 ` Maxime Coquelin
2022-06-21 9:31 ` Maxime Coquelin
2022-06-22 9:01 ` Poczatek, Jakub
2022-06-22 9:26 ` Zhang, Roy Fan [this message]
2022-06-22 14:07 ` David Marchand
2022-06-22 15:21 ` Poczatek, Jakub
2022-06-22 15:31 ` David Marchand
2022-05-20 20:13 ` [PATCH 00/12] Fix compilation with gcc 12 Stephen Hemminger
2022-05-21 9:39 ` Morten Brørup
2022-06-15 8:49 ` David Marchand
2022-06-15 14:45 ` Stephen Hemminger
2022-06-15 14:59 ` Thomas Monjalon
2022-06-15 15:15 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW5PR11MB5809C3E9C341BC04AB0E3F38B8B29@MW5PR11MB5809.namprd11.prod.outlook.com \
--to=roy.fan.zhang@intel.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jakub.poczatek@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).