From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E12FA0032; Thu, 16 Dec 2021 16:05:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31B7441104; Thu, 16 Dec 2021 16:05:31 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 8998A40696; Thu, 16 Dec 2021 16:05:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639667129; x=1671203129; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=tFfC6796E/F0qEBmkgugf7blsAghw0+yb8gMV0m/raY=; b=QR05CHExa8Qj1bXeyPnprfMyZGcp2WcS5swovmk7IDwtsb8eJKc9dWJA Kg4y77QzbHIRjtWMVJBLEh/FCoJwt9ac+CH3Ni3If0KeVlK0u9Xmydhbz OyhzW7n79ha0jeqyKWniqf/T7qpdlUuN9E5k66uhnbbeAaWTNXmPOWAhv pL5/5K1M3iqU0yaPY2Hxw4b0Tb8fQJqOsU/nZdIBi5vDP+Vd8njZSBjzh NOByF2ZYJGCBzwySSq5RUS82TG61cQW0BqHQ/wxXsLwtYi+wXGzw2HfCg O0+JO0vEdS8+kp0e706FALo8cr4mc92rRzhAszMh8wpiIYVhWwnLH0JYW g==; X-IronPort-AV: E=McAfee;i="6200,9189,10199"; a="263677206" X-IronPort-AV: E=Sophos;i="5.88,211,1635231600"; d="scan'208";a="263677206" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2021 07:03:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,211,1635231600"; d="scan'208";a="520300824" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 16 Dec 2021 07:03:48 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 16 Dec 2021 07:03:48 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 16 Dec 2021 07:03:48 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 16 Dec 2021 07:03:48 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 16 Dec 2021 07:03:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Msc0ztAyFhTN7DO9Eq2zaNMOTwptQO7GdtM+rAb6LesYWtKDJQtp/Rj0kSE3vXO/O4RnF/6Krr6fnsFH8CB3F0xvGa7Th4fq4i7r63BW7UuVhFQWUwJ5dLRoHnMeDKSYZ6JHO+BueU7X57UAhwey2CZrmIDZ8WhpoEGQxh0tZ4jkPzkwcCFxliAK7k1x/8FG2UeinNt2EWuwkFjwRWypOheGo3sxRfE6i+T/OqkcJEUXfhvwTBFbCVaRK1mAdp6RE0H01YPH9ajRmioemTuYVZCmvRgGppCRYI/+tX3zKFaxiXkjLQ0ueFWDOLrz07EP5ugmh6w5UwK+RVaSKxElTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tFfC6796E/F0qEBmkgugf7blsAghw0+yb8gMV0m/raY=; b=aLYPJFcLBE4VrfnnfQrNdJTLZEcuXy4bZqdPAJddNgoaPxURuQVaFS9/XDiAEXrJOFWcW/fUH3Y3DlSuOxBTr/bCM6Mx/7ATkbfA1f3p0K7nXj9SBcwVAllJcBOmj+vdw7dIvtLVl/al152T5t+HOIEKpTIaRq3uHaE0KqQWcCCWeufmCQcblYmS7wn846/zqeZPzl/tbzccBRDCiKNEi6PIbySluiQLvdX7awEJUZlk5rWipiPCxiHOnnRX/Dy81zZfIg2SMb1Kl9GJvZDyEvW20QHMBggjDop/3dvQdqadfcLUZrwBMYvmUQVXxrlwL28qTNikeaLLCMbCUPZirQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by CO1PR11MB4994.namprd11.prod.outlook.com (2603:10b6:303:91::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Thu, 16 Dec 2021 15:03:45 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::6044:ba49:2592:68c5]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::6044:ba49:2592:68c5%2]) with mapi id 15.20.4778.017; Thu, 16 Dec 2021 15:03:45 +0000 From: "Zhang, Roy Fan" To: "Power, Ciara" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Mcnamara, John" , "Bronowski, PiotrX" , "De Lara Guarch, Pablo" Subject: RE: [PATCH 3/3] crypto/ipsec_mb: fix tainted data for session Thread-Topic: [PATCH 3/3] crypto/ipsec_mb: fix tainted data for session Thread-Index: AQHX7c+q50eSJuuZTUiryvSCA+Ag86w1QJCQ Date: Thu, 16 Dec 2021 15:03:45 +0000 Message-ID: References: <20211210140952.2907974-1-ciara.power@intel.com> <20211210140952.2907974-3-ciara.power@intel.com> In-Reply-To: <20211210140952.2907974-3-ciara.power@intel.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0e407276-735d-41f4-1d5d-08d9c0a541c1 x-ms-traffictypediagnostic: CO1PR11MB4994:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3w7qEU7e8uRqWQgh6atVksJ4V+3CSZ3J8ou73R86ep9jxyzIsMfa+r6n8YoFfmsKHvxMJGvertTu8idPB3G+QQWK6mN8o092K2KVqrilJKnIM7HQlIy7iVGTTEDrTbZspgf5gwYFXF/4NduUpeF8C75n8tzdHxwcKyC8a2Vsc7oaAag5spL2w3eSfMVmnSPDEaWYfqHLXJCxmQ4qh37gwassJsb7WrMr707Np5ZtrxXeoQ3acKB2OClonTudXMRxJpyEYu/evcdqbIFWKPLEEcHR0+0NFpy0YafF+qzLp3g24IDw1MqIUFvJuGWlyRQUw9RmrykFGt1Wcq2QaqlfGXk3ZWnwrTpnL4o9p7H7n2MvQCRu0UqQw/YaIZcw3a5zcA+yuZiM+uQSdTbby3lishnU166ruJKFlCpK4yoIy9zLGkqRSRVQCIdp7eiC3i7edShxSZJm/Cm7h1BE7ajWcis3IX/RWPaKMm/Em16M3xrw3MnX+a3lHUP/pXptnBAYNmw/GC/NjDUHNP5TqIJK6ZnQQByRlaVglmBx8vUG+JNKFK2ZpeECtpAEIOEMW4ZNh7c0Rr34uVnJD8Ww9QtkOLzwRe5rdC+tX7dnpFyvhkav/9E9/1EjABUPwezs+C5z7ZQeLLjAjIxZ7RzixTqNC2wRKjgsp/Q3eUteFafwR/F2kiqlaOaKF9idcWUATX/DTf+6ejw9iXqWLtGuBl1eDw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(55016003)(316002)(122000001)(66446008)(4744005)(66476007)(38070700005)(186003)(508600001)(66946007)(8676002)(8936002)(71200400001)(6506007)(53546011)(64756008)(66556008)(83380400001)(26005)(4326008)(7696005)(38100700002)(76116006)(54906003)(2906002)(5660300002)(86362001)(107886003)(450100002)(52536014)(110136005)(9686003)(33656002)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?VFiegFBPwHRKPEt7EIg6mUESE45vbb7Deef8nmKhfq7EfBLrKcVEs6Oo?= =?Windows-1252?Q?Vc+BavgCwDZW5U8bO7+HSA098C7TfCZ1s23qevyEh5tHShbPTSXAxe17?= =?Windows-1252?Q?EoFg6lxfxGCw3iQOmTPvKzpHDeucEw6MFaUaGWWg9+2Lcm1P4y7SRBbw?= =?Windows-1252?Q?CQeJchrcdTVCzWEi85WOBijjwyanY0+dBtZkLwd7nhhyK9OfsxFK+3hH?= =?Windows-1252?Q?Lhnty7EAMHEIOspDVhHL3DJe/XoOQp3U+eNFyYvJ4XiaM14VIykvQtcK?= =?Windows-1252?Q?hGPQoLljFtGF8yp5nj7S1krQd3Zjxy+MhYVMXrySdMZfXgdpFUt2VBJS?= =?Windows-1252?Q?al5csrTgbdqmvKzGGguviGjM7s344hIaqYOA8PAbd19cID3p5+nnG09I?= =?Windows-1252?Q?Rlriotz8B0Fnlr/iRXy8nHLDrbUekuO+OE10mJ1AlGTC4hSHjLu/moVA?= =?Windows-1252?Q?IT8FPpOl9DOcmhJGfxy+i4ZKTx7NqmiW4x/sUMtcygzI+PUgaoAdMbdC?= =?Windows-1252?Q?oDxXO01qTGnoEnVDw2l0DYUZwUv//F+Ehd1iuC2ul3R3ac3xzZfzpWLp?= =?Windows-1252?Q?m6rKx4JLx0adNM47AY3iJQIuy5liRA54bbywMQkv67F8lLAerN26Tiu4?= =?Windows-1252?Q?bJ6L15om3U0OremxryB0OSh4DBsYj+iOqHtAfr+4C+eW3k2tP/nZcHmV?= =?Windows-1252?Q?j3c+3jeQmCB7HD9tKIznjPBg0GwrnN6hMXeSHdrW4onlYWkOyTRHynEx?= =?Windows-1252?Q?VkrR+mmZGiF+Ub57kUY/IrG3HtAWFp9M8VFWyLmef/iyDjOiB0EcMwmQ?= =?Windows-1252?Q?/NkFbu526JMd0k1BopYjYnWIEcSw8Nu4a5rEXvU20OFHzeux6oKQJ6ck?= =?Windows-1252?Q?WYEFuocsHUYZpM64LVm9hFqP/1HPFYYj8yXt4bpprYVUd3jCqXukZ7rP?= =?Windows-1252?Q?+/kjZk6/mE8v5Nck3Nq1jl+VI8cdyhpVIO3GPcgUDu6XWqrCuwOeLD4M?= =?Windows-1252?Q?yV2Jb7MP/i2dqTavzIKZ6chlQSYORX/RK3N1POUrwf/KyhcXutHYb/4D?= =?Windows-1252?Q?F9+d1/lHyVfs5WKDyD8wq+ndD4s+UjtR3sZ378GGc4T6pFzJpecPEIED?= =?Windows-1252?Q?oYAyZhwU3fkjrsWGT6s7X4VIBdO7BMcwR2eO+YI18U03TFdKSymQMwqP?= =?Windows-1252?Q?OHa53kB93x/GRKZf0vl4kbdYxXWVdrHWhs+97uoDnyX2Sel/+NUB9Lh2?= =?Windows-1252?Q?lhhSq5PqbPHkowqIrB81ewipoa9DukfUC66SncmbKsuGTCtlpKe+tDE2?= =?Windows-1252?Q?rdQUjuTjTlEIv3F8rNSPxlcbGR6xPDlbZUpzOaLlt3kPkegq2FbkUfzr?= =?Windows-1252?Q?sB/nYqe/myuvFD15tPJ4gqVzWEyRsJ+lyxkR2s22WFZTdAX7fqyXglEG?= =?Windows-1252?Q?NIvC/LmM2KMnam0Q63GMbkCT0QFELeT8RYQ/g5xNPujkCbfSwSb0z+AK?= =?Windows-1252?Q?VuUjd0Wp0XjqCB+wiWn99+bMDPLE6vko2/AT7+JO/c5v/52Q5xPV2ER3?= =?Windows-1252?Q?7ZrbgI9ZINGBJG0i4lT/0zHfCDTYM+kIc3JULIsm0M7HkRNrpIaayVcs?= =?Windows-1252?Q?iKpgeFa8wE7hatkpKNC+GfwbYMYHFSeHSnSFc65AjhVrmL+KUvaSsaAh?= =?Windows-1252?Q?AqxTANWZ2nKIPTruVe/nquWJw2+sOYPErVrGEaMhsgxrIHY4xUaVgwD9?= =?Windows-1252?Q?seY/gajGcaftNxPw6/k=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e407276-735d-41f4-1d5d-08d9c0a541c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2021 15:03:45.4010 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7IpYiIuXSvWC0eEXt90X66XL5/J94S16t0+W8YxKWbl9iySta7YPXNMAwUIwl0LlMfyeMzxCVqcnxgOZxfjONA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4994 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Power, Ciara > Sent: Friday, December 10, 2021 2:10 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Mcnamara, John ; Zhang, > Roy Fan ; Power, Ciara ; > Bronowski, PiotrX ; De Lara Guarch, Pablo > > Subject: [PATCH 3/3] crypto/ipsec_mb: fix tainted data for session >=20 > Downcasting a void * to struct aesni_gcm_session * caused the session > data to be treated as tainted. > Removing the void * temporary variable and adding a cast avoids this > issue. >=20 > Coverity issue: 374377 > Fixes: 746825e5c0ea ("crypto/ipsec_mb: move aesni_gcm PMD") > Cc: piotrx.bronowski@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Ciara Power > --- Acked-by: Fan Zhang