From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B42BEA0503; Thu, 19 May 2022 11:14:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BE9540150; Thu, 19 May 2022 11:14:28 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 601CB40140 for ; Thu, 19 May 2022 11:14:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652951666; x=1684487666; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2FJC1aTKeTURbylcLeP7g8j4FF4hUxU/ZrehueP2qWY=; b=RR3gVjdFbKU7xWdBHPfsudRr+nNxSxmD9cyC8l15yj/IcKgW2fI/jJAC n1A1DbaoZnJyh6tS0k1QBIaZ5xEqdHC32xZG2WzqJyPhBstMoDOTBedQv 3C2BSBFtzjJg1UFvKF+kJB9a5ON/6714RIJ9HpkVaQZdhx+Wm/8lTCS+G wGNDYiu42wSlBycTte2VoX7ov/a/rW5VTqBIjts99BO5PdO7MpnXhnlcJ e/QI74MMOiO51sixEXAzS0KnwGmgogP7dbcAHdh5j+o1HTd9ZoDdynzTu uzoY9sWgRASxIDyZyhNjmL1ArMqZxAoiYyYuU719O0X9xO1C1OZR6GDXm g==; X-IronPort-AV: E=McAfee;i="6400,9594,10351"; a="252005895" X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="252005895" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 02:14:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="570105393" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 19 May 2022 02:14:17 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 02:14:17 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 19 May 2022 02:14:17 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 19 May 2022 02:14:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HL6BGdFQ2BI2/wa+KqPnWLI4wOzF0lNRI4m2JgA4w+V5Zhyz+7ajDd1k+/BdBLytOMZXNGSHmmSlYA4xU7tHPTjBt+239Ze71Wr0aTeUs/gkAaGZOeBz/92xijQe2aoX1hQsX6/xPgruMcUTTdMqS4oEo1VGQW/U02cAIjeU8A43t+/JHQjSqC91bbm9f748C1g2K0rEHDHvj3OL/C4+GlUbCLK+sMlstQbhwZs+ata3F0NLJYzU07WccyivqtExyBlTAXEaVrB5SRvneyN+indDkLAoiW2fiqXtk7nAxIbxHzgSXnUrO3tKCTuf8l5rqOyUHh7Z4+WsJK6lh2XPjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VFXrsFOOXV6xCVowI1GIO0cEgj1xoBRkOdjWAmas4dM=; b=EUa3jIlkYul+Gi5QSrqjxg4Wsdc5OLhlOMgDF3jU6lRLopaCzUGI7YjRJs8cBU1zXdoxEwGOC3Kux3x4YTjtnnABoQP9ZPELTY7mK3JrrWfu7g//fctuKWlTk5wXk2mrLr0tUTNnzqAPWXLUOApkObts8EPFd6nfzSPgIpWFdAZ9NeGmL+rF9XgM23vKaQrqZmln/P9EHt+o6FbuhddyQmzX++EYpwCwctAYWrT5tyi8gqopXg96RV5VsOOfps1BAKgqW9ks0H657CYT/tra5sMb2830fQYxjIXaREdNtUGiEnn097IcWAUHNoz1F09qivQuMglSZoTvhHL1t2Lrtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by DM6PR11MB4234.namprd11.prod.outlook.com (2603:10b6:5:1dc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Thu, 19 May 2022 09:14:15 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::b9ba:9827:9cbd:9f37]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::b9ba:9827:9cbd:9f37%5]) with mapi id 15.20.5273.014; Thu, 19 May 2022 09:14:15 +0000 From: "Zhang, Roy Fan" To: "Richardson, Bruce" , Ferruh Yigit CC: "Ji, Kai" , "dev@dpdk.org" Subject: RE: [dpdk-dev v2 1/2] build: add in option for qat use intel ipsec-mb lib Thread-Topic: [dpdk-dev v2 1/2] build: add in option for qat use intel ipsec-mb lib Thread-Index: AQHYafjrqItVlHeRmEyyIVp3gjwCU60kR/uAgAAniYCAAAHgAIABebeQ Date: Thu, 19 May 2022 09:14:14 +0000 Message-ID: References: <20220407152931.8771-1-roy.fan.zhang@intel.com> <20220517141652.53769-1-kai.ji@intel.com> In-Reply-To: Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dc41691e-d9dc-4100-567d-08da3977f1fe x-ms-traffictypediagnostic: DM6PR11MB4234:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jOTpUpokkXgli7sCZJ3RniIJeLVO7q6e0FjoJpquUPDiQmMfszG0s4ERVd0/bFT4jADbP9QAEC4yCWyDOg5VvXLh3787x6ZtEkUtnVRusfCVc29YY0hwyXEDi62HZk2FS/ZMX0YPHXNCI6K//yu3tQH7HtgOzQemIyVVMX1SCN8sWyBt4vZHr7hsqIrSOdLS3SFbEz2gc/9l5YmMKKB7XiHHvsXKj1B+9fhSp7Zvy88PKtVepHmA7iVDuXgBKjS3flwNgK6GJ3ZgNA+hXypoTzLTD6t2epmotx0t1zRugPY3wUCvx1uv76D/0zPUcCrTrHjbF976JWnb0xYU0jScrOHWC/LAAthma0ogVCFSnquiS2+Pv5axKRj3CS31q1rLZVcmowCtcknR/Az1IS8C6Vtz3z1ymOiO/6eX/4OhcLA1/ifHeyVQ18sO7IPFvkVMV7tDKorDYkTQ/Vxu9K/UAba0pfq2lSFqpdCDYckGULMGssrcIsf8apft13YBymgJvzlH8m0V8d3mHB4Met5vub8iK49QmnL5K8+yb5ldYZK4J8qW5Jm/2wB4iUptj/JDRd7GwAjswWZIH/u37a3UqboU6s1BT60liIIt6NrEz6UAg0tP1+lVFKNg7k9IMyygodH7MfSu+bPT7sijviKHDVJbq15T4M21MkPl0jeyBFXkdFANcAPWN9wJ/dL1xjrj8j8Kn9gE+WHsQab8O/7dvw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(83380400001)(186003)(316002)(4326008)(8676002)(7696005)(33656002)(6506007)(52536014)(8936002)(9686003)(26005)(53546011)(66476007)(66446008)(64756008)(55016003)(54906003)(5660300002)(508600001)(38070700005)(38100700002)(110136005)(66946007)(76116006)(66556008)(122000001)(82960400001)(86362001)(71200400001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?XCg0hJUOisFBVRxyqp6SnKk7qTclbR0Yub4Gaj9trN79wsnXOSJN/dZd?= =?Windows-1252?Q?SzdOb3J0R8txAKUTEERx4QUoKLsaabg0lRKWDYV+/Ut8CMsxrvF29U9O?= =?Windows-1252?Q?T9z3IgM+4VQLBHbiKbJZXx6HnC97amQOPrqo2UiLrdLowAe6EUAdss+t?= =?Windows-1252?Q?Spu+CcKH/ajwYXLcSx2zNIa5yUhSDWQJaUDhI3McnPgtf6Og4ec63qLC?= =?Windows-1252?Q?K1SdeGzO6WzwlkEcEm4VGW+JFY2JW8o7BssrrkP7Yn6s1v2O2Rc6CeM3?= =?Windows-1252?Q?QLRSy94aWIgeKWJRp6H9Sle25B2lqSDQ6816DzPAJlYzlkS0MWqM/yx9?= =?Windows-1252?Q?SQhilFpV8krXbZ+7GJwkIVq2U0FJdwMxdI5s2e+vkUYr0SVPh/QkMHbT?= =?Windows-1252?Q?6grFHj+BIqoZymZYJMZCecXNOHUGwYv+ywWfuaavTT3PW2DIev3fxhmd?= =?Windows-1252?Q?L896jeoPWbkMjQpzQr04vJGB0f9Ju3a8UHUyw0QFypUBwfy0p9P+jfVg?= =?Windows-1252?Q?51hjWl+7CjiB5SwONITyXLzoD7RZ+jC9FmGDqf/+r871FUqwXrxf8ZBl?= =?Windows-1252?Q?HsEGDvaMvoMSzU5Pq6FSoH9jiCJe2iU059Q68mAdvgfOM4IQjA1W9rnT?= =?Windows-1252?Q?Jl/+drwXdU8aZpDSvx0yKCQFqFjgt7tjuuAgFui5o7sbPQWlMBRRQKn1?= =?Windows-1252?Q?ZK8xI1KNfD3uDt2wJdIXH/tsVYkOilmvi65Xj4Wc9oiR600whNspTH3x?= =?Windows-1252?Q?PczCjU7tcNptSWEuSDkYx23eUKZi0n4YoGNYPPKOuZoWoDVdUobO5Iuz?= =?Windows-1252?Q?6FvXdX0pqQBZTEU6xRaXTpHYkPkTQ/tNyG1nYXJky8SzoKn8ubDyoWYG?= =?Windows-1252?Q?8LN5URsSwH9HCRc1utEjsEwXEblqNmpYNWGrh/DRYQntfovnyqorSQhp?= =?Windows-1252?Q?FYvEcnR/SCj7Q51d3AdT30dvQZ8mAycyRy59UUjiUy4h19f7w+0h7QRy?= =?Windows-1252?Q?KZiBgCG0tAHTSwrRusUjxxTyFlIpYu6SpsNbizHNv/l+O1g7ExcOc0Sm?= =?Windows-1252?Q?OmA9Jy/BGCU4H8e/bwDW73ROK9HXJQyDCtOaEH7VHkToGyIRgWrJ/Jvx?= =?Windows-1252?Q?Xl91C0lC69o4fzk/FFqj+N+SXeat58bS5ih/zLNSsZgk5rBzNxL2/iJT?= =?Windows-1252?Q?W6NLIWzC2hpYSrE3cTBhndjcwykiJKKWPjCRjGH/YV8r/D2jN07bSKwL?= =?Windows-1252?Q?9Dk689Xq4lzH3kLKBzZgKsTMc0O+qwYBZmGfLkPTCWQu1zOIOOMAxmSP?= =?Windows-1252?Q?weBj8XQSi8kCpIK5CBKXkTuPyS+YP9Gs7PUpC6VczyJA5YnvfqqqSQ5v?= =?Windows-1252?Q?fJq7H0F57pL0U0UeIbfu/0bTNPziiE+rP/QNwgRC24cj5hsLQcSwyzTr?= =?Windows-1252?Q?GlQM2NCDPiPlBZ1toKgq7gtaOWgEcmo5vDi36Em240i6oNIlboEDO8wc?= =?Windows-1252?Q?VA13V4zICycqErQ5MbF2AZO9gZ8JnMHLf3/cNggponNM2VvZh3XfQua9?= =?Windows-1252?Q?//5Z+/xryqqcW9ekJzcW90zZm0f3K3RYJsJ48ogmyYRvbZ90srdCcs4p?= =?Windows-1252?Q?kjI9udFZE8RBX/E3ksZjCbDuYbfeNXUGm1lmj2yxiTPDFtV8K+eoWRkE?= =?Windows-1252?Q?VnyIQkNO3NVOQaIz2Ikq91iamyjzABvYX8ei5/EwqBbBaj7sFUre3u6u?= =?Windows-1252?Q?l6w1YvcEi1+uvhNX5VQrVXykoqbJ1bmdae4MiwBy5kEM1RSm/Hwx0mXs?= =?Windows-1252?Q?TxOnfATojybWg2Mh6Hrpd0wKjDbTX4YsNy72CgVRyqQbo9rsGIeMCExY?= =?Windows-1252?Q?7b27m6YPa1/4DQ=3D=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc41691e-d9dc-4100-567d-08da3977f1fe X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2022 09:14:14.9590 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ydny1I86PyCgXasFBE+OVcV/TJ8e88Oa2BBzS9TAGTVKzkQxDR8uSlLlaUuk0b0SOjxqtR4nnZ9bJ1JoPrgzMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4234 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Richardson, Bruce > Sent: Wednesday, May 18, 2022 11:33 AM > To: Ferruh Yigit > Cc: Ji, Kai ; dev@dpdk.org; Zhang, Roy Fan > > Subject: Re: [dpdk-dev v2 1/2] build: add in option for qat use intel ips= ec-mb > lib >=20 > On Wed, May 18, 2022 at 11:26:27AM +0100, Ferruh Yigit wrote: > > On 5/18/2022 9:04 AM, Bruce Richardson wrote: > > > On Tue, May 17, 2022 at 10:16:51PM +0800, Kai Ji wrote: > > > > Add in build option for QAT pmd use intel ipsec-mb lib > > > > instead openssl for precompute partial hash & aes. > > > > > > > > Signed-off-by: Kai Ji > > > > --- > > > > drivers/common/qat/meson.build | 12 ++++++++++++ > > > > meson_options.txt | 2 ++ > > > > 2 files changed, 14 insertions(+) > > > > > > > > diff --git a/drivers/common/qat/meson.build > b/drivers/common/qat/meson.build > > > > index b7027f3164..d6eaff3e0e 100644 > > > > --- a/drivers/common/qat/meson.build > > > > +++ b/drivers/common/qat/meson.build > > > > @@ -35,6 +35,18 @@ if qat_crypto and not libcrypto.found() > > > > 'missing dependency, libcrypto') > > > > endif > > > > +if get_option('qat_libipsecmb') > > > > + IMB_required_ver =3D '1.0.0' > > > > + libipsecmb =3D cc.find_library('IPSec_MB', required: false) > > > > + if not lib.found() > > > > + build =3D false > > > > + reason =3D 'missing dependency, "libIPSec_MB"' > > > > + else > > > > + ext_deps +=3D libipsecmb > > > > + dpdk_conf.set('RTE_QAT_LIBIPSECMB', true) > > > > + endif > > > > +endif > > > > + > > > > > > In general it's not a good idea for individual drivers to add top-lev= el > > > meson.build options. If every driver does this for all its options we= will > > > have an unmanageable set of hundreds of options. Unfortunately, > though, I > > > don't see a really good way to replace this with something other than= a > > > build option - I assume it's not just good enough to check which of t= he > > > dependencies is found/not-found? Is there some way that this can be a > > > generic option, that may be applicable to other drivers? Could the op= tion > > > be instead to prioritize FIPs compatibility? > > > > > > > +1 to not have top level meson option for a driver. > > > > Will it work to give priority to intel-ipsec-mb lib, like when ipsec-mb > > library exists use it, else use openssl? >=20 > Looking at the patch a bit more, is there a reason why this cannot be mad= e > a run-time option when both libraries are available? Hi Bruce, Thanks for the review. Are you suggesting adding a EAL option to the QAT PMD? Regards, Fan