From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AEFF0A0C43; Wed, 20 Oct 2021 14:43:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DCDF4118F; Wed, 20 Oct 2021 14:43:24 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id B270340142 for ; Wed, 20 Oct 2021 14:43:22 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10142"; a="215933700" X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; d="scan'208";a="215933700" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2021 05:43:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; d="scan'208";a="444922271" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga003.jf.intel.com with ESMTP; 20 Oct 2021 05:43:21 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 20 Oct 2021 05:43:21 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 20 Oct 2021 05:43:21 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 20 Oct 2021 05:43:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e9NTHH+eri9DFCRN/uEyD/ukZFGMJyjbHa6l3oh8Z2UQf3sL4QMKU+W7/4dk3YGjjQ2Bfwvmma8HLVAXgmtnWGAACdC6KvJ6ZgDRicEv1ZQvIxda65lOHMygtu3P47mxLgc21c3jdCcQiD1H2p1DSjuibH2a3PolrZdPZRCOfs8v079XItLX9JNfD1Gq/nVF0sOthG0LPUPHIulXh1s0v07e0/KsZCNU5qUwc69e10RxiCsLdML1HiNIy/Ne7aEZwoJK2Sy1ZXxt8EgIlFTgaDxe8ukOZGRWosMLEXmtRM36FaILyMeIwmOlGcT2NL7upasXGpwhpLqNKP0fLRWgvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HAqT1bpObPQzpCNCmnmrL+xlQYeVJL16jfvs7SyqsjU=; b=m0NJQqj3FAMbVIyv7wUjMyI/ksRkGTonDmME8XDBLtQydJAfmwfs4AAXnSnJMAy+bLGaS7u1NLETL4CXlGXgO+PRd8nGET0v9VMKDZHiaGhpzcHslwg3B8G37DbQP0vM44Dl3AsnNz28BV7eo1p2dy3HJrcJgo+Fk6J7toegN0JN0XFe7Zi04hMx97C1dl9WMCCQltLJV1pX3p8LX7nwYgsnK2Vk72ECPnjki5gDZhgY1x79G77NcIeTL0Mbmb7RKAk4ON8hKTQmt5kRVT+mCAHOBUOggBgh9cZYsDkc4o4rOG8hpA4ZH4qQGhPsUVgW+8hE1KGTkeqrIFYIO1j2FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HAqT1bpObPQzpCNCmnmrL+xlQYeVJL16jfvs7SyqsjU=; b=eB+VfGZCqc2dXyG67Z8M2zszhFgD+Csw2q8pJ+mjg9ms8fgKzZKewANU2A1Sd+CgQgmKgpY5kBM3IAiJ856wYhZWeOtyUDIxaf6fB/FONBbx6qUcM02FxcHM1MAm4+Tzj3QuBOh97Ho9LoUv467rEwg2genby5zKRNU+Lm/d5Hc= Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by MWHPR11MB1599.namprd11.prod.outlook.com (2603:10b6:301:e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Wed, 20 Oct 2021 12:43:10 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::2c31:1470:3036:959b]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::2c31:1470:3036:959b%8]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021 12:43:10 +0000 From: "Zhang, Roy Fan" To: Thomas Monjalon , Gagandeep Singh , Hemant Agrawal , Akhil Goyal CC: "dev@dpdk.org" , "Ananyev, Konstantin" , "aconole@redhat.com" , "david.marchand@redhat.com" Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH v5 14/15] test/crypto: add raw API test for dpaax Thread-Index: AQHXw3MewqHmO/In2ECdMGJwzPBQhavbnUyAgAAB6ICAAAHCAIAAAuMAgAAtKwCAAAMrkA== Date: Wed, 20 Oct 2021 12:43:10 +0000 Message-ID: References: <20211013190032.2308-1-hemant.agrawal@nxp.com> <4018747.7GKOkI4Wxd@thomas> <1737616.tSrxHmIIMQ@thomas> In-Reply-To: <1737616.tSrxHmIIMQ@thomas> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: de5d145e-e26f-4b40-2b88-08d993c72c8b x-ms-traffictypediagnostic: MWHPR11MB1599: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: l2cuJTYR6dFC2UFEgcrucI4yDrm/5GeKB/ficgzT4hDSaCKgvWLcJa5ir/4RbSzlxdvJKngxnSARD5PAVstK6WviiqBMwf4goXSvzWkP/IXRamprMBkslcdnHjrWsG+YeiicNkKsWH7o/bq70pMsgw104ykQ2AyI1bBsZV1MUWU5loCFjslI8T7wh0gQDBKy+EXpzWpeAFifBjklDcuc3072D7z/7gJYuaTJwApCkEGETMlw/4XEytUCZAirBAU5jwpcqFTwFWw4XNtItDxbG+QyY4IWXaQ4nSK305DNM9ZnrWrO2f3pIoVCTkdsFq0lKErN1vge64OPiu33yu2KRLwsQHv8N+rsgkEDIi12p01k7W4eVE8Cx/WVrmkI+e43l7RNqrCEQBg8jI6DQAFucOzY/k+D6cfREN7R9U1BHkLok3kxsiCBx7oPuYTLVNmcx6ihnI7tVKUjjDr9Fx6+LDRGlqZNvlYL+tdfmRFji42QIkxYIu4U5Itpc24m0N8gRB9Gzd3qXVYOoNtTW3uafFAyN3Hh/anmvv5r2kn87g5AhkEreFO/9IElUwu8yvACEg0SSnsWnovc8XYszxmzgp2dhEccQ4OjswWfCLAvTCp9OkUqHHGPvqT2+LshHwP2AGTe4Zhj8ABdzjlxTDgVBl3FrLzT3cVlashkK3E/lL+C54CCAwB/SZasJcMmcOoiwDni9za1Rtyo8tJZRdEUYg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(4326008)(316002)(110136005)(54906003)(122000001)(55016002)(86362001)(8676002)(6506007)(38100700002)(53546011)(9686003)(82960400001)(186003)(33656002)(8936002)(2906002)(5660300002)(7696005)(26005)(66446008)(64756008)(76116006)(66476007)(66556008)(52536014)(508600001)(38070700005)(83380400001)(66946007)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?OyhBgowtNzu+1YszjJZVw8gnDKmKPv8TqAf8fSzXJMt96XEJ9mU7X+17?= =?Windows-1252?Q?mpd9YFXpEbm0eQPyo/25Oy41RyQkMahIX7ZJYz2zdvvACNq1HWuR4egY?= =?Windows-1252?Q?5C/J+XJyGwwvyM34gyLVEoF0CsQ6vCQzF2DKS5woS0HCG4UM3SFBUfJs?= =?Windows-1252?Q?EaKBYPdeDtwLWSf6aZgSyt+tuiRKEG3K7zoW87tHGM1WwsRnd7YnKoQp?= =?Windows-1252?Q?LgE1I/UkoobrXgAcsOXsMDhCs/QRz4j9nPmtNMOLzO312hSeug7MZ29A?= =?Windows-1252?Q?nY5kj045uwrRFP9TagS/biaaDeITkQVr4N1kIn0V1MxSqjiL5GOFIXTg?= =?Windows-1252?Q?rILfm3zacTu5xqjVSAb41l2iXn4xSZa0/vUUTaNpVObMtGpjwvSSRXLK?= =?Windows-1252?Q?oqAHxgfEu+6Bdck5JKUn1qFyDlQt3L+wE4RpkT/z3nEYbu4OjkCMLH8L?= =?Windows-1252?Q?8Sw0hiYbU0TCR4oqGcN+XGTCrVCtMjC+aUhWp+6ie3k0r9Up2dhQ9apz?= =?Windows-1252?Q?isMkPU+1SB+AkFPKHLDGMFJnNXVqD1bL6jbq4/0sKNpRLnmPlp0U33uO?= =?Windows-1252?Q?SStr3b4yd7+RX18hjqPBicmjj932YADpa6evNTIxqjgr8AB//008ZsTn?= =?Windows-1252?Q?hmo4jONdX5n6/9cKCsNsWGeyYRShl+LBys6llf5/BUWer/Z8xTfzFG8T?= =?Windows-1252?Q?nDnjFSjjNIwPoXkU8Kkiv+ASBb/BPl3EoS9m1o5xg4fR6huWGfaeJQwV?= =?Windows-1252?Q?Myd4XdVaWCQEChdfiYTIJuog+xZh6nGKxNYKF2+GfzBYHQtbnsq0xy/1?= =?Windows-1252?Q?GnrLlcl6KuvhFYPpwnIUsDdNQv7Hkq48TmmKNSL0T6Ug22CG7crPBRCo?= =?Windows-1252?Q?pognsCaV5eC1QcCWjrmGdSjoUWpiBlS7TNujCA8WPRyC8A3kiFrfn4Vm?= =?Windows-1252?Q?RbY8ZZK1o7YWmG5GHOYF71fJyKgYDgyuRwK4SL65P85Iana6AsWgTkxS?= =?Windows-1252?Q?x7mGQiF55qyfjIX68wR/F/fLvIpV8VKorEJ6TPl0eAbQzAovIrvlJxoe?= =?Windows-1252?Q?ESelmG5x0Tzbzm/qDeNxlrcxiveMsHLVxDpJrxvbGK2FSO6QikSZpfWI?= =?Windows-1252?Q?Fc2jtR5aIbdbL7pPyvoYiDqL8bzj8ZsiLxE+0WV2k1NYPxCT8+b5f3yt?= =?Windows-1252?Q?+htoUc0BF0eZcEyGzAFyQ829412pCRSFc0nbMZaxEM11Gv/Epd/qhe3T?= =?Windows-1252?Q?/h2MmCdBnH9+K1BoJSkt368oLapSsdC13mUe7S6AFu7r8XtO/NImCjXG?= =?Windows-1252?Q?YjASGjcfWU3iQhJHz7UFzfcq3eMUKIP97IdmVp+dfglSTeM4I/Pm3hav?= =?Windows-1252?Q?Bpido5m59GntJEUj5y5sCmfKHiuUhrqgn75suwMoxORpcnPfVkNRbE2m?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de5d145e-e26f-4b40-2b88-08d993c72c8b X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2021 12:43:10.3046 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: roy.fan.zhang@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1599 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v5 14/15] test/crypto: add raw API test for dpaax X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, The raw data path API tests takes advantage of existing cryptodev unit test cases with one difference: - in cryptodev sym crypto unit tests, all data is described by both rte_mbu= fs and rte_crypto_ops. - in raw data path API tests, the same data is converted from mbufs and cry= pto ops into rte_crypto_sym_vec to test. However for each test case we can only use either crypto op way or raw data path API way to run a test. To distinguish which way to use there is a glob= al flag set by test command. If you want to use crypto op way to test all cases you use one command, otherwise with other command. What complicated things is, cryptodev unit test needs to prepare the data for every test. Once the test is finished the data is either encrypted or decrypted and cannot be reused immediately. Using only the device capability flag to cover both crypto op tests and raw= data path api tests in the same test function means each and every test function= in test_cryptodev.c needs to be expanded by ~30% as all data needs to be re-prepared again for each test type. Also for the PMDs that do not support= this test type will be shown 100% more bypassed tests in the test result briefin= g. That's the reason to have this global knob so each test function only have = to act slight differently between crypto op test and raw data path API test. Regards, Fan > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, October 20, 2021 1:14 PM > To: Zhang, Roy Fan ; Gagandeep Singh > ; Hemant Agrawal ; Akhil > Goyal > Cc: dev@dpdk.org; Ananyev, Konstantin ; > aconole@redhat.com; david.marchand@redhat.com > Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v5 14/15] test/crypto: add raw A= PI > test for dpaax >=20 > 20/10/2021 11:32, Akhil Goyal: > > > 20/10/2021 11:15, Akhil Goyal: > > > > > 17/10/2021 18:16, Hemant Agrawal: > > > > > > This patch add support for raw API tests for > > > > > > dpaa_sec and dpaa2_sec platforms. > > > > > > > > > > Why do we have tests specific to some drivers? > > > > > Is there a plan to remove them? > > > > > > > > > > > > > The testsuites are common and there is no driver specific test. > > > > The test command is different for each of the PMD, > > > > that is why it is registered for each PMD. > > > > For Raw data path APIs, all of the testsuite is run with a global f= lag set. > > > > Currently only 3 PMDs support raw APIs, we can get rid of this glob= al > flag in > > > future if more > > > > PMDs start supporting these APIs. > > > > > > No there is something wrong. > > > It shows that it is not generic enough for any app. > > > What is missing to make the same calls no matter the driver? > > > Do we need to add some capability flags? > > > > Capability flags are there for raw data path APIs but the PMD can suppo= rt > both APIs. > > And we need to test both data paths. > > So for this we have a global variable to enable raw data path and we > register a new > > Command for the PMD and enable that global flag while doing that. > > The tests, however have the capability flags checks in place but we dec= ide > to enable > > Raw APIs only when the PMD support that and that global flag is set. > > I hope it is clear now. >=20 > No sorry, it is not clear. > How may I know that the raw API is supported in a PMD? > If there is such info, no need for specific tests? >=20