From: "Stokes, Ian" <ian.stokes@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Shetty, Praveen" <praveen.shetty@intel.com>,
"Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Leyi Rong <leyi.rong@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Subject: RE: [PATCH v2 1/2] drivers: fix build warnings when using icx
Date: Mon, 10 Feb 2025 10:55:50 +0000 [thread overview]
Message-ID: <MW6PR11MB8309953B8CB8BFC8F18C097A92F22@MW6PR11MB8309.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20250205182918.4041268-2-bruce.richardson@intel.com>
> The Intel oneAPI DPC++/C++ Compiler (icx), issues warnings on build when
> the "-march=native", or other configured global "-march" flag, is
> overridden to "skylake-avx512", when compiling AVX-512 code.
>
> Allow building with icx with warnings-as-errors flag (werror) enabled by
> disabling the warning for the cases where we pass that extra "-march"
> flag.
>
> Fixes: e6a6a138919f ("net/i40e: add AVX512 vector path")
> Fixes: 31737f2b66fb ("net/iavf: enable AVX512 for legacy Rx")
> Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path")
> Fixes: 0fac6a1c44d5 ("common/idpf: add AVX512 for single queue model")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> drivers/common/idpf/meson.build | 3 +++
> drivers/net/intel/i40e/meson.build | 3 +++
> drivers/net/intel/iavf/meson.build | 3 +++
> drivers/net/intel/ice/meson.build | 3 +++
> 4 files changed, 12 insertions(+)
>
> diff --git a/drivers/common/idpf/meson.build
> b/drivers/common/idpf/meson.build
> index 46fd45c03b..7dbcdabd90 100644
> --- a/drivers/common/idpf/meson.build
> +++ b/drivers/common/idpf/meson.build
> @@ -21,6 +21,9 @@ if arch_subdir == 'x86'
> avx512_args = cflags + cc_avx512_flags
> if cc.has_argument('-march=skylake-avx512')
> avx512_args += '-march=skylake-avx512'
> + if cc.has_argument('-Wno-overriding-option')
> + avx512_args += '-Wno-overriding-option'
> + endif
> endif
> idpf_common_avx512_lib = static_library('idpf_common_avx512_lib',
> 'idpf_common_rxtx_avx512.c',
> diff --git a/drivers/net/intel/i40e/meson.build
> b/drivers/net/intel/i40e/meson.build
> index 5c93493124..ffa40c5d64 100644
> --- a/drivers/net/intel/i40e/meson.build
> +++ b/drivers/net/intel/i40e/meson.build
> @@ -57,6 +57,9 @@ if arch_subdir == 'x86'
> avx512_args = cflags + cc_avx512_flags
> if cc.has_argument('-march=skylake-avx512')
> avx512_args += '-march=skylake-avx512'
> + if cc.has_argument('-Wno-overriding-option')
> + avx512_args += '-Wno-overriding-option'
> + endif
> endif
> i40e_avx512_lib = static_library('i40e_avx512_lib',
> 'i40e_rxtx_vec_avx512.c',
> diff --git a/drivers/net/intel/iavf/meson.build
> b/drivers/net/intel/iavf/meson.build
> index d9b605f55a..c2bef0230f 100644
> --- a/drivers/net/intel/iavf/meson.build
> +++ b/drivers/net/intel/iavf/meson.build
> @@ -40,6 +40,9 @@ if arch_subdir == 'x86' and
> is_variable('static_rte_common_iavf')
> avx512_args = cflags + cc_avx512_flags
> if cc.has_argument('-march=skylake-avx512')
> avx512_args += '-march=skylake-avx512'
> + if cc.has_argument('-Wno-overriding-option')
> + avx512_args += '-Wno-overriding-option'
> + endif
> endif
> iavf_avx512_lib = static_library('iavf_avx512_lib',
> 'iavf_rxtx_vec_avx512.c',
> diff --git a/drivers/net/intel/ice/meson.build
> b/drivers/net/intel/ice/meson.build
> index beaf21e176..3b13a5913d 100644
> --- a/drivers/net/intel/ice/meson.build
> +++ b/drivers/net/intel/ice/meson.build
> @@ -40,6 +40,9 @@ if arch_subdir == 'x86'
> avx512_args = cflags + cc_avx512_flags
> if cc.has_argument('-march=skylake-avx512')
> avx512_args += '-march=skylake-avx512'
> + if cc.has_argument('-Wno-overriding-option')
> + avx512_args += '-Wno-overriding-option'
> + endif
> endif
> ice_avx512_lib = static_library('ice_avx512_lib',
> 'ice_rxtx_vec_avx512.c',
> --
> 2.43.0
Tested ok and looks good to me.
Acked-by: Ian Stokes <ian.stokes@intel.com>
next prev parent reply other threads:[~2025-02-10 10:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 16:18 [PATCH] build: remove support for icc compiler Bruce Richardson
2025-02-05 16:33 ` Stephen Hemminger
2025-02-05 17:03 ` David Marchand
2025-02-05 17:32 ` Bruce Richardson
2025-02-05 17:46 ` Bruce Richardson
2025-02-05 18:29 ` [PATCH v2 0/2] replace icc support with icx Bruce Richardson
2025-02-05 18:29 ` [PATCH v2 1/2] drivers: fix build warnings when using icx Bruce Richardson
2025-02-10 10:55 ` Stokes, Ian [this message]
2025-02-05 18:29 ` [PATCH v2 2/2] build: replace support for icc with icx Bruce Richardson
2025-02-06 15:19 ` David Marchand
2025-02-10 10:55 ` Stokes, Ian
2025-02-10 17:18 ` [PATCH v3] " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW6PR11MB8309953B8CB8BFC8F18C097A92F22@MW6PR11MB8309.namprd11.prod.outlook.com \
--to=ian.stokes@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=leyi.rong@intel.com \
--cc=praveen.shetty@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).