From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B272245A68; Mon, 30 Sep 2024 15:29:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 952C7402F1; Mon, 30 Sep 2024 15:29:17 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id 2E8114014F for ; Mon, 30 Sep 2024 15:29:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727702955; x=1759238955; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=d7sBiA1LlzJS49GkFgbjvEcH9nfnpmVk8ppQh4bVT3s=; b=MoXr6+YFu0AjiVsXTLi1FhEyHO4C0OhkUlCigoKaGMoGgzX3yHr7Y3hS jYgaUhFWNQVHRKsqzBulT5tmnh7t/KixfudmaOo+12WljAfxyRxRTeT68 E0tg2QVzaYwzV2QoiTIyPXBNzYdW9ZbCRY3elktiKKp80GAmoCIMqntHe 9OX/xtSmhh9MAKWCOL/MiVFpd0BeWpk2G7ZW4aPFiZa2By58GSS9I76cR 8v3z3uyM3EB7gIViFI58pgbeJJqFY8g/Tf9mnGRLkhTNhMD5UMmMGBmWb Cwk1o0/jL8J+7QGqZBiOaM8GmceioACHfl1zDGyyd8cSheQceLDIc/5/V w==; X-CSE-ConnectionGUID: //Lu75TsSK2Nigvs4f4d0g== X-CSE-MsgGUID: AwVVq/VPT7uCF4mK0nicVQ== X-IronPort-AV: E=McAfee;i="6700,10204,11211"; a="26599473" X-IronPort-AV: E=Sophos;i="6.11,165,1725346800"; d="scan'208";a="26599473" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2024 06:29:13 -0700 X-CSE-ConnectionGUID: b2D6MDvpTz+s5fWDQgkHZQ== X-CSE-MsgGUID: mBP36NoGSaSutkoA91mIEQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,165,1725346800"; d="scan'208";a="104107328" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Sep 2024 06:29:13 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 30 Sep 2024 06:29:13 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 30 Sep 2024 06:29:13 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 30 Sep 2024 06:29:12 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 30 Sep 2024 06:29:12 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 30 Sep 2024 06:29:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oJ+HUD3H2pq1I7mWlhRjEhAHgnuB9MAAlfL+2mX5OS+bNGKcCZ1EzzyWpk1LLTh3ltk2BsIX39/AhIILs5dLaqcqLAeGe1IhuGpPUceSpwsaY8Jok9rI1gpsGArr+MHIoZYFFrDTzPljctRXH3GzOmdP1UtXhSCs21Hx2IHB7owiJlxpr/jnT4DqFWg4k8y4WAjQKbFChHBUwLqDp85msppWubx7G7UGCio3fZZWyk48UEqalzWXdu8E7IIKKk1ldPgamAjqN4ZwSetgH1Mye+2gByGJ2P7oxNd8KUOqpdO3jisGaQXbhq4akKnbv8O/SexIiHVUWIW2nlwaPLt62Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PQOo+ksAFQ+9Goczuu5oiAX2QuDLa9YNRhZdCYgXaT8=; b=gpg7lj29dvgPzKUEt2aCj2KTPM2SAT0TGTqDRbvH//ztjjtxYpAifdXcjaCrfFw7TAEt/BRGWdBkTE5JhKX4WnTLCpyHjiWfbN2d2xqgWBrZydkHE/Ea0ptJgzk/eBByhaGkgqlq9ddz9AM3ZiclhEOR3so/7B/fJFsOstZ/3qNZjCJi82OkxI8lyq7XYmKiKPmY9Sfa5o3UNY8JITmJy50mfQ/rlwgoLcT9v2mPqfCi2vFxQw/ga55X+FoyLzOYzufnkvK7qJaOjPP6nEMws880gBT8ALl4Kf/RTFnEoNw2M6jZ9NXC3ZoBTRKEAWbhbw6wQeGsdk7b1+1JzRrh2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW6PR11MB8309.namprd11.prod.outlook.com (2603:10b6:303:24c::19) by DM6PR11MB4689.namprd11.prod.outlook.com (2603:10b6:5:2a0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.27; Mon, 30 Sep 2024 13:29:09 +0000 Received: from MW6PR11MB8309.namprd11.prod.outlook.com ([fe80::ba43:b01f:aee0:10a8]) by MW6PR11MB8309.namprd11.prod.outlook.com ([fe80::ba43:b01f:aee0:10a8%3]) with mapi id 15.20.8005.024; Mon, 30 Sep 2024 13:29:09 +0000 From: "Stokes, Ian" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Richardson, Bruce" , "stable@dpdk.org" Subject: RE: [PATCH 2/4] net/ice: fix AVX-512 pointer copy on 32-bit Thread-Topic: [PATCH 2/4] net/ice: fix AVX-512 pointer copy on 32-bit Thread-Index: AQHbAGbU9wJvJtUlJ0m3iApyp4+eYrJweIIw Date: Mon, 30 Sep 2024 13:29:09 +0000 Message-ID: References: <20240906141127.628873-1-bruce.richardson@intel.com> <20240906141127.628873-3-bruce.richardson@intel.com> In-Reply-To: <20240906141127.628873-3-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW6PR11MB8309:EE_|DM6PR11MB4689:EE_ x-ms-office365-filtering-correlation-id: 90eee08a-f0d9-41f9-357f-08dce153ddc2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?LovQk4QPNUpYbo/niSs9EayqRYMRfeENFFtejnv+GRzlW4ZHBOaye8WKa+aL?= =?us-ascii?Q?6hMTe+kcNjash4RlRl3wpjdGULnbiii9z+xvXw6/x6VL9EArJUjaSNFpkbKN?= =?us-ascii?Q?MMiFdWbqzP5vreJt7iRnXiKkt6qohv7F5DjTa7Lx3KZFer1nq/9AYEuGaZ8n?= =?us-ascii?Q?3kKz465ht/zhkNniD3fes8A37iYT7VRgBVoPLkOE+AF3cjbiBUA8h0DQITD3?= =?us-ascii?Q?8MWw9FhDn/RyKhK5Yu6SPmE/O/nb4D381jM/4DpQv2uu4ZxlE9akzjg6oUvc?= =?us-ascii?Q?uySIWzUDcr8DbUHFrvSujzIdAceYIGTRwrAJPg8JRoMbUe986wnwM3JCM5Cr?= =?us-ascii?Q?qBGwWfgPKXdBqyFh+wNAkZ8cgNh344kDnpTrCbeRT/nct5l8sR6nShkw0jXG?= =?us-ascii?Q?W+2mV7wtlng05sT+Q7ssxWCQU9PbnGZ8wmik+9TxzTxckoNLp4ARYvf7v4dK?= =?us-ascii?Q?aSwnehwv3sfPuinquFXOSlhr6n7l98OdTWD2tQeLA/Bm4ALq4py2FnpyjyKh?= =?us-ascii?Q?rwLEqHHcevppSsHNr5Qxf3vjKLPyzrsP0+bHzhpoOCKSkp5nNvBgfC2bn1xr?= =?us-ascii?Q?xG7HXDWxy3Rvh2OsuGn1jquSiyyDK3JdWYvwJzqQOTalUhm7l1AgTNmzKLot?= =?us-ascii?Q?WXdWA6CH27rRzxfql1BfhCt2xUcrAqPsJFWOl0wOonKH/tU99NUkIKK5829G?= =?us-ascii?Q?kZNO5+nXlApWO0dMq7tMaquRlUi/bB/6B5YwnM2kVICXs0gc16fivfTAkZrB?= =?us-ascii?Q?NCButJwPzffTCw/qVLqQBL549FYBPeJ+YLXZO3iqTXIBJ2gWShgqcEY0OqmY?= =?us-ascii?Q?yqob/4bBPoVhQpcNWvoxcxTOu0YnESmq0Mc53UM78zPWNZEgbTkmcYcWjGqO?= =?us-ascii?Q?VJiPumc1nHQF3Dlise+TNyenYj1MbFUuYtDJWxx1XN+vIqnKLPnEl8Zw9jSH?= =?us-ascii?Q?+LLJ7PSwOmQulQjscgNYT+FL5woBh99T2kykX06fnDvoHhA+4Yob5UeMnVbJ?= =?us-ascii?Q?8HYqzNn//BCUKEhYZXsrkMT9Rn1AVUJGMN6Iip82O/KFb37dpKDyM4bj506p?= =?us-ascii?Q?MlSmtmcZcrGz2t++i11Slckkmm8SLanhSNHsZoegPdyxm6W0tgLQJq8sPmWj?= =?us-ascii?Q?Zju7eVWwtxkq7Y1lA6maWqLocOncFPR47ZJz7i9xtBPIh8JA81jPqDzpQ6Av?= =?us-ascii?Q?mhdUot5kYS+kittOmDDTjrv0XBRrj3xweu1JJeqOTTWA2rVzv1EbWWoLfTSB?= =?us-ascii?Q?JLNHPSqLroWaNJwRtdiIlmY+i7s/5iKhJjgMLn7Xu2X70NXXQrfB+jYmOlmg?= =?us-ascii?Q?ws3lWmXjSZ3W4xKG2Zlf2WnleY43DxDoo/2I5eLO+QhM0w=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW6PR11MB8309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vdeNAvtQ/XhjGKXAg0Inckh+2CPS2RpCiAn1ssav76SQreh3gipUzkF0Gkmo?= =?us-ascii?Q?R2e3OwKSdGlVxl49lzSRWO1rzS+TO1AFsXKvA9SQNuHgNZ4PKTvEne11twcl?= =?us-ascii?Q?t2KAhxNQax/4RoozXcjs4VJOxNA3IjA0bKovtITz83kF1TP6UwG0LrdhOW5W?= =?us-ascii?Q?APsgdfigFld3ZvPYES/jkLUF3hSnaM2+ULdOPVjGFC3ZFaouXcOXs8KNW7k7?= =?us-ascii?Q?VoU+OjTfMcyHzaBS7jIFcRMi8dNBDVeW982s+M/wfAVsn6btmRKt8b+upWmC?= =?us-ascii?Q?7QI4lKbVC2kO9NytK2TZ8z+9W80HmW7tAVF1P7TnvV3gCEm4MGcixABiy2X/?= =?us-ascii?Q?hdtbuZutLWiO6TbiUiH0AFk0SUT2YInYEg8RhPncLGyBSIXGc83+M2SERFdx?= =?us-ascii?Q?OIdOqA4Ll8em4sjnXOrflIw7IlO3C6McuCONlX0s+24Nf0Vz0iIEnxW9rYFI?= =?us-ascii?Q?9QaIifdOYBJ80TaTykGcFeAIsxHUFms0oo/UAXz+pa8irs4xyzEEypoY3/gf?= =?us-ascii?Q?WYtnW0bItF+8J5ovXGJRCUNK4FX80UJjGJFPmf/YXBGDO69cr0y65RMTM/H3?= =?us-ascii?Q?pqDwae4L6YZfKnfEup+ubvyTjKX1I/0FioeoMXEtEqApfa4EQt+n3rHQLodZ?= =?us-ascii?Q?wWG/keU7ArCcWX9F9CcldwyhowsI7Et8X7B/PCuExA7kgYii/d7YFrIf0Dkx?= =?us-ascii?Q?wYN7TBqdD+gOn+BtvtBbjf/qYUCAcY1zFdUIcbRxpX7XwLbCmdcwqeh8i+9F?= =?us-ascii?Q?JyR+04adHbvulGE6pl3byv9rEFbgSTdd0rQpezsAcF3aWlY3BXI/qyr5rw94?= =?us-ascii?Q?AhZFEBHJ7oo6zIoSvoMyBQZ0MoDsS1YYqVCsK7zq4G+d4Ni+a3CcUWf6Hhjf?= =?us-ascii?Q?pxmQNnk3jbrqPuoxTIsSSbfU/5n2PLSVxuhiXfWRUlLSoD2KtIBWgYQo2iyG?= =?us-ascii?Q?Z1XCBIhMlGym4ytrTat8EAaDl+qiiX5XWP8Bo6g9TwXC5sPhla2JtOKl9Kne?= =?us-ascii?Q?NsZpG+pbQHsdLk/kvtrtYROmtoAz86YkJpGFgJnjH9KMq3UtzMomsEfnFSIi?= =?us-ascii?Q?zoA/KFeeySmunyd+KrczR62LL8NIzZJ+1zJkUqsHF0XcVXG67OsfBHIJ6FHJ?= =?us-ascii?Q?Ho3zzKA+6Xhe2FvtMXnBNhScKCCAveTg2tUiTU3o4bOj21/MvOfzKX5pouza?= =?us-ascii?Q?Z/3Y2rZqjpNd4k+oYtaNTlhjyYzZNxKrMMU8qpN5X4RdGgrqEMPUTKg7AXmY?= =?us-ascii?Q?YrhdtgagdXIhm4+AbQCMT1XNeQUGIQWYRBKAPM/Cl9VsjAQGa7mbIUa6oBBm?= =?us-ascii?Q?p4INxJiXcLffqIFJxt4KOYf6KsyFV+08Ge+p5SnOP2Vubbon0283lcFtuSRm?= =?us-ascii?Q?Qk+usfgFI2vYcvAPudE/eRZO+HXBlAmbWAzW+EcV/dtXMZdqdKrJXmo573d1?= =?us-ascii?Q?Izbbi4hd4jp3zEOwLhoZdn90MNL5xq29oKGkIclh98Lm0Qx0ALIaCpCgyiK1?= =?us-ascii?Q?CkJ7D8n4dnt948y2NBdPhDmtQUVFCqUFmJQ6b/Mlm3gbRg5wLGVNIWicZRxV?= =?us-ascii?Q?JOB4vaCyW8IdzbiOmLJX9YioL9WxGwEuI887MVcR?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW6PR11MB8309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90eee08a-f0d9-41f9-357f-08dce153ddc2 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2024 13:29:09.8190 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uSOW44ccx0Ga2H4H5nT1L7KOLejfTOlYmPhQo2qCF5UIScaTUM31185VmlNcMjO5OwVMWa9mTD91NPK/LHiGqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4689 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > The size of a pointer on 32-bit is only 4 rather than 8 bytes, so > copying 32 pointers only requires half the number of AVX-512 load store > operations. >=20 > Fixes: a4e480de268e ("net/ice: optimize Tx by using AVX512") > Cc: stable@dpdk.org >=20 > Signed-off-by: Bruce Richardson > --- > drivers/net/ice/ice_rxtx_vec_avx512.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/drivers/net/ice/ice_rxtx_vec_avx512.c > b/drivers/net/ice/ice_rxtx_vec_avx512.c > index 04148e8ea2..add095ef06 100644 > --- a/drivers/net/ice/ice_rxtx_vec_avx512.c > +++ b/drivers/net/ice/ice_rxtx_vec_avx512.c > @@ -907,6 +907,7 @@ ice_tx_free_bufs_avx512(struct ice_tx_queue *txq) > uint32_t copied =3D 0; > /* n is multiple of 32 */ > while (copied < n) { > +#ifdef RTE_ARCH_64 > const __m512i a =3D > _mm512_loadu_si512(&txep[copied]); > const __m512i b =3D _mm512_loadu_si512(&txep[copied > + 8]); > const __m512i c =3D _mm512_loadu_si512(&txep[copied + > 16]); > @@ -916,6 +917,12 @@ ice_tx_free_bufs_avx512(struct ice_tx_queue *txq) > _mm512_storeu_si512(&cache_objs[copied + 8], b); > _mm512_storeu_si512(&cache_objs[copied + 16], c); > _mm512_storeu_si512(&cache_objs[copied + 24], d); > +#else > + const __m512i a =3D > _mm512_loadu_si512(&txep[copied]); > + const __m512i b =3D _mm512_loadu_si512(&txep[copied > + 16]); > + _mm512_storeu_si512(&cache_objs[copied], a); > + _mm512_storeu_si512(&cache_objs[copied + 16], b); > +#endif > copied +=3D 32; > } > cache->len +=3D n; > -- LGTM, Acked. Thanks Ian