DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Shaikh, Shahed" <Shahed.Shaikh@cavium.com>,
	Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/qede: fix slow path completion timeout
Date: Thu, 24 May 2018 18:02:20 +0000	[thread overview]
Message-ID: <MWHPR0701MB36758C70126AA9877FAFB6D79F6A0@MWHPR0701MB3675.namprd07.prod.outlook.com> (raw)
In-Reply-To: <25511254-ce5b-cb92-594b-7a3c8d1f3b26@intel.com>

Hi Ferruh,

> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Thursday, May 24, 2018 10:22 AM
> 
> On 5/23/2018 7:48 PM, Rasesh Mody wrote:
> > From: Shahed Shaikh <shahed.shaikh@cavium.com>
> >
> > In 100G mode, we poll firmware slow path completion for every 1
> > second, which is not enough and may result in completion timeout if
> > driver misses that window.
> >
> > Patch "eal: set affinity for control threads" exposed this issue since
> > alarm callback runs in control thread context.
> >
> > Fix this issue by update polling period to 100ms.
> >
> > Fixes: d651ee4919cd ("eal: set affinity for control threads")
> > Fixes: 2af14ca79c0a ("net/qede: support 100G")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Shahed Shaikh <shahed.shaikh@cavium.com>
> 
> Hi Rasesh,
> 
> I can see it fixes an issue introduced because of a change in this release, what
> is the priority of the defect?

This is important for us to get this change in as it fixes slow path completion timeout for our 100G adapters leading to PMD load failure. Please apply to 18.05.

Thanks!
-Rasesh

  reply	other threads:[~2018-05-24 18:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23 18:48 Rasesh Mody
2018-05-24 17:22 ` Ferruh Yigit
2018-05-24 18:02   ` Mody, Rasesh [this message]
2018-05-25  9:35     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR0701MB36758C70126AA9877FAFB6D79F6A0@MWHPR0701MB3675.namprd07.prod.outlook.com \
    --to=rasesh.mody@cavium.com \
    --cc=Dept-EngDPDKDev@cavium.com \
    --cc=Shahed.Shaikh@cavium.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).