Re: [dpdk-dev] [PATCH 1/5] net/qede: convert to new Rx/Tx offloads API

["Mody, Rasesh" <Rasesh.Mody@cavium.com>]

> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Monday, May 14, 2018 5:53 AM
> 
> On 5/11/2018 10:16 AM, Andrew Rybchenko wrote:
> > On 03/28/2018 03:15 AM, Rasesh Mody wrote:
> >> From: Harish Patil <harish.patil@cavium.com>
> >>
> >> Ethdev RX/TX offloads API has changed since:
> >> commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
> >> commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")
> >>
> >> This patch makes use of new offload flags as suggested and fix the
> >> default RX/TX configuration. Also indent the code properly around
> >> those changes.
> >>
> >> Signed-off-by: Harish Patil <harish.patil@cavium.com>
> >> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
> 
> <...>
> 
> >>  				     DEV_TX_OFFLOAD_GENEVE_TNL_TSO);
> >> +	dev_info->tx_queue_offload_capa = dev_info->tx_offload_capa;
> >> +
> >> +	dev_info->default_txconf = (struct rte_eth_txconf) {
> >> +		.txq_flags = DEV_TX_OFFLOAD_MULTI_SEGS,
> >
> > It is incorrect to initialize TxQ flags using Tx offload define.
> 
> Yes it is wrong, thanks for pointing it out. I assume intentions is .offloads
> 
> Rashed, Harish,
> 
> Can you send a fix please?

Fix sent, thanks Andrew.

-Rasesh

> 
> >
> >> +	};
> >> +
> >> +	dev_info->default_rxconf = (struct rte_eth_rxconf) {
> >> +		/* Packets are always dropped if no descriptors are available
> */
> >> +		.rx_drop_en = 1,
> >> +		/* The below RX offloads are always enabled */
> >> +		.offloads = (DEV_RX_OFFLOAD_CRC_STRIP  |
> >> +			     DEV_RX_OFFLOAD_IPV4_CKSUM |
> >> +			     DEV_RX_OFFLOAD_TCP_CKSUM  |
> >> +			     DEV_RX_OFFLOAD_UDP_CKSUM),
> >> +	};
> >>
> >>  	memset(&link, 0, sizeof(struct qed_link_output));
> >>  	qdev->ops->common->get_link(edev, &link);