From: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
To: Andy Green <andy@warmcat.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/4] net/bnx2x: do not cast function pointers as a policy
Date: Tue, 15 May 2018 19:47:18 +0000 [thread overview]
Message-ID: <MWHPR0701MB3675E70169E602B04381F25D9F930@MWHPR0701MB3675.namprd07.prod.outlook.com> (raw)
In-Reply-To: <152627426857.53058.13797630196021627334.stgit@localhost.localdomain>
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green
> Sent: Sunday, May 13, 2018 10:04 PM
>
> This is stopping the compiler telling you when you have done something
> stupid... that is something none of us can afford...
>
> Now gcc 8.x can tell you did something stupid despite trying to hide the
> evidence.
>
> Remove all the "black magic" casts.
>
> Fix the actual problems.
>
> Signed-off-by: Andy Green <andy@warmcat.com>
> Fixes: b5bf7719221d ("bnx2x: driver support routines")
> Cc: stable@dpdk.org
> ---
Acked-by: Rasesh Mody <rasesh.mody@cavium.com>
next prev parent reply other threads:[~2018-05-15 19:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 1:51 [dpdk-dev] [PATCH v2 0/4] GCC8 fixes for MLX4/5/BNX2X PMD Andy Green
2018-05-12 1:51 ` [dpdk-dev] [PATCH v2 1/4] net/bnx2x: do not cast function pointers as a policy Andy Green
2018-05-12 1:51 ` [dpdk-dev] [PATCH v2 2/4] net/bnx2x: correct unmeetable comparison Andy Green
2018-05-12 1:51 ` [dpdk-dev] [PATCH v2 3/4] net/mlx5: solve var may be used uninitialized Andy Green
2018-05-12 1:51 ` [dpdk-dev] [PATCH v2 4/4] net/bnx2x: solve overruns Andy Green
2018-05-14 5:04 ` [dpdk-dev] [PATCH v3 0/4] GCC8 fixes for MLX4/5/BNX2X PMD Andy Green
2018-05-14 5:04 ` [dpdk-dev] [PATCH v3 1/4] net/bnx2x: do not cast function pointers as a policy Andy Green
2018-05-15 19:47 ` Mody, Rasesh [this message]
2018-05-14 5:04 ` [dpdk-dev] [PATCH v3 2/4] net/bnx2x: correct unmeetable comparison Andy Green
2018-05-14 11:17 ` Ferruh Yigit
2018-05-14 22:17 ` Mody, Rasesh
2018-05-14 22:16 ` Mody, Rasesh
2018-05-15 14:46 ` Thomas Monjalon
2018-05-15 19:52 ` Mody, Rasesh
2018-05-14 5:04 ` [dpdk-dev] [PATCH v3 3/4] net/mlx5: solve var may be used uninitialized Andy Green
2018-05-15 17:25 ` Yongseok Koh
2018-05-14 5:04 ` [dpdk-dev] [PATCH v3 4/4] net/bnx2x: solve overruns Andy Green
2018-05-15 19:47 ` Mody, Rasesh
2018-05-15 20:30 ` [dpdk-dev] [PATCH v3 0/4] GCC8 fixes for MLX4/5/BNX2X PMD Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR0701MB3675E70169E602B04381F25D9F930@MWHPR0701MB3675.namprd07.prod.outlook.com \
--to=rasesh.mody@cavium.com \
--cc=andy@warmcat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).