DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	"Trahe, Fiona" <fiona.trahe@intel.com>,
	"Trybula, ArturX" <arturx.trybula@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"shallyv@marvell.com" <shallyv@marvell.com>,
	"Dybkowski, AdamX" <adamx.dybkowski@intel.com>,
	"Danilewicz, MarcinX" <marcinx.danilewicz@intel.com>,
	Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/compress: replace test vector
Date: Mon, 20 Jan 2020 13:54:22 +0000
Message-ID: <MWHPR1101MB2158E4DC04DA485963B3FBA1FC320@MWHPR1101MB2158.namprd11.prod.outlook.com> (raw)
In-Reply-To: <3347026.0YcMNavOfZ@xps>

> -----Original Message-----
> From: stable <stable-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> Sent: Friday, January 17, 2020 9:52 PM
> To: Trahe, Fiona <fiona.trahe@intel.com>; Trybula, ArturX
> <arturx.trybula@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; shallyv@marvell.com; Dybkowski, AdamX
> <adamx.dybkowski@intel.com>; Danilewicz, MarcinX
> <marcinx.danilewicz@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: Re: [dpdk-stable] [PATCH] test/compress: replace test vector
> 15/01/2020 16:54, Akhil Goyal:
> > > >
> > > > This patch replaces existing test vector with a new one containing
> > > > C code to fix license issue.
> > > >
> > > > Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> > > Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> > Applied to dpdk-next-crypto
> This is a terrible idea.
> Adding C code in a C project as text, and worst, its own code, will make
> grep matching on fake text.


I don't think this is a valid criticism. The patch replace code in Pascal with some code in C as a compression test. The grep part isn't really relevant, it should be clear to anyone who finds a match.

If you have a strong objection we will replace it with some more public domain text.

> Why do you need so much text to compress?
> Why not just opening our own code files as text?

That probably isn't worth the effort.

> Why stable@dpdk.org is Cc'ed in this email?

Ok. We'll do that.

> What is the license issue?

The issue is that the Pascal code from the Calgary Corpus (a standard body of compression test input) doesn't have a license or explicitly say that it is in the public domain so it isn't clear if we can relicense  it as BSD-3. We are being overly cautious here but we didn't want to run into any potential license issues. 

  reply	other threads:[~2020-01-20 13:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 11:56 [dpdk-dev] " Artur Trybula
2020-01-14 12:33 ` Trahe, Fiona
2020-01-15 15:54   ` Akhil Goyal
2020-01-17 21:51     ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2020-01-20 13:54       ` Mcnamara, John [this message]
2020-01-20 14:33         ` Thomas Monjalon
2020-01-20 15:00           ` Trahe, Fiona
2020-01-20 18:00           ` Mcnamara, John
2020-01-27 10:59             ` Mcnamara, John
2020-02-06  9:37 ` [dpdk-dev] [PATCH v2] " Artur Trybula
2020-02-12 13:25   ` Akhil Goyal
2020-02-12 13:31     ` Thomas Monjalon
2020-02-12 14:12       ` Akhil Goyal
2020-02-12 14:56         ` Trybula, ArturX
2020-02-13  9:30           ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR1101MB2158E4DC04DA485963B3FBA1FC320@MWHPR1101MB2158.namprd11.prod.outlook.com \
    --to=john.mcnamara@intel.com \
    --cc=adamx.dybkowski@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=arturx.trybula@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=marcinx.danilewicz@intel.com \
    --cc=shallyv@marvell.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git