From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C947A04EF; Mon, 1 Jun 2020 09:58:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 862BE1D167; Mon, 1 Jun 2020 09:58:05 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id E9EED1C300 for ; Mon, 1 Jun 2020 09:58:03 +0200 (CEST) IronPort-SDR: t3GDVSn/yxlhe9UOmHec4karEyW74/csn3WjCv7AlpKlM263AUBSoYguLCHAnJFjhMPZKcktPQ ZfxNK0Y6Zq6Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2020 00:58:02 -0700 IronPort-SDR: YduOyfgevpG7PB4s0xwIGnOaI9fUJiy2m6kZ/mgKrxub6A86lwZvyGvlJmRPSJZH8TkUmiYXXW 1ziiLJEq+PLg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,460,1583222400"; d="scan'208";a="268240729" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga003.jf.intel.com with ESMTP; 01 Jun 2020 00:58:01 -0700 Received: from orsmsx153.amr.corp.intel.com (10.22.226.247) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 1 Jun 2020 00:58:01 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX153.amr.corp.intel.com (10.22.226.247) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 1 Jun 2020 00:58:01 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.55) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 1 Jun 2020 00:58:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cuyqxnynCRlvNVH1kzrWD3NG6dNgn29cZpixigJJsrCYjaKnSx6cwchJJ0m5V7AyzVBCLN8VLBLmldBA2LkIUDvMjdu2SmlcoOL7LbP8JydHQIAQjMLhWmJMDMD3NmLQ07dVpVUFEN5cGQXCx5KNasDpUhWy045mDiZERVCFRmiDELdezYrCOnerzdA8lyclUN7E3uW5Mo3IYyxpSSWw7iun8X6fWl5gQ2IMPDS8Ixf9+062CFhfSuMn79ZDnLpXTC9+0zQtoqZM0IA1INhYFtHRv28mg13+/WppNmrsFYNSsNtaCdNygIr8zCvXxUedZvIugY2tAOWtI2Xu/ZiDvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K9YMB5C2uCmmesz/IsoKwhmKuqxEal2wckgw4K3u1Lo=; b=m60vVwMJEFbEoOv+kmdlwEaqLsqZrgGmshZ+AJghxMagSxz1VwYs9960IHeoCBEoBeDc/zXgVHAbWT+pZjj0S///v0umA3EW6qNDUU7q327gj1wJWSaS86QyIUFbVc/xhseUlVVFCznrn+FmLq9CpQDH/KFq1pBFwz0FMoqX3EX2Ub20Y7qzcwUpdj1ompwCBOp1B6r9Xkczu6aAz0m8akCQ7ae3L819y3TiMJWmCl7WQtshdujVaL45eU5H8NBx08sBM3vfWWyFbSwnmZfjXJEUOMUW8pnH8FH8MgTGWeeJlCMDZtHmzWI75UW117cvaK/UWfMNa5ifrlo5dYjiXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K9YMB5C2uCmmesz/IsoKwhmKuqxEal2wckgw4K3u1Lo=; b=h5rifuO6sQNMjOF7qw8R/AW8PxIId+KIcbkO05nwpE2MqaLKlkQt0UCi5C59qYxwHgYbuV+g1mrnSkaGQg8+BOTM3/h2bPUYvieHuDLkzk8xs8OKwe/KCefIBSskKUyRF+CZj09Qg4vSF02epwpPNpQzlIFzmZc+9NUcLQMh94M= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15) by MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19; Mon, 1 Jun 2020 07:58:00 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211%7]) with mapi id 15.20.3045.024; Mon, 1 Jun 2020 07:58:00 +0000 From: "Zhao1, Wei" To: Renata Saiakhova , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 3/4] drivers/net: Fix in i40e HW rings memory overlap Thread-Index: AQHWKSi+2N2+/CY4lUiygTcvbk9ANajDcrAg Date: Mon, 1 Jun 2020 07:58:00 +0000 Message-ID: References: <20200513131425.27817-1-Renata.Saiakhova@ekinops.com> <20200513131425.27817-4-Renata.Saiakhova@ekinops.com> In-Reply-To: <20200513131425.27817-4-Renata.Saiakhova@ekinops.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjQ0ODQwZWQtNTU0OS00YmE2LWIyY2MtMDExYjBjOTc1NDNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZ05YZlB3Z3VmWFZDMGttWGVhaDdKTit0RE1cL3BLNU9DV3dUUzFBd250Y1B1ZEJQNis3WnFZcGVpMldSM1Nkb3AifQ== dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: ekinops.com; dkim=none (message not signed) header.d=none;ekinops.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.223] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 64e9ebf1-b06d-4e1e-8409-08d806018112 x-ms-traffictypediagnostic: MWHPR11MB1775: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 0421BF7135 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: G95y55OkVG0eh3O7fkxoJpeafL/4MJrzvX4TIdyDnZNkugWn3fIwVb1bUnPr/q14+HJ3j0DqCpbIzU7uMQFPp8jm/F6L3sO6NxEa1sT1E+423svewJ+vCOY2k48SFMS9zSFiRILBhTy6VhsDH5An/aHeJVVKBlxoshf3ayJGWIYFUrP6okv/vX3C0UzWUzdJs3J8eRGxL6mp/tnUi+7GWumUb0nzc9xa2Vjs64r+gVAwrwcpsj6eyfHqBO4+m0x1qREmAjqbodHT+KrlUd+bdEoUIz9Co2CsuG0iwNXg49qf8X1s2q/ZBYaRVwfS9HKfKjbZy0bCuaOMCZAR4yAesA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(39860400002)(136003)(396003)(346002)(366004)(376002)(186003)(8936002)(316002)(2906002)(26005)(110136005)(478600001)(86362001)(7696005)(55016002)(6506007)(71200400001)(66946007)(66476007)(66556008)(64756008)(66446008)(76116006)(53546011)(83380400001)(5660300002)(33656002)(9686003)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: OyCceuPRQ/ioi4jhmncXYAJMXLijOcfBwxs078H81RFciIGbsvRu9WtwjOH+bMYyj/SEUvuDE3NVV/wV9O6cwxPD4pDI9zSg9Smx53T1xqpjIDSmem74iNEXP5UjEzI+FwfN8LCAkaDW+jfVLFDKIpSbuYYkm/XiG1T7MoJsnFtqpwisGsPZ9FGg9rnTfjdI8faRZoLsxNLU+Nt1Sss6fSocRhQXmOqZOx10/0uBKfbDafFpnS0lsBSMF0ks1nySwct1WX6Cm7MXbc8gLTj7MFN1clWxDtf34qmIScgSJzVEZVKavQCSCADTuvTjJ85Q+7bM4KQ/6dtRBp8VF7xvZfT4RZQDCQ1YsoEhCg5YqJ0nqaPfsC1J+8Bi1g6e+kZVFmpAr4mo9OPLIVAKEjfqkIPRHoTc3DYjWYMIHjzS+98fXMQAuCI4uO3u+LLhdHShwbZ3ymHIZ0j8g5Ld6D6+XyKMyncJeXLJE7jfz38EkdA= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 64e9ebf1-b06d-4e1e-8409-08d806018112 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2020 07:58:00.1694 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rvjEkYNnmBW8AUnnt8D3no4hb9xKnU4aIp/WgOvvYIoXwPjhj4MhfF0filGD1hWpLJkRAYa5yus5Ba2zYNnr/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1775 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 3/4] drivers/net: Fix in i40e HW rings memory overlap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Renata Saiakhova I think this patch is very important, It seems all kind of NIC has memor= y leak problem that used for store Tx or rx descriptor. If that is true, memory point by rxq-> rx_ring/ txq-> = tx_ring will never be freed even if dev_close?=20 Is my understanding right or wrong? If that is true, it seems you should also add in functioni40e_fdir_teardown= (), because Tx_ring allocated in i40e_fdir_setup_tx_resources() also need freed, and me= mzones need to be delete. Is that so? Thanks. > -----Original Message----- > From: dev On Behalf Of Renata Saiakhova > Sent: Wednesday, May 13, 2020 9:14 PM > To: dev@dpdk.org > Cc: Renata Saiakhova > Subject: [dpdk-dev] [PATCH v3 3/4] drivers/net: Fix in i40e HW rings memo= ry > overlap >=20 > Delete memzones for HW rings in i40e while freeing queues >=20 > Signed-off-by: Renata Saiakhova > --- > drivers/net/i40e/i40e_rxtx.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c = index > 5e7c86ed8..99cec9b99 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -2900,6 +2900,7 @@ i40e_dev_free_queues(struct rte_eth_dev *dev) > continue; > i40e_dev_rx_queue_release(dev->data->rx_queues[i]); > dev->data->rx_queues[i] =3D NULL; > + rte_eth_dma_zone_free(dev, "rx_ring", i); > } >=20 > for (i =3D 0; i < dev->data->nb_tx_queues; i++) { @@ -2907,6 +2908,7 @@ > i40e_dev_free_queues(struct rte_eth_dev *dev) > continue; > i40e_dev_tx_queue_release(dev->data->tx_queues[i]); > dev->data->tx_queues[i] =3D NULL; > + rte_eth_dma_zone_free(dev, "tx_ring", i); > } > } >=20 > -- > 2.17.2