From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Peng, ZhihongX" <zhihongx.peng@intel.com>,
"Guo, Jia" <jia.guo@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "wei.dai@intel.com" <wei.dai@intel.com>
Subject: Re: [dpdk-dev] [DPDK] net/e1000: add the VLAN capabilities of NIC
Date: Mon, 20 Jul 2020 01:59:32 +0000 [thread overview]
Message-ID: <MWHPR11MB139104139FC4CC29E332EC92B77B0@MWHPR11MB1391.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200720014636.13145-1-zhihongx.peng@intel.com>
Hi,
> -----Original Message-----
> From: Peng, ZhihongX <zhihongx.peng@intel.com>
> Sent: Monday, July 20, 2020 9:47 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; Peng, ZhihongX <zhihongx.peng@intel.com>;
> wei.dai@intel.com
> Subject: [DPDK] net/e1000: add the VLAN capabilities of NIC
>
> From: Peng Zhihong <zhihongx.peng@intel.com>
>
> The rte_eth_dev_set_vlan_offload function will check whether the NIC has the
> set vlan feature. If it has not, it will return failure. So need to add all the vlan
> feature flags of the NIC.
>
> Fixes: ef990fb56e55 ("net/e1000: convert to new Rx offloads API")
> Cc: wei.dai@intel.com
you should cc stable not wei.dai
>
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
> drivers/net/e1000/igb_rxtx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index
> 5717cdb70..966df3f20 100644
> --- a/drivers/net/e1000/igb_rxtx.c
> +++ b/drivers/net/e1000/igb_rxtx.c
> @@ -1647,7 +1647,8 @@ igb_get_rx_port_offloads_capa(struct rte_eth_dev
> *dev)
> DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_KEEP_CRC |
> DEV_RX_OFFLOAD_SCATTER |
> - DEV_RX_OFFLOAD_RSS_HASH;
> + DEV_RX_OFFLOAD_RSS_HASH |
> + DEV_RX_OFFLOAD_VLAN_EXTEND;
>
> return rx_offload_capa;
> }
> --
> 2.17.1
next prev parent reply other threads:[~2020-07-20 1:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 1:46 zhihongx.peng
2020-07-20 1:59 ` Zhao1, Wei [this message]
2020-07-20 6:48 ` [dpdk-dev] [DPDK v2] " zhihongx.peng
2020-07-21 3:05 ` [dpdk-dev] [DPDK v3] net/e1000: add VLAN extend feature to capability zhihongx.peng
2020-07-21 3:31 ` Zhao1, Wei
2020-07-21 5:05 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB139104139FC4CC29E332EC92B77B0@MWHPR11MB1391.namprd11.prod.outlook.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=wei.dai@intel.com \
--cc=zhihongx.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).