From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89C1AA0350; Tue, 23 Jun 2020 04:23:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 63BF31D560; Tue, 23 Jun 2020 04:23:48 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 2CB541D178 for ; Tue, 23 Jun 2020 04:23:47 +0200 (CEST) IronPort-SDR: +0FrXwW7hWEZkb5TfaplqI28N/MGReGidAVFuFXxuYAGzQ5XWuEe6DDniGSB9NNzTydswieSMb WmyOwaBMeRSQ== X-IronPort-AV: E=McAfee;i="6000,8403,9660"; a="228593336" X-IronPort-AV: E=Sophos;i="5.75,269,1589266800"; d="scan'208";a="228593336" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2020 19:23:46 -0700 IronPort-SDR: y99XlC8iBSuStuOLJmW92MJBoVISXqjh/zAJ9hj8h4zJQu9SZc4kBP/SxNOEDEX7xSvTXRYAeq Tmo/1wunVsKg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,269,1589266800"; d="scan'208";a="283428403" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga007.jf.intel.com with ESMTP; 22 Jun 2020 19:23:45 -0700 Received: from orsmsx122.amr.corp.intel.com (10.22.225.227) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 22 Jun 2020 19:23:45 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX122.amr.corp.intel.com (10.22.225.227) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 22 Jun 2020 19:23:45 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 22 Jun 2020 19:23:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m4u7flodlFMoyL4EzBORBsF2hnahP9Z5lkKgZcRbsakZegFQ0wHWeHp7a/DQO2KyjuFGATXkZhcGHnG5jzlSc9FN3wCG+Rp8/uONbqfM7MGpAUtfnJLVw1EET+uWFjdbnKSregkfR6PyPqpdPKYFvE9ciQptAauKmIsVwrO633JQt75+UmvrMGeqtBPRI8Tc7NkjknI4Hb5tu+FveK9zblLaPH122QTFjEwyTlUeBrCDCDLv860KdvhITRYU7TaR2RJ2bCGEnlL2aZZWrtJRVpaRXiGEY4L2qCxtpTI6vzy/YnozHQcjtWO5tVRQv9T8QU4XqYBMLfsmgpjL93Rxgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=706Mj5LGZ+kBRSZ7r1UyCiZ8g1spkX8inEw/FALiaAU=; b=MCVOBflfsFowUKsJ2qjPJoYoIVK/BQAwA1IasYFxExAEG2pTEO4N51k6NXfBbOHDKOvlZagqYjfmgDCBo9WrCsAJ80+TsRvdB3K/LsdSP0JYXb7wo1AXsNh04MkRtAFjKQxEj1GI0aRttAxXRFh/HJambSMHOOBU6jFBhA5giftB2nan1eNY5yx5OOweQm77aCg0iwZTmg0OUBrWthXb4xZN5O6S9s1NHG+j0+xP6/8Gdw7Nf/B+H3n8eLLl6l+04RCq6/oLTVStNz+kqZ3wBXz+4OPoTPp9nKcG8jjJtzL0DtnWC5bLcnh6UV4YUldIa2tvXoDDByoQzpjVQ3rn0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=706Mj5LGZ+kBRSZ7r1UyCiZ8g1spkX8inEw/FALiaAU=; b=cbn/cXbPzgzFFC36sGFWW4aoWeWmxNsOU5daS/26bGbbWATivHd2yAaIiMNTQxI+EJgpPOCcva0epr/xFODjH36UGJY7lZ3ciYE9+8trE9Jd8i6cpVIV0xnv2rxO5M6pHi91VNcC/CUF0hXkdDL0Yv2pIs3BAwBLsHk1iR4elfk= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15) by MW3PR11MB4617.namprd11.prod.outlook.com (2603:10b6:303:59::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Tue, 23 Jun 2020 02:23:43 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::f8f5:b48c:be92:ac17]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::f8f5:b48c:be92:ac17%3]) with mapi id 15.20.3109.027; Tue, 23 Jun 2020 02:23:43 +0000 From: "Zhao1, Wei" To: "Sun, GuinanX" , "dev@dpdk.org" CC: "Guo, Jia" , Dima Ruinskiy Thread-Topic: [PATCH 16/70] net/e1000/base: implement Low-Power-Link-Up (LPLU) for i225 Thread-Index: AQHWSGOV1k7DnsqLFUKE87ZUxScxpqjlebkg Date: Tue, 23 Jun 2020 02:23:43 +0000 Message-ID: References: <20200622064634.70941-1-guinanx.sun@intel.com> <20200622064634.70941-17-guinanx.sun@intel.com> In-Reply-To: <20200622064634.70941-17-guinanx.sun@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzRkYTMxZjktMjE5OS00MGMyLThiZjgtM2U5YmRiNGQ5Mjc4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYXlySXZ4M3dkOXpTakdvRFlFV0JTS08rdkZydkFsNHFBOUFieldmMTRHZGg3RExSZjVTQlFLS0YrV3J5TjFvKyJ9 dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.222] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f0960896-85dd-43d6-6040-08d8171c7334 x-ms-traffictypediagnostic: MW3PR11MB4617: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:913; x-forefront-prvs: 04433051BF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kD3LEz1bU6uW2620naVL/supzEP+IusCnu9faC/MCOMKpUbxlfMRieh7h+E2/HSseqXg663u/D2ws8yBcLWLIIN5CP7lWiu/rGi8zHK4QMF9BqwVGFk21iRHIHkUGb0+ZzLGF2+2wFB6vgVuCdRtLCLTZD/lDWdcq7l8bfb+AUViTQF8E8HQxd6trEuVBmiDm6bGhaez0bFy0p0FofUrWB34wEt9zn9OFjSaUQGk8BTTUzTqsMUFeHuCcvt7mSfG01ekdl+BIJfFhEqUgJCAWARNwcVq70eIXBA/xVBxPRjOAYHCS0eTW1AACzcBXKN4aqKJnQTm81D0CmnoXCSWxA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(136003)(376002)(396003)(39860400002)(366004)(76116006)(54906003)(66946007)(66476007)(66556008)(64756008)(66446008)(110136005)(8936002)(8676002)(33656002)(9686003)(53546011)(107886003)(6506007)(26005)(186003)(55016002)(4326008)(2906002)(86362001)(83380400001)(478600001)(316002)(71200400001)(52536014)(7696005)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: hXcOPzv8898+jWe05XC2rvoxAWVg5fo/lvulJLW8dQgko0u1CmJA1IrWI1NdQ6nbkABYU7Gc1X3JK23bcHlxp60xz+CVwqkNjftCr493GRu66GCIQ6xnl5EXRrorw3gq+1AR9MEUw0n5KrDGabERIV6vbsc/vwrxp692cCRJnBmHPIE4ir4XYdd0jss3kgNR6QB7FH/xqEoJlInJKE++H3SefVkmgHLHEf4XTa2rCC9V6DmmhVlf1DEz+7w9OePY5srvcqeVvf4yl6o/vOm29DMhLOco7MQDNLXkshVkiGRGHKMU9nJJjDoGnZc/h7cDqssQRvyBvWF1MCGGurflimdRKXmCwiEtGDOxaUimZarJH8+KWTW3I0bSusJWSxbdpWStaaZVKlwWW2Gu/fUqEygLQReCx/qU1gvgipW/b7PFrhZwJzij9YJFgHtm3RjzZil7cPmBZiHoruo4du1eiIbksH+VNE/higXBGRj8bLp4mJqutL30xQWYVVBwcWZk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f0960896-85dd-43d6-6040-08d8171c7334 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2020 02:23:43.0991 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9O9REive+zSbD1iwl2GngFegAgC/0mxjgwJO9/iSGWUnRtM+ZHi+xTWCKFkHZoNmr6FRqxS9uFxWpQINwhRY8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4617 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 16/70] net/e1000/base: implement Low-Power-Link-Up (LPLU) for i225 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi,=20 > -----Original Message----- > From: Sun, GuinanX > Sent: Monday, June 22, 2020 2:46 PM > To: dev@dpdk.org > Cc: Guo, Jia ; Zhao1, Wei ; Sun, > GuinanX ; Dima Ruinskiy > Subject: [PATCH 16/70] net/e1000/base: implement Low-Power-Link-Up (LPLU) > for i225 >=20 > I225 introduces a new mechanism for Low-Power-Link-Up (LPLU) control. > This patch implements the new functions and sets the PHY OPS pointers. >=20 > Signed-off-by: Dima Ruinskiy > Signed-off-by: Guinan Sun > --- > drivers/net/e1000/base/e1000_i225.c | 58 > +++++++++++++++++++++++++++++ > 1 file changed, 58 insertions(+) >=20 > diff --git a/drivers/net/e1000/base/e1000_i225.c > b/drivers/net/e1000/base/e1000_i225.c > index 621dc6863..dbebb6fa3 100644 > --- a/drivers/net/e1000/base/e1000_i225.c > +++ b/drivers/net/e1000/base/e1000_i225.c It seems we should commit to folder dpdk/drivers/net/igc/base not in e1000 = folder for i225 > @@ -1147,3 +1147,61 @@ s32 e1000_init_hw_i225(struct e1000_hw *hw) > ret_val =3D e1000_init_hw_82575(hw); > return ret_val; > } > + > +/* > + * e1000_set_d0_lplu_state_i225 - Set Low-Power-Link-Up (LPLU) D0 state > + * @hw: pointer to the HW structure > + * @active: true to enable LPLU, false to disable > + * > + * Note: since I225 does not actually support LPLU, this function > + * simply enables/disables 1G and 2.5G speeds in D0. > + */ > +s32 e1000_set_d0_lplu_state_i225(struct e1000_hw *hw, bool active) { > + u32 data; > + > + DEBUGFUNC("e1000_set_d0_lplu_state_i225"); > + > + data =3D E1000_READ_REG(hw, E1000_I225_PHPM); > + > + if (active) { > + data |=3D E1000_I225_PHPM_DIS_1000; > + data |=3D E1000_I225_PHPM_DIS_2500; > + } else { > + data &=3D ~E1000_I225_PHPM_DIS_1000; > + data &=3D ~E1000_I225_PHPM_DIS_2500; > + } > + > + E1000_WRITE_REG(hw, E1000_I225_PHPM, data); > + return E1000_SUCCESS; > +} > + > +/* > + * e1000_set_d3_lplu_state_i225 - Set Low-Power-Link-Up (LPLU) D3 state > + * @hw: pointer to the HW structure > + * @active: true to enable LPLU, false to disable > + * > + * Note: since I225 does not actually support LPLU, this function > + * simply enables/disables 100M, 1G and 2.5G speeds in D3. > + */ > +s32 e1000_set_d3_lplu_state_i225(struct e1000_hw *hw, bool active) { > + u32 data; > + > + DEBUGFUNC("e1000_set_d3_lplu_state_i225"); > + > + data =3D E1000_READ_REG(hw, E1000_I225_PHPM); > + > + if (active) { > + data |=3D E1000_I225_PHPM_DIS_100_D3; > + data |=3D E1000_I225_PHPM_DIS_1000_D3; > + data |=3D E1000_I225_PHPM_DIS_2500_D3; > + } else { > + data &=3D ~E1000_I225_PHPM_DIS_100_D3; > + data &=3D ~E1000_I225_PHPM_DIS_1000_D3; > + data &=3D ~E1000_I225_PHPM_DIS_2500_D3; > + } > + > + E1000_WRITE_REG(hw, E1000_I225_PHPM, data); > + return E1000_SUCCESS; > +} > -- > 2.17.1