DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Sun, GuinanX" <guinanx.sun@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Sun, GuinanX" <guinanx.sun@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix statistics error in flow	control mode
Date: Tue, 12 May 2020 08:39:45 +0000	[thread overview]
Message-ID: <MWHPR11MB13916DD62A81E82C3FE56134B7BE0@MWHPR11MB1391.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200512081306.16013-1-guinanx.sun@intel.com>

Reviewed-by: Wei Zhao <wei.zhao1@intel.com>


> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Guinan Sun
> Sent: Tuesday, May 12, 2020 4:13 PM
> To: dev@dpdk.org
> Cc: Sun, GuinanX <guinanx.sun@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix statistics error in flow control
> mode
> 
> The register autoneg can't be updated synchronously with flow control mode
> setting in the state of port start , so NIC statistics error occurs. AUTO_NEG
> Advt register should be updated by ixgbe_setup_fc() when enabling flow
> control.
> The patch fixes the issue.
> 
> Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> ---
> v2 changes:
> * Replaced mac.ops.setup_fc() with ixgbe_setup_fc()
> * Modified commit message.
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index a4e5c539d..f8a84c565 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev,
> struct ixgbe_hw *hw)
>  	int err;
>  	uint32_t mflcn;
> 
> +	ixgbe_setup_fc(hw);
> +
>  	err = ixgbe_fc_enable(hw);
> 
>  	/* Not negotiated is not an error case */
> --
> 2.17.1


  reply	other threads:[~2020-05-12  8:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08  8:29 [dpdk-dev] [PATCH] " Guinan Sun
2020-05-09  3:13 ` Jiang, YuX
2020-05-11  1:03 ` Zhao1, Wei
2020-05-12  8:28   ` Sun, GuinanX
2020-05-12  8:13 ` [dpdk-dev] [PATCH v2] " Guinan Sun
2020-05-12  8:39   ` Zhao1, Wei [this message]
2020-05-13  0:59   ` [dpdk-dev] [dpdk-stable] " Ye Xiaolong
2020-05-13  7:03     ` Jiang, YuX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB13916DD62A81E82C3FE56134B7BE0@MWHPR11MB1391.namprd11.prod.outlook.com \
    --to=wei.zhao1@intel.com \
    --cc=dev@dpdk.org \
    --cc=guinanx.sun@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).