From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3F79A0093; Mon, 18 May 2020 08:48:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8AB2D1D42A; Mon, 18 May 2020 08:48:07 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2DD721D417; Mon, 18 May 2020 08:48:04 +0200 (CEST) IronPort-SDR: Zmx1z8025lePnDuCdCozZTruwMrCvhZbw80QpbkSUfL27ypKtUsld4gtJ2ZiAmyC0P1CljOLIS PfCdRra1CKjw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2020 23:48:03 -0700 IronPort-SDR: QRbYNTdJ4miuYVjJ27TsyclEGEkfFsmsjIDbH+r1nYEn6wgwYSS9bS5Bgn2HPShFqoIEjNZ0r0 M+hf309q1eYw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,406,1583222400"; d="scan'208";a="254365345" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga008.fm.intel.com with ESMTP; 17 May 2020 23:48:03 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 17 May 2020 23:48:03 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 17 May 2020 23:48:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EPQmYiphl77S7+bVUe/9MaIFJJ/5WV2UgC/eogLueAuLvUi0bjnGg48G96R166WwhGO43RKB/SW9Poqo4F+n8HMvHfv3H3GV17ZwqU1B+CBARgUWp9nJfwgkcP6NydgPefjRu17y6Staa9iympyC/BoH22pWFo0CAfoDJY1PXJH2D+qVBmoy8HuR0pquugnNkmUyapM6Qim4ggUgXMB3RYMFQQGp+3T6v5SXm3AngptF87j8JM1xDKmzcT4G1j1eOQbrwgPbwlXhIMsasnzE0eOJVoNRr1NVOH2JQn8xW7uSeky/NbJpWRXnKw2D50+jNW0JmyuLafbN3/ILkpriPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vx5Bg24nDlc7x+CnUFBApgonbATRN2lDZMItPG0n2nQ=; b=kTUUXEtkEgQ9tLIW57N3NQb3CMNQO+kqmFbiEQaN5ofRY7EOyRW2KeAVHU6DcR0efPUSXKdz4Tw6ueV5EjDND0JNPPMRmNvg6R/w5Uj285c62N5dA+pbEwUFpzIofxppH2yoLlq6CK4iAWixEeDJvz3Se6qaKCoVvoF/ROghmO9h29QxFCkxEAmkuqSPQ1Mvx/l19h0Kmn1PlfLO4k6GBuC+6vNbg60vJciUawV1VsfIxgc+qmBXZe2N1nRkY7ss9ET4/4VX0lokhD38qwAsgb8cOuyq4Sg0qEbN1orrnBrvLVOo39i1WOBOlRMwf2HF3uusaoddQ2LCOJ0sT0MzdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vx5Bg24nDlc7x+CnUFBApgonbATRN2lDZMItPG0n2nQ=; b=prDetJLgFLL0tYtJcILkYDKexgC5iGLy4jbIXHXi/+sxuYbVVpi8W5tns/IuBXm/La4h1uTEfzsjemCBD4fey5sjm+vxGhCynET/iE+vqrMgDuLl2VWOno9cKp/qGMQw2DBqG+v9BJGCrS/w2e9HlQvINZWTkyA8BUkSVfArN5s= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15) by MWHPR11MB0047.namprd11.prod.outlook.com (2603:10b6:301:68::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.26; Mon, 18 May 2020 06:48:00 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211%7]) with mapi id 15.20.3000.034; Mon, 18 May 2020 06:48:00 +0000 From: "Zhao1, Wei" To: "Ye, Xiaolong" , "Sun, GuinanX" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Min, JiaqiX" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] net/e1000: fix defects of macro in VF Thread-Index: AQHWLLRtaZuy7bUtpEyu7QlDgEKDEaitZQbA Date: Mon, 18 May 2020 06:48:00 +0000 Message-ID: References: <20200508015913.48764-1-guinanx.sun@intel.com> <20200508044618.70535-1-guinanx.sun@intel.com> <20200508044618.70535-3-guinanx.sun@intel.com> <20200518012453.GA93575@intel.com> In-Reply-To: <20200518012453.GA93575@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGQ3NzcxMDUtYjdhYS00MTg5LWJmOTctOTQ0YTE3ZDlhMzY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS1wvbzlIUFNOeXVCQzVWMlFjWTFqdWk1WUJzWmR4b1dmRXR1aWFcL0p2WGJHdmVXdUJjUU1QazM2bFUwT0t4YWVFIn0= dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9b60bd51-ca4e-4048-d79c-08d7faf76807 x-ms-traffictypediagnostic: MWHPR11MB0047: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1824; x-forefront-prvs: 04073E895A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qAxJ0sa//1ikItKNURt/lQtJcymReeh91h4uhkqyuNk8Ca5qGXOuCOq1zUtbTYufoMjzffgCwyOaqP7Ot/jbeYvHLU6Pfa57Kl9QrzFdBPA0lUGhEeXI768D9a50cjYdYAKx1xmC3sIVkc+CgtbZ3+sHtJ9bSi8dIuTijiJDjUee/yz8ad7eX7mPIS2QF14sQ4uk/ihbfGHiRlV28TG7epqo7BXKO7VZY7TMZxCM01cIh6dYYfcuA4m1BBoSCdxuHNBSH9YqIG2CpkN3u8Tbyr7yZTpK/T5v4zx1D7WKr+mkReWCmPOjDT/qW9Q+nDizvA+LPfTGIomA5IVPDll5MdK+a0lFbeEhcb1xkAQNSWOvqvprrWv+/8mKBDmOADk1r97jFweTC9g/cYIapFxmUkLHyIHAT2WCNYLXGahNzRdGBURc4XtjOxem0OARDcVISbjZbjOYWX3l9UCJ3iOVGtn5WWzFknV64yfNHBMZ18m1qjxyWFDJGo0OY/5YIK9E/rdgwlCj2MZZwWK/UqF39g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(376002)(396003)(366004)(136003)(39860400002)(346002)(2906002)(66556008)(33656002)(450100002)(5660300002)(53546011)(52536014)(66946007)(66446008)(86362001)(66476007)(76116006)(7696005)(4326008)(6506007)(64756008)(26005)(71200400001)(316002)(966005)(107886003)(54906003)(478600001)(8936002)(186003)(6636002)(8676002)(9686003)(55016002)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: OhtLKXvE9AKiGVJZeqGL0GDesNMtMrZH5GXDvWLj0+rk1VrwT70sLR0dKMXRma4J1FBRMC7f9szRHFjj4rED/dc/Vz2Gry4FePZKotZDZMmUhcBmFZjgbigFZBUs6grbjN55vbsN7hforWczLRRnd8LURqHAngruz+f8jHXR4jK+mKLH/386Jv35JI/PZMQgq5Y5xlSsV4UmCNAcOAWZHJw6NUnSp31+SxJg6H8hLgdXCfE//zxs/tkRfySeebT1dM4g5uOqnCNo9agClmXosNzPhUCb/190FgTOXi3XbBKDi76CsOlsv35/+zRPcCewvCoHK3OPnP49QvLFDas38TOumMdY6xblwZ4W7aqmdGsCezKglc/JeN6ne/sp0PNdfdBDz4ZxUb/I69Z0Z79nv2MU5rHqsVf7XVdnh6POejCo952kj8kifD34QobLgcZqyUNMuA7CxvAKLAIbRogsws3T+10yD3RTya6PJkZEqhE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 9b60bd51-ca4e-4048-d79c-08d7faf76807 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2020 06:48:00.4925 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4NOVTkQIMZwQd5qkRy+Io/Jv1Cfn18NMkMtvRgJVpTsrxStA/SCTuDNaSbQXwsXr8cgAif2wFHCEVm+4xspHDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0047 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] net/e1000: fix defects of macro in VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, xiaolong > -----Original Message----- > From: dev On Behalf Of Ye Xiaolong > Sent: Monday, May 18, 2020 9:25 AM > To: Sun, GuinanX > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] net/e1000: fix defec= ts of > macro in VF >=20 > Hi, guinan >=20 > On 05/08, Guinan Sun wrote: > >The defects in the macros UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT > exist. > >If latest is less than last, we will get wrong result. > >The patch fixes the defect. >=20 > There was similar patch before, https://patches.dpdk.org/patch/65131/, if= I > understand it correctly, you are trying to solve the rollover issue, righ= t? > Could you find the Ferruh's comment and check if this is a real issue? this issue has not been fixed by now, we need this patch to fix it. If (latest < last), there will be issue, is that right? >=20 > > > >Fixes: d15fcf76c8b7 ("e1000: move to drivers/net/") >=20 > This fix commit isn't correct. >=20 > Thanks, > Xiaolong >=20 > >Cc: stable@dpdk.org >=20 >=20 >=20 > > > >Signed-off-by: Guinan Sun > >--- > >v2 changes: > >* Aligned line-continuation character "\". > >--- > > drivers/net/e1000/igb_ethdev.c | 18 +++++++++++++----- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > >diff --git a/drivers/net/e1000/igb_ethdev.c > >b/drivers/net/e1000/igb_ethdev.c index 520fba8fa..4cd4e55c0 100644 > >--- a/drivers/net/e1000/igb_ethdev.c > >+++ b/drivers/net/e1000/igb_ethdev.c > >@@ -47,6 +47,8 @@ > > #define IGB_4_BIT_MASK RTE_LEN2MASK(IGB_4_BIT_WIDTH, uint8_t) > > #define IGB_8_BIT_WIDTH CHAR_BIT > > #define IGB_8_BIT_MASK UINT8_MAX > >+#define IGB_32_BIT_WIDTH (CHAR_BIT * 4) #define IGB_32_BIT_MASK > >+RTE_LEN2MASK(IGB_32_BIT_WIDTH, uint32_t) > > > > /* Additional timesync values. */ > > #define E1000_CYCLECOUNTER_MASK 0xffffffffffffffffULL > >@@ -261,11 +263,17 @@ static int igb_filter_restore(struct rte_eth_dev > >*dev); > > /* > > * Define VF Stats MACRO for Non "cleared on read" register > > */ > >-#define UPDATE_VF_STAT(reg, last, cur) \ > >-{ \ > >- u32 latest =3D E1000_READ_REG(hw, reg); \ > >- cur +=3D (latest - last) & UINT_MAX; \ > >- last =3D latest; \ > >+#define UPDATE_VF_STAT(reg, last, cur) > \ > >+{ > \ > >+ uint64_t latest =3D E1000_READ_REG(hw, reg); \ > >+ uint64_t stat =3D 0; \ > >+ if (latest >=3D last) \ > >+ stat =3D latest - last; \ > >+ else \ > >+ stat =3D (uint64_t)((latest + \ > >+ ((uint64_t)1 << IGB_32_BIT_WIDTH)) - last);\ > >+ cur +=3D stat & IGB_32_BIT_MASK; \ > >+ last =3D latest; \ > > } > > > > #define IGB_FC_PAUSE_TIME 0x0680 > >-- > >2.17.1 > >