From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 9F770A034F;
Tue, 28 Apr 2020 09:46:31 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 75F2A1D50E;
Tue, 28 Apr 2020 09:46:31 +0200 (CEST)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id 8D2E61D44B;
Tue, 28 Apr 2020 09:46:29 +0200 (CEST)
IronPort-SDR: snOVpgVKQeDsMxQlssvp90fXA71d+3DW032X1m62m7PC18aGoBUQEpMiLo55kFhT6yMjJ2T5tU
rdWQc82fCtJg==
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
28 Apr 2020 00:46:28 -0700
IronPort-SDR: 2IcW50AclAueDVi5UyTSb8RDG01p2EifG8o1Q2aTOIB3kCR6KKYQDkXV7rp/nULTPY0n/Mf3Em
CwZpV+0fibOg==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.73,327,1583222400"; d="scan'208";a="249102908"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
by fmsmga008.fm.intel.com with ESMTP; 28 Apr 2020 00:46:28 -0700
Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by
fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
id 14.3.439.0; Tue, 28 Apr 2020 00:46:28 -0700
Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by
FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS)
id 14.3.439.0; Tue, 28 Apr 2020 00:46:28 -0700
Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.55) by
edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server
(TLS) id 14.3.439.0; Tue, 28 Apr 2020 00:46:11 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=EAawnN9qlyI/ELh69IA02iywcPodeX/6u92aAOUq6ItMi44drYM8n0K4/xgkvtAnNcysxAhLi+LrnhZShBNsr6KKXpY08Ol3W7Pxofogpcz2txszeoiZkKc/QCgTKOg5MWoYj6gHL9d6oQ7953Pk02kdfcohQtQt5FVHgyjZOzmvww/ZDu2M92SlA6EmFAdliSUld5R8vpmPJ54eFWXdfnuWeQIfbIAB4rbO6lwuMxSXlwdnU6/8pRo2R+YzcSCHpnh9eZkyQzMQzs/q/rJxqZ7Difn259jbtyhCfGnuHLi+XQeiQyRzZeVrQ3Os3I0fyihbNy+bk3cRio7EoWbavw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=QbJ1XJEFe2M/nRq5j5ylgruPRCBbpeIE8/cq6uRU8no=;
b=HFb6eglKkiaWxUKjMgAAscorQMUvXUqSV5X8z+I9h+6eo6e1GVVScSa8oXcE5iw3DY67f7Nsv8uC4yXagJ2RU5qVI+/+SsfbsZuVl0/s85QNHfnJgLlrwXAakdgXaHY9vykSZaAYkV7iGPwPzfhpIFNBFCrJB47ktAzJ6c/iZwAy/TPF/gXORdfwwkQN4KQX6hHGEPjACr8abl27+z77+XBGegvPVWusd30AhKIYXs6tvKDwrGyJh6eq01Qe6Me+hO0zUgzauH+uLzB0btyXbD7Axo1zpl4ElPx7tKaRBOmWncv2nzAdlfGki/HXKz7l2rZ/Q42eLc1ZoaBv92K4Vw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=QbJ1XJEFe2M/nRq5j5ylgruPRCBbpeIE8/cq6uRU8no=;
b=KDRmSjvShh6kJo6ahwC1Z84vc4tI+vh5Od1d5AJPQVblRPLvogCy/WcpgJhZ6BDliGibHMfqIFzUDNd+HwP9OdoZG5DYd0Tcu2JIM8tlxQ3y/Z9Mo1WPzZJ5zJqrER7jGGxW0aJxclfTRKb6/P5EOBoiLmyeNz/Y9LO1H/2lZOY=
Received: from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15)
by MWHPR11MB1327.namprd11.prod.outlook.com (2603:10b6:300:2a::9) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Tue, 28 Apr
2020 07:46:10 +0000
Received: from MWHPR11MB1391.namprd11.prod.outlook.com
([fe80::c809:34b4:173b:d211]) by MWHPR11MB1391.namprd11.prod.outlook.com
([fe80::c809:34b4:173b:d211%7]) with mapi id 15.20.2937.023; Tue, 28 Apr 2020
07:46:10 +0000
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "stable@dpdk.org" <stable@dpdk.org>, "maxime.leroy@6wind.com"
<maxime.leroy@6wind.com>
Thread-Topic: [PATCH v2 1/3] net/i40e: fix FDIR issue for ARP packets
Thread-Index: AQHWHSPiYnYmmDGmpUCh2yTE7Xww1qiOJaYAgAACK/A=
Date: Tue, 28 Apr 2020 07:46:10 +0000
Message-ID: <MWHPR11MB1391AF7C65140CCEC2A20B37B7AC0@MWHPR11MB1391.namprd11.prod.outlook.com>
References: <20200427071500.14767-1-wei.zhao1@intel.com>
<20200428054815.3551-1-wei.zhao1@intel.com>
<20200428054815.3551-2-wei.zhao1@intel.com>
<BYAPR11MB3541EED61244807FE7BDB94BF7AC0@BYAPR11MB3541.namprd11.prod.outlook.com>
In-Reply-To: <BYAPR11MB3541EED61244807FE7BDB94BF7AC0@BYAPR11MB3541.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTQ2MDkzZGItMDcwZi00YjU3LTgyMTUtYmFiNjYyMjM3ZmMxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTHhlbW9KYXlWSDY4bE9mdzVvQXFjM1c0UnVRdjVEWXFTMEdIMFNuNTRsWUMrcUJrRHhSb1VJV2lPdDhvVDFDcyJ9
dlp-version: 11.0.600.7
dlp-product: dlpe-windows
x-ctpclassification: CTP_NT
dlp-reaction: no-action
authentication-results: intel.com; dkim=none (message not signed)
header.d=none;intel.com; dmarc=none action=none header.from=intel.com;
x-originating-ip: [134.191.221.116]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b8e71e73-0ee9-4689-6509-08d7eb4837d1
x-ms-traffictypediagnostic: MWHPR11MB1327:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <MWHPR11MB132777F723EA9F212AB547AEB7AC0@MWHPR11MB1327.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-forefront-prvs: 0387D64A71
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFTY:;
SFS:(346002)(136003)(39860400002)(396003)(376002)(366004)(186003)(55016002)(4326008)(26005)(110136005)(9686003)(64756008)(66476007)(7696005)(8936002)(53546011)(66446008)(76116006)(81156014)(52536014)(54906003)(316002)(66946007)(66556008)(6506007)(71200400001)(2906002)(33656002)(478600001)(8676002)(86362001)(5660300002);
DIR:OUT; SFP:1102;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: +CBWsY6n+PvXGlaqEROVzn6hK/gp9LqZQRPHr5hGiYUQT1qxmWhwy2/GaT5bLc+Csy8Sx/I+lw5xTokioOG9VAI31gyR74dO56uyNolIUdmoASDRf2eCMFa0n5V+WjaeAomA+IC5HGsDlT8MZH2b3VSrB/wBt2G+cs6es946vT2B106nBP4AvjomRYWUTKiEURiUJ/qo3iRaU8f16axQcbwozM9akrrDRP2491pfdsKysKto/TE9CvYHKHwkpruDfQ5zf9YZHvT+nJi9///slVD7y/fASicZWYzXwDBZJg5Zj4sxi2T0iXxv2iKScuhqy4PVqt/OSaXimSaaCwoVMXILL6gw/fRI3ivBzILKyoi5k/V7i/9uYerf02tkz9ghbo3zav5pdl0Q1DuxxCtCkSTT32GeZAmX4qo28EOQ2Ps5SjRMWn9RsZG+KB09sKBz
x-ms-exchange-antispam-messagedata: V6S5ldPoQmhlYhCWd2BQjT9xuo/7rP+20oEfubst8+90qgHGw3Exmv7TUQWRRTlHZmIEwMNolGS9MC5GJb/5ZHvlU31yglyMAkukLMrkZYn1LFoPjQmLFd8w8ExTWpmHJErIEm5Ssnp7ysH8DK7M0KWpmzrHedQF17MeG3g8/e9JcNUX8vsIXT3u5bkHjwEbnYUc/O5wrZXoqn+TPvFuuICkveTtim2Ex50K7spRwukwOAzTMDt2eCe0OHGlvOYB1ILFfZbsEcMl+OycSk8whe2yCf4fXOcmO+TSzFtsjQ9Dx8OJAtdLsdCjf0HaMBao0tag1gPhDbq/CAOUeIf9dHaMeLvrwtenp+BQOBUnEEUCYyZRJqERpb5Dskpx7T+VEDo0ZNDV91XC6jR1W9eMak6GIY6pJ7V8ROS7SCcgppgUN81H3wtRdCNXEg2kBIl40oPsyI+NtVWvrs5I+rKjF0yQWYDa0bgVHjHgzmr37QiVXQjozr/xuFQzPUL/p66L2eccZki0N2DR8ImbXCv/AmQ7bhYmXtCDuw6ZX9BAVPYugBpnauZPRKHvRJMlBnTnlawXOkX4x0qOGbq/nWcoQwsxECuHsvpWoEOVSeRkYq3ZkMbRWHqfEH5cjO/W58pTFB+FYjMvTbUPhc343iMs8hIYPe1RIbFmztYMsu9rs9+AerGYGHtSxHqqvi5N5R5ADZIEuyTid75GD6yx1LzBOdnp+0CUc8hycReiIzUjPT7i/GcGVriY+3bDGS7eplfjUlUCdbygghs835ccZzjW5WcYwY9wkeeO5jFjBO9XMGREo94R5PesiUVCWAy/8EtP
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b8e71e73-0ee9-4689-6509-08d7eb4837d1
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2020 07:46:10.1997 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gUK0JzScREpx05lVczoorxRTfHP7el3hjjCgXR06inHimdWKHFla+EGsqFzD7fzUKpsRPe6cUBfwNPWcAf3Tyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1327
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/i40e: fix FDIR issue for ARP
packets
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Tuesday, April 28, 2020 3:38 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; maxime.leroy@6wind.com
> Subject: RE: [PATCH v2 1/3] net/i40e: fix FDIR issue for ARP packets
>=20
>=20
>=20
> > -----Original Message-----
> > From: Zhao1, Wei <wei.zhao1@intel.com>
> > Sent: Tuesday, April 28, 2020 1:48 PM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Xing, Beilei <beilei.xing@intel.com>;
> > maxime.leroy@6wind.com; Zhao1, Wei <wei.zhao1@intel.com>
> > Subject: [PATCH v2 1/3] net/i40e: fix FDIR issue for ARP packets
> >
> > This patch can enable FDIR awith ethertype as input set for ARP
> > packet, it will associate this rule, "flow create 0 ingress pattern
> > eth type is 0x0806 / end actions mark id 0x86 / rss / end", with
> > pctype I40E_FILTER_PCTYPE_L2_PAYLOAD for ARP packet rule.
> > I have tried to enable ARP ethertype for FDIR filter, it work well for
> > ARP for FDIR filter, so delete the check.
>=20
> How about
> 'Currently, flow "pattern eth type is 0x0806 / end actions mark id 0x86 /=
rss /
> end" can't be created successfully. FDIR parser shouldn't deny
> RTE_ETHER_TYPE_ARP since ARP packets will be parsed as
> PCTYPE_L2_PAYLOAD.
> This patch fixes the issue.' ?
Ok=20
>=20
> >
> > Bugzilla ID: 402
> > Fixes: 42044b69c67d ("net/i40e: support input set selection for FDIR")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> > drivers/net/i40e/i40e_flow.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_flow.c
> > b/drivers/net/i40e/i40e_flow.c index 7e64ae53a..1533d5abb 100644
> > --- a/drivers/net/i40e/i40e_flow.c
> > +++ b/drivers/net/i40e/i40e_flow.c
> > @@ -2666,7 +2666,6 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev
> > *dev,
> > if (next_type =3D=3D
> > RTE_FLOW_ITEM_TYPE_VLAN ||
> > ether_type =3D=3D RTE_ETHER_TYPE_IPV4 ||
> > ether_type =3D=3D RTE_ETHER_TYPE_IPV6 ||
> > - ether_type =3D=3D RTE_ETHER_TYPE_ARP ||
> > ether_type =3D=3D outer_tpid) {
> > rte_flow_error_set(error, EINVAL,
> >
> > RTE_FLOW_ERROR_TYPE_ITEM,
> > @@ -2711,7 +2710,6 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev
> > *dev,
> >
> > if (ether_type =3D=3D RTE_ETHER_TYPE_IPV4 ||
> > ether_type =3D=3D RTE_ETHER_TYPE_IPV6 ||
> > - ether_type =3D=3D RTE_ETHER_TYPE_ARP ||
> > ether_type =3D=3D outer_tpid) {
> > rte_flow_error_set(error, EINVAL,
> >
> > RTE_FLOW_ERROR_TYPE_ITEM,
> > --
> > 2.19.1