DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Guo, Jia" <jia.guo@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	 "Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: enable 10Mb/s speed for x553
Date: Tue, 30 Jun 2020 01:32:10 +0000
Message-ID: <MWHPR11MB1391C18B6E7554636641684CB76F0@MWHPR11MB1391.namprd11.prod.outlook.com> (raw)
In-Reply-To: <071506a2-87c4-a94b-7f7c-d5100cb3f801@intel.com>

Hi, jia

> -----Original Message-----
> From: Guo, Jia <jia.guo@intel.com>
> Sent: Monday, June 29, 2020 4:21 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>
> Subject: Re: [PATCH] net/ixgbe: enable 10Mb/s speed for x553
> 
> hi, wei
> 
> On 6/28/2020 2:12 PM, Wei Zhao wrote:
> > For ixgbe x553(IXGBE_DEV_ID_X550EM_A_1G_T) it support 10M link speed,
> > so enable it for the kind of ixgbe nic.
> 
> 
> This is not an enabling patch i think, it just add the support link speed info for
> specific nic, so suggest you refine the commit log and bring my
> 
> ack at coming version.
> 

Ok 

> 
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> >   drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index f8a84c565..d812579fe 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -4320,6 +4320,10 @@ ixgbe_dev_link_update_share(struct
> rte_eth_dev *dev,
> >   			link.link_speed = ETH_SPEED_NUM_100M;
> >   		break;
> >
> > +	case IXGBE_LINK_SPEED_10_FULL:
> > +		link.link_speed = ETH_SPEED_NUM_10M;
> > +		break;
> > +
> >   	case IXGBE_LINK_SPEED_100_FULL:
> >   		link.link_speed = ETH_SPEED_NUM_100M;
> >   		break;
> Acked-by:  Jeff Guo <jia.guo@intel.com>

  reply	other threads:[~2020-06-30  1:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-28  6:12 Wei Zhao
2020-06-29  8:21 ` Jeff Guo
2020-06-30  1:32   ` Zhao1, Wei [this message]
2020-06-30  1:16 ` [dpdk-dev] [PATCH v2] net/ixgbe: add the support link speed info " Wei Zhao
2020-06-30 14:14   ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB1391C18B6E7554636641684CB76F0@MWHPR11MB1391.namprd11.prod.outlook.com \
    --to=wei.zhao1@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jia.guo@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git