From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C50B1A0093; Fri, 22 May 2020 11:42:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A1F7C1D971; Fri, 22 May 2020 11:42:53 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 2D2491D969; Fri, 22 May 2020 11:42:52 +0200 (CEST) IronPort-SDR: LE9GP5ybQScbV/LYHJdP0FAXbcjScg2ox2NthqDVUlmUiuTV98dEwE1Hl0HjRcB/Nn/5125xjc saxFNds6neJA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2020 02:42:51 -0700 IronPort-SDR: WskspglVxrfEwEVuzFH74ve6tH9I+8s5eI1mKubBgzhgBA8+mv6e+1ebPIjzBWIjTmdKShc7wX E28JYHUr5Czg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,421,1583222400"; d="scan'208";a="309330672" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by FMSMGA003.fm.intel.com with ESMTP; 22 May 2020 02:42:50 -0700 Received: from orsmsx154.amr.corp.intel.com (10.22.226.12) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 22 May 2020 02:42:50 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX154.amr.corp.intel.com (10.22.226.12) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 22 May 2020 02:42:50 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 22 May 2020 02:42:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cyb+VRh9guXYFfsvx6aZmiEss5t3Yqx4dXL+sF+JriKILSszRkCt6kNJVs7J1QzEEVsl100tS/N5hmivoDTwBCTw+xFk8lp1k5qmJk1hU16MMo0DCdRW6aZqbWnYeGT75+Yzv0AfaGk/9fDV+S2iYfGVjUdOHTei2C40YwMOs896N1BeQ91dbGX8NhP/X3X7A+jprPIvFb2XeXzqJ7Fb35kg9Vdh8h0pQa7cmOJ0C0F6b9GITylj9+WVwwU7eeZWb5o+S+GDrj3nCrQyrBn/usl9UD2WUz1w4iWuVKAxxcWxeiRgpyIuz/oU3O+GhUenfCgKSphqSW+bMe+3vNr+2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=suf9xPfKpjSLoZfEqWLNgP9De5kA7R4Gn3HMxPSB/Hg=; b=Vsh6BI8BGS/lnuk/DYDdLMikxJlXRpcCQQyK3yEY0KI3LfAOHBhCLmSdEGTlRDwliVeQ44e4Y12Gflz/5SpXYIehCqolywfprBrGGw+lzT1ySrGRVXKFwwwhlm7Nu3gS+qNFw/i3G4kYE3sZM96s8EcHfn094zDF73TOVGWz5tV7/rWUOTX4l3UTNsX1qq4X26O073QE/vJFJhI4GmHTnYcHcG94GQZ0+1SqQr6U12YaoQjpk41ZPYJFvV7v5AXE3rxIrb+TBj6QxfOtvYdQhszYvPzdc/adFx0r4+bwn8hhJLqctrJJp2bclLAA7nOs6EZT9ijTnT4XaEetLpFdDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=suf9xPfKpjSLoZfEqWLNgP9De5kA7R4Gn3HMxPSB/Hg=; b=I+jodZK7F773VWPf5hJvaRqRkqnKGy+NRSpGQySewC0204LV64ViBpYene7IQ1NkH0YGFD3UhUxnkUYO7CDnbeHuEq08/Rphk2By9zU3XB2celYfI3+UzdUG8YjuUj/PmAl6W20Rep02daLWs/cMGtrWv4UWjJtfJUnFwXEwYFE= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (10.169.233.143) by MWHPR11MB0029.namprd11.prod.outlook.com (10.164.204.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.24; Fri, 22 May 2020 09:42:48 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211%7]) with mapi id 15.20.3021.024; Fri, 22 May 2020 09:42:48 +0000 From: "Zhao1, Wei" To: "Sun, GuinanX" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Ye, Xiaolong" , "Yang, Qiming" Thread-Topic: [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter Thread-Index: AQHWMAKP7LvQ+1xyfU2gqq57qOf1Yaiz2kAg Date: Fri, 22 May 2020 09:42:48 +0000 Message-ID: References: <20200522061208.31694-1-guinanx.sun@intel.com> In-Reply-To: <20200522061208.31694-1-guinanx.sun@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGJhNzVhMzItNTZiOC00M2M0LTkzNjItZjU1YTQxNjQ3NTUyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoia1pzb2pBczhtUnBJWElpOVFMQ1ozS0JNb3RhU2pFUFRmOG9CK1lPS3pXVVFHdWx1QUFOeHNqSkNYWTZ3NFNBWSJ9 dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.213] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6c77acb8-cfce-4f4a-9d1a-08d7fe347d07 x-ms-traffictypediagnostic: MWHPR11MB0029: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 04111BAC64 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XDJcL5S+ZH3b50lVVNxUokJPTseWkNMUBKczOlsNTSFSfJivezl8caC1V/Wo7zb8vRVx45gabybhoC5zj3CfVQnNV0+Wo805HxOqBqxomTAfaEj/4DyBUzTQx19DTJhFZzaYGksxAszcFrIJl0mCIGaLTF+xgmmR9oRJRld7F3sROAxyPzgVIgiMYRwSvvLEa3WX9ivytHrFPQ8Tfsi5aDTNWiMnEcicdfhhpV9MxG1G9Yr/KSvtqE79vAyTUFoJ/Be/9fpGTFzvybeRuU7N40QIOZ8AGyWENHsTK5oiMt3HqAbCtfOVrfVNEynJi8CDipd9Ky8bqw73aAsbfvRfnA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(346002)(366004)(136003)(376002)(39860400002)(396003)(110136005)(8936002)(64756008)(52536014)(66946007)(54906003)(316002)(7696005)(8676002)(66446008)(2906002)(33656002)(86362001)(55016002)(66476007)(76116006)(66556008)(26005)(450100002)(478600001)(107886003)(4326008)(71200400001)(9686003)(186003)(53546011)(6506007)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: +/cYLBdRpkJf6kbEIVUeDRVuCnMMSwE9XDCwWmdKMDyUIsFBwnSVg9jAvGvy9Lv+RvLNGVfEONGrb4kHtuGldnwFr8+Q7CwTe4UwO2/xMqFbkbO7O1LwCMER4HNJUMKnCfjUsogVKu1hx1qA9nhyRerUbrRcguZwaGUZFeLZi3mrp9KKbP9H4feg5RyST859nyzOFYk18cKn3Gdl0B98iWLGbgIvt3WEU8VYf+SG3vzQFXF41x6pM3GptIbtmtsQfxki6MVVNmDlBqfHg0DuvUGtFFHSKjdfFzGnHTlNVNQlzymweKxu/COTBXBUDglfqWKebusOZ3dDB4z6AcpViNBTR1Qcndalg8203b3Nx86g4MophmpeX5FEiEoP1AMqlAlCHtfWRgDtbxof+GJ2AWwQ9J2fOfvybWk1eLSD5Nu5tDB5TfK+DaVQj6tQl1igj9IPJU6Ajh33O8QkK94S0CZrX6jlVsySJABIjroZhVI= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 6c77acb8-cfce-4f4a-9d1a-08d7fe347d07 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2020 09:42:48.3420 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Cv0dGvJd5yivqWI9SFtX1HyoB5SIR9/ci8LikyPmTiD0o0TJ99j78JRubGOvqAoUlQbXEdu/MrFeJXjNINjQ6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0029 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Guinan =20 > -----Original Message----- > From: Sun, GuinanX > Sent: Friday, May 22, 2020 2:12 PM > To: dev@dpdk.org > Cc: Zhao1, Wei ; Sun, GuinanX > ; stable@dpdk.org > Subject: [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapte= r >=20 > If some user set mac_ctrl_frame_fwd to 1 from fc ops, then he do a port r= eset > process of >=20 > testpmd> start > testpmd> set flow_ctrl mac_ctrl_frame_fwd on 0 stop port stop 0 port > testpmd> start 0 start This test step seems confused. >=20 > Then after this process, the mac_ctrl_frame_fwd has been change to "off",= so > we should delete "adapter->mac_ctrl_frame_fwd =3D 0;" from dev-stop. >=20 > In addition, add a value to mac_ctrl_frame_fwd in the ixgbe_flow_ctrl_get= () > function. >=20 > Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting") > Cc: stable@dpdk.org >=20 > Signed-off-by: SunGuinan > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index f8a84c565..dd4023f01 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2939,8 +2939,6 @@ ixgbe_dev_stop(struct rte_eth_dev *dev) >=20 > adapter->rss_reta_updated =3D 0; >=20 > - adapter->mac_ctrl_frame_fwd =3D 0; > - > hw->adapter_stopped =3D true; > } >=20 > @@ -4754,6 +4752,8 @@ ixgbe_flow_ctrl_get(struct rte_eth_dev *dev, struct > rte_eth_fc_conf *fc_conf) > * MFLCN register. > */ > mflcn_reg =3D IXGBE_READ_REG(hw, IXGBE_MFLCN); > + fc_conf->mac_ctrl_frame_fwd =3D mflcn_reg; > + > if (mflcn_reg & (IXGBE_MFLCN_RPFCE | IXGBE_MFLCN_RFCE)) > rx_pause =3D 1; > else > -- > 2.17.1