From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14F5AA00BE; Tue, 28 Apr 2020 07:39:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D17E81C2F0; Tue, 28 Apr 2020 07:39:10 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id CB8501C2DB; Tue, 28 Apr 2020 07:39:08 +0200 (CEST) IronPort-SDR: oBVYvfTd4Wl458hq4zm1ZHcYA02AEoxDu6awOAEGP8GBrXQ4Odyd++PVEMj9giye85KpnTkHEE HlJU5fQKeRKg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2020 22:39:07 -0700 IronPort-SDR: 27EGhjHyu6lTxmK/mJ0qg0p/eZ+EvqFrWXYlXA5USNszeKtTJkJQxcUvZBIjy684mFX3HQHbI8 yURtOuQ8lZ6w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,326,1583222400"; d="scan'208";a="292745471" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by fmsmga002.fm.intel.com with ESMTP; 27 Apr 2020 22:39:07 -0700 Received: from orsmsx160.amr.corp.intel.com (10.22.226.43) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 22:39:07 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX160.amr.corp.intel.com (10.22.226.43) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 22:39:06 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.50) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Apr 2020 22:39:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ODS9n5nhWIJwrWB/rzYQOWU+zxc4I0LLwplmirEvK3rT4WmGvFnGlMiA+uIH4hjpHew6FzJoTwqVSu8ReFYy5xayWluObeV9CXrtZ1HkSSrHut9XMesozh3er3DQo8YX3/PhcjTrZszCAdLVyzVSp3mWKAiTItSjedoDTdRSZKm0HcFCrm8WPYckGaZ1/irtATIzGly7wAUQJdcZGGUSS67e1X81ImuQnni6QVJwXbm+X6p9j9mzx6Ml3CQX7FcD2ZcdYbWBUXimcw4MxWcD1FXC8Lf7IR5La5MJSp2VKqZG0Yk6RT9LzA1vGDXivuR9VHj4c5GMiY1A/uwnp/SOFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0LTEHrbczk0ryy4Vzps6UzVLFt3dTmX/LpUCdjgw7Oc=; b=Ngf7kqcUn4iYZyjJQnUn7K1UkyFrnSu5WlLg171sQLrWCeJcpraKW2M+rprDQqm9/vLUjGpWHPRuCzcKm52iP4aniRJYctnFSd5W6D4yWnZLtK2qqLFIowwGQb4bVrfGGLvx4IKyx7JkJtghk/QMPjAtrYeC0QUnhU0q4gysSLXYa0RNzTTEMcx4FO4pgjxZPuStHk2Oh19VBrUi6smjWFC887mnoOvRWOD12S9K8zuS2cj0/kQNBnTWEHT/yeXamj7qgycYvpd902AYKLef/Llf9ZIJoqwSFnFFjj4rcPOOsiiNH/jLklwUnL3bPuoXz8Rp8UnYor2NNCDd2mzB4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0LTEHrbczk0ryy4Vzps6UzVLFt3dTmX/LpUCdjgw7Oc=; b=u7klAnhpIWqZQ0tKCS+/n01DXQS6d9xs/+xPr9T17DMgLDZWic6eRx4OXobATXmuLhi5fS9EsyM4jy7aVmPXZKDooAH9lk4zerApd6d8OHAgkGtIFv+HvVFPbDwt8549DsvTwIWq+60Rkd9ou1rK9Cjmvh8Xc9ZbTJKzIjO8eBs= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15) by MWHPR11MB0063.namprd11.prod.outlook.com (2603:10b6:301:6c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Tue, 28 Apr 2020 05:39:04 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211%7]) with mapi id 15.20.2937.023; Tue, 28 Apr 2020 05:39:04 +0000 From: "Zhao1, Wei" To: "Xing, Beilei" , "dev@dpdk.org" CC: "maxime.leroy@6wind.com" , "stable@dpdk.org" Thread-Topic: [PATCH 1/3] net/i40e: remove ARP type check for FDIR filter Thread-Index: AQHWHGbSqVKTiYxomEKW84NRAsxbG6iNvZ+AgABHbSA= Date: Tue, 28 Apr 2020 05:39:03 +0000 Message-ID: References: <20200427071500.14767-1-wei.zhao1@intel.com> <20200427071500.14767-2-wei.zhao1@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjg4YTM3YjEtNmE2NS00ZjJjLTg4MzUtYTUzMzA2MWVhZTNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaDY5Y0VjTWRvem9hYTdqR2xhalhCRFpNbWo3OTVFd2FMbVkwNjE4V1wvRVZKK3VDZkFZTERNeHFIVVpPbm15ZVoifQ== dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [134.191.221.116] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 656d5876-d489-4b94-b41a-08d7eb367640 x-ms-traffictypediagnostic: MWHPR11MB0063: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:369; x-forefront-prvs: 0387D64A71 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(396003)(39860400002)(136003)(376002)(346002)(7696005)(6506007)(55016002)(54906003)(53546011)(9686003)(110136005)(186003)(478600001)(8676002)(52536014)(33656002)(64756008)(316002)(5660300002)(81156014)(66946007)(66446008)(86362001)(66556008)(4326008)(71200400001)(76116006)(26005)(2906002)(8936002)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C/rPtkr9XbAm9lzR2t6yyp+/1Bzz4WfDr4AZ2BAjnBxDtzMCFGUyE7S/N2nm/2W8shq93F9zRMRVEzHjw1l8yYj4kXhZK6qQpwSV6ya6CrRgvTPGnKyMm2vgTvVdLFDXTEREPNY1odz7zWJLmttgaebK3vbVm1M7EDEsreuKr0bk9AAh6siWRVfBHZWRbqLreowqBc4JXc85fMq+Igq54E5yINqNIKckW3zXi8tNcoB/n7DpgNngCHiC1xuySRIYtycPZtfubp97UDQvDWzisAqYLGz805jb0ILElstWE0OL+dFfwXzx6Nd18WVRdgD9y9e4gq1O0rsNuOZ4Nbv5TIM/5+S0JBUDqkwrtf8u9oQWkA5Q9DwwBIlNa8Po/KipAI59xkUSOS4KTwFQ5Pk5gxD04aOmXaTz0aRZ7wJAavGuVi/PCWksJZVFHijJcLpB x-ms-exchange-antispam-messagedata: GBDdR1/Hdv9rt3dQX7md9YR+WRKARaDDHz5BMws1ZFI3/Kn4dA80c6KR5IcqZmNlt3neFo1kqyEIdbFm4cqYHIPkcTsVTncFJ53DjLahP3Z6l8TuNuBDBXZm7M56Rn09ZCNaxq+PD3GzphKdlDX2J/9u1VCBUjzWLZ9JmxUjv8xwz4pTL7t3+HMqoxJLdfMfUbsfYygZ4mQpKytd29TS0zckj6WoPN2dY+Z40oo8xFSd+HkCpQr2d3JYsKUwkC+SwkP51tUGA8Kc64cui4O1Cex8y919eSkoATq1N7bzF04Bs/J8eIf1TXOyWfpJTw1b5ZXM+uyukBRTVUU9x9ClqZ0F5mluZKAPG+ngezLxqbGdOOXFa00r8k2AX2+7oYORdEGql648rehsfO+FOURdATrrfOr/gz8plUNHEQNyZgKXANmZ7s1DM7VHzw6ISBO2Ggnbc4Zqn0chZwDOslXGGWOD3CIKUXn8XCnsDn33Qp6OFFor9P9DzBS76gfdW2aISabnrOoQMc9jQtbD2zVPUZl4hKojD2TQkwEDpn8zLicjz1eBQwR8TenUWgoOTifgwpNIW3Cv1ThcBmlqQGPYFbtRaBEtp7kZCxkeoQTXFdzjqSaqzfG2u7Fz7TmLny4VJwM+J+JiqFyuehW8wG4gt6s9TF4i4UMIo2JtrtjLD3JlTpwKaxIwJvUWXPnGBhpoyvC0NGN3XvFwb12DBDlOAs89Rtw0fj5kfzs6vKLFOzlmsej4tLA+m8SAo83EPf2hrGFkYOEJmubHxesw333Dush9/IKbDzSictKyieO03y+4nXyLH8IfKQyqmfWA1hZ7 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 656d5876-d489-4b94-b41a-08d7eb367640 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2020 05:39:03.8858 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S8GgK9CIDW3/fd2FJPS5LOOpUwa0hfSB/CeFFwpqb5Z45gw5UJohw3WnMpMhrUPhuA9oVLkVXwbIIgpxMFF0Vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0063 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/3] net/i40e: remove ARP type check for FDIR filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Xing, Beilei > Sent: Tuesday, April 28, 2020 9:21 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: maxime.leroy@6wind.com; stable@dpdk.org > Subject: RE: [PATCH 1/3] net/i40e: remove ARP type check for FDIR filter >=20 >=20 >=20 > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Monday, April 27, 2020 3:15 PM > > To: dev@dpdk.org > > Cc: Xing, Beilei ; maxime.leroy@6wind.com; > > stable@dpdk.org; Zhao1, Wei > > Subject: [PATCH 1/3] net/i40e: remove ARP type check for FDIR filter > > > > I have try to enable ARP ethertype for FDIR filter, it work well for > > ARP for FDIR filter, so delete it. >=20 > Could you rework the commit log by describing the problem and the root ca= use? > And the title maybe 'fix FDIR issue for ARP packets' > I guess the root cause is: if the ether_type is RTE_ETHER_TYPE_ARP, the > PCTYPE parsed during pipeline is I40E_FILTER_PCTYPE_L2_PAYLOAD. Please > double check. After check, this patch can enable FDIR with pctype I40E_FILTER_PCTYPE_L2_P= AYLOAD for ARP packet. Comment will be update. =20 >=20 > > > > Bugzilla ID: 402 > > Fixes: 42044b69c67d ("net/i40e: support input set selection for FDIR") > > Cc: stable@dpdk.org > > > > Signed-off-by: Wei Zhao > > --- > > drivers/net/i40e/i40e_flow.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > b/drivers/net/i40e/i40e_flow.c index 7e64ae53a..1533d5abb 100644 > > --- a/drivers/net/i40e/i40e_flow.c > > +++ b/drivers/net/i40e/i40e_flow.c > > @@ -2666,7 +2666,6 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev > > *dev, > > if (next_type =3D=3D > > RTE_FLOW_ITEM_TYPE_VLAN || > > ether_type =3D=3D RTE_ETHER_TYPE_IPV4 || > > ether_type =3D=3D RTE_ETHER_TYPE_IPV6 || > > - ether_type =3D=3D RTE_ETHER_TYPE_ARP || > > ether_type =3D=3D outer_tpid) { > > rte_flow_error_set(error, EINVAL, > > > > RTE_FLOW_ERROR_TYPE_ITEM, > > @@ -2711,7 +2710,6 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev > > *dev, > > > > if (ether_type =3D=3D RTE_ETHER_TYPE_IPV4 || > > ether_type =3D=3D RTE_ETHER_TYPE_IPV6 || > > - ether_type =3D=3D RTE_ETHER_TYPE_ARP || > > ether_type =3D=3D outer_tpid) { > > rte_flow_error_set(error, EINVAL, > > > > RTE_FLOW_ERROR_TYPE_ITEM, > > -- > > 2.19.1