From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5E1AA04B5; Thu, 29 Oct 2020 07:47:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BE89472F0; Thu, 29 Oct 2020 07:47:52 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E4F9C72ED for ; Thu, 29 Oct 2020 07:47:51 +0100 (CET) IronPort-SDR: bTAxPKSmanMY2PZbsO9X4vfcLuAY6jhpBvlqeoSyBNnA9QPv81R+VQOo+SmE13bdRacYJPRaLo gZ4SwPxx29zw== X-IronPort-AV: E=McAfee;i="6000,8403,9788"; a="232569389" X-IronPort-AV: E=Sophos;i="5.77,429,1596524400"; d="scan'208";a="232569389" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 23:47:49 -0700 IronPort-SDR: yoCVaureL6I41WXP3EAFXj5I0sPTSLEBiF8R4Xx0a0qfP/zyy0zf9mKQVW5pedaYtmXA/pdoZI JmogShfX+ajQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,429,1596524400"; d="scan'208";a="350862367" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga008.jf.intel.com with ESMTP; 28 Oct 2020 23:47:49 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 28 Oct 2020 23:47:49 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 28 Oct 2020 23:47:48 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 28 Oct 2020 23:47:48 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 28 Oct 2020 23:47:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c79xPf9TcaCoQ0TVuXPFXsQi0Pa41hU9BoQJjkL1jpwD4CHdaFbiTjJJdheTuOMzAR+Zi+9Xnama/zN87xNEdkt4cOF2jd1T3AGB7IpLMguxaKt+EuYgGV0rlJnpfFlxMOTFyDstFxpfeFT1wy0bOwpPGFAqfIxiCUoOwCFUiQrWGL5GDUh7wCW10xk88JDEnq/At9AwVdr0hpsQctEX/Hpos2fd6JcmLT+TlO6WIkZyWCi1k0UOVRYPzszhzgSfyXORcDoP1O6v5W3tm5Dgu0GAFwnHrHTZZylcqJAwXVsKXJUKXGvSRwx3DFaJHYrLPM5gUp4SSdAv00PQ9ojS9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YR5LfJxRp+HTIJ1DeqSWhx03mOadnxF88ztSnUTwr1I=; b=hyQoea8r54CulCx2H1OfggPWVbVQ1UYfdxcUK6LEzDO4MTON+5L6P+eWnVBNWNfb9y7qb662gW8YvZa4wuQ19Dy+gnLH79v7im5KKyOMiLdMLx1zP2iHIlcaKPrMPmPRotoG/bStlJOo6iMEfYUQwFtPhGodNDnAdAmtj4KRpwitzjDWPW+b3fBi1gcVMz8akIEFPfnIVi2o3DNhohFNT2SDmoLZwdwZuq+JLbWZAlsDkcZg8YtHGnyJaHTL1WvjSUK+UZkIe8ZmkLOwg6CvKcVsta73Yroin38xwyoIJECCPJevo1Ll842d2Kbwo5ImJd0EjX63oHq06cp1DiTXjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YR5LfJxRp+HTIJ1DeqSWhx03mOadnxF88ztSnUTwr1I=; b=m1IbnMuIaQYQA1V2TYqNejN3OU1IKkojgUjUdKSI9uRet/K9t8j8dN1NHUARWGRgINtyuN9PKOggy3HDobG8GunY//ok8MhQZxX3wPhIW7KWLwV0Mf0J4y/AlsBiaajCan4kfrfQdIhRiIJIQInEg4IKHFm5UL6nFT9oj8bdNbY= Received: from MWHPR11MB1663.namprd11.prod.outlook.com (2603:10b6:301:d::15) by MWHPR11MB1472.namprd11.prod.outlook.com (2603:10b6:301:d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Thu, 29 Oct 2020 06:47:43 +0000 Received: from MWHPR11MB1663.namprd11.prod.outlook.com ([fe80::5f5:db3b:9fe4:bf4]) by MWHPR11MB1663.namprd11.prod.outlook.com ([fe80::5f5:db3b:9fe4:bf4%12]) with mapi id 15.20.3477.028; Thu, 29 Oct 2020 06:47:43 +0000 From: "Zhu, TaoX" To: "Zhang, Qi Z" , "Yang, Qiming" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] net/ice: support show RSS hash configuration Thread-Index: AQHWrbMYB7Z/q0oD+Uy0cyOuj3WjJamuFDmAgAAOtiA= Date: Thu, 29 Oct 2020 06:47:43 +0000 Message-ID: References: <20201029050550.645-1-taox.zhu@intel.com> <20201029051129.784-1-taox.zhu@intel.com> <323100ffaa6741a6b304bc5e834c9f76@intel.com> In-Reply-To: <323100ffaa6741a6b304bc5e834c9f76@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 96a222a1-6df0-4b72-8054-08d87bd689af x-ms-traffictypediagnostic: MWHPR11MB1472: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BVfkmJQqhMobqJP3GRXx7lp+p+cTXn+5qJaEPJ7HEjW0WC7DB1SfQoLedC5rzFquc5s7klLyHycFTWwnUgmWmblMgODyzmOtBa3NScmW3WJ+/aPMR06BUbOxCYLHkLF/VNgEnEgfVq/Xn35QQLSgGN6nvkoUPxXvz0gkJNc2WvWrYnMsetA+POu1kZAQ0cyTkJgaGa0RRHFYgQGindHBQJv6BOxUpe3aL5hP2RVNo+7GybaS77UryhnoZXdlQxrTB7j1WF1oxnRHHWSBp1trgFBDeEIpXW4Rxv1JNbhF8RdPIByzxb3Rc5KFcEl/cWSjvfKRzhC8sjAP49qiagD9pQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1663.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(136003)(346002)(396003)(376002)(26005)(186003)(6506007)(33656002)(53546011)(316002)(83380400001)(2906002)(110136005)(6636002)(9686003)(66946007)(7696005)(66446008)(8936002)(4326008)(55016002)(478600001)(71200400001)(64756008)(5660300002)(66556008)(76116006)(86362001)(52536014)(8676002)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: IXDEa6+HXJ0Cq+3m7aiO9hWQJpXq+thfOSmko/1t7gGHdk6dxW05w8DFYGIvXFnOgDNNWQL8lzSOxlsSR9eEtmD9FMimTwAIlVRq2uu5WRIWgyruOIDbdCPhcy/ZcdN4qOTePsZ1LMyW7aF9/USadhefk+D6r742XOjgQyTuLnZBEcOmD1CfLQ5zu0aJZ12TnLubT8VdBk5fkSA900nHXqmDvSEK2fR0qBgX8vNoPWmf1FQ+9R/iKSUQjA6onU6U0lDvH5m+WoP4i+YOB2oeFR9fm5AGrio6mOfgKXMgvLpPwYOqmvCCVdIPbQBqsfHDQO5ogSulPTcXJdVrF4OqTH/PNlAXUjy9XvEvS73/ZD1Xo624ocb6WvMNkX0Gqh4m6N7cZ5qBwHPK4DUlXbbBIMrkEiECGOc8cFvD5aLtXoziASbRQqrkm7F33BNYi9mswMCQ/hfadjHowSH+jRh0ziPqnfHBaeJgfwDGqHaANc82GveKne15RcA1ycydSD7GssrlK6pHrAgPq5WriL6EX5tz8rWkagYX5jAUTbgycNe9HhDK7fCrvbO7UZqAChxP708lPhOFCVD6BOXt1WYgUgJNOIcKWA9msXSWWil1NrKFIVCIYzrK7mEY3c907zQaqrGZKT30Kh+2NFyOcIB6kA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1663.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96a222a1-6df0-4b72-8054-08d87bd689af X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2020 06:47:43.5033 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ShKO2PTnjC30kwz7iBiJwQJSN/UHasBPXuPFWzWnEdhKDpWc4J2bvhOdktZ+ESYKf+ShEju/OCGiE6QzJsBfow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1472 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/ice: support show RSS hash configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks, Qi I'll send v3 patch according to your comments. BRs, Zhu Tao -----Original Message----- From: Zhang, Qi Z =20 Sent: Thursday, October 29, 2020 1:53 PM To: Zhu, TaoX ; Yang, Qiming Cc: dev@dpdk.org; Zhu, TaoX Subject: RE: [PATCH v2] net/ice: support show RSS hash configuration > -----Original Message----- > From: taox.zhu@intel.com > Sent: Thursday, October 29, 2020 1:11 PM > To: Yang, Qiming ; Zhang, Qi Z=20 > > Cc: dev@dpdk.org; Zhu, TaoX > Subject: [PATCH v2] net/ice: support show RSS hash configuration >=20 > From: Zhu Tao >=20 > Implement interface 'ice_rss_hash_conf_get' to support show RSS hash=20 > configuration. >=20 > Note: > Not support the same time setting RSS with RTE and classify API. Only return rss_hf from latest dev_configure or dev_rss_hash_update.=20 All configures from rte_flow are ignored. And better to add above notes in ice_rss_hash_conf_get also. Otherwise Acked-by: Qi Zhang >=20 > Signed-off-by: Zhu Tao > --- > drivers/net/ice/ice_ethdev.c | 15 +++++++++++++--=20 > drivers/net/ice/ice_ethdev.h | 1 + > 2 files changed, 14 insertions(+), 2 deletions(-) >=20 > v2 changes: > Committed log. >=20 > diff --git a/drivers/net/ice/ice_ethdev.c=20 > b/drivers/net/ice/ice_ethdev.c index > d51f3faba..ff8106317 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -2923,6 +2923,16 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t=20 > rss_hf) struct ice_vsi *vsi =3D pf->main_vsi; int ret; >=20 > +#define ICE_RSS_HF_ALL ( \ > +ETH_RSS_IPV4 | \ > +ETH_RSS_IPV6 | \ > +ETH_RSS_NONFRAG_IPV4_UDP | \ > +ETH_RSS_NONFRAG_IPV6_UDP | \ > +ETH_RSS_NONFRAG_IPV4_TCP | \ > +ETH_RSS_NONFRAG_IPV6_TCP | \ > +ETH_RSS_NONFRAG_IPV4_SCTP | \ > +ETH_RSS_NONFRAG_IPV6_SCTP) > + > /* Configure RSS for IPv4 with src/dst addr as input set */ if=20 > (rss_hf & ETH_RSS_IPV4) { ret =3D ice_add_rss_cfg_wrap(pf, vsi->idx,=20 > ICE_FLOW_HASH_IPV4, @@ > -3216,6 +3226,8 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t=20 > rss_hf) PMD_DRV_LOG(ERR, "%s GTPU_EH_IPV6_SCTP rss flow fail %d", > __func__, ret); > } > + > +pf->rss_hf =3D rss_hf & ICE_RSS_HF_ALL; > } >=20 > static int ice_init_rss(struct ice_pf *pf) @@ -4439,8 +4451,7 @@=20 > ice_rss_hash_conf_get(struct rte_eth_dev *dev, ice_get_rss_key(vsi,=20 > rss_conf->rss_key, &rss_conf->rss_key_len); >=20 > -/* TODO: default set to 0 as hf config is not supported now */=20 > -rss_conf->rss_hf =3D 0; > +rss_conf->rss_hf =3D pf->rss_hf; > return 0; > } >=20 > diff --git a/drivers/net/ice/ice_ethdev.h=20 > b/drivers/net/ice/ice_ethdev.h index > 05218af05..452fd9050 100644 > --- a/drivers/net/ice/ice_ethdev.h > +++ b/drivers/net/ice/ice_ethdev.h > @@ -457,6 +457,7 @@ struct ice_pf { > uint64_t old_rx_bytes; > uint64_t old_tx_bytes; > uint64_t supported_rxdid; /* bitmap for supported RXDID */ > +uint64_t rss_hf; > }; >=20 > #define ICE_MAX_QUEUE_NUM 2048 > -- > 2.18.4